)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"adcbacc3f4dd6547f79a4a052cf67b1100abbcb3","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \u0027iproute\u0027,"},{"line_number":233,"context_line":"        \u0027iscsi-initiator-utils\u0027,"},{"line_number":234,"context_line":"        \u0027lvm2\u0027,"},{"line_number":235,"context_line":"        \u0027python\u0027,"},{"line_number":236,"context_line":"        \u0027scsi-target-utils\u0027,"},{"line_number":237,"context_line":"        \u0027socat\u0027,"},{"line_number":238,"context_line":"        \u0027sudo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bfdaf3ff_f809c52b","line":235,"range":{"start_line":235,"start_character":9,"end_line":235,"end_character":15},"updated":"2019-01-16 10:10:01.000000000","message":"this fails for my local testing, we need a way to not telling it to install python2 on an rhel system","commit_id":"17b5dd3993848eee74934b79f903463a1665d834"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d5dcd9281ce5ec2029dd166619daaef76d2d2c64","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \u0027iproute\u0027,"},{"line_number":233,"context_line":"        \u0027iscsi-initiator-utils\u0027,"},{"line_number":234,"context_line":"        \u0027lvm2\u0027,"},{"line_number":235,"context_line":"        \u0027python\u0027,"},{"line_number":236,"context_line":"        \u0027scsi-target-utils\u0027,"},{"line_number":237,"context_line":"        \u0027socat\u0027,"},{"line_number":238,"context_line":"        \u0027sudo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bfdaf3ff_f841c50c","line":235,"range":{"start_line":235,"start_character":9,"end_line":235,"end_character":15},"in_reply_to":"bfdaf3ff_f809c52b","updated":"2019-01-16 10:21:50.000000000","message":"{% if rpm_distro_python3 %}\u0027python3\u0027{% else %}\u0027python\u0027{% endif %}\n\nor something","commit_id":"17b5dd3993848eee74934b79f903463a1665d834"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49a1e531a75109ee37aae972c50dbe8dd665ed77","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        \u0027iproute\u0027,"},{"line_number":233,"context_line":"        \u0027iscsi-initiator-utils\u0027,"},{"line_number":234,"context_line":"        \u0027lvm2\u0027,"},{"line_number":235,"context_line":"        \u0027python\u0027,"},{"line_number":236,"context_line":"        \u0027scsi-target-utils\u0027,"},{"line_number":237,"context_line":"        \u0027socat\u0027,"},{"line_number":238,"context_line":"        \u0027sudo\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"bfdaf3ff_415579c5","line":235,"range":{"start_line":235,"start_character":9,"end_line":235,"end_character":15},"in_reply_to":"bfdaf3ff_f841c50c","updated":"2019-01-16 15:51:13.000000000","message":"Done","commit_id":"17b5dd3993848eee74934b79f903463a1665d834"}],"docker/nova/nova-base/Dockerfile.j2":[{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"dffb1a27520dc44ba43be28d69de660ad6275618","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":150,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":151,"context_line":"        {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":152,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":153,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":154,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9fdfeff1_ac05d511","line":151,"range":{"start_line":151,"start_character":29,"end_line":151,"end_character":61},"updated":"2019-02-28 06:47:50.000000000","message":"\u0027fedora\u0027 isn\u0027t it required here too ?","commit_id":"5962d62a3550faa6ccc6e839efb29d89f567a2f8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4acb1adeb02d2f4adaa17eba59dc4a169258a7ed","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":150,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":151,"context_line":"        {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":152,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":153,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":154,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9fdfeff1_3cfa6642","line":151,"range":{"start_line":151,"start_character":29,"end_line":151,"end_character":61},"in_reply_to":"9fdfeff1_522de08c","updated":"2019-02-28 15:41:44.000000000","message":"No because this isn\u0027t needed for fedora. It\u0027s only a RHEL7 based thing.","commit_id":"5962d62a3550faa6ccc6e839efb29d89f567a2f8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2f6c0abf99867fa3a4104ecfc44cabb922643304","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":150,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":151,"context_line":"        {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":152,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":153,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":154,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"9fdfeff1_522de08c","line":151,"range":{"start_line":151,"start_character":29,"end_line":151,"end_character":61},"in_reply_to":"9fdfeff1_ac05d511","updated":"2019-02-28 08:33:19.000000000","message":"if package_format \u003d\u003d \u0027rpm\u0027 (or how that variable was named) would solve issue.","commit_id":"5962d62a3550faa6ccc6e839efb29d89f567a2f8"}],"kolla/common/config.py":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8aa414f5b5ca8dd051bdbd325ffc5a0419ff615e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DISTRO_RELEASE \u003d {"},{"line_number":34,"context_line":"    \u0027fedora\u0027: \u002728\u0027,"},{"line_number":35,"context_line":"    \u0027centos\u0027: \u00277\u0027,"},{"line_number":36,"context_line":"    \u0027rhel\u0027: \u00277\u0027,"},{"line_number":37,"context_line":"    \u0027oraclelinux\u0027: \u00277\u0027,"},{"line_number":38,"context_line":"    \u0027debian\u0027: \u0027stretch-backports\u0027,"},{"line_number":39,"context_line":"    \u0027ubuntu\u0027: \u002718.04\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfdaf3ff_9af0c3cb","line":36,"updated":"2019-01-15 14:41:25.000000000","message":"could we poke that to 8 as well?","commit_id":"30419c5260d6331605560af50e584886c0dbaffe"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4fc32ed59c19f5c59bd6b1e3e2efd67ca0020c50","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"BASE_OS_DISTRO \u003d [\u0027fedora\u0027, \u0027centos\u0027, \u0027rhel\u0027, \u0027ubuntu\u0027, \u0027oraclelinux\u0027,"},{"line_number":23,"context_line":"                  \u0027debian\u0027]"},{"line_number":24,"context_line":"BASE_ARCH \u003d [\u0027x86_64\u0027, \u0027ppc64le\u0027, \u0027aarch64\u0027]"},{"line_number":25,"context_line":"DEFAULT_BASE_TAGS \u003d {"},{"line_number":26,"context_line":"    \u0027fedora\u0027: \u002728\u0027,"}],"source_content_type":"text/x-python","patch_set":52,"id":"9fb8cfa7_2ce2f630","line":23,"updated":"2019-06-18 18:49:03.000000000","message":"no need to break that early; if you want to break, then putting ubuntu and debian together would be more meaningful","commit_id":"fa3f9f4bfa4a9566e2c90abcbf4c01fe59518cea"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"c1fd115772664cc0720b512b9a96918e00eff0b4","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"BASE_OS_DISTRO \u003d [\u0027fedora\u0027, \u0027centos\u0027, \u0027rhel\u0027, \u0027ubuntu\u0027, \u0027oraclelinux\u0027,"},{"line_number":23,"context_line":"                  \u0027debian\u0027]"},{"line_number":24,"context_line":"BASE_ARCH \u003d [\u0027x86_64\u0027, \u0027ppc64le\u0027, \u0027aarch64\u0027]"},{"line_number":25,"context_line":"DEFAULT_BASE_TAGS \u003d {"},{"line_number":26,"context_line":"    \u0027fedora\u0027: \u002728\u0027,"}],"source_content_type":"text/x-python","patch_set":52,"id":"9fb8cfa7_4c496a30","line":23,"in_reply_to":"9fb8cfa7_2ce2f630","updated":"2019-06-18 18:52:49.000000000","message":"if you need to update it, just make it alphabetical with\none release per line, is easier to sort with editor.","commit_id":"fa3f9f4bfa4a9566e2c90abcbf4c01fe59518cea"}],"kolla/image/build.py":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"aade9fd4d9c235da6e4c16dbd6b2c389fefd2d90","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        deb_base \u003d [\u0027ubuntu\u0027, \u0027debian\u0027]"},{"line_number":696,"context_line":"        deb_type \u003d [\u0027source\u0027, \u0027binary\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        if self.conf.distro_python3 is not None:"},{"line_number":699,"context_line":"            self.distro_python3 \u003d self.conf.distro_python3"},{"line_number":700,"context_line":"        elif self.base in rh_base and self.base_tag in [\u002728\u0027, \u00278\u0027]:"},{"line_number":701,"context_line":"            # RHEL 8+ is python3"},{"line_number":702,"context_line":"            self.distro_python3 \u003d True"},{"line_number":703,"context_line":"        else:"},{"line_number":704,"context_line":"            self.distro_python3 \u003d False"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        if self.conf.distro_package_manager is not None:"},{"line_number":707,"context_line":"            pkg_mgr \u003d self.conf.distro_package_manager"}],"source_content_type":"text/x-python","patch_set":35,"id":"9fdfeff1_dc98fa69","line":704,"range":{"start_line":698,"start_character":0,"end_line":704,"end_character":39},"updated":"2019-02-28 15:35:18.000000000","message":"I would find easier if we would learn from ansible_pkg_mgr approach with is \u0027dnf\u0027 and \u0027yum\u0027 based on os/version.\nHow about defining a self.pkg_mgr variable and use that?\n\nPS. Just an idea, feel tree to ignore.","commit_id":"5962d62a3550faa6ccc6e839efb29d89f567a2f8"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"c3a76fb34923b2fa8a67a80342ed2c6fe9c32cbb","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        deb_base \u003d [\u0027ubuntu\u0027, \u0027debian\u0027]"},{"line_number":696,"context_line":"        deb_type \u003d [\u0027source\u0027, \u0027binary\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        if self.conf.distro_python3 is not None:"},{"line_number":699,"context_line":"            self.distro_python3 \u003d self.conf.distro_python3"},{"line_number":700,"context_line":"        elif self.base in rh_base and self.base_tag in [\u002728\u0027, \u00278\u0027]:"},{"line_number":701,"context_line":"            # RHEL 8+ is python3"},{"line_number":702,"context_line":"            self.distro_python3 \u003d True"},{"line_number":703,"context_line":"        else:"},{"line_number":704,"context_line":"            self.distro_python3 \u003d False"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        if self.conf.distro_package_manager is not None:"},{"line_number":707,"context_line":"            pkg_mgr \u003d self.conf.distro_package_manager"}],"source_content_type":"text/x-python","patch_set":35,"id":"9fdfeff1_9b856e5c","line":704,"range":{"start_line":698,"start_character":0,"end_line":704,"end_character":39},"in_reply_to":"9fdfeff1_3c8fc6cd","updated":"2019-03-02 11:49:29.000000000","message":"Ok. This is one of the reasons why I opened https://docs.google.com/document/d/1aGGHabTYBVa6hbJXJTvctLkZCA_HsLDGszH-M2cGaCA/edit#  and I want to find a cleaner way to distinguish between py3/py3 systems. This is the kind of logic we need on a huge number of places, better to get some code right.","commit_id":"5962d62a3550faa6ccc6e839efb29d89f567a2f8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4acb1adeb02d2f4adaa17eba59dc4a169258a7ed","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        deb_base \u003d [\u0027ubuntu\u0027, \u0027debian\u0027]"},{"line_number":696,"context_line":"        deb_type \u003d [\u0027source\u0027, \u0027binary\u0027]"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        if self.conf.distro_python3 is not None:"},{"line_number":699,"context_line":"            self.distro_python3 \u003d self.conf.distro_python3"},{"line_number":700,"context_line":"        elif self.base in rh_base and self.base_tag in [\u002728\u0027, \u00278\u0027]:"},{"line_number":701,"context_line":"            # RHEL 8+ is python3"},{"line_number":702,"context_line":"            self.distro_python3 \u003d True"},{"line_number":703,"context_line":"        else:"},{"line_number":704,"context_line":"            self.distro_python3 \u003d False"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        if self.conf.distro_package_manager is not None:"},{"line_number":707,"context_line":"            pkg_mgr \u003d self.conf.distro_package_manager"}],"source_content_type":"text/x-python","patch_set":35,"id":"9fdfeff1_3c8fc6cd","line":704,"range":{"start_line":698,"start_character":0,"end_line":704,"end_character":39},"in_reply_to":"9fdfeff1_dc98fa69","updated":"2019-02-28 15:41:44.000000000","message":"See the next block. That\u0027s where we solve for package manager. But package manager could be independent of python3 which is why this is it\u0027s own thing.","commit_id":"5962d62a3550faa6ccc6e839efb29d89f567a2f8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4fc32ed59c19f5c59bd6b1e3e2efd67ca0020c50","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        if self.base in rh_base and self.base_tag.startswith(\u00277\u0027):"},{"line_number":694,"context_line":"            self.conf.distro_python_version \u003d \"2.7\""},{"line_number":695,"context_line":"        elif self.base in rh_base and (self.base_tag.startswith(\u00278\u0027) or"},{"line_number":696,"context_line":"                                       self.base_tag.startswith(\u002728\u0027)):"},{"line_number":697,"context_line":"            self.conf.distro_python_version \u003d \"3.6\""},{"line_number":698,"context_line":"        elif self.base in [\u0027debian\u0027]:"},{"line_number":699,"context_line":"            self.conf.distro_python_version \u003d \"3.7\""}],"source_content_type":"text/x-python","patch_set":52,"id":"9fb8cfa7_ecd5be44","line":696,"updated":"2019-06-18 18:49:03.000000000","message":"would be best paired with fedora exact match","commit_id":"fa3f9f4bfa4a9566e2c90abcbf4c01fe59518cea"}]}