)]}'
{"kolla/cmd/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8ba0dae0b5c687c3dd9fcd1f2f6ee0e0a0e0b4d8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from kolla.image import build"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(SamYaple): Update the search path to prefer PROJECT_ROOT as the source"},{"line_number":21,"context_line":"#                 of packages to import if we are using local tools instead of"},{"line_number":22,"context_line":"#                 pip installed kolla tools"},{"line_number":23,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("},{"line_number":24,"context_line":"    os.path.dirname(os.path.realpath(__file__)), \u0027../..\u0027))"},{"line_number":25,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":26,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_1dee3722","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":36},"updated":"2018-12-27 10:19:57.000000000","message":"I think this change will break this code which is used for development.","commit_id":"d73baf161e114281b4cb266a7442d2440643da7d"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"5d7a3fe8ebe2adfafea33321c41872dcfa46dc8a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from kolla.image import build"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(SamYaple): Update the search path to prefer PROJECT_ROOT as the source"},{"line_number":21,"context_line":"#                 of packages to import if we are using local tools instead of"},{"line_number":22,"context_line":"#                 pip installed kolla tools"},{"line_number":23,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("},{"line_number":24,"context_line":"    os.path.dirname(os.path.realpath(__file__)), \u0027../..\u0027))"},{"line_number":25,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":26,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_fd89fb25","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":36},"in_reply_to":"1f769fc5_1dee3722","updated":"2018-12-27 10:54:59.000000000","message":"@Mark thanks for review, maybe have to check, then either we need change way of updating search path or development env setup with local tools. Do you any approach for this ?\nAs pep8 is failing on version update.\n\nThanks","commit_id":"d73baf161e114281b4cb266a7442d2440643da7d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8aae6fa00f0d5b7ee25fb381a3b06ae6d3881bcb","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from kolla.image import build"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(SamYaple): Update the search path to prefer PROJECT_ROOT as the source"},{"line_number":21,"context_line":"#                 of packages to import if we are using local tools instead of"},{"line_number":22,"context_line":"#                 pip installed kolla tools"},{"line_number":23,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("},{"line_number":24,"context_line":"    os.path.dirname(os.path.realpath(__file__)), \u0027../..\u0027))"},{"line_number":25,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":26,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_1de2b7d6","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":36},"in_reply_to":"1f769fc5_fd89fb25","updated":"2018-12-27 11:00:22.000000000","message":"Could just add \u0027# noqa\u0027 to the import (and move it back to the original position).","commit_id":"d73baf161e114281b4cb266a7442d2440643da7d"}],"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8ba0dae0b5c687c3dd9fcd1f2f6ee0e0a0e0b4d8","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# NOTE(SamYaple): Update the search path to prefer PROJECT_ROOT as the source"},{"line_number":50,"context_line":"#                 of packages to import if we are using local tools instead of"},{"line_number":51,"context_line":"#                 pip installed kolla tools"},{"line_number":52,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("},{"line_number":53,"context_line":"    os.path.dirname(os.path.realpath(__file__)), \u0027../..\u0027))"},{"line_number":54,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":55,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"LOG \u003d utils.make_a_logger()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_bdf2a305","line":55,"range":{"start_line":50,"start_character":0,"end_line":55,"end_character":36},"updated":"2018-12-27 10:19:57.000000000","message":"As before.","commit_id":"d73baf161e114281b4cb266a7442d2440643da7d"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"c1bd418362595cb17e1e090383e8ab52aabacc5e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":47,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from kolla.common import config as common_config  # noqa"},{"line_number":50,"context_line":"from kolla.common import task  # noqa"},{"line_number":51,"context_line":"from kolla.common import utils  # noqa"},{"line_number":52,"context_line":"from kolla import exception  # noqa"},{"line_number":53,"context_line":"from kolla.template import filters as jinja_filters  # noqa"},{"line_number":54,"context_line":"from kolla.template import methods as jinja_methods  # noqa"},{"line_number":55,"context_line":"from kolla import version  # noqa"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"LOG \u003d utils.make_a_logger()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f769fc5_5be7bbe5","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":33},"updated":"2019-01-02 09:44:19.000000000","message":"why all this with noqa?","commit_id":"8acba6ff5640f16995bbdc35e14e0661eeb404c1"},{"author":{"_account_id":23717,"name":"Surya Prakash Singh","email":"singh.surya64mnnit@gmail.com","username":"SuryaPrakash"},"change_message_id":"45b467c85ae1924b5631249b8b4f15da1f2ba7c7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":47,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from kolla.common import config as common_config  # noqa"},{"line_number":50,"context_line":"from kolla.common import task  # noqa"},{"line_number":51,"context_line":"from kolla.common import utils  # noqa"},{"line_number":52,"context_line":"from kolla import exception  # noqa"},{"line_number":53,"context_line":"from kolla.template import filters as jinja_filters  # noqa"},{"line_number":54,"context_line":"from kolla.template import methods as jinja_methods  # noqa"},{"line_number":55,"context_line":"from kolla import version  # noqa"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"LOG \u003d utils.make_a_logger()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffd0ebdf_c7a79c4f","line":55,"range":{"start_line":49,"start_character":0,"end_line":55,"end_character":33},"in_reply_to":"1f769fc5_5be7bbe5","updated":"2019-01-03 10:52:21.000000000","message":"@Eduardo Thanks for query. Putting this on top of the file could have break dev env.\n\nPlease take a look on discussion and pep8 failures.\nhttps://review.openstack.org/#/c/627148/4/kolla/cmd/build.py\n\nhttp://logs.openstack.org/48/627148/1/check/openstack-tox-pep8/d3cf50a/job-output.txt.gz#_2018-12-24_07_20_54_872211\n\nAs some of the pep8 standard wasn\u0027t compatible with this latest hacking version.","commit_id":"8acba6ff5640f16995bbdc35e14e0661eeb404c1"}],"tests/test_build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8ba0dae0b5c687c3dd9fcd1f2f6ee0e0a0e0b4d8","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from kolla.image import build"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"sys.path.append("},{"line_number":26,"context_line":"    os.path.abspath(os.path.join(os.path.dirname(__file__), \u0027../tools\u0027)))"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_7ddc0b74","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":73},"updated":"2018-12-27 10:19:57.000000000","message":"And again.","commit_id":"d73baf161e114281b4cb266a7442d2440643da7d"}],"tools/version-check.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8ba0dae0b5c687c3dd9fcd1f2f6ee0e0a0e0b4d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from kolla.common import config"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# NOTE(SamYaple): Update the search path to prefer PROJECT_ROOT as the source"},{"line_number":27,"context_line":"#                 of packages to import if we are using local tools instead of"},{"line_number":28,"context_line":"#                 pip installed kolla tools"},{"line_number":29,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("},{"line_number":30,"context_line":"    os.path.dirname(os.path.realpath(__file__)), \u0027..\u0027))"},{"line_number":31,"context_line":"if PROJECT_ROOT not in sys.path:"},{"line_number":32,"context_line":"    sys.path.insert(0, PROJECT_ROOT)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"logging.basicConfig(level\u003dlogging.INFO)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_3de69346","line":32,"range":{"start_line":26,"start_character":0,"end_line":32,"end_character":36},"updated":"2018-12-27 10:19:57.000000000","message":"And again.","commit_id":"d73baf161e114281b4cb266a7442d2440643da7d"}]}