)]}'
{"kolla/image/build.py":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"05ecbf15d439e6f346f32a697c8f067bb45b583f","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build leaf nodes, where a leaf is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"},{"line_number":1254,"context_line":"                LOG.info(\u0027Added image %s to queue\u0027, image.name)"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_cca93490","line":1252,"range":{"start_line":1250,"start_character":11,"end_line":1252,"end_character":76},"updated":"2019-03-15 18:21:51.000000000","message":"is this for the use case where you want to do a partial rebuild of just some of the leaf nodes?","commit_id":"82d8eef6592fd4f9be6b174c6366ea730af6d37b"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"59b1e5cfc11136ca695d1b88736367b426181d8a","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build leaf nodes, where a leaf is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"},{"line_number":1254,"context_line":"                LOG.info(\u0027Added image %s to queue\u0027, image.name)"},{"line_number":1255,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_cc8134c5","line":1252,"range":{"start_line":1250,"start_character":11,"end_line":1252,"end_character":76},"in_reply_to":"5fc1f717_cca93490","updated":"2019-03-15 18:31:57.000000000","message":"Yes, exactly. I wanted to build just a leaf node because I was iterating on overriding the Dockerfile.","commit_id":"82d8eef6592fd4f9be6b174c6366ea730af6d37b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"87480f0db02e3563ba291fcd9ace8167e1561817","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build leaf nodes, where a leaf is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_71ca47a1","line":1250,"range":{"start_line":1250,"start_character":69,"end_line":1250,"end_character":75},"updated":"2019-03-18 11:15:56.000000000","message":"Perhaps just a terminology issue, but I understand a leaf node to be something that has no children. A root node has not parent.","commit_id":"18a373d3f29192b6692c1cc5208e13383265931a"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"9a7e534594ddbb0e3717f7ed759ff27974a18e5d","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build leaf nodes, where a leaf is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_1bf2eb07","line":1250,"range":{"start_line":1250,"start_character":69,"end_line":1250,"end_character":75},"in_reply_to":"5fc1f717_61f4acf1","updated":"2019-05-31 19:32:43.000000000","message":"Done","commit_id":"18a373d3f29192b6692c1cc5208e13383265931a"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"666c2064d0880d39a2999ef43ca7d9822703c693","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build leaf nodes, where a leaf is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_61f4acf1","line":1250,"range":{"start_line":1250,"start_character":69,"end_line":1250,"end_character":75},"in_reply_to":"5fc1f717_71ca47a1","updated":"2019-03-18 16:16:35.000000000","message":"Indeed, I guess this is mixing terms a bit. The new behavior will be to queue a build of all root nodes, and additionally queue a build of any nodes that have their parent skipped. I can rephrase this comment.","commit_id":"18a373d3f29192b6692c1cc5208e13383265931a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"75ea1c10f316c2270fc101debde90731322ab504","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build all root nodes, where a root is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_1e56195e","line":1250,"range":{"start_line":1250,"start_character":79,"end_line":1250,"end_character":80},"updated":"2019-06-05 13:09:14.000000000","message":"If you remove the comma here it should make the line short enough for pep8 tests to pass.","commit_id":"31ed1741fc4b9344aad6124d53064021242716a0"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"2e45b9b6836faee76302d860e56184cfa95d3332","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"                # were not matched in the first place... (not worth the"},{"line_number":1248,"context_line":"                # effort to run them, if they won\u0027t be used anyway)."},{"line_number":1249,"context_line":"                continue"},{"line_number":1250,"context_line":"            # Build all root nodes, where a root is defined as having no parent,"},{"line_number":1251,"context_line":"            # or having a parent that is explicitly being skipped."},{"line_number":1252,"context_line":"            if image.parent is None or image.parent.status \u003d\u003d STATUS_SKIPPED:"},{"line_number":1253,"context_line":"                queue.put(BuildTask(self.conf, image, push_queue))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_3ba3eaa0","line":1250,"range":{"start_line":1250,"start_character":79,"end_line":1250,"end_character":80},"in_reply_to":"9fb8cfa7_1e56195e","updated":"2019-06-05 15:33:17.000000000","message":"Done","commit_id":"31ed1741fc4b9344aad6124d53064021242716a0"}]}