)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d0b555ec6247b44880a4f66a3390c15478a9c4bd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"a customization but if the differences are purely rpm vs deb, then the"},{"line_number":13,"context_line":"base_package_type can be used."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I8a0c6c8fbc32a8cfa6932fddf28a449fceda3d49"},{"line_number":16,"context_line":"Change-Id: I8d720bb185df65a0178061ccf20b1ab2265da2c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_ffa2044b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"updated":"2019-01-16 17:30:43.000000000","message":"we didn\u0027t need this because it was already dependent on his commit. I stacked the changes","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"}],"docker/aodh/aodh-base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"42744f960ae8bd81316cf48ec196e8a9a94a8226","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027aodh\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_packaging_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"       {% set aodh_base_packages \u003d ["},{"line_number":14,"context_line":"            \u0027httpd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"bfdaf3ff_cbeaea73","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":29},"updated":"2019-01-16 14:58:55.000000000","message":"https://review.openstack.org/#/c/631098/ defines base_package_type, not base_packaging_type.","commit_id":"4366b2aada7ce45e33709186286ca2841732cce7"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"796abd80b5910f2ce329f9d46a695466cd374b81","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    {% endif %}"},{"line_number":254,"context_line":"    {# endif for install type is source for RPM based distros #}"},{"line_number":255,"context_line":"{# endif for base_distro centos,oraclelinux,rhel #}"},{"line_number":256,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_40e1de29","line":255,"range":{"start_line":255,"start_character":13,"end_line":255,"end_character":48},"updated":"2019-01-17 13:40:34.000000000","message":"base_package_type rpm","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd0a93461cea8e615d88c849d25adc5fbd0aa3b8","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    {% endif %}"},{"line_number":254,"context_line":"    {# endif for install type is source for RPM based distros #}"},{"line_number":255,"context_line":"{# endif for base_distro centos,oraclelinux,rhel #}"},{"line_number":256,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_e6634a41","line":255,"range":{"start_line":255,"start_character":13,"end_line":255,"end_character":48},"in_reply_to":"bfdaf3ff_40e1de29","updated":"2019-01-17 15:23:57.000000000","message":"Done","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"796abd80b5910f2ce329f9d46a695466cd374b81","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \u0026\u0026 ln -s dist-packages /usr/lib/python2.7/site-packages"},{"line_number":392,"context_line":"{% endif %}"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"{# endif for base_distro debian, ubuntu #}"},{"line_number":395,"context_line":"{% endif %}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"COPY set_configs.py /usr/local/bin/kolla_set_configs"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_e03812a1","line":394,"range":{"start_line":394,"start_character":13,"end_line":394,"end_character":39},"updated":"2019-01-17 13:40:34.000000000","message":"base_package_type deb","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd0a93461cea8e615d88c849d25adc5fbd0aa3b8","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    \u0026\u0026 ln -s dist-packages /usr/lib/python2.7/site-packages"},{"line_number":392,"context_line":"{% endif %}"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"{# endif for base_distro debian, ubuntu #}"},{"line_number":395,"context_line":"{% endif %}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"COPY set_configs.py /usr/local/bin/kolla_set_configs"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_0669ae1f","line":394,"range":{"start_line":394,"start_character":13,"end_line":394,"end_character":39},"in_reply_to":"bfdaf3ff_e03812a1","updated":"2019-01-17 15:23:57.000000000","message":"Done","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"}],"docker/magnum/magnum-base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"9d43ad11c4d451721b690ea3e3b1482caed14092","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_d6d35b37","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":50},"updated":"2019-01-17 09:25:16.000000000","message":"I feel like rhel was accidentally left out.\n\nIMO it should also make use of \"base_package_type\". This can go in a follow-up patch if you want to keep this one as strictly refactoring.","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"796abd80b5910f2ce329f9d46a695466cd374b81","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_803a66c9","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":50},"in_reply_to":"bfdaf3ff_d6d35b37","updated":"2019-01-17 13:40:34.000000000","message":"+1 for a follow up","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd0a93461cea8e615d88c849d25adc5fbd0aa3b8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_261f12b8","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":50},"in_reply_to":"bfdaf3ff_d6d35b37","updated":"2019-01-17 15:23:57.000000000","message":"Done","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"d192166b3facdbfa8f5df546995767fedf634a3e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bfdaf3ff_bbdea96a","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":35},"updated":"2019-01-18 09:08:06.000000000","message":"this includes RHEL too but isnt in the original list. Does rhel osp have this package?","commit_id":"ae1322ec10861678abe1137f3013030b34335bc7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"313f54312a902e9c086810c1ddb213a9ffeb8081","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bfdaf3ff_6f8b986d","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":35},"in_reply_to":"bfdaf3ff_5c4f706a","updated":"2019-01-18 15:52:57.000000000","message":"https://review.openstack.org/631813 follow up","commit_id":"ae1322ec10861678abe1137f3013030b34335bc7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61994c1f70f11405764ea9ca5a2b8b2d205d0ffa","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bfdaf3ff_5c4f706a","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":35},"in_reply_to":"bfdaf3ff_a68a10bc","updated":"2019-01-18 15:06:28.000000000","message":"Can I follow up with a fix to this one? The magnum-api/magnum-conductor were already inconsistent with this logic.","commit_id":"ae1322ec10861678abe1137f3013030b34335bc7"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"49796f5456e8ca802b253b95a17ea36875a87433","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027magnum\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":"       {% set magnum_base_packages \u003d [\u0027openstack-magnum-common\u0027] %}"},{"line_number":13,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"       {% set magnum_base_packages \u003d [\u0027magnum-common\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bfdaf3ff_a68a10bc","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":35},"in_reply_to":"bfdaf3ff_bbdea96a","updated":"2019-01-18 10:32:19.000000000","message":"Eduardo, you\u0027re correct, mistral is not available in rhel osp. The correct way to handle this would be to add the following instruction for rhel base_distro:\n\n  RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\\n      \u0026\u0026 /bin/false\n\nRight now, magnum-base image builds for rhel (it doesn\u0027t install anything) then it fails to build magnum-api and magnum-conductor. This is not really a big deal though, since when building rhel images we\u0027re explicitly only building images for the supported services.","commit_id":"ae1322ec10861678abe1137f3013030b34335bc7"}],"docker/xtrabackup/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"9d43ad11c4d451721b690ea3e3b1482caed14092","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RUN yum-config-manager --enable percona\\*"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set xtrabackup_packages \u003d [\u0027percona-xtrabackup-24\u0027, \u0027qpress\u0027] %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_96b633fa","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":74},"updated":"2019-01-17 09:25:16.000000000","message":"if base_package_type in [\u0027deb\u0027, \u0027rpm\u0027]","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"796abd80b5910f2ce329f9d46a695466cd374b81","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RUN yum-config-manager --enable percona\\*"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set xtrabackup_packages \u003d [\u0027percona-xtrabackup-24\u0027, \u0027qpress\u0027] %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_c0a70e0b","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":74},"in_reply_to":"bfdaf3ff_96b633fa","updated":"2019-01-17 13:40:34.000000000","message":"+1","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd0a93461cea8e615d88c849d25adc5fbd0aa3b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RUN yum-config-manager --enable percona\\*"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":"    {% set xtrabackup_packages \u003d [\u0027percona-xtrabackup-24\u0027, \u0027qpress\u0027] %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bfdaf3ff_a632225d","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":74},"in_reply_to":"bfdaf3ff_96b633fa","updated":"2019-01-17 15:23:57.000000000","message":"Done","commit_id":"0851ca54e645698b5c2e1239db20fb1d25ff9d73"}]}