)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Schultz \u003caschultz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-18 10:52:41 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add python3 packages for RHEL systems and non-voting fedora job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RDO is currently working on python3 support for the next version of"},{"line_number":10,"context_line":"CentOS/RHEL based systems.  This package uses the distro_python3 flag"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fdfeff1_9b7321b5","line":7,"updated":"2019-02-19 12:59:58.000000000","message":"Looks like you\u0027ve dropped the fedora job in PS10 without updating the commit title.\n\nIf we don\u0027t want to run it each time, perhaps we should make it experimental?","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Schultz \u003caschultz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-18 10:52:41 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add python3 packages for RHEL systems and non-voting fedora job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RDO is currently working on python3 support for the next version of"},{"line_number":10,"context_line":"CentOS/RHEL based systems.  This package uses the distro_python3 flag"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fdfeff1_ed3952a3","line":7,"in_reply_to":"9fdfeff1_9b7321b5","updated":"2019-02-19 15:19:55.000000000","message":"We need to add the job later after things are merged. The job was added to this patch (and it shouldn\u0027t have been).  We\u0027d have to merge the fedora support change for the job so i pulled it out of this patch. We can discuss adding a fedora28 patch later as necessary","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"}],"docker/aodh/aodh-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"       {# NOTE(aschultz): added api because the common package doesn\u0027t include the wsgi file. I think this needs fixing #}"},{"line_number":20,"context_line":"       {% if distro_python3 %}"},{"line_number":21,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":22,"context_line":"            \u0027python3-mod_wsgi\u0027,"},{"line_number":23,"context_line":"            \u0027python3-ldappool\u0027"},{"line_number":24,"context_line":"        ] %}"},{"line_number":25,"context_line":"       {% else %}"},{"line_number":26,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_5ad6bff3","line":23,"range":{"start_line":22,"start_character":10,"end_line":23,"end_character":30},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"       {# NOTE(aschultz): added api because the common package doesn\u0027t include the wsgi file. I think this needs fixing #}"},{"line_number":20,"context_line":"       {% if distro_python3 %}"},{"line_number":21,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":22,"context_line":"            \u0027python3-mod_wsgi\u0027,"},{"line_number":23,"context_line":"            \u0027python3-ldappool\u0027"},{"line_number":24,"context_line":"        ] %}"},{"line_number":25,"context_line":"       {% else %}"},{"line_number":26,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_dd12a909","line":23,"range":{"start_line":22,"start_character":10,"end_line":23,"end_character":30},"in_reply_to":"5fc1f717_5ad6bff3","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        ] %}"},{"line_number":25,"context_line":"       {% else %}"},{"line_number":26,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["},{"line_number":27,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":28,"context_line":"            \u0027python2-ldappool\u0027"},{"line_number":29,"context_line":"        ] %}"},{"line_number":30,"context_line":"       {% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_da038f72","line":29,"range":{"start_line":27,"start_character":12,"end_line":29,"end_character":12},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        ] %}"},{"line_number":25,"context_line":"       {% else %}"},{"line_number":26,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["},{"line_number":27,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":28,"context_line":"            \u0027python2-ldappool\u0027"},{"line_number":29,"context_line":"        ] %}"},{"line_number":30,"context_line":"       {% endif %}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{{ macros.install_packages(aodh_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_7df935c6","line":29,"range":{"start_line":27,"start_character":12,"end_line":29,"end_character":12},"in_reply_to":"5fc1f717_da038f72","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ] %}"},{"line_number":60,"context_line":"       {% if distro_python3 %}"},{"line_number":61,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":62,"context_line":"            \u0027python3-mod_wsgi\u0027,"},{"line_number":63,"context_line":"            \u0027python3-ldappool\u0027"},{"line_number":64,"context_line":"        ] %}"},{"line_number":65,"context_line":"       {% else %}"},{"line_number":66,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_3af41386","line":63,"range":{"start_line":62,"start_character":15,"end_line":63,"end_character":28},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ] %}"},{"line_number":60,"context_line":"       {% if distro_python3 %}"},{"line_number":61,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":62,"context_line":"            \u0027python3-mod_wsgi\u0027,"},{"line_number":63,"context_line":"            \u0027python3-ldappool\u0027"},{"line_number":64,"context_line":"        ] %}"},{"line_number":65,"context_line":"       {% else %}"},{"line_number":66,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_3d03adba","line":63,"range":{"start_line":62,"start_character":15,"end_line":63,"end_character":28},"in_reply_to":"5fc1f717_3af41386","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        ] %}"},{"line_number":65,"context_line":"       {% else %}"},{"line_number":66,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["},{"line_number":67,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":68,"context_line":"            \u0027python2-ldappool\u0027"},{"line_number":69,"context_line":"        ] %}"},{"line_number":70,"context_line":"       {% endif %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_5aef9faf","line":68,"range":{"start_line":67,"start_character":14,"end_line":68,"end_character":16},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        ] %}"},{"line_number":65,"context_line":"       {% else %}"},{"line_number":66,"context_line":"       {% set aodh_base_packages \u003d  aodh_base_packages + ["},{"line_number":67,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":68,"context_line":"            \u0027python2-ldappool\u0027"},{"line_number":69,"context_line":"        ] %}"},{"line_number":70,"context_line":"       {% endif %}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_fd2e8541","line":68,"range":{"start_line":67,"start_character":14,"end_line":68,"end_character":16},"in_reply_to":"5fc1f717_5aef9faf","updated":"2019-03-11 16:35:27.000000000","message":"this is alphabetical","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"4107407aef0d7c15429db95cfb445c5483f8cd55","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027openstack-aodh-api\u0027,"},{"line_number":18,"context_line":"            \u0027openstack-aodh-common\u0027"},{"line_number":19,"context_line":"       ] %}"},{"line_number":20,"context_line":"       {% if distro_python_version.startswith(\u00273\u0027) %}"},{"line_number":21,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":22,"context_line":"            \u0027python3-ldappool\u0027,"},{"line_number":23,"context_line":"            \u0027python3-mod_wsgi\u0027"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"5fc1f717_7aee00b5","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":49},"updated":"2019-03-12 17:19:54.000000000","message":"Hopefully python won\u0027t go as far as version 30.","commit_id":"804f72f06210aa0b4297693102b7644189c9ebb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f4cb094eb4d94578224138c94e0b54b535a9d31","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027openstack-aodh-api\u0027,"},{"line_number":18,"context_line":"            \u0027openstack-aodh-common\u0027"},{"line_number":19,"context_line":"       ] %}"},{"line_number":20,"context_line":"       {% if distro_python_version.startswith(\u00273\u0027) %}"},{"line_number":21,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":22,"context_line":"            \u0027python3-ldappool\u0027,"},{"line_number":23,"context_line":"            \u0027python3-mod_wsgi\u0027"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"5fc1f717_f511a305","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":49},"in_reply_to":"5fc1f717_75ba930a","updated":"2019-03-12 17:45:29.000000000","message":"or !\u003d \u00272.7\u0027 to avoid changing the order. I\u0027m fine with startswith","commit_id":"804f72f06210aa0b4297693102b7644189c9ebb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8e0d8f1dea9003f7a548ffe93686626ce39e1cf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027openstack-aodh-api\u0027,"},{"line_number":18,"context_line":"            \u0027openstack-aodh-common\u0027"},{"line_number":19,"context_line":"       ] %}"},{"line_number":20,"context_line":"       {% if distro_python_version.startswith(\u00273\u0027) %}"},{"line_number":21,"context_line":"       {% set aodh_base_packages \u003d aodh_base_packages + ["},{"line_number":22,"context_line":"            \u0027python3-ldappool\u0027,"},{"line_number":23,"context_line":"            \u0027python3-mod_wsgi\u0027"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"5fc1f717_75ba930a","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":49},"in_reply_to":"5fc1f717_7aee00b5","updated":"2019-03-12 17:41:18.000000000","message":"{% if distro_python_version \u003d\u003d \u00272.7\u0027 %}\n\npython\n\n{% else %}\n\npython3\n\n{% endif %}","commit_id":"804f72f06210aa0b4297693102b7644189c9ebb9"}],"docker/barbican/barbican-api/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_api_packages \u003d ["},{"line_number":11,"context_line":"                \u0027httpd\u0027,"},{"line_number":12,"context_line":"                \u0027mod_ssl\u0027,"},{"line_number":13,"context_line":"                \u0027openstack-barbican-api\u0027,"},{"line_number":14,"context_line":"       ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"       {% if distro_python3 %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_9a68a721","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":41},"updated":"2019-03-11 16:12:45.000000000","message":"no leading commas","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"       {% set barbican_api_packages \u003d ["},{"line_number":11,"context_line":"                \u0027httpd\u0027,"},{"line_number":12,"context_line":"                \u0027mod_ssl\u0027,"},{"line_number":13,"context_line":"                \u0027openstack-barbican-api\u0027,"},{"line_number":14,"context_line":"       ] %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"       {% if distro_python3 %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_1d64b1b8","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":41},"in_reply_to":"5fc1f717_9a68a721","updated":"2019-03-11 16:35:27.000000000","message":"K i\u0027ll update that, but I think that\u0027s a mistake for jinja to prevent multiple line changes when you have to add something. Yes that\u0027s true for python but that\u0027s not a requirement for jinja (and i disagree that it should be removed)","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"92804acea64ac2f56d4b4fee367b6cf3114001cd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; \\"},{"line_number":39,"context_line":"    fi \\"},{"line_number":40,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc \\"},{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 \\"},{"line_number":42,"context_line":"{% if distro_python3 %}"},{"line_number":43,"context_line":"    /etc/dnf/dnf.conf"},{"line_number":44,"context_line":"{% else %}"},{"line_number":45,"context_line":"    /etc/yum.conf"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block base_yum_conf %}"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_38af047e","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":11},"updated":"2019-01-29 19:06:45.000000000","message":"the whitespace after substitution is odd with a blank line before the file name, which is likely not what you were looking to do., might need to collapse the {%  brackets closer to the text you want left in or collapse to one liner\n\n... \\\n\n/etc/dnf/dnf.conf","commit_id":"e6e7cc44261105980df09d8da2fdcbc73608840e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"88d4f95fb37042ff92479603c843e22034164ad6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; \\"},{"line_number":39,"context_line":"    fi \\"},{"line_number":40,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc \\"},{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 \\"},{"line_number":42,"context_line":"{% if distro_python3 %}"},{"line_number":43,"context_line":"    /etc/dnf/dnf.conf"},{"line_number":44,"context_line":"{% else %}"},{"line_number":45,"context_line":"    /etc/yum.conf"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block base_yum_conf %}"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_892024ae","line":46,"range":{"start_line":41,"start_character":0,"end_line":46,"end_character":11},"in_reply_to":"9fdfeff1_38af047e","updated":"2019-01-29 21:43:33.000000000","message":"ah i might need to {%- this. I\u0027ll follow up with this later. I did this for readability here","commit_id":"e6e7cc44261105980df09d8da2fdcbc73608840e"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"92804acea64ac2f56d4b4fee367b6cf3114001cd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{% if base_arch in [\u0027aarch64\u0027, \u0027ppc64le\u0027] %}"},{"line_number":54,"context_line":"    {% set centos_contentdir \u003d \u0027altarch\u0027 %}"},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":"{% if not distro_python3 %}"},{"line_number":57,"context_line":"RUN echo {{ centos_contentdir }} \u003e\u003e /etc/yum/vars/contentdir"},{"line_number":58,"context_line":"{% endif %}"},{"line_number":59,"context_line":"{% endif %}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"{% if distro_python3 %}"},{"line_number":62,"context_line":"COPY dnf.conf /etc/dnf/dnf.conf"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_589be864","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":11},"updated":"2019-01-29 19:06:45.000000000","message":"I don\u0027t think you need this guard here for this patch, I think it may have crept into one of the rebases","commit_id":"e6e7cc44261105980df09d8da2fdcbc73608840e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"88d4f95fb37042ff92479603c843e22034164ad6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"{% if base_arch in [\u0027aarch64\u0027, \u0027ppc64le\u0027] %}"},{"line_number":54,"context_line":"    {% set centos_contentdir \u003d \u0027altarch\u0027 %}"},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":"{% if not distro_python3 %}"},{"line_number":57,"context_line":"RUN echo {{ centos_contentdir }} \u003e\u003e /etc/yum/vars/contentdir"},{"line_number":58,"context_line":"{% endif %}"},{"line_number":59,"context_line":"{% endif %}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"{% if distro_python3 %}"},{"line_number":62,"context_line":"COPY dnf.conf /etc/dnf/dnf.conf"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_e92530c3","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":11},"in_reply_to":"9fdfeff1_589be864","updated":"2019-01-29 21:43:33.000000000","message":"Depends on how centos8 handles this. Right now this only affects centos 7 which i believe this covers correctly. fedora doesn\u0027t have /etc/yum/vars because dnf.","commit_id":"e6e7cc44261105980df09d8da2fdcbc73608840e"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        \u0027socat\u0027,"},{"line_number":238,"context_line":"        \u0027sudo\u0027,"},{"line_number":239,"context_line":"        \u0027which\u0027,"},{"line_number":240,"context_line":"        \u0027findutils\u0027"},{"line_number":241,"context_line":"] %}"},{"line_number":242,"context_line":"{% if distro_python3 %}"},{"line_number":243,"context_line":"{% set base_centos_binary_packages \u003d base_centos_binary_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_bb78658f","line":240,"updated":"2019-02-19 12:59:58.000000000","message":"nit: order alphabetically","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        \u0027socat\u0027,"},{"line_number":238,"context_line":"        \u0027sudo\u0027,"},{"line_number":239,"context_line":"        \u0027which\u0027,"},{"line_number":240,"context_line":"        \u0027findutils\u0027"},{"line_number":241,"context_line":"] %}"},{"line_number":242,"context_line":"{% if distro_python3 %}"},{"line_number":243,"context_line":"{% set base_centos_binary_packages \u003d base_centos_binary_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_8d3e8689","line":240,"in_reply_to":"9fdfeff1_bb78658f","updated":"2019-02-19 15:19:55.000000000","message":"Done","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"3731e0687b611c0c3a5dcfa103183a9656d8ef3b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; \\"},{"line_number":39,"context_line":"    fi \\"},{"line_number":40,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc \\"},{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 {% if distro_python3 %}/etc/dnf/dnf.conf{% else %}/etc/yum.conf{% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{% block base_yum_conf %}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9fdfeff1_61e50f0a","line":41,"range":{"start_line":41,"start_character":78,"end_line":41,"end_character":95},"updated":"2019-02-24 20:41:16.000000000","message":"This seems unrelated. DNF/YUM does not depend on Python version nor the other way around.","commit_id":"44aa4252e8080992fb6d898e629c73b1d0b475c8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97584d1ef74676f649aee682f0c417414fafd591","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; \\"},{"line_number":39,"context_line":"    fi \\"},{"line_number":40,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc \\"},{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 {% if distro_python3 %}/etc/dnf/dnf.conf{% else %}/etc/yum.conf{% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{% block base_yum_conf %}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9fdfeff1_f4276eb5","line":41,"range":{"start_line":41,"start_character":78,"end_line":41,"end_character":95},"in_reply_to":"9fdfeff1_61e50f0a","updated":"2019-02-25 15:14:52.000000000","message":"Except RDO won\u0027t be supporting python3 on a non-dnf based distro. The next CentOS is dnf based which is the target for the python3 packages.","commit_id":"44aa4252e8080992fb6d898e629c73b1d0b475c8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c527ca9b56edfe984f3a648310d09cc4891719b6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; \\"},{"line_number":39,"context_line":"    fi \\"},{"line_number":40,"context_line":"    \u0026\u0026 cat /tmp/kolla_bashrc \u003e\u003e /etc/bashrc \\"},{"line_number":41,"context_line":"    \u0026\u0026 sed -i \u0027s|^\\(override_install_langs\u003d.*\\)|# \\1|\u0027 {% if distro_python3 %}/etc/dnf/dnf.conf{% else %}/etc/yum.conf{% endif %}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"{% block base_yum_conf %}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9fdfeff1_b70d5e3f","line":41,"range":{"start_line":41,"start_character":78,"end_line":41,"end_character":95},"in_reply_to":"9fdfeff1_f4276eb5","updated":"2019-02-25 23:31:12.000000000","message":"k I\u0027ve split out the dnf/yum bits into it\u0027s own patch, https://review.openstack.org/#/c/639219/","commit_id":"44aa4252e8080992fb6d898e629c73b1d0b475c8"},{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"3731e0687b611c0c3a5dcfa103183a9656d8ef3b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"{% endif %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if distro_python3 %}"},{"line_number":55,"context_line":"COPY dnf.conf /etc/dnf/dnf.conf"},{"line_number":56,"context_line":"{% else %}"},{"line_number":57,"context_line":"COPY yum.conf /etc/yum.conf"},{"line_number":58,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9fdfeff1_81e033fa","line":55,"updated":"2019-02-24 20:41:16.000000000","message":"ditto","commit_id":"44aa4252e8080992fb6d898e629c73b1d0b475c8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97584d1ef74676f649aee682f0c417414fafd591","unresolved":false,"context_lines":[{"line_number":52,"context_line":"{% endif %}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if distro_python3 %}"},{"line_number":55,"context_line":"COPY dnf.conf /etc/dnf/dnf.conf"},{"line_number":56,"context_line":"{% else %}"},{"line_number":57,"context_line":"COPY yum.conf /etc/yum.conf"},{"line_number":58,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9fdfeff1_142d5294","line":55,"in_reply_to":"9fdfeff1_81e033fa","updated":"2019-02-25 15:14:52.000000000","message":"same","commit_id":"44aa4252e8080992fb6d898e629c73b1d0b475c8"}],"docker/base/dnf.conf":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"0c252b26b647ad875c04fd4a9d391fa27361bd54","unresolved":false,"context_lines":[{"line_number":7,"context_line":"plugins\u003d1"},{"line_number":8,"context_line":"installonly_limit\u003d0"},{"line_number":9,"context_line":"skip_missing_names_on_install\u003dFalse"},{"line_number":10,"context_line":"clean_requirements_on_remove\u003dTrue"},{"line_number":11,"context_line":"tsflags\u003dnodocs"}],"source_content_type":"text/plain","patch_set":2,"id":"9fdfeff1_2f55b3c6","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":33},"updated":"2019-01-25 17:26:36.000000000","message":"Good! I\u0027m thinking this setting should also be added to yum.conf.","commit_id":"cc27416e57401624d7ca17a3f15548734a2de8e9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"67b49e4c5597bca9916669a7966365c84f8810f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"plugins\u003d1"},{"line_number":8,"context_line":"installonly_limit\u003d0"},{"line_number":9,"context_line":"skip_missing_names_on_install\u003dFalse"},{"line_number":10,"context_line":"clean_requirements_on_remove\u003dTrue"},{"line_number":11,"context_line":"tsflags\u003dnodocs"}],"source_content_type":"text/plain","patch_set":2,"id":"9fdfeff1_ca5c15ef","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":33},"in_reply_to":"9fdfeff1_2f55b3c6","updated":"2019-02-11 15:36:15.000000000","message":"Done","commit_id":"cc27416e57401624d7ca17a3f15548734a2de8e9"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"0d6241667b78c02c6984f577f3f0cc9f53dd1cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdfeff1_ea831955","line":12,"updated":"2019-02-11 15:30:24.000000000","message":"can we add the following to avoid unnecessary deps including Xorg installed in containers\n\ninstall_weak_deps\u003dFalse","commit_id":"cc27416e57401624d7ca17a3f15548734a2de8e9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"67b49e4c5597bca9916669a7966365c84f8810f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdfeff1_6ac5e98d","line":12,"in_reply_to":"9fdfeff1_ea831955","updated":"2019-02-11 15:36:15.000000000","message":"Done","commit_id":"cc27416e57401624d7ca17a3f15548734a2de8e9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b4de38c8cbffaff5b3cb164c7f4c765b35f61005","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fdfeff1_8ac04d7e","line":12,"in_reply_to":"9fdfeff1_ea831955","updated":"2019-02-11 15:34:35.000000000","message":"that\u0027s a great finding! +42 for that :)","commit_id":"cc27416e57401624d7ca17a3f15548734a2de8e9"}],"docker/base/yum.conf":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"installonly_limit\u003d0"},{"line_number":9,"context_line":"skip_missing_names_on_install\u003dFalse"},{"line_number":10,"context_line":"tsflags\u003dnodocs"},{"line_number":11,"context_line":"clean_requirements_on_remove\u003dTrue"}],"source_content_type":"text/plain","patch_set":26,"id":"5fc1f717_3a50935d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":33},"updated":"2019-03-11 16:12:45.000000000","message":"not related - do it in separate patch","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"installonly_limit\u003d0"},{"line_number":9,"context_line":"skip_missing_names_on_install\u003dFalse"},{"line_number":10,"context_line":"tsflags\u003dnodocs"},{"line_number":11,"context_line":"clean_requirements_on_remove\u003dTrue"}],"source_content_type":"text/plain","patch_set":26,"id":"5fc1f717_9d1d0111","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":33},"in_reply_to":"5fc1f717_3a50935d","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"}],"docker/ceilometer/ceilometer-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        ] %}"},{"line_number":15,"context_line":"        {% if distro_python3 %}"},{"line_number":16,"context_line":"        {% set ceilometer_base_packages \u003d ceilometer_base_packages + ["},{"line_number":17,"context_line":"            \u0027python3-panko\u0027,"},{"line_number":18,"context_line":"            \u0027python3-gnocchiclient\u0027,"},{"line_number":19,"context_line":"            \u0027python3-oslo-db\u0027,"},{"line_number":20,"context_line":"            \u0027python3-tooz\u0027"},{"line_number":21,"context_line":"         ] %}"},{"line_number":22,"context_line":"        {% else %}"},{"line_number":23,"context_line":"        {% set ceilometer_base_packages \u003d ceilometer_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_1acb571e","line":20,"range":{"start_line":17,"start_character":18,"end_line":20,"end_character":23},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        ] %}"},{"line_number":15,"context_line":"        {% if distro_python3 %}"},{"line_number":16,"context_line":"        {% set ceilometer_base_packages \u003d ceilometer_base_packages + ["},{"line_number":17,"context_line":"            \u0027python3-panko\u0027,"},{"line_number":18,"context_line":"            \u0027python3-gnocchiclient\u0027,"},{"line_number":19,"context_line":"            \u0027python3-oslo-db\u0027,"},{"line_number":20,"context_line":"            \u0027python3-tooz\u0027"},{"line_number":21,"context_line":"         ] %}"},{"line_number":22,"context_line":"        {% else %}"},{"line_number":23,"context_line":"        {% set ceilometer_base_packages \u003d ceilometer_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_5d1799ee","line":20,"range":{"start_line":17,"start_character":18,"end_line":20,"end_character":23},"in_reply_to":"5fc1f717_1acb571e","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"}],"docker/cinder/cinder-api/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"        {% if distro_python3 %}"},{"line_number":16,"context_line":"        {% set cinder_api_packages \u003d cinder_api_packages + ["},{"line_number":17,"context_line":"                \u0027python3-mod_wsgi\u0027,"},{"line_number":18,"context_line":"                \u0027python3-keystone\u0027"},{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":"        {% else %}"},{"line_number":21,"context_line":"        {% set cinder_api_packages \u003d cinder_api_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_fa63eb18","line":18,"range":{"start_line":17,"start_character":20,"end_line":18,"end_character":21},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"}],"docker/collectd/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    {% endif %}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  {% endif %}"},{"line_number":90,"context_line":"  {% if not distro_pytho3 %}"},{"line_number":91,"context_line":"# make sure, collectd is pulled from centos-opstools"},{"line_number":92,"context_line":"RUN yum-config-manager --disable epel"},{"line_number":93,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_5b6db9ca","line":90,"updated":"2019-02-19 12:59:58.000000000","message":"typo: distro_python3","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    {% endif %}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  {% endif %}"},{"line_number":90,"context_line":"  {% if not distro_pytho3 %}"},{"line_number":91,"context_line":"# make sure, collectd is pulled from centos-opstools"},{"line_number":92,"context_line":"RUN yum-config-manager --disable epel"},{"line_number":93,"context_line":"  {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_4dc3be8b","line":90,"in_reply_to":"9fdfeff1_5b6db9ca","updated":"2019-02-19 15:19:55.000000000","message":"Done","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4ee4b6048347aac8b73f74d3b854e71ca0c2b9f5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_dcad39eb","line":49,"updated":"2019-03-05 21:17:27.000000000","message":"amqp1","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"efd14b310dc5b43fd1731aa94f86c76700e76ba7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_84b74587","line":49,"in_reply_to":"5fc1f717_bee137d3","updated":"2019-03-06 15:01:07.000000000","message":"Yes but we can fix that later. This is the initial patch and i\u0027m assuming there are other things that need to be addressed for the python3 version of packages.  I just changed it to what is available and it it\u0027s not available that\u0027s not necessarily a kolla problem.","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37ee8dafc84914b5b3e6b9687f6a15ccff3fee12","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_fcccb562","line":49,"in_reply_to":"5fc1f717_dcad39eb","updated":"2019-03-05 21:47:31.000000000","message":"This is not a typo, this is the only thing available from the fedora28 repo. https://trunk.rdoproject.org/fedora/stable-base/latest/Packages/","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"b7b4207324fea451d8012473284043811b69fe85","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_bee137d3","line":49,"in_reply_to":"5fc1f717_fcccb562","updated":"2019-03-06 09:10:47.000000000","message":"Then we should make that a typo. amqp1 is very important piece in service assurance framework and we need it. If it is not in fedora, then removing amqp1 plugin from kolla container is not a proper fix.","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4ee4b6048347aac8b73f74d3b854e71ca0c2b9f5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"},{"line_number":53,"context_line":"  ] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_1ca42108","line":50,"updated":"2019-03-05 21:17:27.000000000","message":"typo, _ needs to be -, see base version.","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37ee8dafc84914b5b3e6b9687f6a15ccff3fee12","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"},{"line_number":53,"context_line":"  ] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_9cd9f123","line":50,"in_reply_to":"5fc1f717_1ca42108","updated":"2019-03-05 21:47:31.000000000","message":"same","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"4ee4b6048347aac8b73f74d3b854e71ca0c2b9f5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"},{"line_number":53,"context_line":"  ] %}"},{"line_number":54,"context_line":"  {% else %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_3ca9ddde","line":51,"updated":"2019-03-05 21:17:27.000000000","message":"ditto.","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37ee8dafc84914b5b3e6b9687f6a15ccff3fee12","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"},{"line_number":53,"context_line":"  ] %}"},{"line_number":54,"context_line":"  {% else %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_5c05c979","line":51,"in_reply_to":"5fc1f717_3ca9ddde","updated":"2019-03-05 21:47:31.000000000","message":"same","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"440d524de1987f5ed5231ee7093cc86f6707e3ea","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"},{"line_number":53,"context_line":"  ] %}"},{"line_number":54,"context_line":"  {% else %}"},{"line_number":55,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_fcc11582","line":52,"updated":"2019-03-05 21:23:38.000000000","message":"ditto, typo, snmp_agent vs. snmp-agent","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"37ee8dafc84914b5b3e6b9687f6a15ccff3fee12","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"},{"line_number":53,"context_line":"  ] %}"},{"line_number":54,"context_line":"  {% else %}"},{"line_number":55,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"5fc1f717_7c0a058b","line":52,"in_reply_to":"5fc1f717_fcc11582","updated":"2019-03-05 21:47:31.000000000","message":"same","commit_id":"7b2fd7b12a44541ed8721530e74e35b4e4f804cf"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"79631103cb4327b45eded6ed84aaf527d317cb4b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-amqp\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":51,"context_line":"      \u0027collectd-ovs_stats\u0027,"},{"line_number":52,"context_line":"      \u0027collectd-snmp_agent\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"5fc1f717_f3c03f53","line":49,"updated":"2019-03-07 07:33:47.000000000","message":"last note, amqp is not the same as amqp1, there is no reason to add amqp here, as that would lead to the assumption, that sending metrics via amqp 0.9 (like via rabbitmq) is a good idea. Using the same rabbit as the one used for internal communication is likely a receipe for disaster.","commit_id":"de524dc9613f1efd614e39d64a94c29a1d2e7635"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"41636d88321c6b6b9897fbd213976b76b0375e82","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ] %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_stats\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_261aac6e","line":47,"updated":"2019-03-12 11:00:19.000000000","message":"Are they missing because they\u0027re no longer available in the distro?","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1a7910efc04f84cbcfc602e3fdba47ea534cb270","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ] %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  {% if distro_python3 %}"},{"line_number":47,"context_line":"  {# TODO(aschultz): there are some missing packages here #}"},{"line_number":48,"context_line":"  {% set collectd_packages \u003d collectd_packages + ["},{"line_number":49,"context_line":"      \u0027collectd-ovs_events\u0027,"},{"line_number":50,"context_line":"      \u0027collectd-ovs_stats\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_d23da2dd","line":47,"in_reply_to":"5fc1f717_261aac6e","updated":"2019-03-12 14:32:48.000000000","message":"They are not currently available via fedora. They will likely be available once we get CentOS8.  So at the moment it\u0027s just to document that this needs to be addressed in the future as available.","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"}],"docker/designate/designate-base/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"        {% if distro_python3 %}"},{"line_number":17,"context_line":"        {% set designate_base_packages \u003d designate_base_packages + ["},{"line_number":18,"context_line":"            \u0027python3-tooz\u0027,"},{"line_number":19,"context_line":"            \u0027python3-oslo-reports\u0027,"},{"line_number":20,"context_line":"            \u0027python3-suds\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"        {% else %}"},{"line_number":23,"context_line":"        {% set designate_base_packages \u003d designate_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_7a77fbd5","line":20,"range":{"start_line":18,"start_character":21,"end_line":20,"end_character":23},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"}],"docker/gnocchi/gnocchi-base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \u0027python3-cradox\u0027"},{"line_number":23,"context_line":"        ] %}"},{"line_number":24,"context_line":"        {% else %}"},{"line_number":25,"context_line":"       {% set gnocchi_base_packages \u003d gnocchi_base_packages + ["},{"line_number":26,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":27,"context_line":"            \u0027python2-ldappool\u0027,"},{"line_number":28,"context_line":"            \u0027python2-cradox\u0027"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_7b72fdaf","line":25,"updated":"2019-02-19 12:59:58.000000000","message":"nit: indentation is off","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \u0027python3-cradox\u0027"},{"line_number":23,"context_line":"        ] %}"},{"line_number":24,"context_line":"        {% else %}"},{"line_number":25,"context_line":"       {% set gnocchi_base_packages \u003d gnocchi_base_packages + ["},{"line_number":26,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":27,"context_line":"            \u0027python2-ldappool\u0027,"},{"line_number":28,"context_line":"            \u0027python2-cradox\u0027"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_6d456215","line":25,"in_reply_to":"9fdfeff1_7b72fdaf","updated":"2019-02-19 15:19:55.000000000","message":"Done","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        ] %}"},{"line_number":18,"context_line":"        {% if distro_python3 %}"},{"line_number":19,"context_line":"        {% set gnocchi_base_packages \u003d gnocchi_base_packages + ["},{"line_number":20,"context_line":"            \u0027python3-mod_wsgi\u0027,"},{"line_number":21,"context_line":"            \u0027python3-ldappool\u0027,"},{"line_number":22,"context_line":"            \u0027python3-cradox\u0027"},{"line_number":23,"context_line":"        ] %}"},{"line_number":24,"context_line":"        {% else %}"},{"line_number":25,"context_line":"        {% set gnocchi_base_packages \u003d gnocchi_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_3a817390","line":22,"range":{"start_line":20,"start_character":15,"end_line":22,"end_character":17},"updated":"2019-03-11 16:12:45.000000000","message":"alphabetical order please","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"}],"docker/heat/heat-engine/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u0027python3-zaqarclient\u0027"},{"line_number":17,"context_line":"        ] %}"},{"line_number":18,"context_line":"        {% else %}"},{"line_number":19,"context_line":"       {% set heat_engine_packages \u003d heat_engine_packages + ["},{"line_number":20,"context_line":"            \u0027python-barbicanclient\u0027,"},{"line_number":21,"context_line":"            \u0027python-zaqarclient\u0027"},{"line_number":22,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_1b6731ed","line":19,"updated":"2019-02-19 12:59:58.000000000","message":"Indent","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u0027python3-zaqarclient\u0027"},{"line_number":17,"context_line":"        ] %}"},{"line_number":18,"context_line":"        {% else %}"},{"line_number":19,"context_line":"       {% set heat_engine_packages \u003d heat_engine_packages + ["},{"line_number":20,"context_line":"            \u0027python-barbicanclient\u0027,"},{"line_number":21,"context_line":"            \u0027python-zaqarclient\u0027"},{"line_number":22,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_ed62b2ad","line":19,"in_reply_to":"9fdfeff1_1b6731ed","updated":"2019-02-19 15:19:55.000000000","message":"Done","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"}],"docker/horizon/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"41636d88321c6b6b9897fbd213976b76b0375e82","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":"        {% if distro_python3 %}"},{"line_number":13,"context_line":"        {% set horizon_pyver \u003d \u00273.6\u0027 %}"},{"line_number":14,"context_line":"        {% set horizon_python \u003d \u0027python3\u0027 %}"},{"line_number":15,"context_line":"        {% else %}"},{"line_number":16,"context_line":"        {% set horizon_pyver \u003d \u00272.7\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_463018e9","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":28},"updated":"2019-03-12 11:00:19.000000000","message":"Will be able to use distro_python_version here.","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1a7910efc04f84cbcfc602e3fdba47ea534cb270","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":11,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":12,"context_line":"        {% if distro_python3 %}"},{"line_number":13,"context_line":"        {% set horizon_pyver \u003d \u00273.6\u0027 %}"},{"line_number":14,"context_line":"        {% set horizon_python \u003d \u0027python3\u0027 %}"},{"line_number":15,"context_line":"        {% else %}"},{"line_number":16,"context_line":"        {% set horizon_pyver \u003d \u00272.7\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_5229b298","line":13,"range":{"start_line":13,"start_character":15,"end_line":13,"end_character":28},"in_reply_to":"5fc1f717_463018e9","updated":"2019-03-12 14:32:48.000000000","message":"Where is that being added?  I\u0027ll be happy to follow up on that as necessary","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"}],"docker/ironic/ironic-conductor/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        {% if distro_python3 %}"},{"line_number":27,"context_line":"{# TODO(aschultz): missing packages?"},{"line_number":28,"context_line":"            \u0027python3-UcsSdk\u0027,"},{"line_number":29,"context_line":"            \u0027python3-ImcSdk\u0027,"},{"line_number":30,"context_line":"#}"},{"line_number":31,"context_line":"        {% set ironic_conductor_packages \u003d ironic_conductor_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_7a605b02","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":27},"updated":"2019-03-11 16:12:45.000000000","message":"UcsSdk is python 2 only upstream","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        {% if distro_python3 %}"},{"line_number":27,"context_line":"{# TODO(aschultz): missing packages?"},{"line_number":28,"context_line":"            \u0027python3-UcsSdk\u0027,"},{"line_number":29,"context_line":"            \u0027python3-ImcSdk\u0027,"},{"line_number":30,"context_line":"#}"},{"line_number":31,"context_line":"        {% set ironic_conductor_packages \u003d ironic_conductor_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_fda1a5aa","line":28,"range":{"start_line":28,"start_character":21,"end_line":28,"end_character":27},"in_reply_to":"5fc1f717_7a605b02","updated":"2019-03-11 16:35:27.000000000","message":"This is commented out, i\u0027ll just delete it though","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"840adedeec5ac47b4a8cc2376a29f19acdb069ea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"        # TODO(Jeffrey4l): no python-oneviewclient"},{"line_number":11,"context_line":"        {% set ironic_conductor_packages \u003d ["},{"line_number":12,"context_line":"            \u0027ansible\u0027,"},{"line_number":13,"context_line":"            \u0027dosfstools\u0027,"},{"line_number":14,"context_line":"            \u0027e2fsprogs\u0027,"},{"line_number":15,"context_line":"            \u0027gdisk\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_d1112406","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":20},"updated":"2019-03-12 11:56:46.000000000","message":"Should this be py2 only?","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1a7910efc04f84cbcfc602e3fdba47ea534cb270","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"        # TODO(Jeffrey4l): no python-oneviewclient"},{"line_number":11,"context_line":"        {% set ironic_conductor_packages \u003d ["},{"line_number":12,"context_line":"            \u0027ansible\u0027,"},{"line_number":13,"context_line":"            \u0027dosfstools\u0027,"},{"line_number":14,"context_line":"            \u0027e2fsprogs\u0027,"},{"line_number":15,"context_line":"            \u0027gdisk\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_32050615","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":20},"in_reply_to":"5fc1f717_d1112406","updated":"2019-03-12 14:32:48.000000000","message":"The existing ansible package is python2 and we\u0027ll likely need to address this when a final CentOS8 comes out with packaging. I think it\u0027ll likely just be python3 without any designation but we\u0027ll have to see.  Right now the naming is based on availability in RDO on Fedora","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"cfe0c4e41df97d3864d49742c7eb82893d114f67","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"        # TODO(Jeffrey4l): no python-oneviewclient"},{"line_number":11,"context_line":"        {% set ironic_conductor_packages \u003d ["},{"line_number":12,"context_line":"            \u0027ansible\u0027,"},{"line_number":13,"context_line":"            \u0027dosfstools\u0027,"},{"line_number":14,"context_line":"            \u0027e2fsprogs\u0027,"},{"line_number":15,"context_line":"            \u0027gdisk\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_52c0d22a","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":20},"in_reply_to":"5fc1f717_d1112406","updated":"2019-03-12 14:13:07.000000000","message":"from my understanding ansible rpm is different than the ansible-python3 rpm but not conflicting with it.","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"}],"docker/ironic/ironic-pxe/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027mod_ssl\u0027,"},{"line_number":13,"context_line":"        \u0027tftp-server\u0027"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"    {% if distro_python %}"},{"line_number":16,"context_line":"    {% set ironic_pxe_packages \u003d ironic_pxe_packages + [\u0027python3-mod_wsgi\u0027] %}"},{"line_number":17,"context_line":"    {% else %}"},{"line_number":18,"context_line":"    {% set ironic_pxe_packages \u003d ironic_pxe_packages + [\u0027mod_wsgi\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_3b6475e5","line":15,"updated":"2019-02-19 12:59:58.000000000","message":"distro_python3","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        \u0027mod_ssl\u0027,"},{"line_number":13,"context_line":"        \u0027tftp-server\u0027"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"    {% if distro_python %}"},{"line_number":16,"context_line":"    {% set ironic_pxe_packages \u003d ironic_pxe_packages + [\u0027python3-mod_wsgi\u0027] %}"},{"line_number":17,"context_line":"    {% else %}"},{"line_number":18,"context_line":"    {% set ironic_pxe_packages \u003d ironic_pxe_packages + [\u0027mod_wsgi\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_2d68ba85","line":15,"in_reply_to":"9fdfeff1_3b6475e5","updated":"2019-02-19 15:19:55.000000000","message":"Done","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"}],"docker/macros.j2":[{"author":{"_account_id":23942,"name":"Matt Kucia","email":"maciej@kucia.net","username":"maciejkucia"},"change_message_id":"3731e0687b611c0c3a5dcfa103183a9656d8ef3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% macro install_packages(packages) -%}"},{"line_number":2,"context_line":"{% if packages is defined and packages|length \u003e 0 -%}"},{"line_number":3,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 -%}"},{"line_number":4,"context_line":"        {% if distro_python3 -%}"},{"line_number":5,"context_line":"        RUN dnf -y install {{ packages | join(\u0027 \u0027) }} \u0026\u0026 dnf clean all \u0026\u0026 rm -rf /var/cache/yum"},{"line_number":6,"context_line":"        {%- else -%}"},{"line_number":7,"context_line":"        RUN yum -y install {{ packages | join(\u0027 \u0027) }} \u0026\u0026 yum clean all \u0026\u0026 rm -rf /var/cache/yum"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9fdfeff1_e1ba5fdf","line":4,"range":{"start_line":4,"start_character":14,"end_line":4,"end_character":28},"updated":"2019-02-24 20:41:16.000000000","message":"I think there should be an alias or global variable instead of \u0027ifs\u0027. But again, seems unrelated to python version.","commit_id":"44aa4252e8080992fb6d898e629c73b1d0b475c8"}],"docker/neutron/neutron-server-opendaylight/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"29e87fe1a3491ae7cce89e96da974e7840972f55","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \u0027python-networking-bgpvpn-heat\u0027"},{"line_number":26,"context_line":"        ] %}"},{"line_number":27,"context_line":"        {% endif %}"},{"line_number":28,"context_line":"    {% else %}"},{"line_number":29,"context_line":"    {% set neutron_server_opendaylight_packages \u003d ["},{"line_number":30,"context_line":"        \u0027python-networking-odl\u0027,"},{"line_number":31,"context_line":"        \u0027python-networking-bgpvpn\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9fdfeff1_1e7f5fab","line":28,"range":{"start_line":28,"start_character":7,"end_line":28,"end_character":11},"updated":"2019-01-31 17:13:52.000000000","message":"This is slightly different in https://review.openstack.org/#/c/625298/9/docker/neutron/neutron-server-opendaylight/Dockerfile.j2\n\nmight want to make sure these line up for easiest resolution.\n\n {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}","commit_id":"0b3c876d46038601b2396f3e595877416338736b"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"36f66408ae09451e19dcfe7e6d6d68f803f49d46","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \u0027python3-anyjson\u0027,"},{"line_number":44,"context_line":"            \u0027python3-aodhclient\u0027,"},{"line_number":45,"context_line":"            \u0027python3-barbicanclient\u0027,"},{"line_number":46,"context_line":"            \u0027python3-beaker\u0027,"},{"line_number":47,"context_line":"            \u0027python3-cachetools\u0027,"},{"line_number":48,"context_line":"            \u0027python3-cffi\u0027,"},{"line_number":49,"context_line":"            \u0027python3-cliff\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_4e5ec276","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":29},"updated":"2019-01-29 20:24:58.000000000","message":"only thing I can find that uses beaker in openstack is refstack and airship, we might be able to drop this package all together it\u0027s yet another WSGI tool","commit_id":"e6e7cc44261105980df09d8da2fdcbc73608840e"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"90150d4b5d43fa3513500fc434c16ebde0eb428a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \u0027python3-anyjson\u0027,"},{"line_number":44,"context_line":"            \u0027python3-aodhclient\u0027,"},{"line_number":45,"context_line":"            \u0027python3-barbicanclient\u0027,"},{"line_number":46,"context_line":"            \u0027python3-beaker\u0027,"},{"line_number":47,"context_line":"            \u0027python3-cachetools\u0027,"},{"line_number":48,"context_line":"            \u0027python3-cffi\u0027,"},{"line_number":49,"context_line":"            \u0027python3-cliff\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9fdfeff1_5e6f272a","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":29},"updated":"2019-01-31 17:05:31.000000000","message":"this is no-longer needed","commit_id":"c0878e0931d65fbf3f7438191ce74a47d530e8c6"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"90150d4b5d43fa3513500fc434c16ebde0eb428a","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \u0027python-anyjson\u0027,"},{"line_number":170,"context_line":"            \u0027python-aodhclient\u0027,"},{"line_number":171,"context_line":"            \u0027python-barbicanclient\u0027,"},{"line_number":172,"context_line":"            \u0027python-beaker\u0027,"},{"line_number":173,"context_line":"            \u0027python-cloudkittyclient\u0027,"},{"line_number":174,"context_line":"            \u0027python-cmd2\u0027,"},{"line_number":175,"context_line":"            \u0027python-congressclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9fdfeff1_1e751ffa","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":28},"updated":"2019-01-31 17:05:31.000000000","message":"this is no-longer needed","commit_id":"c0878e0931d65fbf3f7438191ce74a47d530e8c6"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5c2587977e6da832abc36211afbda2b679bb1d83","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":36,"context_line":"        ] %}"},{"line_number":37,"context_line":"        {% if distro_python3 %}"},{"line_number":38,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":39,"context_line":"            \u0027python3-PyMySQL\u0027,"},{"line_number":40,"context_line":"            \u0027python3-PyYAML\u0027,"},{"line_number":41,"context_line":"            \u0027python3-alembic\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_db60c9d2","line":38,"updated":"2019-02-19 12:59:58.000000000","message":"https://review.openstack.org/#/c/581380/ should help make the openstack-base change more bearable.","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f362ca7ecb68de6ac380a52eaf983a5b4a902c70","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":36,"context_line":"        ] %}"},{"line_number":37,"context_line":"        {% if distro_python3 %}"},{"line_number":38,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":39,"context_line":"            \u0027python3-PyMySQL\u0027,"},{"line_number":40,"context_line":"            \u0027python3-PyYAML\u0027,"},{"line_number":41,"context_line":"            \u0027python3-alembic\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fdfeff1_4df65edb","line":38,"in_reply_to":"9fdfeff1_db60c9d2","updated":"2019-02-19 15:19:55.000000000","message":"ugh this was such a pain to do :D I\u0027ll try and rebase","commit_id":"b90adf97788d3e2391929da8443790cc287d2ca8"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"99dec65a09ab95da51329d6309863a24e566ecf5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        {% if distro_python3 %}"},{"line_number":35,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":36,"context_line":"            \u0027procps-ng\u0027,"},{"line_number":37,"context_line":"            \u0027python3-PyMySQL\u0027,"},{"line_number":38,"context_line":"            \u0027python3-PyYAML\u0027,"},{"line_number":39,"context_line":"            \u0027python3-alembic\u0027,"},{"line_number":40,"context_line":"            \u0027python3-anyjson\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9fdfeff1_4cf54950","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":29},"updated":"2019-02-28 07:35:01.000000000","message":"Shouldn\u0027t be needed, python3-oslo-db depends on python3-PyMySQL.\n\nhttps://review.rdoproject.org/r/gitweb?p\u003dopenstack/oslo-db-distgit.git;a\u003dblob;f\u003dpython-oslo-db.spec;h\u003da9bc86963138ec28674d76e3d98b79c152ba563b;hb\u003drefs/heads/rpm-master#l151","commit_id":"759d7780a4ad60d84bcfc9357348d8d7f73768e1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"74f69eb04c3feac5f0921622c785213f84429a52","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        {% if distro_python3 %}"},{"line_number":35,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":36,"context_line":"            \u0027procps-ng\u0027,"},{"line_number":37,"context_line":"            \u0027python3-PyMySQL\u0027,"},{"line_number":38,"context_line":"            \u0027python3-PyYAML\u0027,"},{"line_number":39,"context_line":"            \u0027python3-alembic\u0027,"},{"line_number":40,"context_line":"            \u0027python3-anyjson\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9fdfeff1_7cdb0eec","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":29},"in_reply_to":"9fdfeff1_4cf54950","updated":"2019-02-28 15:39:38.000000000","message":"Ok i\u0027ll check out what the deal with that is","commit_id":"759d7780a4ad60d84bcfc9357348d8d7f73768e1"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d48449a8f84f4409e31691de022c3add934e2b07","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        {% if distro_python3 %}"},{"line_number":35,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":36,"context_line":"            \u0027procps-ng\u0027,"},{"line_number":37,"context_line":"            \u0027python3-PyMySQL\u0027,"},{"line_number":38,"context_line":"            \u0027python3-PyYAML\u0027,"},{"line_number":39,"context_line":"            \u0027python3-alembic\u0027,"},{"line_number":40,"context_line":"            \u0027python3-anyjson\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9fdfeff1_f731590c","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":29},"in_reply_to":"9fdfeff1_7cdb0eec","updated":"2019-02-28 16:18:41.000000000","message":"We should not need this either as it should be coming from oslo-db as implicit dep.","commit_id":"759d7780a4ad60d84bcfc9357348d8d7f73768e1"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d48449a8f84f4409e31691de022c3add934e2b07","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027python3-mimeparse\u0027,"},{"line_number":68,"context_line":"            \u0027python3-mistralclient\u0027,"},{"line_number":69,"context_line":"            \u0027python3-muranoclient\u0027,"},{"line_number":70,"context_line":"            \u0027python3-mysql\u0027,"},{"line_number":71,"context_line":"            \u0027python3-neutronclient\u0027,"},{"line_number":72,"context_line":"            \u0027python3-novaclient\u0027,"},{"line_number":73,"context_line":"            \u0027python3-openstackclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9fdfeff1_f3bbac0b","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":28},"updated":"2019-02-28 16:18:41.000000000","message":"I don\u0027t think we need this either here.","commit_id":"759d7780a4ad60d84bcfc9357348d8d7f73768e1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d6185a050f225e365957782d5890ae635d95cd36","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027python3-mimeparse\u0027,"},{"line_number":68,"context_line":"            \u0027python3-mistralclient\u0027,"},{"line_number":69,"context_line":"            \u0027python3-muranoclient\u0027,"},{"line_number":70,"context_line":"            \u0027python3-mysql\u0027,"},{"line_number":71,"context_line":"            \u0027python3-neutronclient\u0027,"},{"line_number":72,"context_line":"            \u0027python3-novaclient\u0027,"},{"line_number":73,"context_line":"            \u0027python3-openstackclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9fdfeff1_552d9cac","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":28},"in_reply_to":"9fdfeff1_f3bbac0b","updated":"2019-03-01 21:50:49.000000000","message":"I think we should remove that separately","commit_id":"759d7780a4ad60d84bcfc9357348d8d7f73768e1"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d48449a8f84f4409e31691de022c3add934e2b07","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            \u0027python2-oslo-versionedobjects\u0027,"},{"line_number":189,"context_line":"            \u0027python2-pika\u0027,"},{"line_number":190,"context_line":"            \u0027python2-pika_pool\u0027,"},{"line_number":191,"context_line":"            \u0027python2-pyOpenSSL\u0027,"},{"line_number":192,"context_line":"            \u0027python2-pyasn1\u0027,"},{"line_number":193,"context_line":"            \u0027python2-sqlalchemy\u0027,"},{"line_number":194,"context_line":"            \u0027python2-sysv_ipc\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"9fdfeff1_937d806e","line":191,"range":{"start_line":191,"start_character":0,"end_line":191,"end_character":32},"updated":"2019-02-28 16:18:41.000000000","message":"where did this one come from?","commit_id":"759d7780a4ad60d84bcfc9357348d8d7f73768e1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5a8ed0452ad41e4e67717b05eb0fd504a9c9969e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"5fc1f717_b032c0a6","updated":"2019-03-06 14:02:50.000000000","message":"just rebased this on request from weshay. the merge conflict was here\n\n(see http://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/periodic-tripleo-fedora-28-master-containers-build-push/bb86bb4/job-output.txt.gz grep for \"failed: 1\"","commit_id":"85b517d5ac3b93ba52e971af8a38c34352172fae"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"9d33910dc2c0cfa9694212d86ef9d60a4d657c58","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027python3-paste-deploy\u0027,"},{"line_number":83,"context_line":"            \u0027python3-pbr\u0027,"},{"line_number":84,"context_line":"            \u0027python3-pika\u0027,"},{"line_number":85,"context_line":"            \u0027python3-pika_pool\u0027,"},{"line_number":86,"context_line":"            \u0027python3-posix_ipc\u0027,"},{"line_number":87,"context_line":"            \u0027python3-prettytable\u0027,"},{"line_number":88,"context_line":"            \u0027python3-psycopg2\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"5fc1f717_77c6369d","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":32},"updated":"2019-03-11 14:59:51.000000000","message":"I7204aab66a252e0fdc3c0eebf5232903340a7e5d dropped pika_pool we should also drop it from this patch\n\nhttps://review.openstack.org/642484 proposed to drop the rpm as well.","commit_id":"de524dc9613f1efd614e39d64a94c29a1d2e7635"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6d2d0b87a076efef8a1de4801ddf3da60a2def7d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027python3-paste-deploy\u0027,"},{"line_number":83,"context_line":"            \u0027python3-pbr\u0027,"},{"line_number":84,"context_line":"            \u0027python3-pika\u0027,"},{"line_number":85,"context_line":"            \u0027python3-pika_pool\u0027,"},{"line_number":86,"context_line":"            \u0027python3-posix_ipc\u0027,"},{"line_number":87,"context_line":"            \u0027python3-prettytable\u0027,"},{"line_number":88,"context_line":"            \u0027python3-psycopg2\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"5fc1f717_17d7b225","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":32},"in_reply_to":"5fc1f717_77c6369d","updated":"2019-03-11 15:01:40.000000000","message":"K i\u0027ll update this but can we not do anymore cleanup until this lands?","commit_id":"de524dc9613f1efd614e39d64a94c29a1d2e7635"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027avahi-libs\u0027,"},{"line_number":13,"context_line":"            \u0027gnutls\u0027,"},{"line_number":14,"context_line":"            \u0027initscripts\u0027,"},{"line_number":15,"context_line":"            \u0027libjpeg-turbo\u0027,"},{"line_number":16,"context_line":"            \u0027libpng\u0027,"},{"line_number":17,"context_line":"            \u0027libxcb\u0027,"},{"line_number":18,"context_line":"            \u0027libxslt\u0027,"},{"line_number":19,"context_line":"            \u0027libyaml\u0027,"},{"line_number":20,"context_line":"            \u0027mailcap\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_bd09dd2c","line":17,"range":{"start_line":15,"start_character":12,"end_line":17,"end_character":21},"updated":"2019-03-11 16:12:45.000000000","message":"Do not install libraries - install packages which depend on libraries and they get installed.\n\n[root@4b34f56c8ad4 /]# rpm -ql libpng\n/usr/lib64/libpng15.so.15\n/usr/lib64/libpng15.so.15.13.0\n/usr/share/doc/libpng-1.5.13\n/usr/share/doc/libpng-1.5.13/CHANGES\n/usr/share/doc/libpng-1.5.13/LICENSE\n/usr/share/doc/libpng-1.5.13/README\n/usr/share/doc/libpng-1.5.13/TODO\n/usr/share/doc/libpng-1.5.13/example.c\n/usr/share/doc/libpng-1.5.13/libpng-manual.txt\n/usr/share/man/man5/png.5.gz\n\nNone of those files are directly needed in openstack-base image. Similar for libjpeg-turbo and libxcb.","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027avahi-libs\u0027,"},{"line_number":13,"context_line":"            \u0027gnutls\u0027,"},{"line_number":14,"context_line":"            \u0027initscripts\u0027,"},{"line_number":15,"context_line":"            \u0027libjpeg-turbo\u0027,"},{"line_number":16,"context_line":"            \u0027libpng\u0027,"},{"line_number":17,"context_line":"            \u0027libxcb\u0027,"},{"line_number":18,"context_line":"            \u0027libxslt\u0027,"},{"line_number":19,"context_line":"            \u0027libyaml\u0027,"},{"line_number":20,"context_line":"            \u0027mailcap\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_fddd2514","line":17,"range":{"start_line":15,"start_character":12,"end_line":17,"end_character":21},"in_reply_to":"5fc1f717_bd09dd2c","updated":"2019-03-11 16:35:27.000000000","message":"These must be a left over from a rebase. I think these used to be here but mandre cleaned it up.","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        {% else %}"},{"line_number":105,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":106,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":107,"context_line":"            \u0027openssl\u0027,"},{"line_number":108,"context_line":"            \u0027python2-cryptography\u0027,"},{"line_number":109,"context_line":"            \u0027python2-eventlet\u0027,"},{"line_number":110,"context_line":"            \u0027python2-iso8601\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_5d18f973","line":107,"range":{"start_line":107,"start_character":13,"end_line":107,"end_character":20},"updated":"2019-03-11 16:12:45.000000000","message":"already in openstack_base_packages","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        {% else %}"},{"line_number":105,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":106,"context_line":"            \u0027MySQL-python\u0027,"},{"line_number":107,"context_line":"            \u0027openssl\u0027,"},{"line_number":108,"context_line":"            \u0027python2-cryptography\u0027,"},{"line_number":109,"context_line":"            \u0027python2-eventlet\u0027,"},{"line_number":110,"context_line":"            \u0027python2-iso8601\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_9dcc2162","line":107,"range":{"start_line":107,"start_character":13,"end_line":107,"end_character":20},"in_reply_to":"5fc1f717_5d18f973","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            \u0027python2-webob\u0027,"},{"line_number":180,"context_line":"            \u0027python-zaqarclient\u0027,"},{"line_number":181,"context_line":"            \u0027PyYAML\u0027,"},{"line_number":182,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":183,"context_line":"            \u0027sysvinit-tools\u0027,"},{"line_number":184,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":185,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_9d0e6130","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":27},"updated":"2019-03-11 16:12:45.000000000","message":"already in openstack_base_packages","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            \u0027python2-webob\u0027,"},{"line_number":180,"context_line":"            \u0027python-zaqarclient\u0027,"},{"line_number":181,"context_line":"            \u0027PyYAML\u0027,"},{"line_number":182,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":183,"context_line":"            \u0027sysvinit-tools\u0027,"},{"line_number":184,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":185,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_3ddbad1b","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":27},"in_reply_to":"5fc1f717_9d0e6130","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ef27b3e90bc58f30ba39e627346abd2f45409de2","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            \u0027PyYAML\u0027,"},{"line_number":182,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":183,"context_line":"            \u0027sysvinit-tools\u0027,"},{"line_number":184,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":185,"context_line":"        ] %}"},{"line_number":186,"context_line":"        {% endif %}"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_3d1ded65","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":31},"updated":"2019-03-11 16:12:45.000000000","message":"already in openstack_base_packages","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"10412f74d55d33dc76ab5550e070bb63b886993e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            \u0027PyYAML\u0027,"},{"line_number":182,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":183,"context_line":"            \u0027sysvinit-tools\u0027,"},{"line_number":184,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":185,"context_line":"        ] %}"},{"line_number":186,"context_line":"        {% endif %}"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"5fc1f717_1d0a7189","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":31},"in_reply_to":"5fc1f717_3d1ded65","updated":"2019-03-11 16:35:27.000000000","message":"Done","commit_id":"9419ef817ef4dcd816426a953a97047dbe814277"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"41636d88321c6b6b9897fbd213976b76b0375e82","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027mailcap\u0027,"},{"line_number":18,"context_line":"            \u0027openssl\u0027,"},{"line_number":19,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":20,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"        {% if distro_python3 %}"},{"line_number":23,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_e62ca403","line":20,"updated":"2019-03-12 11:00:19.000000000","message":"There is a patch proposing to remove this: https://review.openstack.org/#/c/642706/1","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7a389632ac18a2b895418c60db6429ea84006c8a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027mailcap\u0027,"},{"line_number":18,"context_line":"            \u0027openssl\u0027,"},{"line_number":19,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":20,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"        {% if distro_python3 %}"},{"line_number":23,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_b243366c","line":20,"in_reply_to":"5fc1f717_b2e496e1","updated":"2019-03-12 14:27:58.000000000","message":"And rebased on top of this one","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"cfe0c4e41df97d3864d49742c7eb82893d114f67","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            \u0027mailcap\u0027,"},{"line_number":18,"context_line":"            \u0027openssl\u0027,"},{"line_number":19,"context_line":"            \u0027systemd-sysv\u0027,"},{"line_number":20,"context_line":"            \u0027tcp_wrappers-libs\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"        {% if distro_python3 %}"},{"line_number":23,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_b2e496e1","line":20,"in_reply_to":"5fc1f717_e62ca403","updated":"2019-03-12 14:13:07.000000000","message":"being rebased to depend on this patch, as it is small cleanup/optimization","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"840adedeec5ac47b4a8cc2376a29f19acdb069ea","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"        {% if distro_python3 %}"},{"line_number":23,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["},{"line_number":24,"context_line":"            \u0027procps-ng\u0027,"},{"line_number":25,"context_line":"            \u0027python3-PyYAML\u0027,"},{"line_number":26,"context_line":"            \u0027python3-alembic\u0027,"},{"line_number":27,"context_line":"            \u0027python3-anyjson\u0027,"},{"line_number":28,"context_line":"            \u0027python3-aodhclient\u0027,"},{"line_number":29,"context_line":"            \u0027python3-barbicanclient\u0027,"},{"line_number":30,"context_line":"            \u0027python3-cachetools\u0027,"},{"line_number":31,"context_line":"            \u0027python3-cloudkittyclient\u0027,"},{"line_number":32,"context_line":"            \u0027python3-congressclient\u0027,"},{"line_number":33,"context_line":"            \u0027python3-contextlib2\u0027,"},{"line_number":34,"context_line":"            \u0027python3-cryptography\u0027,"},{"line_number":35,"context_line":"            \u0027python3-designateclient\u0027,"},{"line_number":36,"context_line":"            \u0027python3-elasticsearch\u0027,"},{"line_number":37,"context_line":"            \u0027python3-eventlet\u0027,"},{"line_number":38,"context_line":"            \u0027python3-extras\u0027,"},{"line_number":39,"context_line":"            \u0027python3-glanceclient\u0027,"},{"line_number":40,"context_line":"            \u0027python3-gnocchiclient\u0027,"},{"line_number":41,"context_line":"            \u0027python3-heatclient\u0027,"},{"line_number":42,"context_line":"            \u0027python3-httplib2\u0027,"},{"line_number":43,"context_line":"            \u0027python3-ironicclient\u0027,"},{"line_number":44,"context_line":"            \u0027python3-iso8601\u0027,"},{"line_number":45,"context_line":"            \u0027python3-kazoo\u0027,"},{"line_number":46,"context_line":"            \u0027python3-keystoneauth1\u0027,"},{"line_number":47,"context_line":"            \u0027python3-keystoneclient\u0027,"},{"line_number":48,"context_line":"            \u0027python3-keystonemiddleware\u0027,"},{"line_number":49,"context_line":"            \u0027python3-logutils\u0027,"},{"line_number":50,"context_line":"            \u0027python3-lxml\u0027,"},{"line_number":51,"context_line":"            \u0027python3-magnumclient\u0027,"},{"line_number":52,"context_line":"            \u0027python3-manilaclient\u0027,"},{"line_number":53,"context_line":"            \u0027python3-migrate\u0027,"},{"line_number":54,"context_line":"            \u0027python3-mimeparse\u0027,"},{"line_number":55,"context_line":"            \u0027python3-mistralclient\u0027,"},{"line_number":56,"context_line":"            \u0027python3-muranoclient\u0027,"},{"line_number":57,"context_line":"            \u0027python3-mysql\u0027,"},{"line_number":58,"context_line":"            \u0027python3-neutronclient\u0027,"},{"line_number":59,"context_line":"            \u0027python3-novaclient\u0027,"},{"line_number":60,"context_line":"            \u0027python3-openstackclient\u0027,"},{"line_number":61,"context_line":"            \u0027python3-oslo-cache\u0027,"},{"line_number":62,"context_line":"            \u0027python3-oslo-concurrency\u0027,"},{"line_number":63,"context_line":"            \u0027python3-oslo-config\u0027,"},{"line_number":64,"context_line":"            \u0027python3-oslo-context\u0027,"},{"line_number":65,"context_line":"            \u0027python3-oslo-db\u0027,"},{"line_number":66,"context_line":"            \u0027python3-oslo-i18n\u0027,"},{"line_number":67,"context_line":"            \u0027python3-oslo-log\u0027,"},{"line_number":68,"context_line":"            \u0027python3-oslo-messaging\u0027,"},{"line_number":69,"context_line":"            \u0027python3-oslo-middleware\u0027,"},{"line_number":70,"context_line":"            \u0027python3-oslo-policy\u0027,"},{"line_number":71,"context_line":"            \u0027python3-oslo-reports\u0027,"},{"line_number":72,"context_line":"            \u0027python3-oslo-rootwrap\u0027,"},{"line_number":73,"context_line":"            \u0027python3-oslo-serialization\u0027,"},{"line_number":74,"context_line":"            \u0027python3-oslo-service\u0027,"},{"line_number":75,"context_line":"            \u0027python3-oslo-utils\u0027,"},{"line_number":76,"context_line":"            \u0027python3-oslo-versionedobjects\u0027,"},{"line_number":77,"context_line":"            \u0027python3-osprofiler\u0027,"},{"line_number":78,"context_line":"            \u0027python3-paramiko\u0027,"},{"line_number":79,"context_line":"            \u0027python3-paste-deploy\u0027,"},{"line_number":80,"context_line":"            \u0027python3-pbr\u0027,"},{"line_number":81,"context_line":"            \u0027python3-pika\u0027,"},{"line_number":82,"context_line":"            \u0027python3-posix_ipc\u0027,"},{"line_number":83,"context_line":"            \u0027python3-prettytable\u0027,"},{"line_number":84,"context_line":"            \u0027python3-psycopg2\u0027,"},{"line_number":85,"context_line":"            \u0027python3-pyasn1\u0027,"},{"line_number":86,"context_line":"            \u0027python3-redis\u0027,"},{"line_number":87,"context_line":"            \u0027python3-retrying\u0027,"},{"line_number":88,"context_line":"            \u0027python3-routes\u0027,"},{"line_number":89,"context_line":"            \u0027python3-saharaclient\u0027,"},{"line_number":90,"context_line":"            \u0027python3-sqlalchemy\u0027,"},{"line_number":91,"context_line":"            \u0027python3-sqlparse\u0027,"},{"line_number":92,"context_line":"            \u0027python3-swiftclient\u0027,"},{"line_number":93,"context_line":"            \u0027python3-sysv_ipc\u0027,"},{"line_number":94,"context_line":"            \u0027python3-tooz\u0027,"},{"line_number":95,"context_line":"            \u0027python3-troveclient\u0027,"},{"line_number":96,"context_line":"            \u0027python3-vitrageclient\u0027,"},{"line_number":97,"context_line":"            \u0027python3-webob\u0027,"},{"line_number":98,"context_line":"            \u0027python3-zaqarclient\u0027,"},{"line_number":99,"context_line":"            \u0027util-linux-user\u0027"},{"line_number":100,"context_line":"        ] %}"},{"line_number":101,"context_line":"        {% else %}"},{"line_number":102,"context_line":"        {% set openstack_base_packages \u003d openstack_base_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"5fc1f717_b10b387b","line":99,"range":{"start_line":24,"start_character":0,"end_line":99,"end_character":29},"updated":"2019-03-12 11:56:46.000000000","message":"I\u0027ve been through all these, looks like they\u0027re all present.","commit_id":"bcf0da3f87d77474d769eb37415794efc98897b2"}]}