)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"3f7a940f1c2cae6edfe09ca486a39f73bf7fc69b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"moved out of openstack and so naming changed from"},{"line_number":11,"context_line":"openstack-gnocchi-XXX to gnocchi-XXX"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"January 2018 - I2a07f09c4ad37c661ea222c775c85f02842cbd64"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also openstack-gnocchi-indexer-sqlalchemy was moved to gnocchi-common"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_c4b7a920","line":13,"updated":"2019-02-18 10:34:48.000000000","message":"Use the URL instead of the Change-Id since these patches are from a different gerrit instance:\nhttps://review.rdoproject.org/r/#/c/11110/","commit_id":"d655c253dc53b8a639fbe276731402df7320b45d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"3f7a940f1c2cae6edfe09ca486a39f73bf7fc69b","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also openstack-gnocchi-indexer-sqlalchemy was moved to gnocchi-common"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"2017 - I7fd7d21b14455f1705e3efce046f7fad8ce027fa"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I511c248bd009d03cad6811c576dd91a7bb29e203"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_0447f11e","line":17,"updated":"2019-02-18 10:34:48.000000000","message":"ditto https://review.rdoproject.org/r/#/c/10449/","commit_id":"d655c253dc53b8a639fbe276731402df7320b45d"}],"docker/gnocchi/gnocchi-api/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d47b1c8797bffa48adc20f79c20acebf52c17b50","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            \u0027gnocchi-common\u0027"},{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":15,"context_line":"        {% set gnocchi_api_packages \u003d [\u0027gnocchi-api\u0027] %}"},{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_19fc023d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":56},"updated":"2019-02-06 15:26:56.000000000","message":"same just doesn\u0027t have gnocchi-common (from the indexer)","commit_id":"b0c5ac2c00914579dd8e40336ad39d8efdce2254"}],"docker/gnocchi/gnocchi-base/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d47b1c8797bffa48adc20f79c20acebf52c17b50","unresolved":false,"context_lines":[{"line_number":16,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":17,"context_line":"            \u0027gnocchi-common\u0027,"},{"line_number":18,"context_line":"            \u0027python2-ldappool\u0027,"},{"line_number":19,"context_line":"            \u0027python2-cradox\u0027"},{"line_number":20,"context_line":"        ] %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{ macros.install_packages(gnocchi_base_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_b9a2964a","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"updated":"2019-02-06 15:26:56.000000000","message":"just noticed cradox vs rados differences here, not for this review but just noticed","commit_id":"b0c5ac2c00914579dd8e40336ad39d8efdce2254"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d47b1c8797bffa48adc20f79c20acebf52c17b50","unresolved":false,"context_lines":[{"line_number":27,"context_line":"       {% set gnocchi_base_packages \u003d ["},{"line_number":28,"context_line":"            \u0027apache2\u0027,"},{"line_number":29,"context_line":"            \u0027build-essential\u0027,"},{"line_number":30,"context_line":"            \u0027gnocchi-common\u0027,"},{"line_number":31,"context_line":"            \u0027libapache2-mod-wsgi\u0027,"},{"line_number":32,"context_line":"            \u0027librados-dev\u0027,"},{"line_number":33,"context_line":"            \u0027python-dev\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_d993daff","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":29},"updated":"2019-02-06 15:26:56.000000000","message":"same name here","commit_id":"b0c5ac2c00914579dd8e40336ad39d8efdce2254"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4b293fe0d21401c8412d7693badfe67da346afa1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u0027httpd\u0027,"},{"line_number":15,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":16,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":17,"context_line":"            \u0027gnocchi-common\u0027,"},{"line_number":18,"context_line":"            \u0027python2-ldappool\u0027,"},{"line_number":19,"context_line":"            \u0027python2-cradox\u0027"},{"line_number":20,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_81109caa","line":17,"updated":"2019-02-19 08:33:03.000000000","message":"might want to keep alphabetical order","commit_id":"9b4648877c454ddfd6f1909be09694c38a4cae7f"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"ed49bd0a73efe1c620117029d21c5f3625d6c959","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \u0027httpd\u0027,"},{"line_number":15,"context_line":"            \u0027mod_ssl\u0027,"},{"line_number":16,"context_line":"            \u0027mod_wsgi\u0027,"},{"line_number":17,"context_line":"            \u0027gnocchi-common\u0027,"},{"line_number":18,"context_line":"            \u0027python2-ldappool\u0027,"},{"line_number":19,"context_line":"            \u0027python2-cradox\u0027"},{"line_number":20,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fdfeff1_21af702c","line":17,"in_reply_to":"9fdfeff1_81109caa","updated":"2019-02-19 08:40:23.000000000","message":"Done","commit_id":"9b4648877c454ddfd6f1909be09694c38a4cae7f"}],"docker/gnocchi/gnocchi-metricd/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"b4f9dd16c4c4ab3c9a00f95028302d903585663a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"       {% set gnocchi_metricd_packages \u003d [\u0027gnocchi-metricd\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":12,"context_line":"        {% set gnocchi_metricd_packages \u003d [\u0027gnocchi-metricd\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"{{ macros.install_packages(gnocchi_metricd_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fdfeff1_a245b5b5","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":15},"updated":"2019-02-18 12:29:29.000000000","message":"We could possibly merge into a single branch now that the packages names are identical.","commit_id":"77accff00478f962e6589a143ba589c2ada3f7f0"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"21afb74648ff0f2438e585df5d30e4f1202e3291","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"       {% set gnocchi_metricd_packages \u003d [\u0027gnocchi-metricd\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":12,"context_line":"        {% set gnocchi_metricd_packages \u003d [\u0027gnocchi-metricd\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"{{ macros.install_packages(gnocchi_metricd_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fdfeff1_1325f15b","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":15},"in_reply_to":"9fdfeff1_5815d69a","updated":"2019-02-18 14:19:53.000000000","message":"In other plackes I used a map to resolve these like \"pkg_map[ansible_pkg_mgr]\" as is very easy to maintain and more future proof/extensible.","commit_id":"77accff00478f962e6589a143ba589c2ada3f7f0"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"1caa54b0bd71b461da4de53f51aaa4523399412d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"       {% set gnocchi_metricd_packages \u003d [\u0027gnocchi-metricd\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":12,"context_line":"        {% set gnocchi_metricd_packages \u003d [\u0027gnocchi-metricd\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"{{ macros.install_packages(gnocchi_metricd_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fdfeff1_5815d69a","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":15},"in_reply_to":"9fdfeff1_a245b5b5","updated":"2019-02-18 13:53:07.000000000","message":"makes sense to me to collapse them","commit_id":"77accff00478f962e6589a143ba589c2ada3f7f0"}],"docker/gnocchi/gnocchi-statsd/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"d47b1c8797bffa48adc20f79c20acebf52c17b50","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"       {% set gnocchi_statsd_packages \u003d [\u0027gnocchi-statsd\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"       {% set gnocchi_statsd_packages \u003d [\u0027gnocchi-statsd\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"{{ macros.install_packages(gnocchi_statsd_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_5987eab7","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":61},"updated":"2019-02-06 15:26:56.000000000","message":"now the same, and could be collapsed down if we really wanted to","commit_id":"b0c5ac2c00914579dd8e40336ad39d8efdce2254"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"b4f9dd16c4c4ab3c9a00f95028302d903585663a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":9,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":10,"context_line":"       {% set gnocchi_statsd_packages \u003d [\u0027gnocchi-statsd\u0027] %}"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":"       {% set gnocchi_statsd_packages \u003d [\u0027gnocchi-statsd\u0027] %}"},{"line_number":13,"context_line":"    {% endif %}"},{"line_number":14,"context_line":"{{ macros.install_packages(gnocchi_statsd_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fdfeff1_62158d9b","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":15},"updated":"2019-02-18 12:29:29.000000000","message":"ditto","commit_id":"77accff00478f962e6589a143ba589c2ada3f7f0"}]}