)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b23933433182d614d0acecce8310bb1f8894047d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"previous proposal was https://review.openstack.org/#/c/632156/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This would prevent having to do an append/remove from packages list when"},{"line_number":16,"context_line":"there\u0027s an alternate package name."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I0a7630e07c5100199236170f745f2c8148df6c42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfb3d3c7_a4bee262","line":16,"updated":"2019-05-21 16:25:11.000000000","message":"Could use an update to the docs to illustrate how this works - finding it hard to visualise.","commit_id":"1d0f125ef3da10411c9d506b8b0351eb97799006"}],"kolla/common/config.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"40d044b0b981ecf304ce9709368a7d7505b9d29c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":251,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":252,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":253,"context_line":"    cfg.MultiOpt(\u0027package-replacements\u0027, types.String(),"},{"line_number":254,"context_line":"                 help\u003d\u0027Path to package replacements file\u0027),"},{"line_number":255,"context_line":"    cfg.MultiOpt(\u0027docker-dir\u0027, types.String(),"},{"line_number":256,"context_line":"                 help\u003d(\u0027Path to additional docker file template directory,\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_53ac958b","line":253,"range":{"start_line":253,"start_character":18,"end_line":253,"end_character":38},"updated":"2019-05-21 08:47:46.000000000","message":"Just wondering, any reason not to do this in the template override file as \u003cvariable\u003e_replacements?","commit_id":"1d0f125ef3da10411c9d506b8b0351eb97799006"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3929bcfd51967a5153269edf4f0fbc0876b541af","unresolved":false,"context_lines":[{"line_number":250,"context_line":"               help\u003d\u0027Time in seconds after which any operation times out\u0027),"},{"line_number":251,"context_line":"    cfg.MultiOpt(\u0027template-override\u0027, types.String(),"},{"line_number":252,"context_line":"                 help\u003d\u0027Path to template override file\u0027),"},{"line_number":253,"context_line":"    cfg.MultiOpt(\u0027package-replacements\u0027, types.String(),"},{"line_number":254,"context_line":"                 help\u003d\u0027Path to package replacements file\u0027),"},{"line_number":255,"context_line":"    cfg.MultiOpt(\u0027docker-dir\u0027, types.String(),"},{"line_number":256,"context_line":"                 help\u003d(\u0027Path to additional docker file template directory,\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_b6a4d8ba","line":253,"range":{"start_line":253,"start_character":18,"end_line":253,"end_character":38},"in_reply_to":"bfb3d3c7_53ac958b","updated":"2019-05-21 14:51:40.000000000","message":"This would be external to a template override file. So technically you could reuse an existing template override file and then swap out all the packages.  So in the tripleo-case, we have various package names in our template override file.  So if we use this we could have the existing configuration and swap out the packages globally. This eliminates the need to key off of OS/Version.  So this was handy when testing python2-* to python3-* names w/o having to change any of the existing Dockerfiles or templates","commit_id":"1d0f125ef3da10411c9d506b8b0351eb97799006"}],"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b23933433182d614d0acecce8310bb1f8894047d","unresolved":false,"context_lines":[{"line_number":947,"context_line":"                      \u0027rpm_setup\u0027: self.rpm_setup,"},{"line_number":948,"context_line":"                      \u0027build_date\u0027: build_date,"},{"line_number":949,"context_line":"                      \u0027clean_package_cache\u0027: self.clean_package_cache,"},{"line_number":950,"context_line":"                      \u0027package_replacements\u0027: self.package_replacements}"},{"line_number":951,"context_line":"            env \u003d jinja2.Environment(  # nosec: not used to render HTML"},{"line_number":952,"context_line":"                loader\u003djinja2.FileSystemLoader(self.working_dir))"},{"line_number":953,"context_line":"            env.filters.update(self._get_filters())"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_447286e5","line":950,"range":{"start_line":950,"start_character":23,"end_line":950,"end_character":43},"updated":"2019-05-21 16:25:11.000000000","message":"Should this be packages_replacement to match \u003ccall_type\u003e_replacement?","commit_id":"1d0f125ef3da10411c9d506b8b0351eb97799006"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b23933433182d614d0acecce8310bb1f8894047d","unresolved":false,"context_lines":[{"line_number":994,"context_line":""},{"line_number":995,"context_line":"        if not replacements:"},{"line_number":996,"context_line":"            return {}"},{"line_number":997,"context_line":"        with open(replacements[0], \u0027r\u0027) as f:"},{"line_number":998,"context_line":"            content \u003d json.load(f)"},{"line_number":999,"context_line":"        for override in replacements[1:]:"},{"line_number":1000,"context_line":"            with open(override, \u0027r\u0027) as f:"},{"line_number":1001,"context_line":"                content \u003d __merge_dict(content, json.load(f))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_84edde8c","line":998,"range":{"start_line":997,"start_character":0,"end_line":998,"end_character":34},"updated":"2019-05-21 16:25:11.000000000","message":"nit: could set content \u003d {}, then iterate over all items.","commit_id":"1d0f125ef3da10411c9d506b8b0351eb97799006"}]}