)]}'
{"docker/nova/nova-base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d9a262fbf2fa31fd97373b5f2820b56cf6c72615","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag !\u003d \u00278\u0027 %} "},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_058c0bd5","line":22,"range":{"start_line":22,"start_character":75,"end_line":22,"end_character":78},"updated":"2019-02-14 08:55:21.000000000","message":"I don\u0027t think we can rely on this being \u00278\u0027. It could be e.g. \u00278.0.1910\u0027, or some other custom tag that doesn\u0027t include the version. I\u0027m not even sure that we can know this at the time of Jinja templating.\n\nMaybe we can use /etc/os-release?","commit_id":"1f81b37458b6cc7adfe1a1d45d84a39b955d12ce"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c68954b1721e1548cc0f5361e6611f9650947ba9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag !\u003d \u00278\u0027 %} "},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_fb2e448a","line":22,"range":{"start_line":22,"start_character":75,"end_line":22,"end_character":78},"in_reply_to":"9fdfeff1_00f7195b","updated":"2019-02-14 09:58:03.000000000","message":"You can use some python in jinja templates:\n\n  {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and not base_distro_tag.startswith(\u00277\u0027) %}","commit_id":"1f81b37458b6cc7adfe1a1d45d84a39b955d12ce"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"126b5be4c3a8ce84d9c233cddc54f964cf7b9cc2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag !\u003d \u00278\u0027 %} "},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_a09badc6","line":22,"range":{"start_line":22,"start_character":75,"end_line":22,"end_character":78},"in_reply_to":"9fdfeff1_058c0bd5","updated":"2019-02-14 09:09:55.000000000","message":"So the following python3 check is also using \u00278\u0027, is the use of custom base_distro_tags that prevalent?\n\nhttps://github.com/openstack/kolla/blob/master/kolla/image/build.py#L694-L696","commit_id":"1f81b37458b6cc7adfe1a1d45d84a39b955d12ce"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a8d6d6517b2327b7d6a91d7c6d7a4073cf0a2fe9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag !\u003d \u00278\u0027 %} "},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_c00b518b","line":22,"range":{"start_line":22,"start_character":75,"end_line":22,"end_character":78},"in_reply_to":"9fdfeff1_a09badc6","updated":"2019-02-14 09:40:11.000000000","message":"That\u0027s a fair point. I think we should at least support using a specific version of the OS e.g. 7.6.1810, I have seen that used when a new image is not yet supported.\n\nIn the Py3 case you\u0027ve linked you can at least set distro_python3 explicitly in config if you need to. We should probably change that conditional to \"startswith(\u00278\u0027)\", or even \"not startswith(\u00277\u0027)\" if we\u0027re being future proof.","commit_id":"1f81b37458b6cc7adfe1a1d45d84a39b955d12ce"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1e132f66ef446bae273c634b9cca56bddd633748","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag !\u003d \u00278\u0027 %} "},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_00f7195b","line":22,"range":{"start_line":22,"start_character":75,"end_line":22,"end_character":78},"in_reply_to":"9fdfeff1_c00b518b","updated":"2019-02-14 09:49:39.000000000","message":"kk, I\u0027ve been looking around for examples of using startswith in these templates and have come up empty handed. Any ideas?","commit_id":"1f81b37458b6cc7adfe1a1d45d84a39b955d12ce"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33c1c5dbec0163e01851cbb20a4ed07c2f681bea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag !\u003d \u00278\u0027 %} "},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_7bded43e","line":22,"range":{"start_line":22,"start_character":75,"end_line":22,"end_character":78},"in_reply_to":"9fdfeff1_fb2e448a","updated":"2019-02-14 10:05:59.000000000","message":"Oops, I got my logic backwards. Thankfully you noticed :)","commit_id":"1f81b37458b6cc7adfe1a1d45d84a39b955d12ce"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"42ec3d899835452637cebcfeb4e546c7f1611874","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":30,"context_line":"                    \u0027AAVMF\u0027"},{"line_number":31,"context_line":"                ] %}"},{"line_number":32,"context_line":"            {% endif %}"},{"line_number":33,"context_line":"        {% elif base_arch \u003d\u003d \u0027ppc64le\u0027 %}"},{"line_number":34,"context_line":"            {# NOTE(Jeffrey4l): no packages for ppc64le #}"},{"line_number":35,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fdfeff1_c5ccc336","line":32,"updated":"2019-02-14 08:49:44.000000000","message":"Yep, both x86_64 and AArch64 conditionals looks good to me.","commit_id":"a271348c3d455d49c2147e7c68a89092ac2529c5"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"a3688d799588659d27b36e8ef62489698d9933c6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        ] %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":22,"context_line":"            {% if base_distro in [\u0027rhel\u0027, \u0027centos\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":23,"context_line":"                {% set nova_base_packages \u003d nova_base_packages + ["},{"line_number":24,"context_line":"                    \u0027OVMF\u0027"},{"line_number":25,"context_line":"                ] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fdfeff1_78321aa9","line":22,"updated":"2019-02-18 13:39:33.000000000","message":"We also need oraclelinux in the list.\n\nhttp://logs.openstack.org/57/636857/3/check/kolla-build-oraclelinux-binary/e57bd68/logs/build/000_FAILED_nova-base.txt.gz","commit_id":"ef033602a592697201501fb439671f901fc3196f"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"6ca5b8e8799506fd8f8b4c51b3d99076f68de733","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":136,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":137,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":138,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":139,"context_line":"    {% endif %}"},{"line_number":140,"context_line":"{% endif %}"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9fdfeff1_63c385ee","line":139,"range":{"start_line":136,"start_character":0,"end_line":139,"end_character":15},"updated":"2019-02-14 17:38:08.000000000","message":"Is this still needed to be symlinked? can we request that it is provided this way or can the code that uses it be adjusted to use the provided paths?","commit_id":"ef033602a592697201501fb439671f901fc3196f"}]}