)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"e601dadb27462eae81beb36d83d0426a3b512f13","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{% set base_yum_repo_files \u003d ["},{"line_number":61,"context_line":" ] %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% set base_yum_url_packages \u003d ["},{"line_number":64,"context_line":"    \u0027https://repo.percona.com/yum/percona-release-latest.noarch.rpm\u0027"},{"line_number":65,"context_line":"] %}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_b9fb55bc","line":63,"updated":"2019-02-21 17:18:27.000000000","message":"small nit, can we open this with {%- set .. here to eat the leading whitespace when template rendering happens?","commit_id":"3c79938dc293b2c14d55974c2070ca591ec3af9f"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"321a672d53eb87cc44cf43ff743578c78c3f85b4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{% set base_yum_repo_files \u003d ["},{"line_number":61,"context_line":" ] %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% set base_yum_url_packages \u003d ["},{"line_number":64,"context_line":"    \u0027https://repo.percona.com/yum/percona-release-latest.noarch.rpm\u0027"},{"line_number":65,"context_line":"] %}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_827f68dd","line":63,"in_reply_to":"9fdfeff1_9c837bcb","updated":"2019-02-28 19:38:27.000000000","message":"Like I said nit only and not needed.  This is a useful patch for cleanup and would like to see it get merged as is and whitespace issues can be dealt with in the future.","commit_id":"3c79938dc293b2c14d55974c2070ca591ec3af9f"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"ae51bfcc653d248b890ffdb0ceffe680c46e26c5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"{% set base_yum_repo_files \u003d ["},{"line_number":61,"context_line":" ] %}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{% set base_yum_url_packages \u003d ["},{"line_number":64,"context_line":"    \u0027https://repo.percona.com/yum/percona-release-latest.noarch.rpm\u0027"},{"line_number":65,"context_line":"] %}"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_9c837bcb","line":63,"in_reply_to":"9fdfeff1_b9fb55bc","updated":"2019-02-27 09:37:08.000000000","message":"If we want to strip new lines from the rendered Dockerfile, we should make the change globally, and perhaps we should consider setting the trim_blocks and lstrip_blocks options?\n\nhttp://jinja.pocoo.org/docs/2.10/templates/#whitespace-control\n\nManually removing leading whitepaces for each jinja2 block will likely be quite painful and error prone. But even when using the above jinja2 options, we would then have to start using {%+ for block that rely on leading whitespaces. There\u0027s also a high risk of screwing things up.\n\nSo I\u0027m not even sure we want this. Our objective is to make the rendered Dockerfiles functionally correct. It would take some work to make them more beautiful to the eyes and that\u0027s not without risks.","commit_id":"3c79938dc293b2c14d55974c2070ca591ec3af9f"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"e601dadb27462eae81beb36d83d0426a3b512f13","unresolved":false,"context_lines":[{"line_number":100,"context_line":"{%- if not loop.last %} \\{% endif %}"},{"line_number":101,"context_line":"{% endfor -%}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"{% block base_rpm_repo_enablement %}"},{"line_number":104,"context_line":"RUN yum-config-manager --disable percona\\*"},{"line_number":105,"context_line":"{% endblock %}"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_d9e41911","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":36},"updated":"2019-02-21 17:18:27.000000000","message":"same here can we do leading whitespace eating please?\n{%- base_rpm_repo_enablement %}","commit_id":"3c79938dc293b2c14d55974c2070ca591ec3af9f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e743d4e225b5b0a4e2253adfa1b369c3938ceaf9","unresolved":false,"context_lines":[{"line_number":101,"context_line":"{% endfor -%}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"{% block base_rpm_repo_enablement %}"},{"line_number":104,"context_line":"RUN yum-config-manager --disable percona\\*"},{"line_number":105,"context_line":"{% endblock %}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_a42333a7","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":42},"updated":"2019-02-21 14:33:17.000000000","message":"Related: Would be nice to do this for all repos, then enable them as needed.","commit_id":"3c79938dc293b2c14d55974c2070ca591ec3af9f"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"a7856102c2772c4f310fe912e8ca381e41b299a7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"{% endfor -%}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"{% block base_rpm_repo_enablement %}"},{"line_number":104,"context_line":"RUN yum-config-manager --disable percona\\*"},{"line_number":105,"context_line":"{% endblock %}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    {% if install_metatype in [\u0027rdo\u0027, \u0027mixed\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_84caaf9e","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":42},"in_reply_to":"9fdfeff1_a42333a7","updated":"2019-02-21 14:39:46.000000000","message":"Yes, indeed","commit_id":"3c79938dc293b2c14d55974c2070ca591ec3af9f"}]}
