)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5c7286490e4cdff408a3710fc7fdbf7765396aa7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b425fdae_3cff7738","updated":"2022-01-04 09:42:00.000000000","message":"There is an upstream docker container available now at https://hub.docker.com/r/alekseizakharov/libvirt-exporter which seems to work just fine, do we still need this? If yes, e.g. because you want to build for arm64, what would be the reason not to base the build on alpine:golang as upstream does?","commit_id":"cca435bfaee46f15bca4fed5ee0d54fbe5a2fca7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"df39bd9b162584385fcbcbb72c58fc627b1ad624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"61c863ee_e9cdac2d","updated":"2022-02-17 09:13:14.000000000","message":"I found a solution but that involves using \"go mod\", I\u0027ll put up a patch for discussion","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"875c451ba26f14b26e63509a54be9ef9de9fe4fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"442a69a5_45d96364","updated":"2022-01-05 10:12:08.000000000","message":"recheck arm build","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9cc426eb975bfea52c88c499b28b850e72c12292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"11f256d4_1bf7dfa2","updated":"2022-01-04 17:04:07.000000000","message":"recheck debug arm","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e5fac803e59a5f14324828757e91c6460329ea81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"78e55755_06d3b4e1","updated":"2022-01-05 14:37:00.000000000","message":"recheck git clone failure","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ea74269c71494bc52cc2a29a350511bc1b2cd754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c835c621_1fb03b7f","updated":"2022-02-17 18:23:04.000000000","message":"Looks good for now, if the project will start releasing binaries we\u0027ll adapt.","commit_id":"afce8598ac098fdb2e11ebac587ef7b13a6d4ec8"}],"docker/prometheus/prometheus-libvirt-exporter/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"05e986809e7994c68197ee9d789a6556afc220b5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block prometheus_libvirt_exporter_header %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["},{"line_number":10,"context_line":"        \u0027go\u0027,"},{"line_number":11,"context_line":"        \u0027libvirt-devel\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_63a139f8","line":8,"range":{"start_line":8,"start_character":5,"end_line":8,"end_character":54},"updated":"2019-03-15 11:21:05.000000000","message":"if base_package_format \u003d\u003d \u0027rpm\u0027 (and deb below) please.","commit_id":"7d33bc181fb3ecd59b6eaaca78f167b3641bf40b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"05e986809e7994c68197ee9d789a6556afc220b5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV GOPATH\u003d/build"},{"line_number":29,"context_line":"RUN mkdir /build \\"},{"line_number":30,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":31,"context_line":"    \u0026\u0026 git clone --branch ${prometheus_libvirt_exporter_version} ${prometheus_libvirt_exporter_url} \\"},{"line_number":32,"context_line":"    \u0026\u0026 cd libvirt_exporter \\"},{"line_number":33,"context_line":"    \u0026\u0026 go get -d ./... \\"},{"line_number":34,"context_line":"    \u0026\u0026 go build \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_83b7853a","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":17},"updated":"2019-03-15 11:21:05.000000000","message":"add \"--depth 1\" to skip history","commit_id":"7d33bc181fb3ecd59b6eaaca78f167b3641bf40b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"05e986809e7994c68197ee9d789a6556afc220b5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"},{"line_number":40,"context_line":"{% block footer %}{% endblock %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# TODO: Root level access is currently required to read libvirt metrics. In"},{"line_number":43,"context_line":"# the future we should investigate read only access as a non-root user. See"},{"line_number":44,"context_line":"# https://libvirt.org/auth.html#ACL_server_polkit."},{"line_number":45,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_a3b2c147","line":42,"range":{"start_line":42,"start_character":2,"end_line":42,"end_character":7},"updated":"2019-03-15 11:21:05.000000000","message":"TODO(nickname): please","commit_id":"7d33bc181fb3ecd59b6eaaca78f167b3641bf40b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5c821739fab27d8dc0c0f7e7ee3275ac640caac","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV GOPATH\u003d/build"},{"line_number":29,"context_line":"RUN mkdir /build \\"},{"line_number":30,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":31,"context_line":"    \u0026\u0026 git clone --depth 1 --branch ${prometheus_libvirt_exporter_version} ${prometheus_libvirt_exporter_url} \\"},{"line_number":32,"context_line":"    \u0026\u0026 cd libvirt_exporter \\"},{"line_number":33,"context_line":"    \u0026\u0026 go get -d ./... \\"},{"line_number":34,"context_line":"    \u0026\u0026 go build \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5fc1f717_d1045b17","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"updated":"2019-03-18 11:05:25.000000000","message":"Any reason not to use a tarball? The backbox exporter does this:\n\nRUN curl -sSL -o /tmp/blackbox_exporter.tar.gz https://github.com/prometheus/blackbox_exporter/releases/download/v${blackbox_exporter_version}/blackbox_exporter-${blackbox_exporter_version}.linux-{{debian_arch}}.tar.gz \\\n    \u0026\u0026 tar xvf /tmp/blackbox_exporter.tar.gz -C /opt/ \\\n    \u0026\u0026 rm -f /tmp/blackbox_exporter.tar.gz \\\n    \u0026\u0026 ln -s /opt/blackbox_exporter* /opt/blackbox_exporter\n\nI can\u0027t see anywhere else where we git clone in a dockerfile.","commit_id":"956ba28007951d219854328ef267c4e438287c53"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d95120cc550284c3a519c9824ca7f9c69fe50c4a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV GOPATH\u003d/build"},{"line_number":29,"context_line":"RUN mkdir /build \\"},{"line_number":30,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":31,"context_line":"    \u0026\u0026 git clone --depth 1 --branch ${prometheus_libvirt_exporter_version} ${prometheus_libvirt_exporter_url} \\"},{"line_number":32,"context_line":"    \u0026\u0026 cd libvirt_exporter \\"},{"line_number":33,"context_line":"    \u0026\u0026 go get -d ./... \\"},{"line_number":34,"context_line":"    \u0026\u0026 go build \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5fc1f717_5fb1fbe0","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"in_reply_to":"5fc1f717_5f0edbe5","updated":"2019-03-21 15:20:54.000000000","message":"Yeah, I think master is a bad idea in case it introduces a breaking change like for example, the node exporters changing their command line syntax. Will update asap to use the tarball. Thanks for taking a look all.","commit_id":"956ba28007951d219854328ef267c4e438287c53"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d95120cc550284c3a519c9824ca7f9c69fe50c4a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV GOPATH\u003d/build"},{"line_number":29,"context_line":"RUN mkdir /build \\"},{"line_number":30,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":31,"context_line":"    \u0026\u0026 git clone --depth 1 --branch ${prometheus_libvirt_exporter_version} ${prometheus_libvirt_exporter_url} \\"},{"line_number":32,"context_line":"    \u0026\u0026 cd libvirt_exporter \\"},{"line_number":33,"context_line":"    \u0026\u0026 go get -d ./... \\"},{"line_number":34,"context_line":"    \u0026\u0026 go build \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5fc1f717_31d27f29","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"in_reply_to":"5fc1f717_d1045b17","updated":"2019-03-21 15:20:54.000000000","message":"Done","commit_id":"956ba28007951d219854328ef267c4e438287c53"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"27dcc9ec71d00f7cf1940436148827cba68028e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ENV GOPATH\u003d/build"},{"line_number":29,"context_line":"RUN mkdir /build \\"},{"line_number":30,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":31,"context_line":"    \u0026\u0026 git clone --depth 1 --branch ${prometheus_libvirt_exporter_version} ${prometheus_libvirt_exporter_url} \\"},{"line_number":32,"context_line":"    \u0026\u0026 cd libvirt_exporter \\"},{"line_number":33,"context_line":"    \u0026\u0026 go get -d ./... \\"},{"line_number":34,"context_line":"    \u0026\u0026 go build \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5fc1f717_5f0edbe5","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"in_reply_to":"5fc1f717_d1045b17","updated":"2019-03-21 15:14:19.000000000","message":"Even if that\u0027s better you can use the master tarball https://github.com/kumina/libvirt_exporter/tarball/master (though it\u0027s better to use a release - just like in Mark\u0027s example)","commit_id":"956ba28007951d219854328ef267c4e438287c53"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7c2080b54c73780286b05ee80d4bf64e65553fff","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["},{"line_number":10,"context_line":"        \u0027go\u0027,"},{"line_number":11,"context_line":"        \u0027libvirt-devel\u0027,"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_9d0cbdec","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":24},"updated":"2019-03-27 16:46:23.000000000","message":"trailing comma","commit_id":"23266dbea0cdf22f09afccb82a67f288e47cde46"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"de4679d008af8503414d2cb202f1cd595c1a76cb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["},{"line_number":10,"context_line":"        \u0027go\u0027,"},{"line_number":11,"context_line":"        \u0027libvirt-devel\u0027,"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":14,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_dd15659d","line":11,"range":{"start_line":11,"start_character":23,"end_line":11,"end_character":24},"in_reply_to":"5fc1f717_9d0cbdec","updated":"2019-03-27 16:51:16.000000000","message":"It\u0027s not a problem, and allows appending a package without changing the line above.","commit_id":"23266dbea0cdf22f09afccb82a67f288e47cde46"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7c2080b54c73780286b05ee80d4bf64e65553fff","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027git\u0027,"},{"line_number":17,"context_line":"        \u0027golang-go\u0027,"},{"line_number":18,"context_line":"        \u0027libvirt-dev\u0027,"},{"line_number":19,"context_line":"        \u0027pkg-config\u0027,"},{"line_number":20,"context_line":"    ] %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_dd06c5ce","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":21},"updated":"2019-03-27 16:46:23.000000000","message":"trailing comma","commit_id":"23266dbea0cdf22f09afccb82a67f288e47cde46"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d5476f4ee55a88242f1fa2d24557944ec362e977","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{ macros.install_packages(prometheus_libvirt_exporter_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block prometheus_libvirt_exporter_version %}"},{"line_number":29,"context_line":"ARG prometheus_libvirt_exporter_version\u003d2.1.1"},{"line_number":30,"context_line":"ARG prometheus_libvirt_exporter_url\u003dhttps://github.com/AlexZzz/libvirt-exporter/archive/refs/tags"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"2e524c76_16773661","line":29,"updated":"2021-09-13 12:14:18.000000000","message":"Please use 2.2.0. This is the latest stable version.","commit_id":"1ac9a777d376d87689f1a7f8782b4a9418b06a55"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b6ef476af4937b437527b65085f84253ecfa2ab1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{ macros.install_packages(prometheus_libvirt_exporter_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block prometheus_libvirt_exporter_version %}"},{"line_number":29,"context_line":"ARG prometheus_libvirt_exporter_version\u003d2.1.1"},{"line_number":30,"context_line":"ARG prometheus_libvirt_exporter_url\u003dhttps://github.com/AlexZzz/libvirt-exporter/archive/refs/tags"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7663d0ec_e3d9da02","line":29,"in_reply_to":"03d5abd0_a152ef1a","updated":"2022-01-27 14:11:54.000000000","message":"Done","commit_id":"1ac9a777d376d87689f1a7f8782b4a9418b06a55"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"c39c5184e93cee7e433e12f6d13cd5e53468c501","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{ macros.install_packages(prometheus_libvirt_exporter_packages | customizable(\"packages\")) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{% block prometheus_libvirt_exporter_version %}"},{"line_number":29,"context_line":"ARG prometheus_libvirt_exporter_version\u003d2.1.1"},{"line_number":30,"context_line":"ARG prometheus_libvirt_exporter_url\u003dhttps://github.com/AlexZzz/libvirt-exporter/archive/refs/tags"},{"line_number":31,"context_line":"{% endblock %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"03d5abd0_a152ef1a","line":29,"in_reply_to":"2e524c76_16773661","updated":"2021-09-14 06:56:12.000000000","message":"Makes sense, thanks Christian.","commit_id":"1ac9a777d376d87689f1a7f8782b4a9418b06a55"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c59a6ffa33136149b71a886c46c5dd9144459159","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["},{"line_number":12,"context_line":"        \u0027go\u0027,"},{"line_number":13,"context_line":"        \u0027libvirt-devel\u0027,"},{"line_number":14,"context_line":"        \u0027git\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":17,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"babbb639_d2475665","line":14,"range":{"start_line":12,"start_character":5,"end_line":14,"end_character":14},"updated":"2021-09-16 14:15:47.000000000","message":"alphabetical order please","commit_id":"cca435bfaee46f15bca4fed5ee0d54fbe5a2fca7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c5fff3dc993f1eca8741efe59f0148d3bb12fc5b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["},{"line_number":12,"context_line":"        \u0027go\u0027,"},{"line_number":13,"context_line":"        \u0027libvirt-devel\u0027,"},{"line_number":14,"context_line":"        \u0027git\u0027,"},{"line_number":15,"context_line":"    ] %}"},{"line_number":16,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":17,"context_line":"    {% set prometheus_libvirt_exporter_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"48b7dde3_b90b8240","line":14,"range":{"start_line":12,"start_character":5,"end_line":14,"end_character":14},"in_reply_to":"babbb639_d2475665","updated":"2022-01-04 10:57:17.000000000","message":"Done","commit_id":"cca435bfaee46f15bca4fed5ee0d54fbe5a2fca7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"84048ab23d5f9e069dfbad858280bab6864ffcda","unresolved":true,"context_lines":[{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block prometheus_libvirt_exporter_install %}"},{"line_number":35,"context_line":"ENV GOPATH\u003d/build"},{"line_number":36,"context_line":"RUN mkdir /build \\"},{"line_number":37,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":38,"context_line":"    \u0026\u0026 curl -o libvirt-exporter.tar.gz ${prometheus_libvirt_exporter_url}/${prometheus_libvirt_exporter_version}.tar.gz  \\"},{"line_number":39,"context_line":"    \u0026\u0026 echo \"${prometheus_libvirt_exporter_sha256sum} libvirt-exporter.tar.gz\" | sha256sum -c \\"},{"line_number":40,"context_line":"    \u0026\u0026 tar xvf libvirt-exporter.tar.gz \\"},{"line_number":41,"context_line":"    \u0026\u0026 cd libvirt-exporter-${prometheus_libvirt_exporter_version} \\"},{"line_number":42,"context_line":"    \u0026\u0026 go build -mod vendor \\"},{"line_number":43,"context_line":"    \u0026\u0026 install -m 0755 libvirt-exporter /opt/ \\"},{"line_number":44,"context_line":"    \u0026\u0026 rm -rf /build"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% endblock %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"b4354e6b_d37e35aa","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":0},"updated":"2022-01-27 13:33:58.000000000","message":"What about:\nGOPATH\u003d/opt/prometheus-libvirt-exporter GO111MODULE\u003doff go get -v github.com/AlexZzz/libvirt-exporter@${prometheus_libvirt_exporter_version}\ninstead of this curly madness?","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4b848c6ac3ea1c36c5023939edfa7cdaf1797e52","unresolved":true,"context_lines":[{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block prometheus_libvirt_exporter_install %}"},{"line_number":35,"context_line":"ENV GOPATH\u003d/build"},{"line_number":36,"context_line":"RUN mkdir /build \\"},{"line_number":37,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":38,"context_line":"    \u0026\u0026 curl -o libvirt-exporter.tar.gz ${prometheus_libvirt_exporter_url}/${prometheus_libvirt_exporter_version}.tar.gz  \\"},{"line_number":39,"context_line":"    \u0026\u0026 echo \"${prometheus_libvirt_exporter_sha256sum} libvirt-exporter.tar.gz\" | sha256sum -c \\"},{"line_number":40,"context_line":"    \u0026\u0026 tar xvf libvirt-exporter.tar.gz \\"},{"line_number":41,"context_line":"    \u0026\u0026 cd libvirt-exporter-${prometheus_libvirt_exporter_version} \\"},{"line_number":42,"context_line":"    \u0026\u0026 go build -mod vendor \\"},{"line_number":43,"context_line":"    \u0026\u0026 install -m 0755 libvirt-exporter /opt/ \\"},{"line_number":44,"context_line":"    \u0026\u0026 rm -rf /build"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% endblock %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"833dcc28_015a9cb9","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":0},"in_reply_to":"315f5dcf_41622520","updated":"2022-02-17 09:02:09.000000000","message":"I tried this, but couldn\u0027t get \"go get\" to work in combination with the \"@tag\" specifier, this always results in:\n\ngo: cannot use path@version syntax in GOPATH mode\n\nI tried searching the internet for a solution, but nothing worked for me.","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b6ef476af4937b437527b65085f84253ecfa2ab1","unresolved":true,"context_lines":[{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block prometheus_libvirt_exporter_install %}"},{"line_number":35,"context_line":"ENV GOPATH\u003d/build"},{"line_number":36,"context_line":"RUN mkdir /build \\"},{"line_number":37,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":38,"context_line":"    \u0026\u0026 curl -o libvirt-exporter.tar.gz ${prometheus_libvirt_exporter_url}/${prometheus_libvirt_exporter_version}.tar.gz  \\"},{"line_number":39,"context_line":"    \u0026\u0026 echo \"${prometheus_libvirt_exporter_sha256sum} libvirt-exporter.tar.gz\" | sha256sum -c \\"},{"line_number":40,"context_line":"    \u0026\u0026 tar xvf libvirt-exporter.tar.gz \\"},{"line_number":41,"context_line":"    \u0026\u0026 cd libvirt-exporter-${prometheus_libvirt_exporter_version} \\"},{"line_number":42,"context_line":"    \u0026\u0026 go build -mod vendor \\"},{"line_number":43,"context_line":"    \u0026\u0026 install -m 0755 libvirt-exporter /opt/ \\"},{"line_number":44,"context_line":"    \u0026\u0026 rm -rf /build"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% endblock %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"bce10c40_5165e0d9","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":0},"in_reply_to":"b4354e6b_d37e35aa","updated":"2022-01-27 14:11:54.000000000","message":"Can one add some kind of checksum validation to that command? Or would you prefer simplicity and consider the validation unnecessary?","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b54c14588d0cea1e801145dc41bf545bc3877864","unresolved":true,"context_lines":[{"line_number":32,"context_line":"{% endblock %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% block prometheus_libvirt_exporter_install %}"},{"line_number":35,"context_line":"ENV GOPATH\u003d/build"},{"line_number":36,"context_line":"RUN mkdir /build \\"},{"line_number":37,"context_line":"    \u0026\u0026 cd /build \\"},{"line_number":38,"context_line":"    \u0026\u0026 curl -o libvirt-exporter.tar.gz ${prometheus_libvirt_exporter_url}/${prometheus_libvirt_exporter_version}.tar.gz  \\"},{"line_number":39,"context_line":"    \u0026\u0026 echo \"${prometheus_libvirt_exporter_sha256sum} libvirt-exporter.tar.gz\" | sha256sum -c \\"},{"line_number":40,"context_line":"    \u0026\u0026 tar xvf libvirt-exporter.tar.gz \\"},{"line_number":41,"context_line":"    \u0026\u0026 cd libvirt-exporter-${prometheus_libvirt_exporter_version} \\"},{"line_number":42,"context_line":"    \u0026\u0026 go build -mod vendor \\"},{"line_number":43,"context_line":"    \u0026\u0026 install -m 0755 libvirt-exporter /opt/ \\"},{"line_number":44,"context_line":"    \u0026\u0026 rm -rf /build"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% endblock %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"315f5dcf_41622520","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":0},"in_reply_to":"bce10c40_5165e0d9","updated":"2022-01-31 12:22:17.000000000","message":"I think checksum validation for binaries is a good to have - here we are compiling the code, I guess we can trust the code downloaded from GitHub and it\u0027s dependencies.","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c5fff3dc993f1eca8741efe59f0148d3bb12fc5b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"},{"line_number":49,"context_line":"{% block footer %}{% endblock %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"197c2197_c646c1a4","line":51,"updated":"2022-01-04 10:57:17.000000000","message":"With the prometheus user I\u0027m getting:\n\nFailed to scrape metrics: virError(Code\u003d89, Domain\u003d47, Message\u003d\u0027error from service: CheckAuthorization: Action org.libvirt.unix.manage is not registered\u0027)\n\nSeems it would need to be added to the libvirt group, not sure if we\u0027d want that, or if running as root inside an unpriviledged container is fine.","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b6ef476af4937b437527b65085f84253ecfa2ab1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"{% block prometheus_libvirt_exporter_footer %}{% endblock %}"},{"line_number":49,"context_line":"{% block footer %}{% endblock %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"USER root"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"1accba52_7ef8823e","line":51,"in_reply_to":"197c2197_c646c1a4","updated":"2022-01-27 14:11:54.000000000","message":"Done","commit_id":"3981c9bf509f8d25c6b6a3da3272a0afbd8c24bf"}]}
