)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"d6385eeacc7cad7e9373992527237d62ad3d7ab1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-02 09:45:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump up pkg versions in kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we use Ansible 2.2 in kolla_toolbox, while lowest supported"},{"line_number":10,"context_line":"version is 2.6 - bumping up to 2.8."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Use upper constrains in Dockerfile.j2, instead of pinning them in"},{"line_number":13,"context_line":"here - Ansible is pinned to 2.8.*"},{"line_number":14,"context_line":"* Add no_log\u003dTrue in kolla_keystone_user"},{"line_number":15,"context_line":"* Add endpoint_type as a param in kolla_keystone_service - now"},{"line_number":16,"context_line":"AnsibleModule requires all options to be defined, otherwise it throws"},{"line_number":17,"context_line":"an UnsupportedParameter error"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2cb0ea2fde1b408d48b39bf7a54b898e850d31aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"7faddb67_94d2775b","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":29},"updated":"2019-08-02 09:50:59.000000000","message":"kolla-toolbox: update to newer Ansible and bump pkg versions\n\nCurrently we use Ansible 2.2 in kolla_toolbox, while lowest supported\nversion is 2.6 - bumping up to 2.8.\n\nUse upper constraints instead of pinning versions of other requirements.\n\nDisable logging in kolla_keystone_user (required by newer Ansible).\n\nAdd endpoint_type as a param in kolla_keystone_service - now\nAnsibleModule requires all options to be defined, otherwise it throws\nan UnsupportedParameter error","commit_id":"eabc0b6d68d891c42f4033f174c1be6fc9e7ea2f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5503970562b126617e2dec235ccfbb254c0012fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Nasiadka \u003cmnasiadka@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-02 09:45:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump up pkg versions in kolla-toolbox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we use Ansible 2.2 in kolla_toolbox, while lowest supported"},{"line_number":10,"context_line":"version is 2.6 - bumping up to 2.8."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Use upper constrains in Dockerfile.j2, instead of pinning them in"},{"line_number":13,"context_line":"here - Ansible is pinned to 2.8.*"},{"line_number":14,"context_line":"* Add no_log\u003dTrue in kolla_keystone_user"},{"line_number":15,"context_line":"* Add endpoint_type as a param in kolla_keystone_service - now"},{"line_number":16,"context_line":"AnsibleModule requires all options to be defined, otherwise it throws"},{"line_number":17,"context_line":"an UnsupportedParameter error"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2cb0ea2fde1b408d48b39bf7a54b898e850d31aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"7faddb67_f4b88b11","line":17,"range":{"start_line":7,"start_character":0,"end_line":17,"end_character":29},"in_reply_to":"7faddb67_94d2775b","updated":"2019-08-02 09:55:01.000000000","message":"is \u0027no_log\u0027 required or just best practice? ;o","commit_id":"eabc0b6d68d891c42f4033f174c1be6fc9e7ea2f"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bceba7597b2ae66321de61de16b026013fd88a44","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":65,"context_line":"        \u0027ansible\u003d\u003d2.7.8\u0027,"},{"line_number":66,"context_line":"        \u0027cmd2\u0027,"},{"line_number":67,"context_line":"        \u0027influxdb\u0027,"},{"line_number":68,"context_line":"        \u0027mysqlclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_0113f10e","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":25},"updated":"2019-03-11 12:55:12.000000000","message":"can not it be \u003e\u003d 2.7 \u003c\u003d2.8? in case of 2.7.9 bugfix release for example","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a7e9e725038c705044eb46e9b00686f7f850901e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":65,"context_line":"        \u0027ansible\u003d\u003d2.7.8\u0027,"},{"line_number":66,"context_line":"        \u0027cmd2\u0027,"},{"line_number":67,"context_line":"        \u0027influxdb\u0027,"},{"line_number":68,"context_line":"        \u0027mysqlclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_a1045d4b","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":25},"in_reply_to":"5fc1f717_0113f10e","updated":"2019-03-11 13:26:57.000000000","message":"\u003c2.8","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bceba7597b2ae66321de61de16b026013fd88a44","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027python-openstackclient\u0027,"},{"line_number":73,"context_line":"        \u0027pytz\u0027,"},{"line_number":74,"context_line":"        \u0027pyudev\u0027,"},{"line_number":75,"context_line":"        \u0027shade\u003d\u003d1.29.0\u0027"},{"line_number":76,"context_line":"    ] %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_81fe01ac","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":23},"updated":"2019-03-11 12:55:12.000000000","message":"why exactly 1.29.0?","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bceba7597b2ae66321de61de16b026013fd88a44","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \u0027shade\u003d\u003d1.29.0\u0027"},{"line_number":76,"context_line":"    ] %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":81,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_a1221d51","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":108},"updated":"2019-03-11 12:55:12.000000000","message":"or maybe set constraints to true so versions set in openstack/requirements will be used instead?","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"02ac59c49f3412061bfaca892733acff1a447375","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \u0027shade\u003d\u003d1.29.0\u0027"},{"line_number":76,"context_line":"    ] %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":81,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_9c41883c","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":108},"in_reply_to":"5fc1f717_81f9214e","updated":"2019-03-11 13:41:40.000000000","message":"kolla-toolbox is always source based as it get\u0027s everything Python by use of pip.\n\ncontrary to openstack-base where we go with packages for binary and pip for source","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"883472d81a1f830cf14f97c8a15056c7c87600db","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \u0027shade\u003d\u003d1.29.0\u0027"},{"line_number":76,"context_line":"    ] %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":81,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_b7c1ff82","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":108},"in_reply_to":"5fc1f717_9c41883c","updated":"2019-03-11 14:21:02.000000000","message":"Yes, but we don\u0027t have a copy of the requirements repo which contains UC.","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a7e9e725038c705044eb46e9b00686f7f850901e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        \u0027shade\u003d\u003d1.29.0\u0027"},{"line_number":76,"context_line":"    ] %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":81,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5fc1f717_81f9214e","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":108},"in_reply_to":"5fc1f717_a1221d51","updated":"2019-03-11 13:26:57.000000000","message":"I don\u0027t think we can use constraints in binary images.","commit_id":"33b542561ee80d73dd384529e5e6bff034117d91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1e70857de905818ba9eb42f0957355457b2ac9ad","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":65,"context_line":"        \u0027ansible\u003d\u003d2.7.8\u0027,"},{"line_number":66,"context_line":"        \u0027cmd2\u0027,"},{"line_number":67,"context_line":"        \u0027influxdb\u0027,"},{"line_number":68,"context_line":"        \u0027mysqlclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bfb3d3c7_04c1ee2e","line":65,"updated":"2019-05-21 16:05:51.000000000","message":"Let\u0027s ensure we pick up minor releases:\n\nansible\u003c2.8.0","commit_id":"75592d987344c901c3c750206288bea37a0d470a"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c75872cd6803d55590c069caf81a4e7c35205602","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":65,"context_line":"        \u0027ansible\u003d\u003d2.8\u0027,"},{"line_number":66,"context_line":"        \u0027cmd2\u0027,"},{"line_number":67,"context_line":"        \u0027influxdb\u0027,"},{"line_number":68,"context_line":"        \u0027mysqlclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9fb8cfa7_fb1f856d","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":21},"updated":"2019-06-06 07:10:01.000000000","message":"2.8.* to get latest 2.8.x one","commit_id":"daced73186acd78e66ba43e9c639b1755dc9a0da"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"18e9ba6ef66cb5679f6f9e58a023f8f20c51d8a4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":65,"context_line":"        \u0027ansible\u003d\u003d2.8.*\u0027,"},{"line_number":66,"context_line":"        \u0027cmd2\u0027,"},{"line_number":67,"context_line":"        \u0027influxdb\u0027,"},{"line_number":68,"context_line":"        \u0027mysqlclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9fb8cfa7_4f7046dd","line":65,"updated":"2019-06-06 14:36:23.000000000","message":"Do we need any changes to our ansible modules to support this?","commit_id":"573bf07c4b8a22bcfcbb7117e4e79c5d40510e91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"18e9ba6ef66cb5679f6f9e58a023f8f20c51d8a4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027cmd2\u0027,"},{"line_number":67,"context_line":"        \u0027influxdb\u0027,"},{"line_number":68,"context_line":"        \u0027mysqlclient\u0027,"},{"line_number":69,"context_line":"        \u0027os-client-config\u003d\u003d1.29.0\u0027,"},{"line_number":70,"context_line":"        \u0027pbr\u0027,"},{"line_number":71,"context_line":"        \u0027pymongo\u0027,"},{"line_number":72,"context_line":"        \u0027python-openstackclient\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9fb8cfa7_0f200eb0","line":69,"updated":"2019-06-06 14:36:23.000000000","message":"Latest is 1.32.0, update?","commit_id":"573bf07c4b8a22bcfcbb7117e4e79c5d40510e91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"18e9ba6ef66cb5679f6f9e58a023f8f20c51d8a4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027python-openstackclient\u0027,"},{"line_number":73,"context_line":"        \u0027pytz\u0027,"},{"line_number":74,"context_line":"        \u0027pyudev\u0027,"},{"line_number":75,"context_line":"        \u0027shade\u003d\u003d1.27.2\u0027"},{"line_number":76,"context_line":"    ] %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9fb8cfa7_8f4f1e91","line":75,"updated":"2019-06-06 14:36:23.000000000","message":"1.27.*?\n\nOr, we have 1.31.0 available now - time to update?","commit_id":"573bf07c4b8a22bcfcbb7117e4e79c5d40510e91"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb9cb74cebf98f3519914984b05695f71cec6c9b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \u0027os-client-config\u003d\u003d1.32.*\u0027,"},{"line_number":68,"context_line":"        \u0027pbr\u0027,"},{"line_number":69,"context_line":"        \u0027pymongo\u0027,"},{"line_number":70,"context_line":"        \u0027python-openstackclient\u0027,"},{"line_number":71,"context_line":"        \u0027pytz\u0027,"},{"line_number":72,"context_line":"        \u0027pyudev\u0027,"},{"line_number":73,"context_line":"        \u0027shade\u003d\u003d1.31.*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"9fb8cfa7_8df25899","line":70,"updated":"2019-06-13 07:18:50.000000000","message":"Don\u0027t we want to pin this too as os-client-config is?","commit_id":"a79ca2798702e2270c465c41b1832634ad43a2b7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bdb794a5556c81f606c555cdf1811ca38de1c151","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \u0027os-client-config\u003d\u003d1.32.*\u0027,"},{"line_number":68,"context_line":"        \u0027pbr\u0027,"},{"line_number":69,"context_line":"        \u0027pymongo\u0027,"},{"line_number":70,"context_line":"        \u0027python-openstackclient\u0027,"},{"line_number":71,"context_line":"        \u0027pytz\u0027,"},{"line_number":72,"context_line":"        \u0027pyudev\u0027,"},{"line_number":73,"context_line":"        \u0027shade\u003d\u003d1.31.*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7faddb67_d43413fe","line":70,"in_reply_to":"7faddb67_9170edde","updated":"2019-07-23 11:10:19.000000000","message":"ok, do note though that we regularly rebuild these containers so not pinning openstack clients may well raise them to unsupported version (as in we still rebuild pike afair)","commit_id":"a79ca2798702e2270c465c41b1832634ad43a2b7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"976a77184fd2dd365c836153ae923e51f7b0562d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \u0027os-client-config\u003d\u003d1.32.*\u0027,"},{"line_number":68,"context_line":"        \u0027pbr\u0027,"},{"line_number":69,"context_line":"        \u0027pymongo\u0027,"},{"line_number":70,"context_line":"        \u0027python-openstackclient\u0027,"},{"line_number":71,"context_line":"        \u0027pytz\u0027,"},{"line_number":72,"context_line":"        \u0027pyudev\u0027,"},{"line_number":73,"context_line":"        \u0027shade\u003d\u003d1.31.*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7faddb67_9170edde","line":70,"in_reply_to":"7faddb67_91d46dbf","updated":"2019-07-23 10:01:48.000000000","message":"makes sense, or unpin os-client-config - it was rather pinned to solve out shade problems/incompatibilities - but now the goal is to move from shade to openstack client SDK. Will do one or the other once I get somewhere.","commit_id":"a79ca2798702e2270c465c41b1832634ad43a2b7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8aa578193601103a65e53d02c74517482cd0585d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \u0027os-client-config\u003d\u003d1.32.*\u0027,"},{"line_number":68,"context_line":"        \u0027pbr\u0027,"},{"line_number":69,"context_line":"        \u0027pymongo\u0027,"},{"line_number":70,"context_line":"        \u0027python-openstackclient\u0027,"},{"line_number":71,"context_line":"        \u0027pytz\u0027,"},{"line_number":72,"context_line":"        \u0027pyudev\u0027,"},{"line_number":73,"context_line":"        \u0027shade\u003d\u003d1.31.*\u0027"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"7faddb67_91d46dbf","line":70,"in_reply_to":"9fb8cfa7_8df25899","updated":"2019-07-23 09:54:55.000000000","message":"kind reminder to answer ^ :-)","commit_id":"a79ca2798702e2270c465c41b1832634ad43a2b7"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6f1079d6292236ad7e88323d0972afcd77a800cc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027shade\u003d\u003d1.27.1\u0027"},{"line_number":74,"context_line":"    ] %}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"},{"line_number":77,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":78,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":79,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7faddb67_541e3f5f","side":"PARENT","line":76,"range":{"start_line":76,"start_character":82,"end_line":76,"end_character":102},"updated":"2019-08-02 09:38:18.000000000","message":"if we use constraints from openstack/requirements then why we set versions in kolla_toolbox_pip_packages for anything other than Ansible?","commit_id":"6295f17985b5e691e136269a2b2fdefed8d722ed"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"360c8ba3d02667220f6e8cf939040e5bfc145899","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027shade\u003d\u003d1.27.1\u0027"},{"line_number":74,"context_line":"    ] %}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse) }} \\"},{"line_number":77,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":78,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":79,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_d446af50","side":"PARENT","line":76,"range":{"start_line":76,"start_character":85,"end_line":76,"end_character":102},"updated":"2019-08-02 09:41:33.000000000","message":"go with this to commit message as well","commit_id":"6295f17985b5e691e136269a2b2fdefed8d722ed"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"37cf5406674dfe5d25c5833962279c2ce2b1a122","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -sSL -o /requirements/upper-constraints.txt https://opendev.org/openstack/requirements/raw/branch/{{openstack_release}}/upper-constraints.txt"},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":81,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"7faddb67_c5d53b1d","line":78,"updated":"2019-08-08 13:26:07.000000000","message":"any reason to break run between these two?","commit_id":"c4bf229ecdee8ef1c7990e44771177b7d843c0bd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"68b671ef88d345cfe6a577732483eefadc78f1c5","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -sSL -o /requirements/upper-constraints.txt https://opendev.org/openstack/requirements/raw/branch/{{openstack_release}}/upper-constraints.txt"},{"line_number":78,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":81,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"7faddb67_0017c147","line":78,"in_reply_to":"7faddb67_c5d53b1d","updated":"2019-08-08 13:56:15.000000000","message":"No special reason, so let me merge those.","commit_id":"c4bf229ecdee8ef1c7990e44771177b7d843c0bd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0f66937e52a69cf31f906e0bd008137dc368965f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    ] %}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":77,"context_line":"    \u0026\u0026 curl -sSL -o /requirements/upper-constraints.txt https://opendev.org/openstack/requirements/raw/branch/{{openstack_release}}/upper-constraints.txt \\"},{"line_number":78,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":79,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":80,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"7faddb67_d89d1358","line":77,"updated":"2019-08-09 08:59:30.000000000","message":"I think we will get some complaints from people behind air gaps if we do not at least make the URL configurable.\n\nIdeally in source builds we\u0027d use the requirements repo, but this image is a bit of a fudge at the moment anyway.","commit_id":"e3108d93c69dbad0c575da719f842d36c195a673"}],"docker/kolla-toolbox/kolla_keystone_service.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"360c8ba3d02667220f6e8cf939040e5bfc145899","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        url\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":39,"context_line":"        interface\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":40,"context_line":"        endpoint_region\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":41,"context_line":"        endpoint_type\u003ddict(type\u003d\u0027str\u0027)"},{"line_number":42,"context_line":"    )"},{"line_number":43,"context_line":"    module \u003d AnsibleModule(argument_spec)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"7faddb67_343e23b8","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":21},"updated":"2019-08-02 09:41:33.000000000","message":"may we get this change note in commit message please","commit_id":"d592b872fcbe46500cb65a3aacad04734508c815"}],"kolla/common/config.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0f66937e52a69cf31f906e0bd008137dc368965f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0027debian\u0027: \u0027buster\u0027,"},{"line_number":36,"context_line":"    \u0027ubuntu\u0027: \u002718.04\u0027,"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":"OPENSTACK_RELEASE \u003d \u0027master\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# This is noarch repository so we will use it on all architectures"},{"line_number":41,"context_line":"DELOREAN \u003d \\"}],"source_content_type":"text/x-python","patch_set":31,"id":"7faddb67_b8f7f78c","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":28},"updated":"2019-08-09 08:59:30.000000000","message":"We could use a list of all the little things like this that need to be updated prior to RC1 in each release: https://docs.openstack.org/kolla/latest/contributor/release-management.html#before-rc1","commit_id":"e3108d93c69dbad0c575da719f842d36c195a673"}]}