)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"1e00952bcf9f9063b23f46762bfdf0e9d9680e09","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    rpm --import {{ key }} \\"},{"line_number":157,"context_line":"{% endfor -%}"},{"line_number":158,"context_line":"{%- if base_centos_yum_repo_keys|customizable(\u0027centos_yum_repo_keys\u0027)|length \u003d\u003d 0 %}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":159,"context_line":"    {{ macros.rpm_security_update(clean_package_cache) }}"},{"line_number":160,"context_line":"    {%- endif %}"},{"line_number":161,"context_line":"    {# Endif for base_distro centos #}"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_1a21414e","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":57},"updated":"2019-03-21 15:51:10.000000000","message":"we need to be extra careful for the macro not to add a new line at the end, otherwise it will break if we try to chain instructions. Perhaps this needs to be added as a comment to the macro.","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"1c972bfb6c978a0948d26abd34304c72e1ab5e45","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    rpm --import {{ key }} \\"},{"line_number":157,"context_line":"{% endfor -%}"},{"line_number":158,"context_line":"{%- if base_centos_yum_repo_keys|customizable(\u0027centos_yum_repo_keys\u0027)|length \u003d\u003d 0 %}RUN {% else %}    \u0026\u0026 {% endif -%}"},{"line_number":159,"context_line":"    {{ macros.rpm_security_update(clean_package_cache) }}"},{"line_number":160,"context_line":"    {%- endif %}"},{"line_number":161,"context_line":"    {# Endif for base_distro centos #}"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_1ad061f7","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":57},"in_reply_to":"5fc1f717_1a21414e","updated":"2019-03-21 15:56:50.000000000","message":"ack noted","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"}],"docker/macros.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"10b3eefdb40066480545a5e0ece05a51ff7abb62","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{%- endmacro %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% macro rpm_security_update(cleanup) -%}"},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 -%}"},{"line_number":20,"context_line":"    {{ distro_package_manager }} -y update --security --sec-severity\u003dImportant --sec-severity\u003dCritical"},{"line_number":21,"context_line":"    {%- if cleanup %} \\"},{"line_number":22,"context_line":"    \u0026\u0026 {{ distro_package_manager }} clean all \u0026\u0026 rm -rf /var/cache/{{ distro_package_manager }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_da9df966","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":36},"updated":"2019-03-21 15:51:56.000000000","message":"I think that this check can be dropped. Macro name already suggests rpm distros.\n\nAnd is used in one place.","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"1c972bfb6c978a0948d26abd34304c72e1ab5e45","unresolved":false,"context_lines":[{"line_number":16,"context_line":"{%- endmacro %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% macro rpm_security_update(cleanup) -%}"},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 -%}"},{"line_number":20,"context_line":"    {{ distro_package_manager }} -y update --security --sec-severity\u003dImportant --sec-severity\u003dCritical"},{"line_number":21,"context_line":"    {%- if cleanup %} \\"},{"line_number":22,"context_line":"    \u0026\u0026 {{ distro_package_manager }} clean all \u0026\u0026 rm -rf /var/cache/{{ distro_package_manager }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_3af43d87","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":36},"in_reply_to":"5fc1f717_da9df966","updated":"2019-03-21 15:56:50.000000000","message":"ack","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"1c972bfb6c978a0948d26abd34304c72e1ab5e45","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% macro rpm_security_update(cleanup) -%}"},{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 -%}"},{"line_number":20,"context_line":"    {{ distro_package_manager }} -y update --security --sec-severity\u003dImportant --sec-severity\u003dCritical"},{"line_number":21,"context_line":"    {%- if cleanup %} \\"},{"line_number":22,"context_line":"    \u0026\u0026 {{ distro_package_manager }} clean all \u0026\u0026 rm -rf /var/cache/{{ distro_package_manager }}{% endif %}"},{"line_number":23,"context_line":"{%- endif %}"},{"line_number":24,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_5a34a94a","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":7},"updated":"2019-03-21 15:56:50.000000000","message":"This is same logic as above and the {%- will eat the whitespace before","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"1e00952bcf9f9063b23f46762bfdf0e9d9680e09","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 -%}"},{"line_number":20,"context_line":"    {{ distro_package_manager }} -y update --security --sec-severity\u003dImportant --sec-severity\u003dCritical"},{"line_number":21,"context_line":"    {%- if cleanup %} \\"},{"line_number":22,"context_line":"    \u0026\u0026 {{ distro_package_manager }} clean all \u0026\u0026 rm -rf /var/cache/{{ distro_package_manager }}{% endif %}"},{"line_number":23,"context_line":"{%- endif %}"},{"line_number":24,"context_line":"{%- endmacro %}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_fac31556","line":22,"updated":"2019-03-21 15:51:10.000000000","message":"I can\u0027t tell for sure, just by looking at it, if this doesn\u0027t add a new line, for the both cases where cleanup is true and false.","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"1c972bfb6c978a0948d26abd34304c72e1ab5e45","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 -%}"},{"line_number":20,"context_line":"    {{ distro_package_manager }} -y update --security --sec-severity\u003dImportant --sec-severity\u003dCritical"},{"line_number":21,"context_line":"    {%- if cleanup %} \\"},{"line_number":22,"context_line":"    \u0026\u0026 {{ distro_package_manager }} clean all \u0026\u0026 rm -rf /var/cache/{{ distro_package_manager }}{% endif %}"},{"line_number":23,"context_line":"{%- endif %}"},{"line_number":24,"context_line":"{%- endmacro %}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_7a85e5ce","line":22,"in_reply_to":"5fc1f717_fac31556","updated":"2019-03-21 15:56:50.000000000","message":"It should but I\u0027ll add a note to make sure to keep macro clean ... do we have any unittests for macros to make sure they behave?","commit_id":"eb5227226f609df543cf13dc2fbb9cb284321015"}]}