)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"089e9169375f73cb527f568d148e89603f07cc32","unresolved":false,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"{% endif %}"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5fc1f717_ba139600","line":429,"range":{"start_line":429,"start_character":9,"end_line":429,"end_character":29},"updated":"2019-03-29 10:07:51.000000000","message":"Happy to add a new block here, although I think you still just want to override the outer block in Tripleo.","commit_id":"aca8b6469b3f65c99a797cdba8107212a761e474"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"74c0029bb1fc42dd5ec6457ee656da79b10685b4","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    \u0026\u0026 rm data.tar.xz {{dumb_init_package_name}}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"{% endif %}"},{"line_number":429,"context_line":"{% endblock %}"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_a064b74a","line":429,"range":{"start_line":429,"start_character":3,"end_line":429,"end_character":11},"updated":"2019-03-30 08:58:20.000000000","message":"Changing the block scope is not backwards compatible.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5a73fcb8ad90847e9dc6f17c5b0613f02f4c26d9","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    \u0026\u0026 rm data.tar.xz {{dumb_init_package_name}}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"{% endif %}"},{"line_number":429,"context_line":"{% endblock %}"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_fb47d21d","line":429,"range":{"start_line":429,"start_character":3,"end_line":429,"end_character":11},"in_reply_to":"5fc1f717_a064b74a","updated":"2019-03-30 11:24:15.000000000","message":"Well it\u0027s intentional change. Someone overriding this block to install it from say rpm rather than source would not know (based on the block name) that ENTRYPOINT also has to be included.\n\nThe thing we added to mariadb template is backward  incompatible. So IMO, we should change this too.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"111bde5c297ac394d359ceb5d76bb4e0f5481be3","unresolved":false,"context_lines":[{"line_number":426,"context_line":"    \u0026\u0026 rm data.tar.xz {{dumb_init_package_name}}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"{% endif %}"},{"line_number":429,"context_line":"{% endblock %}"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_c871c0e0","line":429,"range":{"start_line":429,"start_character":3,"end_line":429,"end_character":11},"in_reply_to":"5fc1f717_fb47d21d","updated":"2019-04-02 16:02:59.000000000","message":"Perhaps not, but the only way they can find out the block name currently is by reading the template :)\n\nI guess I\u0027m ok with changing it on master if we include it in a release note. Changing it on rocky could break users, including TripleO.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"}],"docker/mariadb/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1376ad99cb2951914f50fa532931d8c8243762f3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# Without --single-child, the TERM signal is sent to all subprocesses,"},{"line_number":60,"context_line":"# including mysqld."},{"line_number":61,"context_line":"ENTRYPOINT [\"dumb-init\"]"},{"line_number":62,"context_line":"CMD [\"kolla_start\"]"},{"line_number":63,"context_line":"{% endblock %}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% block mariadb_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_bffaa8b6","side":"PARENT","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":19},"updated":"2019-03-29 09:05:19.000000000","message":"Need to keep this somehow.","commit_id":"636fce475b7b1525f4ad353d2a0740f784d22aad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1376ad99cb2951914f50fa532931d8c8243762f3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_1f573ccc","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":29},"updated":"2019-03-29 09:05:19.000000000","message":"I don\u0027t think this overrides the block in the base template, because each Dockerfile.j2 is templated independently. See failure in http://logs.openstack.org/82/648582/1/check/kolla-ansible-centos-binary/7378f19/primary/logs/ansible/deploy.\n\nWhy not add the mariadb_entrypoint to your overrides?","commit_id":"317bc08e154b97c1d7b6c1aa852d9d122d18a2dc"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6ac2ff08fb62783e5b699b00ed05f8f3e9e241a1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_5f15c49a","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":29},"in_reply_to":"5fc1f717_1f573ccc","updated":"2019-03-29 09:26:17.000000000","message":"No, it is. That\u0027s why it is failing. I think it\u0027s failing as I\u0027ve to use\nENTRYPOINT [\"dumb-init\", \"--\"]\n\n\u003e Why not add the mariadb_entrypoint to your overrides?\n\nThe issue is the earlier way is incorrect as it assumes that dumb-init is installed which may not...","commit_id":"317bc08e154b97c1d7b6c1aa852d9d122d18a2dc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1bdba15657011e817251079afbbac0026cbb9b46","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_bfdce8e0","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":29},"in_reply_to":"5fc1f717_5f15c49a","updated":"2019-03-29 09:36:03.000000000","message":"Try this:\n\nkolla-build --template-only\n\nThere is only a single generated base Dockerfile. The mariadb Dockerfile has just this:\n\n# NOTE(mgoddard): Override the dumb-init arguments to avoid passing\n# --single-child. This does not play well with mysqld_safe, which ignores\n# SIGTERM, meaning Docker needs to forcibly kill the container to stop it.\n# Without --single-child, the TERM signal is sent to all subprocesses,\n# including mysqld.\n\nENTRYPOINT [\"dumb-init\"]","commit_id":"317bc08e154b97c1d7b6c1aa852d9d122d18a2dc"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7d0aeb4f09238b068561cd8fcf9e0e0e9f98a5b0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_cd94a98f","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":29},"in_reply_to":"5fc1f717_bfdce8e0","updated":"2019-03-29 12:05:08.000000000","message":"I think I had this *wrong* understanding that these j2 templates have some kind of inheritance from override pov. Sorry I did not get your earlier point that the jinja overrides (with --template-override) are applied separately to the templates and cross Dockerfile.j2 overrides have no significance.\n\nMy intention is to override everything related to dumb-init by a single override block across base/other images.\n\nSo I guess we could use {% block dumb_init_installation %} (may be rename it) across files(?) for dumb-init related stuff, so  that when we override that, it would replace contents in all templates to nothing?","commit_id":"317bc08e154b97c1d7b6c1aa852d9d122d18a2dc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5c01d956d6b35c208fb46c289be173f30ed4c1b7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5fc1f717_8d4c61c9","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":29},"in_reply_to":"5fc1f717_cd94a98f","updated":"2019-03-29 12:37:38.000000000","message":"I think that is something that could potentially work - an outer block that wraps all entrypoint-related stuff. I think we\u0027d need to be quite clear that it is just for disabling dumb-init.\n\nAlternatively, a new config option might be a bit more intuitive:\n\nuse_dumb_init \u003ctrue|false\u003e","commit_id":"317bc08e154b97c1d7b6c1aa852d9d122d18a2dc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"089e9169375f73cb527f568d148e89603f07cc32","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5fc1f717_9aed7af1","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":29},"updated":"2019-03-29 10:07:51.000000000","message":"As discussed in IRC, this cannot have the same name as the block in base image, because the contents of the block is different.","commit_id":"aca8b6469b3f65c99a797cdba8107212a761e474"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"810653ca67a5d640530e6e8c56624e105217efb1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_installation %}"},{"line_number":56,"context_line":"# Nothing to do, installed in base image"},{"line_number":57,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":58,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5fc1f717_e173aee7","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":31},"updated":"2019-03-29 15:44:51.000000000","message":"I think this needs to be given a different name. Someone overriding this block in the base image would have the same block generated here.","commit_id":"61db8069227df0a76e2b686291e6f0381e5a8ce0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a5cdb4cc5566b6ef9a6119ca8f5beb9541b4bac","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_installation %}"},{"line_number":56,"context_line":"# Nothing to do, installed in base image"},{"line_number":57,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":58,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5fc1f717_bc670db8","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":31},"in_reply_to":"5fc1f717_3ccebdb4","updated":"2019-03-29 16:00:55.000000000","message":"No, but I can\u0027t think of a way to do it in a backwards compatible way that works for everyone.","commit_id":"61db8069227df0a76e2b686291e6f0381e5a8ce0"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a080c47d2bff0750e4c572aac137173e800d7478","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_installation %}"},{"line_number":56,"context_line":"# Nothing to do, installed in base image"},{"line_number":57,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":58,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5fc1f717_3ccebdb4","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":31},"in_reply_to":"5fc1f717_e173aee7","updated":"2019-03-29 15:57:49.000000000","message":"OK. That would not be backward compatible with the way we disable it downstream atm with an empty block for it. But yeah I get your point about something else for installing dumb-init.","commit_id":"61db8069227df0a76e2b686291e6f0381e5a8ce0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"810653ca67a5d640530e6e8c56624e105217efb1","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% block dumb_init_installation %}"},{"line_number":56,"context_line":"# Nothing to do, installed in base image"},{"line_number":57,"context_line":"{% block dumb_init_entrypoint %}"},{"line_number":58,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":59,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":60,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5fc1f717_814e6a94","line":57,"range":{"start_line":57,"start_character":9,"end_line":57,"end_character":29},"updated":"2019-03-29 15:44:51.000000000","message":"Still needs to be named differently from the block in the base image. Please leave it as \u0027mariadb_entrypoint\u0027.","commit_id":"61db8069227df0a76e2b686291e6f0381e5a8ce0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"74c0029bb1fc42dd5ec6457ee656da79b10685b4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% if use_dumb_init %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_605ecf77","line":55,"updated":"2019-03-30 08:58:20.000000000","message":"Please keep the block, so that someone can override it if they choose.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"111bde5c297ac394d359ceb5d76bb4e0f5481be3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% if use_dumb_init %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_2bfdde07","line":55,"in_reply_to":"5fc1f717_1b45fe15","updated":"2019-04-02 16:02:59.000000000","message":"I\u0027ve also included the block name in a release note, so let\u0027s just keep it. I don\u0027t know exactly what you might use it for, but there\u0027s no reason to remove it.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5a73fcb8ad90847e9dc6f17c5b0613f02f4c26d9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":53,"context_line":"{% endif %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% if use_dumb_init %}"},{"line_number":56,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":57,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":58,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5fc1f717_1b45fe15","line":55,"in_reply_to":"5fc1f717_605ecf77","updated":"2019-03-30 11:24:15.000000000","message":"What would they override it with? I thought that\u0027s only way you can use dumb-init with mariadb as per your earlier change?","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"}],"releasenotes/notes/add-use-dumb-init-config-option-26b47f6d97d7585c.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"74c0029bb1fc42dd5ec6457ee656da79b10685b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds cli config option use_dumb_init, which can be"},{"line_number":5,"context_line":"    disabled with --nouse-dumb-init from cli when"},{"line_number":6,"context_line":"    building imges."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_00534b6e","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":12},"updated":"2019-03-30 08:58:20.000000000","message":"nit: not just CLI, can be added in a config file also.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5a73fcb8ad90847e9dc6f17c5b0613f02f4c26d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds cli config option use_dumb_init, which can be"},{"line_number":5,"context_line":"    disabled with --nouse-dumb-init from cli when"},{"line_number":6,"context_line":"    building imges."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_bb514adc","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":12},"in_reply_to":"5fc1f717_00534b6e","updated":"2019-03-30 11:24:15.000000000","message":"Isn\u0027t every cli option a config option in kolla? This mentions cli config though. If you think this can be misleading I can change though.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"111bde5c297ac394d359ceb5d76bb4e0f5481be3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds cli config option use_dumb_init, which can be"},{"line_number":5,"context_line":"    disabled with --nouse-dumb-init from cli when"},{"line_number":6,"context_line":"    building imges."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5fc1f717_4b2b8a81","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":12},"in_reply_to":"5fc1f717_bb514adc","updated":"2019-04-02 16:02:59.000000000","message":"I think so, yes. I guess it does say config option, perhaps it\u0027s ok.","commit_id":"fb29081d5f2be964455d806f80aafb8292aa4872"}]}