)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39849538010be4863af9f2f208e896d3116a3766","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Also ceph-osd bootstrap mode fails when no mon config is provided, so"},{"line_number":18,"context_line":"we added --no-mon-config (mon config is injected later after bootstrap)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"FIXME: Currently, ceph-nfs is not building due to package conflicts:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"--\u003e Processing Dependency: liburcu-bp.so.1()(64bit) for package: nfs-ganesha-2.7.3-0.1.el7.x86_64"},{"line_number":23,"context_line":"--\u003e Finished Dependency Resolution"},{"line_number":24,"context_line":"Error: Package: nfs-ganesha-2.7.3-0.1.el7.x86_64 (nfs_ganesha)"},{"line_number":25,"context_line":"           Requires: liburcu-bp.so.1()(64bit)"},{"line_number":26,"context_line":"           Available: userspace-rcu-0.7.16-1.el7.x86_64 (epel)"},{"line_number":27,"context_line":"               liburcu-bp.so.1()(64bit)"},{"line_number":28,"context_line":"           Installing: userspace-rcu-0.10.0-3.el7.x86_64 (centos-ceph-nautilus)"},{"line_number":29,"context_line":"              ~liburcu-bp.so.6()(64bit)"},{"line_number":30,"context_line":" You could try using --skip-broken to work around the problem"},{"line_number":31,"context_line":" You could try running: rpm -Va --nofiles --nodigest"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[1] https://github.com/ceph/ceph/commit/d6def8ba1126209f8dcb40e296977dc2b09a376e"},{"line_number":34,"context_line":"[2] http://docs.ceph.com/docs/master/releases/nautilus/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_0c7e89ae","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":52},"updated":"2019-05-28 16:44:45.000000000","message":"Is this still an issue? Anything we can do? We\u0027ll at least need a known issue in the release note and a bug on LP.","commit_id":"61027acd2bc6263b06c0905ede87d85638236835"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbd02db236c7a3e0d02823e05f4cd63955fd252a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Also ceph-osd bootstrap mode fails when no mon config is provided, so"},{"line_number":18,"context_line":"we added --no-mon-config (mon config is injected later after bootstrap)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"FIXME: Currently, ceph-nfs is not building due to package conflicts:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"--\u003e Processing Dependency: liburcu-bp.so.1()(64bit) for package: nfs-ganesha-2.7.3-0.1.el7.x86_64"},{"line_number":23,"context_line":"--\u003e Finished Dependency Resolution"},{"line_number":24,"context_line":"Error: Package: nfs-ganesha-2.7.3-0.1.el7.x86_64 (nfs_ganesha)"},{"line_number":25,"context_line":"           Requires: liburcu-bp.so.1()(64bit)"},{"line_number":26,"context_line":"           Available: userspace-rcu-0.7.16-1.el7.x86_64 (epel)"},{"line_number":27,"context_line":"               liburcu-bp.so.1()(64bit)"},{"line_number":28,"context_line":"           Installing: userspace-rcu-0.10.0-3.el7.x86_64 (centos-ceph-nautilus)"},{"line_number":29,"context_line":"              ~liburcu-bp.so.6()(64bit)"},{"line_number":30,"context_line":" You could try using --skip-broken to work around the problem"},{"line_number":31,"context_line":" You could try running: rpm -Va --nofiles --nodigest"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[1] https://github.com/ceph/ceph/commit/d6def8ba1126209f8dcb40e296977dc2b09a376e"},{"line_number":34,"context_line":"[2] http://docs.ceph.com/docs/master/releases/nautilus/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_b5969cef","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":52},"in_reply_to":"bfb3d3c7_0c7e89ae","updated":"2019-05-28 19:40:40.000000000","message":"Unfortunately due to two facts:\n1. CentOS Storage SIG does not deliver nfs-ganesha for Ceph FSAL\n2. upstream Ceph nfs-ganesha relies on older userspace-rcu\n\nI think it\u0027s best to also move to Ceph upstream repos in this change - will update soon.","commit_id":"61027acd2bc6263b06c0905ede87d85638236835"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a9ee93aeff3202f82dda5fbde1c0fead7957178","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Also ceph-osd bootstrap mode fails when no mon config is provided, so"},{"line_number":18,"context_line":"we added --no-mon-config (mon config is injected later after bootstrap)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"FIXME: Currently, ceph-nfs is not building due to package conflicts:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"--\u003e Processing Dependency: liburcu-bp.so.1()(64bit) for package: nfs-ganesha-2.7.3-0.1.el7.x86_64"},{"line_number":23,"context_line":"--\u003e Finished Dependency Resolution"},{"line_number":24,"context_line":"Error: Package: nfs-ganesha-2.7.3-0.1.el7.x86_64 (nfs_ganesha)"},{"line_number":25,"context_line":"           Requires: liburcu-bp.so.1()(64bit)"},{"line_number":26,"context_line":"           Available: userspace-rcu-0.7.16-1.el7.x86_64 (epel)"},{"line_number":27,"context_line":"               liburcu-bp.so.1()(64bit)"},{"line_number":28,"context_line":"           Installing: userspace-rcu-0.10.0-3.el7.x86_64 (centos-ceph-nautilus)"},{"line_number":29,"context_line":"              ~liburcu-bp.so.6()(64bit)"},{"line_number":30,"context_line":" You could try using --skip-broken to work around the problem"},{"line_number":31,"context_line":" You could try running: rpm -Va --nofiles --nodigest"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[1] https://github.com/ceph/ceph/commit/d6def8ba1126209f8dcb40e296977dc2b09a376e"},{"line_number":34,"context_line":"[2] http://docs.ceph.com/docs/master/releases/nautilus/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_8328f896","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":52},"in_reply_to":"bfb3d3c7_b5969cef","updated":"2019-05-29 11:10:47.000000000","message":"\u003e Unfortunately due to two facts:\n \u003e 1. CentOS Storage SIG does not deliver nfs-ganesha for Ceph FSAL\n \u003e 2. upstream Ceph nfs-ganesha relies on older userspace-rcu\n \u003e \n \u003e I think it\u0027s best to also move to Ceph upstream repos in this\n \u003e change - will update soon.\n\nBecause of this.","commit_id":"61027acd2bc6263b06c0905ede87d85638236835"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39849538010be4863af9f2f208e896d3116a3766","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Co-Authored-By: Michal Nasiadka \u003cmichal.nasiadka@nokia.com\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Depends-On: https://review.opendev.org/660792/"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I000398f587c5f4d6cc8995e34e162eebc77bc3e3"},{"line_number":41,"context_line":"Implements: blueprint centos-ceph-nautilus"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_4cb32199","line":38,"updated":"2019-05-28 16:44:45.000000000","message":"Abandoned","commit_id":"61027acd2bc6263b06c0905ede87d85638236835"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbd02db236c7a3e0d02823e05f4cd63955fd252a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Co-Authored-By: Michal Nasiadka \u003cmichal.nasiadka@nokia.com\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Depends-On: https://review.opendev.org/660792/"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I000398f587c5f4d6cc8995e34e162eebc77bc3e3"},{"line_number":41,"context_line":"Implements: blueprint centos-ceph-nautilus"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bfb3d3c7_d59b1015","line":38,"in_reply_to":"bfb3d3c7_4cb32199","updated":"2019-05-28 19:40:40.000000000","message":"Will remove.","commit_id":"61027acd2bc6263b06c0905ede87d85638236835"}],"docker/base/apt_preferences.ubuntu":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f5c3ababbea242816c154aed6efa0162d1b20ddf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# We want Ceph/Mimic"},{"line_number":2,"context_line":"Package: ceph* *cephfs* librbd* *rados* python*-rbd librgw* python*-rados python*-ceph* python*-rgw"},{"line_number":3,"context_line":"Pin: version 13.*"},{"line_number":4,"context_line":"Pin-Priority: -1"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"bfb3d3c7_03ec088d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":20},"updated":"2019-05-29 11:06:21.000000000","message":"this code says: we DO NOT want 13.* (mimic) as we wanted Luminous","commit_id":"7288cd9ff29f0735a8048868d5a4806a53111aea"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e388d55f4fce3624ee0ed75e88da0644a130fa39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# We want Ceph/Mimic"},{"line_number":2,"context_line":"Package: ceph* *cephfs* librbd* *rados* python*-rbd librgw* python*-rados python*-ceph* python*-rgw"},{"line_number":3,"context_line":"Pin: version 13.*"},{"line_number":4,"context_line":"Pin-Priority: -1"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"bfb3d3c7_e3445476","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":20},"in_reply_to":"bfb3d3c7_03ec088d","updated":"2019-05-29 11:07:47.000000000","message":"Oh yeah. That\u0027s confusing.","commit_id":"7288cd9ff29f0735a8048868d5a4806a53111aea"}],"docker/ceph/ceph-base/Dockerfile.j2":[{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"1a0954d706ef747cc71c37ee8a2ede246b0374d2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TESTING 1 2 3"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ceph_base_header %}{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dfbec78f_7be05e97","line":4,"updated":"2019-05-09 20:09:22.000000000","message":"...?\n\n:)","commit_id":"147d315272664cebb6dd9c3c4daf2de6a692fb71"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"32aa502b48759052649abe78842d59b877fbedff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TESTING 1 2 3"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ceph_base_header %}{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dfbec78f_7b4b7d2a","line":4,"in_reply_to":"dfbec78f_7be05e97","updated":"2019-05-09 20:33:40.000000000","message":"Need to change docker/ceph/ to trigger ceph CI jobs. Initially didn\u0027t have a change here.","commit_id":"147d315272664cebb6dd9c3c4daf2de6a692fb71"}],"docker/ceph/ceph-mon/extend_start.sh":[{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"1a0954d706ef747cc71c37ee8a2ede246b0374d2","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # Generating initial keyrings and monmap"},{"line_number":24,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_MON}\" --gen-key -n mon. --cap mon \u0027allow *\u0027"},{"line_number":25,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_ADMIN}\" --gen-key -n client.admin --cap mon \u0027allow *\u0027 --cap osd \u0027allow *\u0027 --cap mds \u0027allow\u0027 --cap mgr \u0027allow *\u0027"},{"line_number":26,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_RGW}\" --gen-key -n client.radosgw.gateway --cap osd \u0027allow rwx\u0027 --cap mon \u0027allow rwx\u0027"},{"line_number":27,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_ADMIN}\""},{"line_number":28,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_RGW}\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"dfbec78f_9b7752d5","line":25,"updated":"2019-05-09 20:09:22.000000000","message":"this is just cosmetic but I wonder if that would work, looks better and be easier to read?\n\nceph-authtool \\\n    --create-keyring \"${KEYRING_ADMIN}\" \\\n    --gen-key -n client.admin --cap mon \u0027allow *\u0027 \\\n    --cap osd \u0027allow *\u0027 --cap mds \u0027allow\u0027 \\\n    --cap mgr \u0027allow *\u0027","commit_id":"147d315272664cebb6dd9c3c4daf2de6a692fb71"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"935221b5b8e1bec600a20c7b3cd8126a674a40b8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # Generating initial keyrings and monmap"},{"line_number":24,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_MON}\" --gen-key -n mon. --cap mon \u0027allow *\u0027"},{"line_number":25,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_ADMIN}\" --gen-key -n client.admin --cap mon \u0027allow *\u0027 --cap osd \u0027allow *\u0027 --cap mds \u0027allow\u0027 --cap mgr \u0027allow *\u0027"},{"line_number":26,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_RGW}\" --gen-key -n client.radosgw.gateway --cap osd \u0027allow rwx\u0027 --cap mon \u0027allow rwx\u0027"},{"line_number":27,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_ADMIN}\""},{"line_number":28,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_RGW}\""},{"line_number":29,"context_line":"    monmaptool --create --add \"${HOSTNAME}\" \"${MON_IP}\" --fsid \"${FSID}\" \"${MONMAP}\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfbec78f_7b74dd68","line":26,"updated":"2019-05-09 20:35:01.000000000","message":"Wonder if we need to include the --set-uid argument for L on Debian and M on Ubuntu.","commit_id":"58c8df48946a03232feee5a036738679376b09cd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39849538010be4863af9f2f208e896d3116a3766","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # Generating initial keyrings and monmap"},{"line_number":24,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_MON}\" --gen-key -n mon. --cap mon \u0027allow *\u0027"},{"line_number":25,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_ADMIN}\" --gen-key -n client.admin --set-uid\u003d0 --cap mon \u0027allow *\u0027 --cap osd \u0027allow *\u0027 --cap mds \u0027allow\u0027 --cap mgr \u0027allow *\u0027"},{"line_number":26,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_RGW}\" --gen-key -n client.radosgw.gateway --set-uid\u003d0 --cap osd \u0027allow rwx\u0027 --cap mon \u0027allow rwx\u0027"},{"line_number":27,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_ADMIN}\""},{"line_number":28,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_RGW}\""}],"source_content_type":"text/x-sh","patch_set":17,"id":"bfb3d3c7_6c2385be","side":"PARENT","line":25,"range":{"start_line":25,"start_character":80,"end_line":25,"end_character":91},"updated":"2019-05-28 16:44:45.000000000","message":"Assume this works on pre-nautilus?","commit_id":"14f7501441924a8e533fc9b75ce16719de3de945"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cbd02db236c7a3e0d02823e05f4cd63955fd252a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    # Generating initial keyrings and monmap"},{"line_number":24,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_MON}\" --gen-key -n mon. --cap mon \u0027allow *\u0027"},{"line_number":25,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_ADMIN}\" --gen-key -n client.admin --set-uid\u003d0 --cap mon \u0027allow *\u0027 --cap osd \u0027allow *\u0027 --cap mds \u0027allow\u0027 --cap mgr \u0027allow *\u0027"},{"line_number":26,"context_line":"    ceph-authtool --create-keyring \"${KEYRING_RGW}\" --gen-key -n client.radosgw.gateway --set-uid\u003d0 --cap osd \u0027allow rwx\u0027 --cap mon \u0027allow rwx\u0027"},{"line_number":27,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_ADMIN}\""},{"line_number":28,"context_line":"    ceph-authtool \"${KEYRING_MON}\" --import-keyring \"${KEYRING_RGW}\""}],"source_content_type":"text/x-sh","patch_set":17,"id":"bfb3d3c7_358aacbe","side":"PARENT","line":25,"range":{"start_line":25,"start_character":80,"end_line":25,"end_character":91},"in_reply_to":"bfb3d3c7_6c2385be","updated":"2019-05-28 19:40:40.000000000","message":"It did.","commit_id":"14f7501441924a8e533fc9b75ce16719de3de945"}],"docker/ceph/ceph-osd/extend_start.sh":[{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"56e3e57f3d5bbb76f3ad782cc1698c68c85b6e6b","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # This will through an error about no key existing. That is normal. It then"},{"line_number":85,"context_line":"        # creates the key in the next step."},{"line_number":86,"context_line":"\techo \"bluestore\" \u003e \"${OSD_DIR}\"/type"},{"line_number":87,"context_line":"        ceph-osd -i \"${OSD_ID}\" --mkkey --no-mon-config"},{"line_number":88,"context_line":"        if [ -n \"${OSD_BS_BLK_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLK_DEV}\" !\u003d \"${OSD_BS_DEV}\" ] \u0026\u0026 [ -n \"${OSD_BS_BLK_PARTNUM}\" ]; then"},{"line_number":89,"context_line":"            sgdisk \"--change-name\u003d\"${OSD_BS_BLK_PARTNUM}\":KOLLA_CEPH_DATA_BS_${OSD_ID}_B\" \"--typecode\u003d\"${OSD_BS_BLK_PARTNUM}\":${CEPH_OSD_TYPE_CODE}\" -- \"${OSD_BS_BLK_DEV}\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"bfb3d3c7_68bc31dc","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":22},"updated":"2019-05-22 09:42:48.000000000","message":"it would be nice to have this as a param\n\nand give a choice filestore/bluestore but this is a new feature","commit_id":"e09a697d2a72a58dc3429ad9969bea436763990e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f3d5e21a5b06e6678092a98c51987bd7f91c15c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # This will through an error about no key existing. That is normal. It then"},{"line_number":85,"context_line":"        # creates the key in the next step."},{"line_number":86,"context_line":"\techo \"bluestore\" \u003e \"${OSD_DIR}\"/type"},{"line_number":87,"context_line":"        ceph-osd -i \"${OSD_ID}\" --mkkey --no-mon-config"},{"line_number":88,"context_line":"        if [ -n \"${OSD_BS_BLK_DEV}\" ] \u0026\u0026 [ \"${OSD_BS_BLK_DEV}\" !\u003d \"${OSD_BS_DEV}\" ] \u0026\u0026 [ -n \"${OSD_BS_BLK_PARTNUM}\" ]; then"},{"line_number":89,"context_line":"            sgdisk \"--change-name\u003d\"${OSD_BS_BLK_PARTNUM}\":KOLLA_CEPH_DATA_BS_${OSD_ID}_B\" \"--typecode\u003d\"${OSD_BS_BLK_PARTNUM}\":${CEPH_OSD_TYPE_CODE}\" -- \"${OSD_BS_BLK_DEV}\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"bfb3d3c7_d6f93a80","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":22},"in_reply_to":"bfb3d3c7_68bc31dc","updated":"2019-05-22 10:32:10.000000000","message":"It is configurable - see L70","commit_id":"e09a697d2a72a58dc3429ad9969bea436763990e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"33d359853fc2d7f7690772a4b107182ddcb40a1d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # This will through an error about no key existing. That is normal. It then"},{"line_number":85,"context_line":"        # creates the key in the next step."},{"line_number":86,"context_line":"        echo \"bluestore\" \u003e \"${OSD_DIR}\"/type"},{"line_number":87,"context_line":"\tif [[ \"$(ceph --version)\" \u003d~ \"nautilus\" ]]; then"},{"line_number":88,"context_line":"          ceph-osd -i \"${OSD_ID}\" --mkkey --no-mon-config"},{"line_number":89,"context_line":"        else"},{"line_number":90,"context_line":"          ceph-osd -i \"${OSD_ID}\" --mkkey"}],"source_content_type":"text/x-sh","patch_set":13,"id":"bfb3d3c7_fd49a48a","line":87,"updated":"2019-05-23 11:10:22.000000000","message":"Should we invert this check to make it future proof?\n\ni.e. ceph version \u003d~ (luminous|mimic)","commit_id":"88195cc30a5b91ca50d27b869f9bdd81aa161104"}]}