)]}'
{"docker/neutron/neutron-base/Dockerfile.j2":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"40614fb99adb4c7b053c99cb07d2824e976df247","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":18,"context_line":"            \u0027iputils\u0027,"},{"line_number":19,"context_line":"            \u0027keepalived\u0027,"},{"line_number":20,"context_line":"            \u0027net-tools\u0027,"},{"line_number":21,"context_line":"            \u0027radvd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfb3d3c7_54597832","line":18,"updated":"2019-05-27 14:22:32.000000000","message":"While this can be good workaround, if it is unconditionally required, this should be an explicit Requires in the Neutron RPM.","commit_id":"ad4435618010ebfe2e2c6b5ee5b16c04a0abab04"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40ea54bf30eee3783aa769b403113f32bdffd837","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":18,"context_line":"            \u0027iputils\u0027,"},{"line_number":19,"context_line":"            \u0027keepalived\u0027,"},{"line_number":20,"context_line":"            \u0027net-tools\u0027,"},{"line_number":21,"context_line":"            \u0027radvd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfb3d3c7_948a9067","line":18,"in_reply_to":"bfb3d3c7_54597832","updated":"2019-05-27 14:26:23.000000000","message":"ok, maybe we can add it to neutron\u0027s spec file as dependency but as this was already merged in master, do You think we can go with this for now? Or should I abandon this patch and add it to spec file as dependency?","commit_id":"ad4435618010ebfe2e2c6b5ee5b16c04a0abab04"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"cad5df2dcbf8fa671a50bf1cbeb8eed6b8c75727","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":18,"context_line":"            \u0027iputils\u0027,"},{"line_number":19,"context_line":"            \u0027keepalived\u0027,"},{"line_number":20,"context_line":"            \u0027net-tools\u0027,"},{"line_number":21,"context_line":"            \u0027radvd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfb3d3c7_f4898cc9","line":18,"in_reply_to":"bfb3d3c7_948a9067","updated":"2019-05-27 15:06:33.000000000","message":"yes, I realized this is a backport after initial comment, I\u0027ve left +1","commit_id":"ad4435618010ebfe2e2c6b5ee5b16c04a0abab04"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"354466f74fb31f2d1f1f39db8b40220c1e6eaa01","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"        {% set neutron_base_packages \u003d ["},{"line_number":18,"context_line":"            \u0027iputils\u0027,"},{"line_number":19,"context_line":"            \u0027keepalived\u0027,"},{"line_number":20,"context_line":"            \u0027net-tools\u0027,"},{"line_number":21,"context_line":"            \u0027radvd\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9fb8cfa7_6b6fc72a","line":18,"in_reply_to":"bfb3d3c7_f4898cc9","updated":"2019-06-13 14:07:58.000000000","message":"I added it to rpm\u0027s dependencies in https://review.rdoproject.org/r/#/c/21125/","commit_id":"ad4435618010ebfe2e2c6b5ee5b16c04a0abab04"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"40614fb99adb4c7b053c99cb07d2824e976df247","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027iputils\u0027,"},{"line_number":19,"context_line":"            \u0027keepalived\u0027,"},{"line_number":20,"context_line":"            \u0027net-tools\u0027,"},{"line_number":21,"context_line":"            \u0027radvd\u0027,"},{"line_number":22,"context_line":"            \u0027openstack-neutron\u0027,"},{"line_number":23,"context_line":"            \u0027openstack-neutron-fwaas\u0027,"},{"line_number":24,"context_line":"            \u0027openstack-neutron-lbaas\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfb3d3c7_7477dca1","line":21,"updated":"2019-05-27 14:22:32.000000000","message":"ditto, probably those too?","commit_id":"ad4435618010ebfe2e2c6b5ee5b16c04a0abab04"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40ea54bf30eee3783aa769b403113f32bdffd837","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027iputils\u0027,"},{"line_number":19,"context_line":"            \u0027keepalived\u0027,"},{"line_number":20,"context_line":"            \u0027net-tools\u0027,"},{"line_number":21,"context_line":"            \u0027radvd\u0027,"},{"line_number":22,"context_line":"            \u0027openstack-neutron\u0027,"},{"line_number":23,"context_line":"            \u0027openstack-neutron-fwaas\u0027,"},{"line_number":24,"context_line":"            \u0027openstack-neutron-lbaas\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"bfb3d3c7_f498acc0","line":21,"in_reply_to":"bfb3d3c7_7477dca1","updated":"2019-05-27 14:26:23.000000000","message":"this can be maybe done in some follow up patch as this patch is not related to radvd at all","commit_id":"ad4435618010ebfe2e2c6b5ee5b16c04a0abab04"}]}