)]}'
{"tests/templates/template_overrides.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"75b3733621ba62dc9a422ff7063cfce18c847544","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN sed -i -e  \"/^mirrorlist/ d\" \\"},{"line_number":41,"context_line":"        -e \"/^metalink/ d\" \\"},{"line_number":42,"context_line":"        -e \"s|^#baseurl|baseurl|\" \\"},{"line_number":43,"context_line":"        -e \"s|http://mirror.centos.org|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":44,"context_line":"        -e \"s|http://download.fedoraproject.org/pub|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":45,"context_line":"        -e \"s|https://trunk.rdoproject.org|{{ nodepool_rdo_proxy }}|g\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_5d753b63","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":35},"updated":"2019-06-08 08:28:14.000000000","message":"disagree here\n\nCentOS/EPEL repo files use mirrorlist by default and have baseurl line commented. We remove mirrorlist and then uncomment and change baseurl to infra mirror. This way we know that only CentOS/EPEL repos get enabled.\n\nYour change enables all baseurl lines. Sure, it may have the same effect with current repo files but I prefer to be sure that only those which really need to be changed are changed.","commit_id":"606172635e8b4d146d700e01b852680ff6b9480b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"d18e6fbc73b7f18d506db58c744092f4169b4762","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN sed -i -e  \"/^mirrorlist/ d\" \\"},{"line_number":41,"context_line":"        -e \"/^metalink/ d\" \\"},{"line_number":42,"context_line":"        -e \"s|^#baseurl|baseurl|\" \\"},{"line_number":43,"context_line":"        -e \"s|http://mirror.centos.org|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":44,"context_line":"        -e \"s|http://download.fedoraproject.org/pub|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":45,"context_line":"        -e \"s|https://trunk.rdoproject.org|{{ nodepool_rdo_proxy }}|g\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_8bf84d7b","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":35},"in_reply_to":"9fb8cfa7_1d0023ab","updated":"2019-06-08 18:43:45.000000000","message":"[some random repo]\nmirrorlist\u003dhttp://some.example.org/mirrors\n# use this baseurl if have VPN access\n# has CentOS repo copy with some preliminary updates\n#baseurl\u003dhttp://only.available.for.our.vpn.users.corp.com/\n# use CentOS repo if do not\n#baseurl\u003dhttp://mirror.centos.org/....\n\nYour change will drop \u0027mirrorlist\u0027, uncomment broken \u0027baseurl\u0027 and then yum will wonder which \u0027baseurl\u0027 to use.\n\nWhile with existing code \u0027mirrorlist\u0027 gets removed, VPN access \u0027baseurl\u0027 will be still commented and centos repo will be redirected to infra mirror.","commit_id":"606172635e8b4d146d700e01b852680ff6b9480b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b5d4253efd261fbb89e10fa18aef5428d1e5e1d0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN sed -i -e  \"/^mirrorlist/ d\" \\"},{"line_number":41,"context_line":"        -e \"/^metalink/ d\" \\"},{"line_number":42,"context_line":"        -e \"s|^#baseurl|baseurl|\" \\"},{"line_number":43,"context_line":"        -e \"s|http://mirror.centos.org|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":44,"context_line":"        -e \"s|http://download.fedoraproject.org/pub|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":45,"context_line":"        -e \"s|https://trunk.rdoproject.org|{{ nodepool_rdo_proxy }}|g\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_1d0023ab","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":35},"in_reply_to":"9fb8cfa7_5d753b63","updated":"2019-06-08 08:37:08.000000000","message":"I disagree.\nIf we kill mirrorlist and metalink, then without baseurl we only leave broken repos.\nWhat you say would be done really only if we applied right commands on single files, otherwise it does not make sense to complicate IMHO.\nIn sum, my approach works under the same assumptions as the previous. (+/- the note I made under change because I change paths to GPG keys too - on purpose).","commit_id":"606172635e8b4d146d700e01b852680ff6b9480b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dea67bb4c699367da2af05aca071ce1831c92ebd","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN sed -i -e  \"/^mirrorlist/ d\" \\"},{"line_number":41,"context_line":"        -e \"/^metalink/ d\" \\"},{"line_number":42,"context_line":"        -e \"s|^#baseurl|baseurl|\" \\"},{"line_number":43,"context_line":"        -e \"s|http://mirror.centos.org|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":44,"context_line":"        -e \"s|http://download.fedoraproject.org/pub|http://{{ nodepool_mirror_host }}|g\" \\"},{"line_number":45,"context_line":"        -e \"s|https://trunk.rdoproject.org|{{ nodepool_rdo_proxy }}|g\" \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_0b1bfdcf","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":35},"in_reply_to":"9fb8cfa7_8bf84d7b","updated":"2019-06-08 19:01:07.000000000","message":"I see your point but this is done only for Zuul, not custom sites, and we control installed repo files. How likely is it that we would deal with such a situation?\nBTW, the last one will always be used.","commit_id":"606172635e8b4d146d700e01b852680ff6b9480b"}]}