)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"343079a47c9cd3759b6044b23c88d178ad6f12b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3abe3c27_3938e6c5","updated":"2021-11-05 09:42:12.000000000","message":"Michal, any reason we are not doing this?","commit_id":"c0565b36992970b3e31fee3e2a4b994d4594f015"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"09fdcb2dae6c2da8d75cca5a835c58d69308c963","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f8f52f0_a41a01e2","in_reply_to":"3abe3c27_3938e6c5","updated":"2021-11-05 09:58:15.000000000","message":"There shouldn\u0027t be any, but let\u0027s check what the might Zuul will say.","commit_id":"c0565b36992970b3e31fee3e2a4b994d4594f015"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"33145c2f64ee1af28073ba2d6a2ec5cd5dcf9940","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23bb8351_e1fb9630","in_reply_to":"3f8f52f0_a41a01e2","updated":"2021-11-05 10:29:42.000000000","message":"Ok, will you handle this?","commit_id":"c0565b36992970b3e31fee3e2a4b994d4594f015"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fbad79c42420bd266901af614d3f130cdfd61355","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29c7aa40_17e4f45d","updated":"2021-11-25 10:25:45.000000000","message":"check experimental","commit_id":"771673dcaf5fbe3cab3f25c6eda733df928ed397"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9add74ba46599580ce50a199275ba5dd77e6307d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"89a9c698_7c0758c4","updated":"2021-11-25 11:03:03.000000000","message":"check experimental","commit_id":"771673dcaf5fbe3cab3f25c6eda733df928ed397"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4b0f018eebc96ff844edf8ef02aa731cacc25377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80299558_759548bc","updated":"2021-11-25 12:40:08.000000000","message":"ovn fails","commit_id":"771673dcaf5fbe3cab3f25c6eda733df928ed397"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"406886fe8eccdbc21641237fda1f75609b97fe10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a6ab97e8_c795ba0b","updated":"2021-11-25 09:10:24.000000000","message":"recheck experimental","commit_id":"771673dcaf5fbe3cab3f25c6eda733df928ed397"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"29023421561f26413af0150de8c3656c05a5087e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"26257766_be71dd92","updated":"2021-11-25 16:45:25.000000000","message":"check experimental","commit_id":"1eb411696df2482eec76c57fe3030776964d10f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a92e65d298dc7e0bef87e733556e171136aecd80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a17f8486_72f8fa47","updated":"2021-11-25 18:27:08.000000000","message":"check experimental","commit_id":"1eb411696df2482eec76c57fe3030776964d10f3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ed4bb43b70149741c92bc63d29bce8bd49c0bb35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"527c9344_4c3f4c2a","updated":"2021-11-26 08:21:56.000000000","message":"check experimental","commit_id":"19f220ae8909f4b5ce80a7c8847f4bf267b152b5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"99edfa85330f3ce762f4b241e986917e308e11c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"821e3452_6903ea29","updated":"2021-11-26 10:28:34.000000000","message":"check experimental","commit_id":"33bca772a74f2973cf83afb13ad8bb3d156a7e9a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e72afbb50faed3d4814521a9c9f60f5d71f53d45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dfb66b0d_311d7c91","updated":"2021-11-26 14:38:53.000000000","message":"check experimental","commit_id":"889a054385c24a1e2469b45f2a4b23a0797ba920"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"41ea68cc1d4fa2095040b662e2de43bff062e9a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ecd73518_962cb950","updated":"2021-12-16 13:49:09.000000000","message":"check experimental","commit_id":"80de72fcf88a4f7bfa48f8e42c3ae55e4d201e19"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7986e05b016582d3133e9fa029530f8e0fb51682","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"79b0c4e4_5ca9f6e9","updated":"2021-12-16 16:20:07.000000000","message":"check experimental","commit_id":"56f707228e378c3506ff829322fcdab9c25d7970"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"d5dc5e6bfd405842c01138894859cc14099de844","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9bff8d45_bda2262c","updated":"2024-02-23 11:20:13.000000000","message":"recheck get some fresh CI results after two years","commit_id":"5235b873b0f7b99941db95ae1f19b653faf9cb45"}],"docker/ovn/ovn-base/extend_start.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"adf617c4cbaa1e31d616b79892073a0277bbb193","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    sudo chown -R ovn:kolla /run/ovn"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %a /run/ovn) !\u003d \"755\" ]]; then"},{"line_number":10,"context_line":"    chmod 755 /var/log/kolla/openvswitch"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [[ ! -d \"/var/log/kolla/openvswitch\" ]]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/openvswitch"}],"source_content_type":"text/x-sh","patch_set":11,"id":"ea90842a_7fa298ae","line":10,"updated":"2021-11-26 08:50:27.000000000","message":"Do you want to chmod /run/ovn instead?\nAlso I don\u0027t understand the need for these conditionals, why not always run this command?","commit_id":"b6fa1946d4e79042b7d5c86683f8523b18f20516"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"336906df074a6751138ddac80d6573b09b224c3c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    sudo chown -R ovn:kolla /run/ovn"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %a /run/ovn) !\u003d \"755\" ]]; then"},{"line_number":10,"context_line":"    chmod 755 /var/log/kolla/openvswitch"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [[ ! -d \"/var/log/kolla/openvswitch\" ]]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/openvswitch"}],"source_content_type":"text/x-sh","patch_set":11,"id":"eaee0115_b849f617","line":10,"in_reply_to":"b216dfbe_0468dec1","updated":"2024-02-23 11:30:29.000000000","message":"I honestly hard disagree on this attitude to refactoring code.\n\nthe benefit of the refactor clearly outweights the small inconsistency of not having the same - useless - code pattern everywhere.\n\nYou can and absolutely should allow iterative code refactoring activities.\n\nBecause if you ask of contributors to refactor code \"everywhere\" they will very likely never do it.\n\nInstead with an incremental approach, you can refactor bad code patterns file by file, or function by function.\n\nThis is also easier to review (nobody can reasonably read thousand line changes).\n\nI\u0027m honestly baffled I have to argue for that, the CompSci literature and the internet is full with arguments about this stuff. This really should not be controversial.\n\nsee e.g. here for a non scientific article why this approach is better:\n\nhttps://medium.com/@klappy/why-you-no-iterative-refactoring-18280a01b123\n\nor to quote someone maybe more authorative - Martin Fowler -:\n\n```\nRefactoring is the first technique I’ve come across that is\nexplicitly about doing iterative development in a controlled\nmanner. It starts with software that currently works but is not\nwell suited to an enhancement you wish to make. \n```\n\nFrom: https://martinfowler.com/distributedComputing/refactoring.pdf\n\nsorry for the rant, but I really wish we could improve our codebase and I feel actively discouraged from doing refactorings myself because it\u0027s always this huge task of \"you have to change this everywhere, in 50k lines of mostly yaml code\".\n\nThis would be much more feasible if we can tackle it file by file.\n\nThanks.","commit_id":"b6fa1946d4e79042b7d5c86683f8523b18f20516"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ec1fe29f60d11badc6445454eae8e734eb76a602","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    sudo chown -R ovn:kolla /run/ovn"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %a /run/ovn) !\u003d \"755\" ]]; then"},{"line_number":10,"context_line":"    chmod 755 /var/log/kolla/openvswitch"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [[ ! -d \"/var/log/kolla/openvswitch\" ]]; then"},{"line_number":13,"context_line":"    mkdir -p /var/log/kolla/openvswitch"}],"source_content_type":"text/x-sh","patch_set":11,"id":"b216dfbe_0468dec1","line":10,"in_reply_to":"ea90842a_7fa298ae","updated":"2021-11-26 08:55:16.000000000","message":"Well, we have them everywhere - so if we change them - then everywhere.\nFor sure not in this change ;-)","commit_id":"b6fa1946d4e79042b7d5c86683f8523b18f20516"}]}