)]}'
{"id":"openstack%2Fkolla~665156","triplet_id":"openstack%2Fkolla~stable%2Fstein~Idd766bd069eda85ab6876a78b8b050ee5ab66cf6","project":"openstack/kolla","branch":"stable/stein","topic":"Support multiple external networks in L3 agent","hashtags":[],"change_id":"Idd766bd069eda85ab6876a78b8b050ee5ab66cf6","subject":"Support multiple external networks in L3 agent","status":"ABANDONED","created":"2019-06-13 15:15:20.000000000","updated":"2019-06-13 15:19:28.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2669be95f0d61f9bfe4ca29d5bb60933be6b4171","_number":665156,"virtual_id_number":665156,"owner":{"_account_id":30484,"name":"Michael","email":"mabarkdoll@gmail.com","username":"mabarkdoll"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-13 15:15:33.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2019-06-13 15:18:49.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"}],"messages":[{"id":"6183d410f6cd152be78c7f331935b7fb153eeff7","author":{"_account_id":30484,"name":"Michael","email":"mabarkdoll@gmail.com","username":"mabarkdoll"},"date":"2019-06-13 15:15:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"296dee9e65ba34957f9f05ce72ee328f687e360e","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2019-06-13 15:15:33.000000000","message":"Patch Set 1:\n\nThank you for your first contribution to OpenStack.\n\nYour patch will now be tested automatically by OpenStack testing frameworks\nand once the automatic tests pass, it will be reviewed by other friendly\ndevelopers. They will give you feedback and may require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches usually take 3 to 7 days to be reviewed so be patient and be\navailable on IRC to ask and answer questions about your work. Also it\ntakes generally at least a couple of weeks for cores to get around to\nreviewing code. The more you participate in the community the more\nrewarding it is for you. You may also notice that the more you get to know\npeople and get to be known, the faster your patches will be reviewed and\neventually approved. Get to know others and become known by doing code\nreviews: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for supporting OpenStack, we look forward to working with you.\n\nIRC: https://wiki.openstack.org/wiki/IRC\nWorkflow: https://docs.openstack.org/infra/manual/developers.html\nCommit Messages: https://wiki.openstack.org/wiki/GitCommitMessages","accounts_in_message":[],"_revision_number":1},{"id":"1c3ae66c0ac328cce48f4ade2d45b69b2a646632","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2019-06-13 15:18:49.000000000","message":"Patch Set 1: Code-Review-1\n\nEmpty commit, message copied from the neutron change.","accounts_in_message":[],"_revision_number":1},{"id":"3054216e758e5926eb0a9a9bb586156dfbd8aa1f","author":{"_account_id":30484,"name":"Michael","email":"mabarkdoll@gmail.com","username":"mabarkdoll"},"date":"2019-06-13 15:19:08.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b4d373676884ce4b44f1d98fae012ae66aa9d3da","author":{"_account_id":30484,"name":"Michael","email":"mabarkdoll@gmail.com","username":"mabarkdoll"},"date":"2019-06-13 15:19:28.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"848253789710e7c540ed1b08c5fcfcad3e64bd05","revisions":{"7c530cbb1c1ff2197c469586dd1204890b05cc0f":{"kind":"REWORK","_number":1,"created":"2019-06-13 15:15:20.000000000","uploader":{"_account_id":30484,"name":"Michael","email":"mabarkdoll@gmail.com","username":"mabarkdoll"},"ref":"refs/changes/56/665156/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/56/665156/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/56/665156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/56/665156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/56/665156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/56/665156/1"}}},"commit":{"parents":[{"commit":"13913023f02ca07a0c737c136c291a4544ef0d24","subject":"Merge \"Bump Monasca Fluentd plugin version\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/13913023f02ca07a0c737c136c291a4544ef0d24"}]}],"author":{"name":"Michael","email":"mabarkdoll@gmail.com","date":"2019-06-13 15:15:20.000000000","tz":0},"committer":{"name":"Michael","email":"mabarkdoll@gmail.com","date":"2019-06-13 15:15:20.000000000","tz":0},"subject":"","message":"\nSupport multiple external networks in L3 agent\n\nChange [1] removed the deprecated option external_network_bridge. Per\ncommit message in change [2], \"l3 agent can handle any networks by\nsetting the neutron parameter external_network_bridge and\ngateway_external_network_id to empty\". So the consequence of [1] was to\nintroduce a regression whereby multiple external networks are not\nsupported by the L3 agent anymore.\n\nThis change proposes a new simplified rule. If\ngateway_external_network_id is defined, that is the network that the L3\nagent will use. If not and multiple external networks exist, the L3\nagent will handle any of them.\n\n[1] https://review.opendev.org/#/c/567369/\n[2] https://review.opendev.org/#/c/59359\n\nChange-Id: Idd766bd069eda85ab6876a78b8b050ee5ab66cf6\nCloses-Bug: #1824571\n(cherry picked from commit 0b3f5f429d2e495eb78d78d46186092ac735e0d5)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/7c530cbb1c1ff2197c469586dd1204890b05cc0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/7c530cbb1c1ff2197c469586dd1204890b05cc0f"}]},"branch":"refs/heads/stable/stein"},"848253789710e7c540ed1b08c5fcfcad3e64bd05":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-06-13 15:19:08.000000000","uploader":{"_account_id":30484,"name":"Michael","email":"mabarkdoll@gmail.com","username":"mabarkdoll"},"ref":"refs/changes/56/665156/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/56/665156/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/56/665156/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/56/665156/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/56/665156/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/56/665156/2"}}},"commit":{"parents":[{"commit":"13913023f02ca07a0c737c136c291a4544ef0d24","subject":"Merge \"Bump Monasca Fluentd plugin version\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/13913023f02ca07a0c737c136c291a4544ef0d24"}]}],"author":{"name":"Michael","email":"mabarkdoll@gmail.com","date":"2019-06-13 15:15:20.000000000","tz":0},"committer":{"name":"Michael","email":"mabarkdoll@gmail.com","date":"2019-06-13 15:18:38.000000000","tz":0},"subject":"Support multiple external networks in L3 agent","message":"Support multiple external networks in L3 agent\n\nChange [1] removed the deprecated option external_network_bridge. Per\ncommit message in change [2], \"l3 agent can handle any networks by\nsetting the neutron parameter external_network_bridge and\ngateway_external_network_id to empty\". So the consequence of [1] was to\nintroduce a regression whereby multiple external networks are not\nsupported by the L3 agent anymore.\n\nThis change proposes a new simplified rule. If\ngateway_external_network_id is defined, that is the network that the L3\nagent will use. If not and multiple external networks exist, the L3\nagent will handle any of them.\n\n[1] https://review.opendev.org/#/c/567369/\n[2] https://review.opendev.org/#/c/59359\n\nChange-Id: Idd766bd069eda85ab6876a78b8b050ee5ab66cf6\nCloses-Bug: #1824571\n(cherry picked from commit 0b3f5f429d2e495eb78d78d46186092ac735e0d5)\n\nRevert \"Pass network\u0027s dns_domain to dnsmasq conf\"\n\nThe dns_domain attribute of a network is intended for use\nby neutron when creating DNS records in an external DNS\nsystem such as Designate.\n\nBy using the networks dns_domain, the configured search\npath on booted instances mismatches with the generated\ndns assignments for instance ports in the hosts file\nfor dnsmasq which creates a mismatched forward/reverse\nlookup behaviour.\n\nThis reverts commit 7fdd6adc7acf99e74fbe1c12606f8c867ae134ae.\nand commit 137a6d61053fb1cfb9a0a583b5a5c0f6253c75e6.\n\nCloses-Bug: 1826419\nDepends-On: I145144c042b100f7e12a02a8ac7e0fbbe41e984d\nChange-Id: I5ff03b5ad8af432a9f7919ef953d7d8c434b93bd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/848253789710e7c540ed1b08c5fcfcad3e64bd05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/848253789710e7c540ed1b08c5fcfcad3e64bd05"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}