)]}'
{"docker/monasca/monasca-base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dcf8b6d2f219bda3b276bad33d1d491705558b23","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_86319fa5","line":47,"updated":"2019-06-17 13:36:38.000000000","message":"A potential issue here is if monasca has a version constraint that is not satisfied by upper-constraints, then we will end up with two versions of this package in different image layers.","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38291ee80520132836fccda2939bf6608894557c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_c671d70e","line":47,"in_reply_to":"9fb8cfa7_669fcb65","updated":"2019-06-17 13:51:40.000000000","message":"Looks like we only use it for monasca-thresh (monasca-thresh-additions-monasca-common).","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2ba4dbcb99ac9462897118a44800ba4d7a1f5d59","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_b89f0e64","line":47,"in_reply_to":"9fb8cfa7_66eeeb8c","updated":"2019-06-18 07:32:53.000000000","message":"so s/confluent-kafka/monasca-common/ should be done?","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3a5b6c69d54853232825769b3d06da5cca815f16","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_669fcb65","line":47,"in_reply_to":"9fb8cfa7_86319fa5","updated":"2019-06-17 13:40:54.000000000","message":"I think this is coming from monasca-common. Could we use that here instead? Incidentally, it\u0027s not actually used for anything yet.","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"45354b659d2c7ef7aed187818b8563bf36e18b8a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_ba8f6721","line":47,"in_reply_to":"9fb8cfa7_a55d147a","updated":"2019-06-27 08:35:27.000000000","message":"Sorry hrw, I think Mark is right that if we add this, it should be in kolla/common/config.py SOURCES dict like the neutron-base image. The Monasca images only support from source builds at the moment.","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0ea25515e7acb3fb168c14714a73eb1bf2dc1513","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_bb35c8aa","line":47,"in_reply_to":"9fb8cfa7_b89f0e64","updated":"2019-06-18 08:16:25.000000000","message":"Monasca Log API, API, Notification and Persister all specify `monasca-common\u003e\u003d2.7.0`, and macros.install_pip defaults to use upper constraints. `s/confluent-kafka/monasca-common` seems reasonable to me.","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5cbbd09386aae67c58b26be5e7257adf90f85bfe","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_9bcfa4af","line":47,"in_reply_to":"9fb8cfa7_b89f0e64","updated":"2019-06-18 08:16:03.000000000","message":"We don\u0027t really have any way to know which version of monasca-common to pull in. It should be defined in the requirements.txt for each monasca project. Unless we add it to kolla/common/config.py as a source for this image?","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"0cfb27be2367ca0c764a83be8d64cfbd14b08c2c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_a55d147a","line":47,"in_reply_to":"9fb8cfa7_bb35c8aa","updated":"2019-06-26 21:57:50.000000000","message":"Done","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"09a6a6c8e354ea9096f779d404e819d2e7fa7c43","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_a72bcfe8","line":47,"in_reply_to":"9fb8cfa7_bb35c8aa","updated":"2019-06-27 11:02:25.000000000","message":"INFO:kolla.common.utils.monasca-base:Collecting monasca-common\u003d\u003d\u003d2.14.0 (from -c /requirements/upper-constraints.txt (line 112))\n\nSo version is defined.","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f739d4ea515cf12d51e2b2d9e01097c0822b9e2b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% block monasca_source_install %}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"{% set monasca_base_pip_packages \u003d ["},{"line_number":47,"context_line":"    \u0027confluent-kafka\u0027"},{"line_number":48,"context_line":"] %}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"RUN {{ macros.install_pip(monasca_base_pip_packages | customizable(\"pip_packages\")) }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_66eeeb8c","line":47,"in_reply_to":"9fb8cfa7_c671d70e","updated":"2019-06-17 13:55:34.000000000","message":"I think practically all the Monasca python services pull monasca-common in via requirements.txt","commit_id":"c6405eaac2f5188719d4ee346e2737cf4d3c0593"}]}