)]}'
{"kolla/image/build.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03c2a015c5a15281e5f3e75bb46a89e74b414c4a","unresolved":false,"context_lines":[{"line_number":988,"context_line":"                if re.search(patterns, image.name):"},{"line_number":989,"context_line":"                    image.status \u003d STATUS_MATCHED"},{"line_number":990,"context_line":"                    if image.name in skipped_images:"},{"line_number":991,"context_line":"                        image.status \u003d STATUS_SKIPPED"},{"line_number":992,"context_line":"                    while (image.parent is not None and"},{"line_number":993,"context_line":"                           image.parent.status not in (STATUS_MATCHED,"},{"line_number":994,"context_line":"                                                       STATUS_SKIPPED)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_51cdf182","line":991,"updated":"2019-06-27 10:14:03.000000000","message":"It begs for a \u0027continue\u0027 here. I would also move it before the previous \u0027status \u003d\u0027","commit_id":"c49c59d03bb7e77c3fe0e0e9b85ec59395e65aee"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ac73a9c4bd0541999fe9a13215a1c1c51a8877c9","unresolved":false,"context_lines":[{"line_number":988,"context_line":"                if re.search(patterns, image.name):"},{"line_number":989,"context_line":"                    image.status \u003d STATUS_MATCHED"},{"line_number":990,"context_line":"                    if image.name in skipped_images:"},{"line_number":991,"context_line":"                        image.status \u003d STATUS_SKIPPED"},{"line_number":992,"context_line":"                    while (image.parent is not None and"},{"line_number":993,"context_line":"                           image.parent.status not in (STATUS_MATCHED,"},{"line_number":994,"context_line":"                                                       STATUS_SKIPPED)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_4439b1d4","line":991,"in_reply_to":"9fb8cfa7_51cdf182","updated":"2019-06-27 10:40:35.000000000","message":"Done","commit_id":"c49c59d03bb7e77c3fe0e0e9b85ec59395e65aee"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03c2a015c5a15281e5f3e75bb46a89e74b414c4a","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"                        LOG.debug(\u0027Image %s matched regex\u0027, image.name)"},{"line_number":1004,"context_line":"                else:"},{"line_number":1005,"context_line":"                    image.status \u003d STATUS_UNMATCHED"},{"line_number":1006,"context_line":"        else:"},{"line_number":1007,"context_line":"            for image in self.images:"},{"line_number":1008,"context_line":"                image.status \u003d STATUS_MATCHED"},{"line_number":1009,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5192d158","line":1006,"updated":"2019-06-27 10:14:03.000000000","message":"Also, this branch has to be fixed too after changing the order or else we try to build them all. Maybe drop all the \u0027if skipped_images\u0027 above and incorporate its simple logic here (as done in the upper branch).","commit_id":"c49c59d03bb7e77c3fe0e0e9b85ec59395e65aee"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ac73a9c4bd0541999fe9a13215a1c1c51a8877c9","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"                        LOG.debug(\u0027Image %s matched regex\u0027, image.name)"},{"line_number":1004,"context_line":"                else:"},{"line_number":1005,"context_line":"                    image.status \u003d STATUS_UNMATCHED"},{"line_number":1006,"context_line":"        else:"},{"line_number":1007,"context_line":"            for image in self.images:"},{"line_number":1008,"context_line":"                image.status \u003d STATUS_MATCHED"},{"line_number":1009,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_e469c58b","line":1006,"in_reply_to":"9fb8cfa7_5192d158","updated":"2019-06-27 10:40:35.000000000","message":"Done","commit_id":"c49c59d03bb7e77c3fe0e0e9b85ec59395e65aee"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03c2a015c5a15281e5f3e75bb46a89e74b414c4a","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"        if self.image_statuses_skipped:"},{"line_number":1068,"context_line":"            LOG.info(\"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\")"},{"line_number":1069,"context_line":"            LOG.info(\"Images skipped due build options\")"},{"line_number":1070,"context_line":"            LOG.info(\"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\")"},{"line_number":1071,"context_line":"            for name in sorted(self.image_statuses_skipped.keys()):"},{"line_number":1072,"context_line":"                LOG.info(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d1d80154","line":1069,"updated":"2019-06-27 10:14:03.000000000","message":"Let\u0027s fix the grammar too \u0027due to\u0027.\nAlso \u0027options\u0027 is a bit misleading as user cannot override it.\nSo I suggest:\n\"Images skipped due to being unsupported\"","commit_id":"c49c59d03bb7e77c3fe0e0e9b85ec59395e65aee"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ac73a9c4bd0541999fe9a13215a1c1c51a8877c9","unresolved":false,"context_lines":[{"line_number":1066,"context_line":""},{"line_number":1067,"context_line":"        if self.image_statuses_skipped:"},{"line_number":1068,"context_line":"            LOG.info(\"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\")"},{"line_number":1069,"context_line":"            LOG.info(\"Images skipped due build options\")"},{"line_number":1070,"context_line":"            LOG.info(\"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\")"},{"line_number":1071,"context_line":"            for name in sorted(self.image_statuses_skipped.keys()):"},{"line_number":1072,"context_line":"                LOG.info(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_c43361aa","line":1069,"in_reply_to":"9fb8cfa7_d1d80154","updated":"2019-06-27 10:40:35.000000000","message":"Done","commit_id":"c49c59d03bb7e77c3fe0e0e9b85ec59395e65aee"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e835505b091dc8356a8aae4315386ef309ba80c6","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                    image.status \u003d STATUS_MATCHED"},{"line_number":990,"context_line":"                    while (image.parent is not None and"},{"line_number":991,"context_line":"                           image.parent.status not in (STATUS_MATCHED,"},{"line_number":992,"context_line":"                                                       STATUS_SKIPPED)):"},{"line_number":993,"context_line":"                        image \u003d image.parent"},{"line_number":994,"context_line":"                        if self.conf.skip_parents:"},{"line_number":995,"context_line":"                            image.status \u003d STATUS_SKIPPED"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_44af7129","line":992,"range":{"start_line":992,"start_character":55,"end_line":992,"end_character":69},"updated":"2019-06-27 10:46:17.000000000","message":"I feel we have to also check for being in skipped_images in here, not only being already marked SKIPPED now. ;/","commit_id":"fe66650bb6782d71c82281fa88ff6ef4568a789b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c38c4c8b003e6cd39a04fc8745194bf725bef7b","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        if filter_:"},{"line_number":1004,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"},{"line_number":1005,"context_line":"            for image in self.images:"},{"line_number":1006,"context_line":"                if image.status in (STATUS_MATCHED, STATUS_SKIPPED):"},{"line_number":1007,"context_line":"                    continue"},{"line_number":1008,"context_line":"                if re.search(patterns, image.name):"},{"line_number":1009,"context_line":"                    image.status \u003d STATUS_MATCHED"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e23c2a94","side":"PARENT","line":1006,"range":{"start_line":1006,"start_character":0,"end_line":1006,"end_character":68},"updated":"2019-07-18 14:12:24.000000000","message":"this actually looks sane having the loop above","commit_id":"0e766d57ad2cfe3c355b7b4ff9dad18ee0354129"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c38c4c8b003e6cd39a04fc8745194bf725bef7b","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"                    if skip_image:"},{"line_number":1031,"context_line":"                        image.status \u003d STATUS_SKIPPED"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"# When we want to build subset of images then filter_ part jumps."},{"line_number":1034,"context_line":"# Otherwise we just mark everything to build."},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        if filter_:"},{"line_number":1037,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_0249465e","line":1034,"range":{"start_line":1033,"start_character":0,"end_line":1034,"end_character":45},"updated":"2019-07-18 14:12:24.000000000","message":"indent. passes pep8?","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8bdc5588a080d95cc0c18f87062c4e3c78f36f8b","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"                    if skip_image:"},{"line_number":1031,"context_line":"                        image.status \u003d STATUS_SKIPPED"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"# When we want to build subset of images then filter_ part jumps."},{"line_number":1034,"context_line":"# Otherwise we just mark everything to build."},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        if filter_:"},{"line_number":1037,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_c2c9ee25","line":1034,"range":{"start_line":1033,"start_character":0,"end_line":1034,"end_character":45},"in_reply_to":"7faddb67_0249465e","updated":"2019-07-18 14:35:31.000000000","message":"passes","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c38c4c8b003e6cd39a04fc8745194bf725bef7b","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                if image.status in STATUS_MATCHED:"},{"line_number":1040,"context_line":"                    continue"},{"line_number":1041,"context_line":"                if re.search(patterns, image.name):"},{"line_number":1042,"context_line":"                    if image.status !\u003d STATUS_SKIPPED:"},{"line_number":1043,"context_line":"                        image.status \u003d STATUS_MATCHED"},{"line_number":1044,"context_line":"                    while (image.parent is not None and"},{"line_number":1045,"context_line":"                           image.parent.status not in (STATUS_MATCHED,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_c2624eae","line":1042,"updated":"2019-07-18 14:12:24.000000000","message":"and this not needed","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8bdc5588a080d95cc0c18f87062c4e3c78f36f8b","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"                if image.status in STATUS_MATCHED:"},{"line_number":1040,"context_line":"                    continue"},{"line_number":1041,"context_line":"                if re.search(patterns, image.name):"},{"line_number":1042,"context_line":"                    if image.status !\u003d STATUS_SKIPPED:"},{"line_number":1043,"context_line":"                        image.status \u003d STATUS_MATCHED"},{"line_number":1044,"context_line":"                    while (image.parent is not None and"},{"line_number":1045,"context_line":"                           image.parent.status not in (STATUS_MATCHED,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_82121661","line":1042,"in_reply_to":"7faddb67_c2624eae","updated":"2019-07-18 14:35:31.000000000","message":"The whole \u0027if filter_\u0027 block is needed as it is.\n\nWhen I run \u0027kolla-build sensu nova\u0027 then I want to get nova images built and get info that sensu images were skipped. \n\nWithout all those checks here I will get info that \u0027cyborg\u0027 was also not built but I did not asked for it so why bother - it will be marked as UNMATCHED and silently ignored.","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c38c4c8b003e6cd39a04fc8745194bf725bef7b","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"                              image.in_docker_cache()):"},{"line_number":1052,"context_line":"                            image.status \u003d STATUS_SKIPPED"},{"line_number":1053,"context_line":"                        else:"},{"line_number":1054,"context_line":"                            if image.status !\u003d STATUS_SKIPPED:"},{"line_number":1055,"context_line":"                                image.status \u003d STATUS_MATCHED"},{"line_number":1056,"context_line":"                        LOG.debug(\u0027Image %s matched regex\u0027, image.name)"},{"line_number":1057,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_8258d6f9","line":1054,"updated":"2019-07-18 14:12:24.000000000","message":"ditto","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c38c4c8b003e6cd39a04fc8745194bf725bef7b","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"                                image.status \u003d STATUS_MATCHED"},{"line_number":1056,"context_line":"                        LOG.debug(\u0027Image %s matched regex\u0027, image.name)"},{"line_number":1057,"context_line":"                else:"},{"line_number":1058,"context_line":"                    # we do not care is it skipped or not as we did not"},{"line_number":1059,"context_line":"                    # requested it"},{"line_number":1060,"context_line":"                    image.status \u003d STATUS_UNMATCHED"},{"line_number":1061,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_a27152aa","line":1058,"range":{"start_line":1058,"start_character":37,"end_line":1058,"end_character":42},"updated":"2019-07-18 14:12:24.000000000","message":"\"if it is\"","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c38c4c8b003e6cd39a04fc8745194bf725bef7b","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"                        LOG.debug(\u0027Image %s matched regex\u0027, image.name)"},{"line_number":1057,"context_line":"                else:"},{"line_number":1058,"context_line":"                    # we do not care is it skipped or not as we did not"},{"line_number":1059,"context_line":"                    # requested it"},{"line_number":1060,"context_line":"                    image.status \u003d STATUS_UNMATCHED"},{"line_number":1061,"context_line":"        else:"},{"line_number":1062,"context_line":"            for image in self.images:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6267daea","line":1059,"range":{"start_line":1059,"start_character":22,"end_line":1059,"end_character":31},"updated":"2019-07-18 14:12:24.000000000","message":"request","commit_id":"4345ccc04f587c8483f4b4226d7c7aebec8211c0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8042faafe4ee9b8ceedb39cc941edeac9fb6a7b9","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"                    if skip_image:"},{"line_number":1031,"context_line":"                        image.status \u003d STATUS_SKIPPED"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"# When we want to build subset of images then filter_ part jumps."},{"line_number":1034,"context_line":"# Otherwise we just mark everything to build."},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        if filter_:"},{"line_number":1037,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_05c4f03e","line":1034,"range":{"start_line":1033,"start_character":0,"end_line":1034,"end_character":45},"updated":"2019-07-18 14:52:24.000000000","message":"pep8 or not - it looks ugly ;p","commit_id":"21628fd40ad9d3687fcb749375b0746b1260f241"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"86cdd74b46e5ccebfc7b78933c355cb490d0b9bf","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"                    if skip_image:"},{"line_number":1031,"context_line":"                        image.status \u003d STATUS_SKIPPED"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"# When we want to build subset of images then filter_ part jumps."},{"line_number":1034,"context_line":"# Otherwise we just mark everything to build."},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        if filter_:"},{"line_number":1037,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_054e30c0","line":1034,"range":{"start_line":1033,"start_character":0,"end_line":1034,"end_character":45},"in_reply_to":"7faddb67_05c4f03e","updated":"2019-07-18 15:00:20.000000000","message":"Done","commit_id":"21628fd40ad9d3687fcb749375b0746b1260f241"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8042faafe4ee9b8ceedb39cc941edeac9fb6a7b9","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        if filter_:"},{"line_number":1037,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"},{"line_number":1038,"context_line":"            for image in self.images:"},{"line_number":1039,"context_line":"                if image.status in STATUS_MATCHED:"},{"line_number":1040,"context_line":"                    continue"},{"line_number":1041,"context_line":"                if re.search(patterns, image.name):"},{"line_number":1042,"context_line":"                    if image.status !\u003d STATUS_SKIPPED:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_25a6ccac","line":1039,"range":{"start_line":1039,"start_character":32,"end_line":1039,"end_character":34},"updated":"2019-07-18 14:52:24.000000000","message":"not \u003d\u003d ?","commit_id":"21628fd40ad9d3687fcb749375b0746b1260f241"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"86cdd74b46e5ccebfc7b78933c355cb490d0b9bf","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        if filter_:"},{"line_number":1037,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"},{"line_number":1038,"context_line":"            for image in self.images:"},{"line_number":1039,"context_line":"                if image.status in STATUS_MATCHED:"},{"line_number":1040,"context_line":"                    continue"},{"line_number":1041,"context_line":"                if re.search(patterns, image.name):"},{"line_number":1042,"context_line":"                    if image.status !\u003d STATUS_SKIPPED:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_2549ecb5","line":1039,"range":{"start_line":1039,"start_character":32,"end_line":1039,"end_character":34},"in_reply_to":"7faddb67_25a6ccac","updated":"2019-07-18 15:00:20.000000000","message":"Done","commit_id":"21628fd40ad9d3687fcb749375b0746b1260f241"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"636157d301ccdfd18e74b704ebbce7b989b23de4","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def run(self):"},{"line_number":363,"context_line":"        self.builder(self.image)"},{"line_number":364,"context_line":"        if self.image.status in (STATUS_BUILT, STATUS_SKIPPED):"},{"line_number":365,"context_line":"            self.success \u003d True"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_4e867cbb","line":364,"range":{"start_line":364,"start_character":47,"end_line":364,"end_character":61},"updated":"2019-07-19 11:56:03.000000000","message":"this is wrong under our new assumption - I think in reality we need a status \u0027unbuildable\u0027 - skipped can be things already built as well and then we want to push them too","commit_id":"998635c65f5763f22ab2fdbee8276b1936f18c7d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"636157d301ccdfd18e74b704ebbce7b989b23de4","unresolved":false,"context_lines":[{"line_number":367,"context_line":"    @property"},{"line_number":368,"context_line":"    def followups(self):"},{"line_number":369,"context_line":"        followups \u003d []"},{"line_number":370,"context_line":"        if self.conf.push and self.success:"},{"line_number":371,"context_line":"            followups.extend(["},{"line_number":372,"context_line":"                # If we are supposed to push the image into a docker"},{"line_number":373,"context_line":"                # repository, then make sure we do that..."},{"line_number":374,"context_line":"                PushIntoQueueTask("},{"line_number":375,"context_line":"                    PushTask(self.conf, self.image),"},{"line_number":376,"context_line":"                    self.push_queue),"},{"line_number":377,"context_line":"            ])"},{"line_number":378,"context_line":"        if self.image.children and self.success:"},{"line_number":379,"context_line":"            for image in self.image.children:"},{"line_number":380,"context_line":"                if image.status \u003d\u003d STATUS_UNMATCHED:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_0e8c04d5","line":377,"range":{"start_line":370,"start_character":0,"end_line":377,"end_character":14},"updated":"2019-07-19 11:56:03.000000000","message":"^ affects this (which failed)","commit_id":"998635c65f5763f22ab2fdbee8276b1936f18c7d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":77,"context_line":"STATUS_ERRORS \u003d (STATUS_CONNECTION_ERROR, STATUS_PUSH_ERROR,"},{"line_number":78,"context_line":"                 STATUS_ERROR, STATUS_PARENT_ERROR)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# The dictionary of skipped images supports keys in the format:"},{"line_number":81,"context_line":"# \u0027\u003cdistro\u003e+\u003cinstallation_type\u003e+\u003carch\u003e\u0027 where each component is optional"},{"line_number":82,"context_line":"# and can be omitted along with the + separator which means that component"},{"line_number":83,"context_line":"# is irrelevant. Otherwise all must match for skip to happen."}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_216b03f1","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":27},"updated":"2019-07-20 16:48:11.000000000","message":"unbuildable ;D","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":77,"context_line":"STATUS_ERRORS \u003d (STATUS_CONNECTION_ERROR, STATUS_PUSH_ERROR,"},{"line_number":78,"context_line":"                 STATUS_ERROR, STATUS_PARENT_ERROR)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# The dictionary of skipped images supports keys in the format:"},{"line_number":81,"context_line":"# \u0027\u003cdistro\u003e+\u003cinstallation_type\u003e+\u003carch\u003e\u0027 where each component is optional"},{"line_number":82,"context_line":"# and can be omitted along with the + separator which means that component"},{"line_number":83,"context_line":"# is irrelevant. Otherwise all must match for skip to happen."}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_69ca411b","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":27},"in_reply_to":"7faddb67_216b03f1","updated":"2019-07-22 13:46:51.000000000","message":"Done","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"                else:"},{"line_number":1003,"context_line":"                    filter_ +\u003d self.conf.profiles[profile]"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        # skip unbuildable images and their children"},{"line_number":1006,"context_line":"        tag_element \u003d r\u0027(%s|%s|%s)\u0027 % (self.base,"},{"line_number":1007,"context_line":"                                       self.install_type,"},{"line_number":1008,"context_line":"                                       self.base_arch)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_416e3f00","line":1005,"range":{"start_line":1005,"start_character":10,"end_line":1005,"end_character":14},"updated":"2019-07-20 16:48:11.000000000","message":"mark?","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"                else:"},{"line_number":1003,"context_line":"                    filter_ +\u003d self.conf.profiles[profile]"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"        # skip unbuildable images and their children"},{"line_number":1006,"context_line":"        tag_element \u003d r\u0027(%s|%s|%s)\u0027 % (self.base,"},{"line_number":1007,"context_line":"                                       self.install_type,"},{"line_number":1008,"context_line":"                                       self.base_arch)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_49bc256c","line":1005,"range":{"start_line":1005,"start_character":10,"end_line":1005,"end_character":14},"in_reply_to":"7faddb67_416e3f00","updated":"2019-07-22 13:46:51.000000000","message":"Done","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"                    image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1019,"context_line":"                else:"},{"line_number":1020,"context_line":"                    # let\u0027s check ancestors"},{"line_number":1021,"context_line":"                    # if any of them is skipped then we mark it"},{"line_number":1022,"context_line":"                    # and then mark image"},{"line_number":1023,"context_line":"                    build_image \u003d True"},{"line_number":1024,"context_line":"                    ancestor_image \u003d image"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_c9d815f2","line":1021,"range":{"start_line":1021,"start_character":40,"end_line":1021,"end_character":47},"updated":"2019-07-22 13:46:51.000000000","message":"missed that one ;D","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00d7d2a40ad50201ddce4a5c9075e8a4a8a36b94","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"                    image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1019,"context_line":"                else:"},{"line_number":1020,"context_line":"                    # let\u0027s check ancestors"},{"line_number":1021,"context_line":"                    # if any of them is skipped then we mark it"},{"line_number":1022,"context_line":"                    # and then mark image"},{"line_number":1023,"context_line":"                    build_image \u003d True"},{"line_number":1024,"context_line":"                    ancestor_image \u003d image"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_e38645bb","line":1021,"range":{"start_line":1021,"start_character":40,"end_line":1021,"end_character":47},"in_reply_to":"7faddb67_c9d815f2","updated":"2019-07-22 13:51:27.000000000","message":"oh, I just left this one for you to discover ;D","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                    ancestor_image \u003d image"},{"line_number":1025,"context_line":"                    while (ancestor_image.parent is not None):"},{"line_number":1026,"context_line":"                        ancestor_image \u003d ancestor_image.parent"},{"line_number":1027,"context_line":"                        if ancestor_image.name in unbuildable_images or \\"},{"line_number":1028,"context_line":"                           ancestor_image.status \u003d\u003d STATUS_UNBUILDABLE:"},{"line_number":1029,"context_line":"                            build_image \u003d False"},{"line_number":1030,"context_line":"                            ancestor_image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1031,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_41471f78","line":1028,"range":{"start_line":1027,"start_character":68,"end_line":1028,"end_character":70},"updated":"2019-07-20 16:48:11.000000000","message":"actually, the way this loop is constructed, the former condition implies this (at some point)","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                    ancestor_image \u003d image"},{"line_number":1025,"context_line":"                    while (ancestor_image.parent is not None):"},{"line_number":1026,"context_line":"                        ancestor_image \u003d ancestor_image.parent"},{"line_number":1027,"context_line":"                        if ancestor_image.name in unbuildable_images or \\"},{"line_number":1028,"context_line":"                           ancestor_image.status \u003d\u003d STATUS_UNBUILDABLE:"},{"line_number":1029,"context_line":"                            build_image \u003d False"},{"line_number":1030,"context_line":"                            ancestor_image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1031,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_4993c501","line":1028,"range":{"start_line":1027,"start_character":68,"end_line":1028,"end_character":70},"in_reply_to":"7faddb67_41471f78","updated":"2019-07-22 13:46:51.000000000","message":"mark openstack-base as unbuildable - your chain will contain:\n\nopenstack-base \n-\u003e neutron-base \n   -\u003e neutron-server \n      -\u003e neutron-server-opendaylight\n\nand you need to mark all those as unbuildable.\n\nWhen your image \u003d\u003d \u0027neutron-server-opendaylight\u0027 than you may have situation when none of it\u0027s ancestors are marked so you get up to \u0027openstack-base\u0027 (and both conditions apply). \n\nBut when you had \u0027neutron-server\u0027 already marked as unbuildable then second condition applies (as \u0027neutron-server\u0027 is not in \u0027unbuildable_images\u0027 list. And you can jump out of look earlier.","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00d7d2a40ad50201ddce4a5c9075e8a4a8a36b94","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                    ancestor_image \u003d image"},{"line_number":1025,"context_line":"                    while (ancestor_image.parent is not None):"},{"line_number":1026,"context_line":"                        ancestor_image \u003d ancestor_image.parent"},{"line_number":1027,"context_line":"                        if ancestor_image.name in unbuildable_images or \\"},{"line_number":1028,"context_line":"                           ancestor_image.status \u003d\u003d STATUS_UNBUILDABLE:"},{"line_number":1029,"context_line":"                            build_image \u003d False"},{"line_number":1030,"context_line":"                            ancestor_image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1031,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_c37b09bc","line":1028,"range":{"start_line":1027,"start_character":68,"end_line":1028,"end_character":70},"in_reply_to":"7faddb67_4993c501","updated":"2019-07-22 13:51:27.000000000","message":"yeah, it\u0027s kind of an optimization, sure; assuming the list is in alphabetical order the gainings are quite nice (still it matters nothing compared to building itself)","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"                        if ancestor_image.name in unbuildable_images or \\"},{"line_number":1028,"context_line":"                           ancestor_image.status \u003d\u003d STATUS_UNBUILDABLE:"},{"line_number":1029,"context_line":"                            build_image \u003d False"},{"line_number":1030,"context_line":"                            ancestor_image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1031,"context_line":"                            break"},{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_e1616b06","line":1030,"range":{"start_line":1030,"start_character":28,"end_line":1030,"end_character":70},"updated":"2019-07-20 16:48:11.000000000","message":"no need to set this here - loop has to take care of it anyway","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00d7d2a40ad50201ddce4a5c9075e8a4a8a36b94","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"                        if ancestor_image.name in unbuildable_images or \\"},{"line_number":1028,"context_line":"                           ancestor_image.status \u003d\u003d STATUS_UNBUILDABLE:"},{"line_number":1029,"context_line":"                            build_image \u003d False"},{"line_number":1030,"context_line":"                            ancestor_image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1031,"context_line":"                            break"},{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_e35de548","line":1030,"range":{"start_line":1030,"start_character":28,"end_line":1030,"end_character":70},"in_reply_to":"7faddb67_8990ddef","updated":"2019-07-22 13:51:27.000000000","message":"yeah, leaving the other screams for this to be left alone","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"                        if ancestor_image.name in unbuildable_images or \\"},{"line_number":1028,"context_line":"                           ancestor_image.status \u003d\u003d STATUS_UNBUILDABLE:"},{"line_number":1029,"context_line":"                            build_image \u003d False"},{"line_number":1030,"context_line":"                            ancestor_image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1031,"context_line":"                            break"},{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_8990ddef","line":1030,"range":{"start_line":1030,"start_character":28,"end_line":1030,"end_character":70},"in_reply_to":"7faddb67_e1616b06","updated":"2019-07-22 13:46:51.000000000","message":"look earlier comment","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        # When we want to build subset of images then filter_ part jumps."},{"line_number":1036,"context_line":"        # Otherwise we just mark everything to build."},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        if filter_:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_81367702","line":1035,"range":{"start_line":1035,"start_character":31,"end_line":1035,"end_character":32},"updated":"2019-07-20 16:48:11.000000000","message":"a","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        # When we want to build subset of images then filter_ part jumps."},{"line_number":1036,"context_line":"        # Otherwise we just mark everything to build."},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        if filter_:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_a157f325","line":1035,"range":{"start_line":1035,"start_character":67,"end_line":1035,"end_character":72},"updated":"2019-07-20 16:48:11.000000000","message":"kicks in?","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        # When we want to build subset of images then filter_ part jumps."},{"line_number":1036,"context_line":"        # Otherwise we just mark everything to build."},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        if filter_:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_099dcd09","line":1035,"range":{"start_line":1035,"start_character":31,"end_line":1035,"end_character":32},"in_reply_to":"7faddb67_81367702","updated":"2019-07-22 13:46:51.000000000","message":"Done","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"                    if not build_image:"},{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        # When we want to build subset of images then filter_ part jumps."},{"line_number":1036,"context_line":"        # Otherwise we just mark everything to build."},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        if filter_:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_29a2094d","line":1035,"range":{"start_line":1035,"start_character":67,"end_line":1035,"end_character":72},"in_reply_to":"7faddb67_a157f325","updated":"2019-07-22 13:46:51.000000000","message":"Done","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5ad1baa83b76cef0e0ff9cb1e573408e1048d38","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        # When we want to build subset of images then filter_ part jumps."},{"line_number":1036,"context_line":"        # Otherwise we just mark everything to build."},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        if filter_:"},{"line_number":1039,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_c1522f35","line":1036,"range":{"start_line":1036,"start_character":43,"end_line":1036,"end_character":44},"updated":"2019-07-20 16:48:11.000000000","message":"not unbuildable","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a3ab0494b1351fee28d77c5bd7307710cfe997df","unresolved":false,"context_lines":[{"line_number":1033,"context_line":"                        image.status \u003d STATUS_UNBUILDABLE"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        # When we want to build subset of images then filter_ part jumps."},{"line_number":1036,"context_line":"        # Otherwise we just mark everything to build."},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        if filter_:"},{"line_number":1039,"context_line":"            patterns \u003d re.compile(r\"|\".join(filter_).join(\u0027()\u0027))"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_e98391a8","line":1036,"range":{"start_line":1036,"start_character":43,"end_line":1036,"end_character":44},"in_reply_to":"7faddb67_c1522f35","updated":"2019-07-22 13:46:51.000000000","message":"Done","commit_id":"75633d56558df2e55ea24e8e2d421289f3ed8246"}]}