)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd7fac4c05c47b2ebf9ddbf1774f37b3f6d1483d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Subprojects which haven\u0027t been migrated bgpvpn, l2gw, odl,"},{"line_number":16,"context_line":"neutron-dynamic-routing, fwaas, vpnaas and neutron-nsx"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I7a7e06124e05df5da26f356d3d60b9b53c16547d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_0b969d40","line":18,"updated":"2019-07-12 08:33:42.000000000","message":"Needs a bug report, and also link to the one Jason is creating.","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"}],"docker/neutron/neutron-server/extend_start.sh":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2d054d74fa375460bae4ca9a6d5e9a0570853fa4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    OPTS\u003d\"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini\""},{"line_number":7,"context_line":"    neutron-db-manage ${OPTS} upgrade head"},{"line_number":8,"context_line":"    neutron-db-manage ${OPTS} --subproject neutron-fwaas upgrade head"},{"line_number":9,"context_line":"    neutron-db-manage ${OPTS} --subproject neutron-vpnaas upgrade head"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_d4e03afd","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":70},"updated":"2019-07-11 09:24:45.000000000","message":"this is executed in main upgrade head.","commit_id":"e3669b47bd56ebac4dabf9723e6f487c79fb93ba"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"2d054d74fa375460bae4ca9a6d5e9a0570853fa4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP and NEUTRON_SFC_ENABLED variables are set."},{"line_number":14,"context_line":"# This catches all cases of the KOLLA_BOOTSTRAP and NEUTRON_SFC_ENABLED variable"},{"line_number":15,"context_line":"# being set, including empty."},{"line_number":16,"context_line":"if [[ \"${!NEUTRON_SFC_BOOTSTRAP[@]}\" ]]; then"},{"line_number":17,"context_line":"    neutron-db-manage --subproject networking-sfc --config-file /etc/neutron/neutron.conf upgrade head"},{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":22,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_94e2c200","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":2},"updated":"2019-07-11 09:24:45.000000000","message":"this too","commit_id":"e3669b47bd56ebac4dabf9723e6f487c79fb93ba"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f638b6183460e571edbe6e9a8b086faee690bd83","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":22,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."},{"line_number":23,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":24,"context_line":"    if [[ \"${!NEUTRON_DB_EXPAND[@]}\" ]]; then"},{"line_number":25,"context_line":"        echo \"Expanding database\""},{"line_number":26,"context_line":"        neutron-db-manage upgrade --expand"},{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":"    if [[ \"${!NEUTRON_DB_CONTRACT[@]}\" ]]; then"},{"line_number":29,"context_line":"        echo \"Contracting database\""},{"line_number":30,"context_line":"        neutron-db-manage upgrade --contract"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"    exit 0"},{"line_number":33,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_67b2f396","line":33,"range":{"start_line":21,"start_character":0,"end_line":33,"end_character":2},"updated":"2019-07-11 14:21:04.000000000","message":"This code has actually changed, although you can\u0027t see it here because the revert is based directly on the original patch from a few months ago. Here\u0027s what it looks like now:\n\n# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases\n# of the KOLLA_UPGRADE variable being set, including empty.\nif [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then\n    if [[ \"${!NEUTRON_DB_EXPAND[@]}\" ]]; then\n        DB_ACTION\u003d\"--expand\"\n        echo \"Expanding database\"\n    fi  \n    if [[ \"${!NEUTRON_DB_CONTRACT[@]}\" ]]; then\n        DB_ACTION\u003d\"--contract\"\n        echo \"Contracting database\"\n    fi  \n\n    if [[ \"${!NEUTRON_ROLLING_UPGRADE_SERVICES[@]}\" ]]; then\n        for service in ${NEUTRON_ROLLING_UPGRADE_SERVICES}; do\n            neutron-db-manage --subproject $service upgrade $DB_ACTION\n        done\n    fi  \n    exit 0\nfi","commit_id":"e3669b47bd56ebac4dabf9723e6f487c79fb93ba"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"685ac25ae3bf49fac2efd9404e62a7aabd6d9dcd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":22,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."},{"line_number":23,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":24,"context_line":"    if [[ \"${!NEUTRON_DB_EXPAND[@]}\" ]]; then"},{"line_number":25,"context_line":"        echo \"Expanding database\""},{"line_number":26,"context_line":"        neutron-db-manage upgrade --expand"},{"line_number":27,"context_line":"    fi"},{"line_number":28,"context_line":"    if [[ \"${!NEUTRON_DB_CONTRACT[@]}\" ]]; then"},{"line_number":29,"context_line":"        echo \"Contracting database\""},{"line_number":30,"context_line":"        neutron-db-manage upgrade --contract"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"    exit 0"},{"line_number":33,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_ca5ace28","line":33,"range":{"start_line":21,"start_character":0,"end_line":33,"end_character":2},"in_reply_to":"7faddb67_67b2f396","updated":"2019-07-11 14:27:43.000000000","message":"We probably want to revert to the code we have here.","commit_id":"e3669b47bd56ebac4dabf9723e6f487c79fb93ba"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd7fac4c05c47b2ebf9ddbf1774f37b3f6d1483d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    OPTS\u003d\"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini\""},{"line_number":7,"context_line":"    neutron-db-manage ${OPTS} upgrade head"},{"line_number":8,"context_line":"    neutron-db-manage ${OPTS} --subproject neutron-fwaas upgrade head"},{"line_number":9,"context_line":"    neutron-db-manage ${OPTS} --subproject neutron-vpnaas upgrade head"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_cb9ba563","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":70},"updated":"2019-07-12 08:33:42.000000000","message":"So we can remove these.","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd7fac4c05c47b2ebf9ddbf1774f37b3f6d1483d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP and NEUTRON_SFC_ENABLED variables are set."},{"line_number":14,"context_line":"# This catches all cases of the KOLLA_BOOTSTRAP and NEUTRON_SFC_ENABLED variable"},{"line_number":15,"context_line":"# being set, including empty."},{"line_number":16,"context_line":"if [[ \"${!NEUTRON_SFC_BOOTSTRAP[@]}\" ]]; then"},{"line_number":17,"context_line":"    neutron-db-manage --subproject networking-sfc --config-file /etc/neutron/neutron.conf upgrade head"},{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":22,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_4ba7b5a8","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":2},"updated":"2019-07-12 08:33:42.000000000","message":"Keep this for now, to avoid breaking kolla-ansible. We should remove the task in kolla-ansible that calls this though, and add a TODO to remove this in the U cycle.","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5117c5c7142645df35113fe222909f49c6677643","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP and NEUTRON_SFC_ENABLED variables are set."},{"line_number":14,"context_line":"# This catches all cases of the KOLLA_BOOTSTRAP and NEUTRON_SFC_ENABLED variable"},{"line_number":15,"context_line":"# being set, including empty."},{"line_number":16,"context_line":"if [[ \"${!NEUTRON_SFC_BOOTSTRAP[@]}\" ]]; then"},{"line_number":17,"context_line":"    neutron-db-manage --subproject networking-sfc --config-file /etc/neutron/neutron.conf upgrade head"},{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Migrate database and exit if KOLLA_UPGRADE variable is set. This catches all cases"},{"line_number":22,"context_line":"# of the KOLLA_UPGRADE variable being set, including empty."}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_cb37254d","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":2},"in_reply_to":"7faddb67_4ba7b5a8","updated":"2019-07-12 08:40:27.000000000","message":"Will take a look and work on this","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd7fac4c05c47b2ebf9ddbf1774f37b3f6d1483d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        echo \"Contracting database\""},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if [[ \"${!NEUTRON_ROLLING_UPGRADE_SERVICES[@]}\" ]]; then"},{"line_number":34,"context_line":"        for service in ${NEUTRON_ROLLING_UPGRADE_SERVICES}; do"},{"line_number":35,"context_line":"            neutron-db-manage --subproject $service upgrade $DB_ACTION"},{"line_number":36,"context_line":"        done"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"    exit 0"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_abaf497b","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":6},"updated":"2019-07-12 08:33:42.000000000","message":"This should go back to \n\nneutron-db-manage upgrade $DB_ACTION\n\nAnd remove NEUTRON_ROLLING_UPGRADE_SERVICES from kolla-ansible.","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"5117c5c7142645df35113fe222909f49c6677643","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        echo \"Contracting database\""},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if [[ \"${!NEUTRON_ROLLING_UPGRADE_SERVICES[@]}\" ]]; then"},{"line_number":34,"context_line":"        for service in ${NEUTRON_ROLLING_UPGRADE_SERVICES}; do"},{"line_number":35,"context_line":"            neutron-db-manage --subproject $service upgrade $DB_ACTION"},{"line_number":36,"context_line":"        done"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"    exit 0"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_eb2c6103","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":6},"in_reply_to":"7faddb67_abaf497b","updated":"2019-07-12 08:40:27.000000000","message":"rolling upgrade is a bit different because some subprojects doesn\u0027t support expand and contract action, so need to migrate those schemas after the upgrade in a non rolling upgrade method","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d94a6138e4b087bf02564524755bbb000114431a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        echo \"Contracting database\""},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if [[ \"${!NEUTRON_ROLLING_UPGRADE_SERVICES[@]}\" ]]; then"},{"line_number":34,"context_line":"        for service in ${NEUTRON_ROLLING_UPGRADE_SERVICES}; do"},{"line_number":35,"context_line":"            neutron-db-manage --subproject $service upgrade $DB_ACTION"},{"line_number":36,"context_line":"        done"},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"    exit 0"},{"line_number":39,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_3d6160d4","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":6},"in_reply_to":"7faddb67_eb2c6103","updated":"2019-07-12 09:10:36.000000000","message":"Hmm, I don\u0027t think we\u0027re doing that currently. We do include bootstrap_service.yml in rolling_upgrade.yml, but only do the SFC bootstrap.\n\nIn general though schema should always be migrated (excluding any contractions) before upgrading services.","commit_id":"04d3d4dfd8645de4ac8b363c3961e2bf008c0c99"}]}