)]}'
{"docker/nova/nova-base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c89e322e2e3abf7d0f051b30e680a9d57ef8b2c","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":135,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":136,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":137,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":138,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_b03818ee","line":135,"range":{"start_line":135,"start_character":51,"end_line":135,"end_character":84},"updated":"2019-07-12 07:45:32.000000000","message":"note-to-cores: we should really save this to a var since rhel derivatives are usually treated the same (and suse is rpm but different if we ever support it)","commit_id":"f1569bdee4eccb329aa6fba56772ac5b04031abb"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"62914438f457ff0c29784fbc6e0bd5378877dfe2","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":135,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":136,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":137,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":138,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_d602696f","line":135,"range":{"start_line":135,"start_character":51,"end_line":135,"end_character":84},"in_reply_to":"7faddb67_002d17fd","updated":"2019-07-12 13:13:46.000000000","message":"Yea I guess I can drop this because it won\u0027t hit on the base_distro_tag.startswith(\u00277\u0027).  And we won\u0027t be supporting centos7 by the time fedora 70 hits :D","commit_id":"f1569bdee4eccb329aa6fba56772ac5b04031abb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cf9c07560563470817c8f1a9643d7d096276f576","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":135,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":136,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":137,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":138,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_002d17fd","line":135,"range":{"start_line":135,"start_character":51,"end_line":135,"end_character":84},"in_reply_to":"7faddb67_0be45de0","updated":"2019-07-12 11:21:04.000000000","message":"Well, fedora does not follow the rhel versioning.","commit_id":"f1569bdee4eccb329aa6fba56772ac5b04031abb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dbf8e124476d5f733d1668666eff605b466532f2","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":135,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":136,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":137,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":138,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_0be45de0","line":135,"range":{"start_line":135,"start_character":51,"end_line":135,"end_character":84},"in_reply_to":"7faddb67_b03818ee","updated":"2019-07-12 08:35:20.000000000","message":"We already do this - base_package_type \u003d\u003d \u0027rpm\u0027 - and we are already inside it (L134).\n\nUnless you are trying to exclude fedora, then it\u0027s not necessary.","commit_id":"f1569bdee4eccb329aa6fba56772ac5b04031abb"}]}