)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c0503d41961c0684ba0318585b72c5f1b85a832d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eddie Yen \u003cmissile0407@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-12 02:53:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reported on Bug #1832306"},{"line_number":8,"context_line":"Since Ubuntu Bionic distro has updated gnocchi binary that require python3, we need to install its python dependences based on python3."},{"line_number":9,"context_line":"Especially \u0027cradox\u0027, this module is necessary for gnocchi to access Ceph. Wrong package version install will cause error during container bootstraping."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_30198821","line":7,"updated":"2019-07-12 07:07:34.000000000","message":"Please follow OpenStack Developer guide on commit message contents and length: https://docs.openstack.org/infra/manual/developers.html#development-workflow","commit_id":"f6a203875e0d160d798048057593c99379a20a6f"}],"docker/gnocchi/gnocchi-api/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6aa89a6b786c6556b2bda04ea8263a88b7aead79","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# ,and it will get port conflict error on apache2 when container launches."},{"line_number":22,"context_line":"# We have to delete default gnocchi config files and just use the file pushed by kolla-ansible."},{"line_number":23,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":24,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":25,"context_line":"RUN rm -rf /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":26,"context_line":"    {% endif %}"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_gnocchi_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_70fb8078","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":15},"updated":"2019-07-12 07:23:49.000000000","message":"this part should really be in the previous \u0027if\u0027 block (along with the comment of course)","commit_id":"f6a203875e0d160d798048057593c99379a20a6f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a49a0f49fa44ae9d2a6ad1b764e6f2cfe81f292a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7faddb67_9dc2bb58","updated":"2019-07-15 10:01:05.000000000","message":"This change will need to be made in master and backported. Could you propose it to master separately and remove from here?","commit_id":"32c8e7ca1534119bdf797dd134c4592e3b370522"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a49a0f49fa44ae9d2a6ad1b764e6f2cfe81f292a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# We have to delete default gnocchi config files and just use the file"},{"line_number":21,"context_line":"# pushed by kolla-ansible."},{"line_number":22,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":23,"context_line":"RUN rm -rf /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":24,"context_line":"    {% endif %}"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7faddb67_7a326512","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":100},"updated":"2019-07-15 10:01:05.000000000","message":"Can you move this inside the debian/ubuntu if on L15?","commit_id":"32c8e7ca1534119bdf797dd134c4592e3b370522"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eb74a9dc3ee83a66720ed059a59107770387515c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_0e576f5a","updated":"2019-07-15 13:49:40.000000000","message":"I don\u0027t think you meant to delete.","commit_id":"86653116b31795ef3dddb8c95038799f68539ab1"}],"docker/macros.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6aa89a6b786c6556b2bda04ea8263a88b7aead79","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{%- endmacro %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":25,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":26,"context_line":"{%- if not pip_version -%}"},{"line_number":27,"context_line":"    {%- set pip_version \u003d \u0027pip\u0027 -%}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_b00b387b","line":24,"range":{"start_line":24,"start_character":65,"end_line":24,"end_character":68},"updated":"2019-07-12 07:23:49.000000000","message":"let\u0027s set the default here...","commit_id":"f6a203875e0d160d798048057593c99379a20a6f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6aa89a6b786c6556b2bda04ea8263a88b7aead79","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":"{%- endmacro %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":25,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":26,"context_line":"{%- if not pip_version -%}"},{"line_number":27,"context_line":"    {%- set pip_version \u003d \u0027pip\u0027 -%}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_101b2cd0","line":24,"range":{"start_line":24,"start_character":51,"end_line":24,"end_character":62},"updated":"2019-07-12 07:23:49.000000000","message":"this is more of \u0027pip_cmd\u0027 rather than \u0027pip_version\u0027","commit_id":"f6a203875e0d160d798048057593c99379a20a6f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6aa89a6b786c6556b2bda04ea8263a88b7aead79","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% macro install_pip(packages, constraints \u003d true, pip_version \u003d pip) %}"},{"line_number":25,"context_line":"{%- if packages is sequence and packages|length \u003e 0 -%}"},{"line_number":26,"context_line":"{%- if not pip_version -%}"},{"line_number":27,"context_line":"    {%- set pip_version \u003d \u0027pip\u0027 -%}"},{"line_number":28,"context_line":"{%- endif -%}"},{"line_number":29,"context_line":"    {{ pip_version }} --no-cache-dir install --upgrade{{ \u0027 \u0027 }}"},{"line_number":30,"context_line":"    {%- if constraints %}-c /requirements/upper-constraints.txt {% endif -%}"},{"line_number":31,"context_line":"    {{ packages | join(\u0027 \u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_10800cc0","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":13},"updated":"2019-07-12 07:23:49.000000000","message":"... instead of here","commit_id":"f6a203875e0d160d798048057593c99379a20a6f"}]}