)]}'
{"docker/gnocchi/gnocchi-api/Dockerfile.j2":[{"author":{"_account_id":30687,"name":"Eddie Yen","email":"missile0407@gmail.com","username":"eddieak"},"change_message_id":"8441b4b12aa6d350ea604ec82454cf2cafc7a164","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"RUN rm -rf /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_8ebd9fd9","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":99},"updated":"2019-07-16 08:54:43.000000000","message":"The deletion must after package install because the files created during installation. Unless we move L17 both into next line after L13 and L15.","commit_id":"795d7f1b6a1c6d9ea344a6e03f04027a58e12ef9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ad28f356a6af3ad3ecb3eead7b2f82a7e458805d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"RUN rm -rf /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_ce739715","line":19,"updated":"2019-07-15 13:49:04.000000000","message":"This could be added on line 15, inside {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}","commit_id":"795d7f1b6a1c6d9ea344a6e03f04027a58e12ef9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"adac93f85a15973e53a92496fc23a71ed04482e2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"RUN rm -rf /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_b13d50de","line":19,"in_reply_to":"7faddb67_c9a9517c","updated":"2019-07-16 08:57:40.000000000","message":"Sorry, I missed that. Thanks for explaining.","commit_id":"795d7f1b6a1c6d9ea344a6e03f04027a58e12ef9"},{"author":{"_account_id":30687,"name":"Eddie Yen","email":"missile0407@gmail.com","username":"eddieak"},"change_message_id":"8441b4b12aa6d350ea604ec82454cf2cafc7a164","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":19,"context_line":"RUN rm -rf /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{% endif %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_c9a9517c","line":19,"in_reply_to":"7faddb67_ce739715","updated":"2019-07-16 08:54:43.000000000","message":"\u003e This could be added on line 15, inside {% elif base_package_type \u003d\u003d\n \u003e \u0027deb\u0027 %}\n\nSorry I think I didn\u0027t get it.\nDo you mean:\n{elif base_package_type \u003d\u003d \u0027deb\u0027 %}\n{% set gnocchi_api_packages \u003d [\u0027gnocchi-api\u0027] %}\nRUN -rf \u003cdefault gnocchi wsgi file\u003e\n{% end if %}\n\nI tested but the result that the deletion is earlier than installation, and the files didn\u0027t remove.","commit_id":"795d7f1b6a1c6d9ea344a6e03f04027a58e12ef9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f83d47a2d3abbac910fe9880bdf643c0a322bd98","unresolved":false,"context_lines":[{"line_number":19,"context_line":"         if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"    {% endif %}"},{"line_number":21,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":22,"context_line":"{{ rm_def_conf }}"},{"line_number":23,"context_line":"{% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_gnocchi_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_514c1c41","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":17},"updated":"2019-07-16 08:26:31.000000000","message":"probably gonna fail for centos","commit_id":"62a0f58ebf2502d63faca8d17bd6e32bbd8ad5f1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"288fc2fbc854ad71e1971b327ba7adb1c1c693a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":15,"context_line":"        {% set gnocchi_api_packages \u003d [\u0027gnocchi-api\u0027] %}"},{"line_number":16,"context_line":"RUN rm -f /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_311640f3","line":16,"updated":"2019-07-16 08:32:00.000000000","message":"That\u0027s what I was proposing, does it make sense to you Eddie?","commit_id":"30603ae65df5073437364eabcce08804bdd25fcc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3c09c8a0be490f795eded38ee4c43b005d67dfb4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":15,"context_line":"        {% set gnocchi_api_packages \u003d [\u0027gnocchi-api\u0027] %}"},{"line_number":16,"context_line":"RUN rm -f /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_91b3740a","line":16,"in_reply_to":"7faddb67_311640f3","updated":"2019-07-16 08:33:35.000000000","message":"But Mark, that\u0027s before the deb package could create it in the first place. ;-)","commit_id":"30603ae65df5073437364eabcce08804bdd25fcc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d1275a2b13e12eb5c1be8e38e55361ec1e995d9e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        ] %}"},{"line_number":14,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":15,"context_line":"        {% set gnocchi_api_packages \u003d [\u0027gnocchi-api\u0027] %}"},{"line_number":16,"context_line":"RUN rm -f /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":17,"context_line":"    {% endif %}"},{"line_number":18,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":19,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_31c4005f","line":16,"in_reply_to":"7faddb67_91b3740a","updated":"2019-07-16 08:34:12.000000000","message":"Doh.","commit_id":"30603ae65df5073437364eabcce08804bdd25fcc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"647889aa72a83da8c769a4c61de66c82d41a073d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":20,"context_line":"RUN rm -f /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7faddb67_31a720aa","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":35},"updated":"2019-07-16 08:39:03.000000000","message":"thought we only want to affect Ubuntu here","commit_id":"757ac4cc03bf03d01a0410c1101c41b94968034d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3e71a02f2323c2842a1a4ad9fdb362c0957add83","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":20,"context_line":"RUN rm -f /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7faddb67_91e4d4e1","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":35},"in_reply_to":"7faddb67_31a720aa","updated":"2019-07-16 08:42:11.000000000","message":"The bug was only seen on ubuntu but in most cases debian and ubuntu packages are the same. Removing the file in debian certainly won\u0027t hurt, and it might help.","commit_id":"757ac4cc03bf03d01a0410c1101c41b94968034d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f7ee0996e5dd27feea93b4630a13803406c3a0c8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{{ macros.install_packages(gnocchi_api_packages | customizable(\"packages\")) }}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":20,"context_line":"RUN rm -f /etc/apache2/sites-enabled/gnocchi-api.conf /etc/apache2/sites-available/gnocchi-api.conf"},{"line_number":21,"context_line":"    {% endif %}"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7faddb67_71d918f1","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":35},"in_reply_to":"7faddb67_91e4d4e1","updated":"2019-07-16 08:49:38.000000000","message":"Explanation accepted.","commit_id":"757ac4cc03bf03d01a0410c1101c41b94968034d"}]}