)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad651a0c39b1e30d52b717284756cfa4e5a9cbcd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Haproxy in centos 7 repos version is only 1.5.18 [1]."},{"line_number":10,"context_line":"It\u0027s quite outdated. Kolla should upgrade Haproxy"},{"line_number":11,"context_line":"package to 1.8.x version for new features."},{"line_number":12,"context_line":"* Binary: Use centos software collections repo. Haproxy"},{"line_number":13,"context_line":" version up to 1.8.17. [2]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://mirror.centos.org/centos/7/os/x86_64/Packages/haproxy-1.5.18-8.el7.x86_64.rpm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_b3a0d191","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"updated":"2019-07-18 07:14:54.000000000","message":"no distinction","commit_id":"74e123287eb0d2dbd388ae1d1a340f663eb38e11"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"ff65ab6cb3d07a301c112871139bd723deb8d503","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Haproxy in centos 7 repos version is only 1.5.18 [1]."},{"line_number":10,"context_line":"It\u0027s quite outdated. Kolla should upgrade Haproxy"},{"line_number":11,"context_line":"package to 1.8.x version for new features."},{"line_number":12,"context_line":"* Binary: Use centos software collections repo. Haproxy"},{"line_number":13,"context_line":" version up to 1.8.17. [2]"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] http://mirror.centos.org/centos/7/os/x86_64/Packages/haproxy-1.5.18-8.el7.x86_64.rpm"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_7616c74b","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"7faddb67_b3a0d191","updated":"2019-07-18 07:48:38.000000000","message":"Done","commit_id":"74e123287eb0d2dbd388ae1d1a340f663eb38e11"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"319dbfe36423e66fe500c90d0d8216f4f5e519b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Haproxy in centos 7 repos version is only 1.5.18 [1]."},{"line_number":10,"context_line":"It\u0027s quite outdated. Kolla should upgrade Haproxy"},{"line_number":11,"context_line":"package to 1.8.x version for new features."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Use centos software collections repo. Haproxy"},{"line_number":14,"context_line":"version up to 1.8.17. [2]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7faddb67_f0f7498b","line":11,"updated":"2019-09-03 08:24:03.000000000","message":"Could you describe here the benefit of this upgrade? Do we actually use any of the new features? CentOS 8 will be released soon (we hope), and could bring its own upgrade of haproxy.","commit_id":"b0ce60163f1f7a23d1af160537c6c77165abf9c4"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad651a0c39b1e30d52b717284756cfa4e5a9cbcd","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-OpsTools \\"},{"line_number":210,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage \\"},{"line_number":211,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization \\"},{"line_number":212,"context_line":"    \u0026\u0026 yum-config-manager --enable ol7_latest ol7_optional_latest ol7_addons software_collections \\"},{"line_number":213,"context_line":"    \u0026\u0026 {{ macros.install_packages( [\u0027yum-plugin-priorities\u0027 ], chain\u003dTrue, clean\u003dFalse) }} \\"},{"line_number":214,"context_line":"    \u0026\u0026 {{ macros.rpm_security_update(clean_package_cache) }}"},{"line_number":215,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_53763d40","line":212,"range":{"start_line":212,"start_character":35,"end_line":212,"end_character":45},"updated":"2019-07-18 07:14:54.000000000","message":"is not it enabled by default?","commit_id":"74e123287eb0d2dbd388ae1d1a340f663eb38e11"}],"docker/haproxy/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a9f1332a00f25646d1820fee96fb302e1a309c23","unresolved":false,"context_lines":[{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block haproxy_install %}"},{"line_number":15,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":17,"context_line":"        \u0027rh-haproxy18\u0027"},{"line_number":18,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7faddb67_94e8b416","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":54},"updated":"2019-07-25 08:42:16.000000000","message":"We do check on deb/rpm not on distro names","commit_id":"8ede30e83ac24478c84a2f8a84d449843a5073d8"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83696450ab119a5ea4eaae370baacb0ad4e6db71","unresolved":false,"context_lines":[{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block haproxy_install %}"},{"line_number":15,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":17,"context_line":"        \u0027rh-haproxy18\u0027"},{"line_number":18,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7faddb67_34ca206e","line":15,"range":{"start_line":15,"start_character":6,"end_line":15,"end_character":54},"in_reply_to":"7faddb67_94e8b416","updated":"2019-07-25 08:59:26.000000000","message":"Done","commit_id":"8ede30e83ac24478c84a2f8a84d449843a5073d8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a9f1332a00f25646d1820fee96fb302e1a309c23","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block haproxy_install %}"},{"line_number":15,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":17,"context_line":"        \u0027rh-haproxy18\u0027"},{"line_number":18,"context_line":"    ] %}"},{"line_number":19,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":21,"context_line":"        \u0027haproxy\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7faddb67_94d1945a","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":8},"updated":"2019-07-25 08:42:16.000000000","message":"Add \"if base_arch in [\u0027x86_64\u0027]\" as this repo was not built for other architectures - there we still are with older version.","commit_id":"8ede30e83ac24478c84a2f8a84d449843a5073d8"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83696450ab119a5ea4eaae370baacb0ad4e6db71","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block haproxy_install %}"},{"line_number":15,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":16,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":17,"context_line":"        \u0027rh-haproxy18\u0027"},{"line_number":18,"context_line":"    ] %}"},{"line_number":19,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":20,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":21,"context_line":"        \u0027haproxy\u0027"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7faddb67_d4c86c75","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":8},"in_reply_to":"7faddb67_94d1945a","updated":"2019-07-25 08:59:26.000000000","message":"Done","commit_id":"8ede30e83ac24478c84a2f8a84d449843a5073d8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"44566653425f16db9690272a60223f118530073b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":"{{ macros.install_packages(haproxy_packages | customizable(\"packages\")) }}"},{"line_number":31,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":32,"context_line":"RUN ln -s /opt/rh/rh-haproxy18/root/usr/sbin/haproxy /usr/sbin/haproxy"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_94d2f433","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":57},"updated":"2019-07-25 08:56:58.000000000","message":"fix this check too","commit_id":"e3b8b80d8241bea38d00a8975f2248a373db15ae"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83696450ab119a5ea4eaae370baacb0ad4e6db71","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ] %}"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":"{{ macros.install_packages(haproxy_packages | customizable(\"packages\")) }}"},{"line_number":31,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":32,"context_line":"RUN ln -s /opt/rh/rh-haproxy18/root/usr/sbin/haproxy /usr/sbin/haproxy"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_54b55ced","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":57},"in_reply_to":"7faddb67_94d2f433","updated":"2019-07-25 08:59:26.000000000","message":"Done","commit_id":"e3b8b80d8241bea38d00a8975f2248a373db15ae"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"44566653425f16db9690272a60223f118530073b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":"{{ macros.install_packages(haproxy_packages | customizable(\"packages\")) }}"},{"line_number":31,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":32,"context_line":"RUN ln -s /opt/rh/rh-haproxy18/root/usr/sbin/haproxy /usr/sbin/haproxy"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN mkdir -p /var/lib/kolla/haproxy \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_b4d5b01d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":70},"updated":"2019-07-25 08:56:58.000000000","message":"x86 only","commit_id":"e3b8b80d8241bea38d00a8975f2248a373db15ae"},{"author":{"_account_id":22406,"name":"Kien Nguyen","email":"kiennt2609@gmail.com","username":"kiennt"},"change_message_id":"83696450ab119a5ea4eaae370baacb0ad4e6db71","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":"{{ macros.install_packages(haproxy_packages | customizable(\"packages\")) }}"},{"line_number":31,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":32,"context_line":"RUN ln -s /opt/rh/rh-haproxy18/root/usr/sbin/haproxy /usr/sbin/haproxy"},{"line_number":33,"context_line":"{% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN mkdir -p /var/lib/kolla/haproxy \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_74b898e4","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":70},"in_reply_to":"7faddb67_b4d5b01d","updated":"2019-07-25 08:59:26.000000000","message":"Done","commit_id":"e3b8b80d8241bea38d00a8975f2248a373db15ae"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c7280319e5ef8dcfa5e367e1beb5ea083dfe9f1c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":18,"context_line":"        \u0027rh-haproxy18\u0027"},{"line_number":19,"context_line":"    ] %}"},{"line_number":20,"context_line":"{% else % }"},{"line_number":21,"context_line":"    {% set haproxy_packages \u003d ["},{"line_number":22,"context_line":"        \u0027haproxy\u0027"},{"line_number":23,"context_line":"    ] %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7faddb67_9461943c","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":11},"updated":"2019-07-25 09:16:58.000000000","message":"INFO:kolla.common.utils:Found the docker image folder at /home/hrw/devel/kolla/kolla/docker\nERROR:kolla.common.utils:Syntax error in template: haproxy/Dockerfile.j2\nERROR:kolla.common.utils:expected token \u0027end of statement block\u0027, got \u0027%\u0027","commit_id":"3a84b5a640598ec62b5c61771a21eadf4918757e"}]}
