)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06d966e1a855dfaca51415d758cd700420247350","unresolved":false,"context_lines":[{"line_number":20,"context_line":"x86_64:"},{"line_number":21,"context_line":"  centos: package from td-agent repo, with ruby embedded and"},{"line_number":22,"context_line":"          elasticsearch plugin embedded"},{"line_number":23,"context_line":"  ubuntu/debian: td-agent repo, with ruby embedded and"},{"line_number":24,"context_line":"                 elasticsearch plugin embedded"},{"line_number":25,"context_line":"arm:"},{"line_number":26,"context_line":"  centos: CentOS opstools repo with backlevel ruby and old fluentd,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"7faddb67_6d98b0cb","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":30},"updated":"2019-08-28 07:25:39.000000000","message":"erm, nope?","commit_id":"99c759b1035e0d72ddf757227d0d295f7eb3ac91"}],"docker/base/td.repo":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06d966e1a855dfaca51415d758cd700420247350","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[treasuredata]"},{"line_number":2,"context_line":"name\u003dTreasureData"},{"line_number":3,"context_line":"baseurl\u003dhttp://packages.treasuredata.com/3/redhat/\\$releasever/\\$basearch"},{"line_number":4,"context_line":"gpgcheck\u003d1"},{"line_number":5,"context_line":"gpgkey\u003dhttps://packages.treasuredata.com/GPG-KEY-td-agent"}],"source_content_type":"application/octet-stream","patch_set":33,"id":"7faddb67_8d9bacc6","line":3,"range":{"start_line":3,"start_character":41,"end_line":3,"end_character":42},"updated":"2019-08-28 07:25:39.000000000","message":"let\u0027s make a note in commit that we bumped repo version","commit_id":"99c759b1035e0d72ddf757227d0d295f7eb3ac91"}],"docker/fluentd/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32ca817f810c7875eb81153af4ff565b45747a87","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027td-agent\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":11,"context_line":"# TODO:remove hostname package as it should be installed by the"},{"line_number":12,"context_line":"# fluentd dependencies."},{"line_number":13,"context_line":"# hostname package is installed by default on CentOS/RHEL but not on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_351785a6","line":10,"updated":"2019-08-09 17:06:00.000000000","message":"why drop the indent?","commit_id":"c25f9d09c35a6c5d18607a438f83de2fa3bc256b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"24a3f6ac323bfb29c3df8680ce6c665b1ad0641b","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{{ macros.configure_user(name\u003d\u0027td-agent\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":11,"context_line":"# TODO:remove hostname package as it should be installed by the"},{"line_number":12,"context_line":"# fluentd dependencies."},{"line_number":13,"context_line":"# hostname package is installed by default on CentOS/RHEL but not on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_15936902","line":10,"in_reply_to":"7faddb67_351785a6","updated":"2019-08-12 10:56:29.000000000","message":"Done","commit_id":"c25f9d09c35a6c5d18607a438f83de2fa3bc256b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e043d7b5c788aeb5bac97698ae6d198564d58975","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 }"},{"line_number":10,"context_line":"        {{ macros.configure_user(name\u003d\u0027td-agent\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":11,"context_line":"        {% set fluentd_packages \u003d ["},{"line_number":12,"context_line":"            \u0027gcc-c++\u0027,"},{"line_number":13,"context_line":"            \u0027make\u0027,"},{"line_number":14,"context_line":"            \u0027ruby-devel\u0027,"},{"line_number":15,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":16,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":17,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":18,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":19,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027,"},{"line_number":20,"context_line":"            \u0027td-agent\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% else }"},{"line_number":23,"context_line":"        {{ macros.configure_user(name\u003d\u0027fluentd\u0027, groups\u003d\u0027mysql\u0027) }}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d ["},{"line_number":25,"context_line":"            \u0027gcc-c++\u0027,"},{"line_number":26,"context_line":"            \u0027make\u0027,"},{"line_number":27,"context_line":"            \u0027ruby-devel\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":31,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":32,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027,"},{"line_number":33,"context_line":"            \u0027fluentd\u0027"},{"line_number":34,"context_line":"        ] %}"},{"line_number":35,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":36,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":37,"context_line":"        \u0027g++\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"7faddb67_e94ee66c","line":34,"range":{"start_line":10,"start_character":0,"end_line":34,"end_character":12},"updated":"2019-08-12 09:17:39.000000000","message":"can you set fluentd_packages for shared entries and then just add \u0027td-agent\u0027 or \u0027fluentd\u0027?\n\nThen you can set \u0027fluent_user\u0027 to \u0027td-agent\u0027 or \u0027fluentd\u0027 in same block so end line will be just \u0027USER {{fluent_user}}\u0027","commit_id":"79b32df1eaaf8f5f17c4b293ad64df56eff1375f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5c516c4ad0a9882d75b5556612184a44ba46443","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027td-agent\u0027"},{"line_number":21,"context_line":"        ] %}"},{"line_number":22,"context_line":"    {% else %}"},{"line_number":23,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d ["},{"line_number":25,"context_line":"            \u0027gcc-c++\u0027,"},{"line_number":26,"context_line":"            \u0027make\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7faddb67_64f21be6","line":23,"range":{"start_line":23,"start_character":31,"end_line":23,"end_character":39},"updated":"2019-08-12 10:43:52.000000000","message":"fluentd?","commit_id":"2811e899578cbaeff0a92c4d3942b69408ca62ce"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f1085caf93dfe566a6471a4bf6bf0bfee781e02d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":13,"context_line":"            \u0027gcc-c++\u0027,"},{"line_number":14,"context_line":"            \u0027make\u0027,"},{"line_number":15,"context_line":"            \u0027ruby-devel\u0027,"},{"line_number":16,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":17,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":18,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":19,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":20,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027,"},{"line_number":21,"context_line":"    ] %}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_e4bfeb5d","line":20,"range":{"start_line":13,"start_character":8,"end_line":20,"end_character":13},"updated":"2019-08-12 11:08:50.000000000","message":"can we go back to 4 spaces?","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f1085caf93dfe566a6471a4bf6bf0bfee781e02d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{{ macros.configure_user(name\u003dfluentd_user, groups\u003d\u0027mysql\u0027) }}"},{"line_number":52,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 and base_arch !\u003d \u0027x86_64\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_4487dfb7","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":62},"updated":"2019-08-12 11:08:50.000000000","message":"Previously it was called only for Debian/Ubuntu systems. Red Hat derived probably had that in package.","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3548a96c816849bb5fee1b07b5cab3dd5d73ecb5","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{{ macros.configure_user(name\u003dfluentd_user, groups\u003d\u0027mysql\u0027) }}"},{"line_number":52,"context_line":"{{ macros.install_packages(fluentd_packages | customizable(\"packages\")) }}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 and base_arch !\u003d \u0027x86_64\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_bae7ce46","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":62},"in_reply_to":"7faddb67_4487dfb7","updated":"2019-08-12 12:40:43.000000000","message":"It seems if we don\u0027t call that - the fluentd_user doesn\u0027t get into kolla unix group - which totally breaks startup","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"365337cccc056bb95db58760a13c5085b5bc9fbe","unresolved":false,"context_lines":[{"line_number":60,"context_line":"COPY rpm_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":61,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":62,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":63,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/fluentd /var/run/fluentd"},{"line_number":64,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":65,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":66,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_a46ed3fd","line":63,"range":{"start_line":63,"start_character":41,"end_line":63,"end_character":48},"updated":"2019-08-12 11:11:32.000000000","message":"should not be correlated with fluentd_user?","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b67f3b597db49c660c58e08e06eb5de222dcbd2a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"COPY rpm_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":61,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":62,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":63,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/fluentd /var/run/fluentd"},{"line_number":64,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":65,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":66,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_eb39f3ce","line":63,"range":{"start_line":63,"start_character":41,"end_line":63,"end_character":48},"in_reply_to":"7faddb67_a46ed3fd","updated":"2019-08-12 16:22:27.000000000","message":"kind reminder to answer","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"365337cccc056bb95db58760a13c5085b5bc9fbe","unresolved":false,"context_lines":[{"line_number":67,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":68,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":69,"context_line":"    \u0026\u0026 rm -f /etc/td-agent/td-agent.conf \\"},{"line_number":70,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/td-agent"},{"line_number":71,"context_line":"    {% else %}"},{"line_number":72,"context_line":"COPY rpm_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":73,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_44759fcb","line":70,"range":{"start_line":70,"start_character":41,"end_line":70,"end_character":49},"updated":"2019-08-12 11:11:32.000000000","message":"ditto","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"365337cccc056bb95db58760a13c5085b5bc9fbe","unresolved":false,"context_lines":[{"line_number":73,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":74,"context_line":"    \u0026\u0026 mkdir -p /etc/fluentd \\"},{"line_number":75,"context_line":"    \u0026\u0026 mkdir -p /var/run/fluentd \\"},{"line_number":76,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/fluentd /var/run/fluentd"},{"line_number":77,"context_line":"    {% endif %}"},{"line_number":78,"context_line":"{% endif %}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"7faddb67_6470dbdb","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":48},"updated":"2019-08-12 11:11:32.000000000","message":"ditto","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"319875ce9ae50b38c1aa7545ac474c79fa3a7bb0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":68,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":69,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":70,"context_line":"    \u0026\u0026 rm -f /etc/td-agent/td-agent.conf \\"},{"line_number":71,"context_line":"    \u0026\u0026 mkdir -p /etc/{{ fluentd_user }} \\"},{"line_number":72,"context_line":"    \u0026\u0026 mkdir -p /var/run/{{ fluentd_user }} \\"},{"line_number":73,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7faddb67_b6a4c24c","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":42},"updated":"2019-08-12 17:11:44.000000000","message":"what about this part? sure only deb x86_64? otherwise now these branches do not differ much and can be merged","commit_id":"685b45a32af371a0db12187fb06d92b889f7e5ac"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"22e26e6baf4df31c33595f52a340008f4faf7a14","unresolved":false,"context_lines":[{"line_number":67,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":68,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":69,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":70,"context_line":"    \u0026\u0026 rm -f /etc/td-agent/td-agent.conf \\"},{"line_number":71,"context_line":"    \u0026\u0026 mkdir -p /etc/{{ fluentd_user }} \\"},{"line_number":72,"context_line":"    \u0026\u0026 mkdir -p /var/run/{{ fluentd_user }} \\"},{"line_number":73,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7faddb67_95edf2b8","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":42},"in_reply_to":"7faddb67_150b4224","updated":"2019-08-13 07:53:33.000000000","message":"Then merge all the branches into one since they are variable-controlled in full now.","commit_id":"685b45a32af371a0db12187fb06d92b889f7e5ac"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"392a7214daeb424bee3358b7e6d23e638eef3184","unresolved":false,"context_lines":[{"line_number":67,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":68,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":69,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":70,"context_line":"    \u0026\u0026 rm -f /etc/td-agent/td-agent.conf \\"},{"line_number":71,"context_line":"    \u0026\u0026 mkdir -p /etc/{{ fluentd_user }} \\"},{"line_number":72,"context_line":"    \u0026\u0026 mkdir -p /var/run/{{ fluentd_user }} \\"},{"line_number":73,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7faddb67_150b4224","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":42},"in_reply_to":"7faddb67_b6a4c24c","updated":"2019-08-13 06:56:46.000000000","message":"I think we should be able to safely remove this, it gets overwritten in k-a anyways: https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/common/templates/fluentd.json.j2#L21","commit_id":"685b45a32af371a0db12187fb06d92b889f7e5ac"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7bea515c52c9d8531a967f3efef30bd26b790462","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":19,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":20,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":21,"context_line":"            \u0027td-agent\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% else %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"7faddb67_1b24d3ae","line":21,"updated":"2019-08-13 09:24:09.000000000","message":"Are we able to pin the version installed here to help make the image build process more repeatable?","commit_id":"40c063b195d270eb85e45caa62a8f49d243bacbb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ade5c12159b19eb1e2159d469139b1add65cec2a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":19,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":20,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":21,"context_line":"            \u0027td-agent\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% else %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_3b53b63b","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":22},"updated":"2019-08-14 13:20:55.000000000","message":"If I\u0027m reading this right, this package is shared across distros now. Maybe it should go in the base package set? \n\n  https://review.opendev.org/#/c/675614/23/docker/fluentd/Dockerfile.j2@12\n\n\nWe\u0027d just need to key off of the arch type and append \"td-agent\" or \"fluentd\"?","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"24c3ddcfe4ea9d4028322daa997577e0c0b54eed","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":19,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":20,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":21,"context_line":"            \u0027td-agent\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% else %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_f6a213ad","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":22},"in_reply_to":"7faddb67_3b53b63b","updated":"2019-08-14 13:36:00.000000000","message":"Well it can\u0027t, because we use td-agent on all x86_64 and Debian/Ubuntu arm, but not on CentOS on arm.","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"36d2ab2081c2d41e544b028b2af169b7b8ed6d21","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            \u0027td-agent\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% else %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"},{"line_number":32,"context_line":"    {% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_3b441647","line":31,"range":{"start_line":24,"start_character":0,"end_line":31,"end_character":12},"updated":"2019-08-14 12:37:30.000000000","message":"Longer lists could use extend\n\n  set _ \u003d fluentd_packages.extend([...])","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"36d2ab2081c2d41e544b028b2af169b7b8ed6d21","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":19,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":20,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":21,"context_line":"            \u0027td-agent\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% else %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"},{"line_number":32,"context_line":"    {% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_605e5946","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":12},"updated":"2019-08-14 12:37:30.000000000","message":"you can use set with append instead of redefining the array.\n\n  set _ \u003d fluentd_packages.append(\u0027td-agent\u0027)","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"24c3ddcfe4ea9d4028322daa997577e0c0b54eed","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":19,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":20,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":21,"context_line":"            \u0027td-agent\u0027"},{"line_number":22,"context_line":"        ] %}"},{"line_number":23,"context_line":"    {% else %}"},{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"},{"line_number":32,"context_line":"    {% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_f68bf31a","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":12},"in_reply_to":"7faddb67_605e5946","updated":"2019-08-14 13:36:00.000000000","message":"I know, but this approach seemed like more readable - I can change it though.","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"36d2ab2081c2d41e544b028b2af169b7b8ed6d21","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    ] %}"},{"line_number":42,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":43,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":44,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":45,"context_line":"            \u0027td-agent\u0027"},{"line_number":46,"context_line":"        ] %}"},{"line_number":47,"context_line":"    {% endif %}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_9ba3ca00","line":46,"range":{"start_line":44,"start_character":8,"end_line":46,"end_character":12},"updated":"2019-08-14 12:37:30.000000000","message":"same as above.","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"36d2ab2081c2d41e544b028b2af169b7b8ed6d21","unresolved":false,"context_lines":[{"line_number":85,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":88,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":89,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":90,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":91,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":92,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":93,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":94,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":95,"context_line":"    ] %}"},{"line_number":96,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":97,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":98,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":99,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":100,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":101,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":102,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":103,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":104,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":105,"context_line":"    ] %}"},{"line_number":106,"context_line":"{% endif %}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_7ba84ed8","line":105,"range":{"start_line":88,"start_character":0,"end_line":105,"end_character":8},"updated":"2019-08-14 12:37:30.000000000","message":"same nit from about about list concatenation.","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"36d2ab2081c2d41e544b028b2af169b7b8ed6d21","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":88,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":89,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":90,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":91,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":92,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":93,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":94,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":95,"context_line":"    ] %}"},{"line_number":96,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":97,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":98,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":99,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":100,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":101,"context_line":"        \u0027fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":102,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":103,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":104,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":105,"context_line":"    ] %}"},{"line_number":106,"context_line":"{% endif %}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"7faddb67_207f01ac","line":106,"range":{"start_line":87,"start_character":0,"end_line":106,"end_character":11},"updated":"2019-08-14 12:37:30.000000000","message":"with the converged package, why are these plugin sets different? I could see using the different version tags but rpm with x86_64 seems to be missing \"fluent-plugin-elasticsearch\".","commit_id":"7a0a3a5f51d73fee4354917a2c9091ff21be4d7f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d3918b71b67ed9d3eccc302506321cb32655def0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_2ff814c2","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":46},"updated":"2019-08-19 08:28:47.000000000","message":"This is another plugin that I think should be removed - perhaps this one could wait until a later change. Currently we use it for parsing Apache logs, but there is a built in Apache parser, or a built in regexp parser that could be used rather than relying on this external Ruby Gem [1].\n\n[1] https://docs.fluentd.org/parser/regexp","commit_id":"9ff0b1c23c3e94ab5af81242eb01f37f3e483217"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"119ffb8ce58784e287ae228f9bed582900e9d0cb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_8f358847","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":46},"in_reply_to":"7faddb67_2ff814c2","updated":"2019-08-19 08:45:27.000000000","message":"currently used, but should be replaced","commit_id":"9ff0b1c23c3e94ab5af81242eb01f37f3e483217"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d3918b71b67ed9d3eccc302506321cb32655def0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_cfedc025","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"updated":"2019-08-19 08:28:47.000000000","message":"Is this a relic from Kolla Kubernetes? It is an external plugin and it would be nice to remove it. If anyone is actually using it they can add it back via an image customisation.","commit_id":"9ff0b1c23c3e94ab5af81242eb01f37f3e483217"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"119ffb8ce58784e287ae228f9bed582900e9d0cb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \u0027fluentd\u0027,"},{"line_number":26,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_0f4198a6","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":63},"in_reply_to":"7faddb67_cfedc025","updated":"2019-08-19 08:45:27.000000000","message":"indeed looks like it\nwe are removing it to unbreak ubuntu atm: https://review.opendev.org/#/c/677144/1/docker/fluentd/Dockerfile.j2","commit_id":"9ff0b1c23c3e94ab5af81242eb01f37f3e483217"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d3918b71b67ed9d3eccc302506321cb32655def0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"},{"line_number":32,"context_line":"    {% endif %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_0fb8b80e","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":20},"updated":"2019-08-19 08:28:47.000000000","message":"This is another external dependency that can go, it looks like it is built in from 0.14.12 [1].\n\n[1] https://github.com/tagomoris/fluent-plugin-secure-forward","commit_id":"9ff0b1c23c3e94ab5af81242eb01f37f3e483217"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"119ffb8ce58784e287ae228f9bed582900e9d0cb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":28,"context_line":"            \u0027rubygem-fluent-plugin-kubernetes_metadata_filter\u0027,"},{"line_number":29,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":30,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":31,"context_line":"        ] %}"},{"line_number":32,"context_line":"    {% endif %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_6f092c82","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":20},"in_reply_to":"7faddb67_0fb8b80e","updated":"2019-08-19 08:45:27.000000000","message":"not used, to be removed","commit_id":"9ff0b1c23c3e94ab5af81242eb01f37f3e483217"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6b389354fd80c00e660e2709f29deda21fd26987","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":63,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":64,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":65,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":66,"context_line":"    \u0026\u0026 mkdir -p /etc/{{ fluentd_user }} \\"},{"line_number":67,"context_line":"    \u0026\u0026 mkdir -p /var/run/{{ fluentd_user }} \\"},{"line_number":68,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"7faddb67_fe247762","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":102},"updated":"2019-08-26 07:31:48.000000000","message":"the 3 branches seem to differ by this very line which looks suspicious at least anyway","commit_id":"f70f5be402cf3ae90fcfd01667fe56acd0f44b3e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"751727a06863d767e8762c4e84543df8bafae667","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":63,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":64,"context_line":"RUN chmod 440 /etc/sudoers.d/kolla_fluentd_sudoers \\"},{"line_number":65,"context_line":"    \u0026\u0026 sed -i -e \"s/USER\u003dtd-agent/USER\u003droot/\" -e \"s/GROUP\u003dtd-agent/GROUP\u003droot/\" /etc/init.d/td-agent \\"},{"line_number":66,"context_line":"    \u0026\u0026 mkdir -p /etc/{{ fluentd_user }} \\"},{"line_number":67,"context_line":"    \u0026\u0026 mkdir -p /var/run/{{ fluentd_user }} \\"},{"line_number":68,"context_line":"    \u0026\u0026 chown -R {{ fluentd_user }}: /etc/{{ fluentd_user }} /var/run/{{ fluentd_user }}"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"7faddb67_feb23706","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":102},"in_reply_to":"7faddb67_fe247762","updated":"2019-08-26 07:34:40.000000000","message":"It was there, that\u0027s why I left it there, maybe Ubuntu/x86_64 is special - but let me test if fluentd deploys if we remove it...","commit_id":"f70f5be402cf3ae90fcfd01667fe56acd0f44b3e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d387626a89c10941ace890c2f58d92c6ecf05b6a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":32,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":33,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":34,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":35,"context_line":"        ] %}"},{"line_number":36,"context_line":"    {% endif %}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7faddb67_28015f3a","line":34,"range":{"start_line":34,"start_character":1,"end_line":34,"end_character":50},"updated":"2019-08-27 08:41:46.000000000","message":"This can be removed, it looks like it is built in from 0.14.12 [1].\n\n[1] https://github.com/tagomoris/fluent-plugin-secure-forward","commit_id":"726c3641bd45be768c5c33e44088540fff753852"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf65462f4761dbe7053f360bc6e7f11ea85b720f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            \u0027rubygem-fluent-plugin-elasticsearch\u0027,"},{"line_number":32,"context_line":"            \u0027rubygem-fluent-plugin-grok-parser\u0027,"},{"line_number":33,"context_line":"            \u0027rubygem-fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":34,"context_line":"            \u0027rubygem-fluent-plugin-secure-forward\u0027"},{"line_number":35,"context_line":"        ] %}"},{"line_number":36,"context_line":"    {% endif %}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7faddb67_b8da7e1a","line":34,"range":{"start_line":34,"start_character":1,"end_line":34,"end_character":50},"in_reply_to":"7faddb67_28015f3a","updated":"2019-08-27 11:07:16.000000000","message":"On CentOS aarch64 we\u0027re still using fluentd from CentOS OpsTools repo - so it\u0027s 0.12, then I guess we should leave it there. Unless it\u0027s totally unused?","commit_id":"726c3641bd45be768c5c33e44088540fff753852"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d387626a89c10941ace890c2f58d92c6ecf05b6a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":84,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":85,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":86,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":87,"context_line":"    ] %}"},{"line_number":88,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":89,"context_line":"    {% set fluentd_plugins \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7faddb67_48fcdb3e","line":86,"range":{"start_line":86,"start_character":7,"end_line":86,"end_character":39},"updated":"2019-08-27 08:41:46.000000000","message":"This can be removed, it looks like it is built in from 0.14.12 [1].\n\n[1] https://github.com/tagomoris/fluent-plugin-secure-forward","commit_id":"726c3641bd45be768c5c33e44088540fff753852"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf65462f4761dbe7053f360bc6e7f11ea85b720f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":84,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":85,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":86,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":87,"context_line":"    ] %}"},{"line_number":88,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":89,"context_line":"    {% set fluentd_plugins \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7faddb67_78e406e1","line":86,"range":{"start_line":86,"start_character":7,"end_line":86,"end_character":39},"in_reply_to":"7faddb67_48fcdb3e","updated":"2019-08-27 11:07:16.000000000","message":"Done","commit_id":"726c3641bd45be768c5c33e44088540fff753852"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d387626a89c10941ace890c2f58d92c6ecf05b6a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":93,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":94,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":95,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":96,"context_line":"    ] %}"},{"line_number":97,"context_line":"{% endif %}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7faddb67_08f6e35e","line":95,"range":{"start_line":95,"start_character":6,"end_line":95,"end_character":39},"updated":"2019-08-27 08:41:46.000000000","message":"Same here.","commit_id":"726c3641bd45be768c5c33e44088540fff753852"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf65462f4761dbe7053f360bc6e7f11ea85b720f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":93,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":94,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":95,"context_line":"        \u0027fluent-plugin-secure-forward\u0027,"},{"line_number":96,"context_line":"    ] %}"},{"line_number":97,"context_line":"{% endif %}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"7faddb67_98e782e4","line":95,"range":{"start_line":95,"start_character":6,"end_line":95,"end_character":39},"in_reply_to":"7faddb67_08f6e35e","updated":"2019-08-27 11:07:16.000000000","message":"Done","commit_id":"726c3641bd45be768c5c33e44088540fff753852"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06d966e1a855dfaca51415d758cd700420247350","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Distro specific files and operations"},{"line_number":59,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":60,"context_line":"COPY rpm_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":61,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":62,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":63,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"7faddb67_0da7bc0b","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":61},"updated":"2019-08-28 07:25:39.000000000","message":"this +2 dittos, refer to sudoers file, it does not have to be repeated now","commit_id":"99c759b1035e0d72ddf757227d0d295f7eb3ac91"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06d966e1a855dfaca51415d758cd700420247350","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":63,"context_line":"COPY fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":64,"context_line":"    {% else %}"},{"line_number":65,"context_line":"RUN /usr/bin/gem install fluentd --no-rdoc --no-ri"},{"line_number":66,"context_line":"COPY rpm_fluentd_sudoers /etc/sudoers.d/kolla_fluentd_sudoers"},{"line_number":67,"context_line":"    {% endif %}"},{"line_number":68,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"7faddb67_2d7b987b","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":50},"updated":"2019-08-28 07:25:39.000000000","message":"this is the only remaining statement and it is for debian now","commit_id":"99c759b1035e0d72ddf757227d0d295f7eb3ac91"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027 %} "},{"line_number":4,"context_line":"LABEL fluentd_version\u003d\"0.12\" fluentd_binary\u003d\"fluentd\""},{"line_number":5,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":6,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_ed5ca04d","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":62},"updated":"2019-08-28 08:31:53.000000000","message":"that space!","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_ed2100b7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":34},"updated":"2019-08-28 08:31:53.000000000","message":"just move it to the if above (or use fluentd_binary)","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":20,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":21,"context_line":"        {% set fluentd_packages \u003d ["},{"line_number":22,"context_line":"            \u0027td-agent\u0027"},{"line_number":23,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_cd2684cc","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":43},"updated":"2019-08-28 08:31:53.000000000","message":"ditto","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":40,"context_line":"        {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":41,"context_line":"        {% set fluentd_packages \u003d ["},{"line_number":42,"context_line":"            \u0027td-agent\u0027"},{"line_number":43,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_ad2b0893","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":43},"updated":"2019-08-28 08:31:53.000000000","message":"ditto","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \u0027td-agent\u0027"},{"line_number":43,"context_line":"        ] %}"},{"line_number":44,"context_line":"    {% else %}"},{"line_number":45,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":46,"context_line":"        \u0027g++\u0027,"},{"line_number":47,"context_line":"        \u0027make\u0027,"},{"line_number":48,"context_line":"        \u0027ruby\u0027,"},{"line_number":49,"context_line":"        \u0027ruby-dev\u0027,"},{"line_number":50,"context_line":"    ] %}"},{"line_number":51,"context_line":"    {% endif %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_2d11585e","line":50,"range":{"start_line":45,"start_character":0,"end_line":50,"end_character":8},"updated":"2019-08-28 08:31:53.000000000","message":"indent","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"ARG monasca_output_plugin_url\u003dhttps://github.com/monasca/fluentd-monasca/archive/$monasca_output_plugin_tag.tar.gz"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"{% if fluentd_user \u003d\u003d \u0027fluentd\u0027 %}"},{"line_number":104,"context_line":"RUN curl -sSL $monasca_output_plugin_url -o /tmp/fluentd-monasca.tar.gz \\ "},{"line_number":105,"context_line":"    \u0026\u0026 tar -xvf /tmp/fluentd-monasca.tar.gz -C /tmp \\"},{"line_number":106,"context_line":"    \u0026\u0026 cd /tmp/fluentd-monasca-* \\"},{"line_number":107,"context_line":"    \u0026\u0026 gem build fluentd-monasca-output.gemspec \\"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_ed0a6025","line":104,"range":{"start_line":104,"start_character":73,"end_line":104,"end_character":74},"updated":"2019-08-28 08:31:53.000000000","message":"another space","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"031f85a3f7d418285c8bf32d7d54c7a375bda64a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"RUN curl -sSL $monasca_output_plugin_url -o /tmp/fluentd-monasca.tar.gz \\"},{"line_number":112,"context_line":"    \u0026\u0026 tar -xvf /tmp/fluentd-monasca.tar.gz -C /tmp \\"},{"line_number":113,"context_line":"    \u0026\u0026 cd /tmp/fluentd-monasca-* \\"},{"line_number":114,"context_line":"    \u0026\u0026 td-agent-gem build fluentd-monasca-output.gemspec \\"},{"line_number":115,"context_line":"    \u0026\u0026 {{ macros.install_fluent_plugins([\u0027fluentd-monasca-output-*.gem\u0027], chain\u003dTrue) }} \\"},{"line_number":116,"context_line":"    \u0026\u0026 rm -rf /tmp/fluentd*"},{"line_number":117,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"7faddb67_cdff6400","line":114,"range":{"start_line":114,"start_character":7,"end_line":114,"end_character":19},"updated":"2019-08-28 08:31:53.000000000","message":"the two branches differ only by this","commit_id":"e9f74299069f6ade96f6cde2fe97cb2bb475b1ab"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"710d2c1a56eaa5478d7461c494adc13491cd46bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch !\u003d \u0027x86_64\u0027 %} "},{"line_number":4,"context_line":"LABEL fluentd_version\u003d\"0.12\" fluentd_binary\u003d\"fluentd\""},{"line_number":5,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":6,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""}],"source_content_type":"text/x-jinja2","patch_set":36,"id":"7faddb67_127fd866","line":3,"range":{"start_line":3,"start_character":61,"end_line":3,"end_character":62},"updated":"2019-08-28 09:53:33.000000000","message":"trim space","commit_id":"263cf368394b9569061d24adfbc197c00a9d0e34"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"710d2c1a56eaa5478d7461c494adc13491cd46bb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            \u0027td-agent\u0027"},{"line_number":46,"context_line":"        ] %}"},{"line_number":47,"context_line":"    {% else %}"},{"line_number":48,"context_line":"    {% set fluentd_packages \u003d ["},{"line_number":49,"context_line":"        \u0027g++\u0027,"},{"line_number":50,"context_line":"        \u0027make\u0027,"},{"line_number":51,"context_line":"        \u0027ruby\u0027,"},{"line_number":52,"context_line":"        \u0027ruby-dev\u0027,"},{"line_number":53,"context_line":"    ] %}"},{"line_number":54,"context_line":"    {% endif %}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":36,"id":"7faddb67_d2d5c048","line":53,"range":{"start_line":48,"start_character":0,"end_line":53,"end_character":8},"updated":"2019-08-28 09:53:33.000000000","message":"indent","commit_id":"263cf368394b9569061d24adfbc197c00a9d0e34"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"710d2c1a56eaa5478d7461c494adc13491cd46bb","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# Distro specific files and operations"},{"line_number":62,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":63,"context_line":"    {% if base_arch !\u003d \u0027x86_64\u0027 and base_distro !\u003d \u0027ubuntu\u0027 %}"},{"line_number":64,"context_line":"RUN /usr/bin/gem install fluentd --no-rdoc --no-ri"},{"line_number":65,"context_line":"    {% endif %}"},{"line_number":66,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":36,"id":"7faddb67_12103800","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":62},"updated":"2019-08-28 09:53:33.000000000","message":"if fluentd_user \u003d\u003d \u0027fluentd\u0027\n\nThis will remove wondering which distro/arch you mean. Cause now I am lost...","commit_id":"263cf368394b9569061d24adfbc197c00a9d0e34"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"710d2c1a56eaa5478d7461c494adc13491cd46bb","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":81,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":82,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":36,"id":"7faddb67_921428eb","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":61},"updated":"2019-08-28 09:53:33.000000000","message":"what about rpm distro on !x86?","commit_id":"263cf368394b9569061d24adfbc197c00a9d0e34"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"05b76903556b45ef11a1b67c3a93473efc8a2fa8","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":81,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":82,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":36,"id":"7faddb67_95ec12bc","line":80,"range":{"start_line":80,"start_character":0,"end_line":80,"end_character":61},"in_reply_to":"7faddb67_921428eb","updated":"2019-08-28 11:15:52.000000000","message":"They are rpm based from CentOS Opstools - see line 33-36","commit_id":"263cf368394b9569061d24adfbc197c00a9d0e34"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"710d2c1a56eaa5478d7461c494adc13491cd46bb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"ARG monasca_output_plugin_url\u003dhttps://github.com/monasca/fluentd-monasca/archive/$monasca_output_plugin_tag.tar.gz"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"{% if fluentd_user \u003d\u003d \u0027fluentd\u0027 %}"},{"line_number":107,"context_line":"RUN curl -sSL $monasca_output_plugin_url -o /tmp/fluentd-monasca.tar.gz \\ "},{"line_number":108,"context_line":"    \u0026\u0026 tar -xvf /tmp/fluentd-monasca.tar.gz -C /tmp \\"},{"line_number":109,"context_line":"    \u0026\u0026 cd /tmp/fluentd-monasca-* \\"},{"line_number":110,"context_line":"    \u0026\u0026 gem build fluentd-monasca-output.gemspec \\"}],"source_content_type":"text/x-jinja2","patch_set":36,"id":"7faddb67_32d1b430","line":107,"range":{"start_line":107,"start_character":73,"end_line":107,"end_character":74},"updated":"2019-08-28 09:53:33.000000000","message":"trim","commit_id":"263cf368394b9569061d24adfbc197c00a9d0e34"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2a2307e9e785613902ceb053d303cb928ff98253","unresolved":false,"context_lines":[{"line_number":109,"context_line":"{% if base_distro \u003d\u003d \u0027debian\u0027 or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_arch !\u003d \u0027x86_64\u0027) %}"},{"line_number":110,"context_line":"    \u0026\u0026 gem build fluentd-monasca-output.gemspec \\"},{"line_number":111,"context_line":"{% else %}"},{"line_number":112,"context_line":"    \u0026\u0026 td-agent-gem build fluentd-monasca-output.gemspec \\"},{"line_number":113,"context_line":"{% endif %}"},{"line_number":114,"context_line":"    \u0026\u0026 {{ macros.install_fluent_plugins([\u0027fluentd-monasca-output-*.gem\u0027], chain\u003dTrue) }} \\"},{"line_number":115,"context_line":"    \u0026\u0026 rm -rf /tmp/fluentd*"}],"source_content_type":"text/x-jinja2","patch_set":43,"id":"7faddb67_81433bb0","line":112,"range":{"start_line":112,"start_character":7,"end_line":112,"end_character":19},"updated":"2019-08-31 11:38:47.000000000","message":"better template the binary","commit_id":"e1e4aba14e19010f58604c05ab978cf7de6d1351"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e2ebac5abdf021878abc0c37fd833a035223a3ff","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"{% block fluentd_plugins_install %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":81,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":82,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":84,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":85,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter\u0027,"},{"line_number":86,"context_line":"    ] %}"},{"line_number":87,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":88,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":89,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":90,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":91,"context_line":"        \u0027fluent-plugin-grok-parser:2.1.4\u0027,"},{"line_number":92,"context_line":"        \u0027fluent-plugin-parser\u0027,"},{"line_number":93,"context_line":"        \u0027fluent-plugin-rewrite-tag-filter:2.0.0\u0027,"},{"line_number":94,"context_line":"    ] %}"},{"line_number":95,"context_line":"{% endif %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{{ macros.install_fluent_plugins(fluentd_plugins | customizable(\"plugins\")) }}"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":47,"id":"7faddb67_528dec2e","line":95,"range":{"start_line":80,"start_character":0,"end_line":95,"end_character":11},"updated":"2019-09-04 09:00:31.000000000","message":"why plugins are versioned for deb but not for rpm?","commit_id":"93b004a8f93bda37ab586353a392899d98b98f91"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"160ad3fb2873e8038c8015143803b69263882619","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":8,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":9,"context_line":"{% else %}"},{"line_number":10,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":11,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_52988c19","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"updated":"2019-09-04 09:28:39.000000000","message":"Should this now be the latest stable version?","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4cc78496af4d35cb9d7ce98bcef5d2d5e267265c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":8,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":9,"context_line":"{% else %}"},{"line_number":10,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":11,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_98b62525","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"in_reply_to":"7faddb67_0de675e8","updated":"2019-09-04 10:49:20.000000000","message":"Wouldn\u0027t it be nice if we could use the same version everywhere :)","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"428cd2665d54a1b27315bd5db7fbaa44937b2d97","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":8,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":9,"context_line":"{% else %}"},{"line_number":10,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":11,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_0de675e8","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"in_reply_to":"7faddb67_52988c19","updated":"2019-09-04 10:10:36.000000000","message":"Well, it is more or less :-) On Debian/Ubuntu we had 0.14 switches in kolla-ansible config.yml, so I preferred to differ the versions as they were in config.yml (0.12 and 0.14). I know we are using 1.x stable branch, but configs/api are the same for 0.14 and 1.0 (https://www.fluentd.org/blog/fluentd-v1.0.0.rc1-has-been-released). Changing here to 1.0 or something similar would require a change in kolla-ansible...","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c1fa7b0a0b783a9f25a3b9c0d3a61fc21fa76c5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":8,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":9,"context_line":"{% else %}"},{"line_number":10,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":11,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_d189ba25","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"in_reply_to":"7faddb67_98b62525","updated":"2019-09-05 13:57:47.000000000","message":"Could change kolla-ansible to use \u003e\u003d, but won\u0027t block on it.","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92c65b958fe5d98d3419e12f8414b074028fb579","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"fluentd\""},{"line_number":8,"context_line":"    {% set fluentd_user \u003d \u0027fluentd\u0027 %}"},{"line_number":9,"context_line":"{% else %}"},{"line_number":10,"context_line":"LABEL fluentd_version\u003d\"0.14\" fluentd_binary\u003d\"td-agent\""},{"line_number":11,"context_line":"    {% set fluentd_user \u003d \u0027td-agent\u0027 %}"},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_d7368ab4","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":27},"in_reply_to":"7faddb67_d189ba25","updated":"2019-09-05 14:56:46.000000000","message":"We could, but I would prefer to do it in a separate patchset.","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c1fa7b0a0b783a9f25a3b9c0d3a61fc21fa76c5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027td-agent\u0027"},{"line_number":48,"context_line":"        ] %}"},{"line_number":49,"context_line":"    {% else %}"},{"line_number":50,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":51,"context_line":"            \u0027ruby\u0027,"},{"line_number":52,"context_line":"            \u0027ruby-dev\u0027"},{"line_number":53,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_165f480f","line":50,"updated":"2019-09-05 13:57:47.000000000","message":"Needs to include fluentd?","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92c65b958fe5d98d3419e12f8414b074028fb579","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027td-agent\u0027"},{"line_number":48,"context_line":"        ] %}"},{"line_number":49,"context_line":"    {% else %}"},{"line_number":50,"context_line":"        {% set fluentd_packages \u003d fluentd_packages + ["},{"line_number":51,"context_line":"            \u0027ruby\u0027,"},{"line_number":52,"context_line":"            \u0027ruby-dev\u0027"},{"line_number":53,"context_line":"        ] %}"}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_17bbc20e","line":50,"in_reply_to":"7faddb67_165f480f","updated":"2019-09-05 14:56:46.000000000","message":"No, it\u0027s using gem install on Debian and Ubuntu non x86_64. See line 64.","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"160ad3fb2873e8038c8015143803b69263882619","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"{% if (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027) or base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":80,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":81,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":82,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":84,"context_line":"        \u0027fluent-plugin-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_324cf09c","line":81,"updated":"2019-09-04 09:28:39.000000000","message":"I know some of these are included in the td-agent repo - are they pre-installed, or do they still need installing? If they are pre-installed maybe it\u0027s still better to be explicit, in which case don\u0027t worry.","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4cc78496af4d35cb9d7ce98bcef5d2d5e267265c","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"{% if (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027) or base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":80,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":81,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":82,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":84,"context_line":"        \u0027fluent-plugin-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_386051a5","line":81,"in_reply_to":"7faddb67_0dff5566","updated":"2019-09-04 10:49:20.000000000","message":"Just thinking about people who can\u0027t pull in random ruby gems. They can override this section at least.","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"428cd2665d54a1b27315bd5db7fbaa44937b2d97","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"{% if (base_package_type \u003d\u003d \u0027rpm\u0027 and base_arch \u003d\u003d \u0027x86_64\u0027) or base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":80,"context_line":"    {% set fluentd_plugins \u003d ["},{"line_number":81,"context_line":"        \u0027fluent-plugin-elasticsearch\u0027,"},{"line_number":82,"context_line":"        \u0027fluent-plugin-grep\u0027,"},{"line_number":83,"context_line":"        \u0027fluent-plugin-grok-parser\u0027,"},{"line_number":84,"context_line":"        \u0027fluent-plugin-parser\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":48,"id":"7faddb67_0dff5566","line":81,"in_reply_to":"7faddb67_324cf09c","updated":"2019-09-04 10:10:36.000000000","message":"elastic search is pre-included in the td-agent repo, but for Debian for example we use gem install fluentd, and I believe it doesn\u0027t include that.\nI don\u0027t think it will kill us if we will update the elastic search plugin in the td-agent bundle?","commit_id":"ef8d7a27ab5b7d6fce8a060b1bc2709b0d1bbb98"}],"docker/fluentd/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5c516c4ad0a9882d75b5556612184a44ba46443","unresolved":false,"context_lines":[{"line_number":17,"context_line":"if [ ! -d /var/log/kolla ]; then"},{"line_number":18,"context_line":"    mkdir -p /var/log/kolla"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":"if [ ! -d /var/lib/${FLUENTD} ]; then"},{"line_number":21,"context_line":"   mkdir -p /var/lib/${FLUENTD}"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":24,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"},{"line_number":25,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_a429f337","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":2},"updated":"2019-08-12 10:43:52.000000000","message":"packages should have handled that, rather look at misconfigured paths than create new ones","commit_id":"2811e899578cbaeff0a92c4d3942b69408ca62ce"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4ca1949ab4b9a3788755c3aec8f9ffc2711f92d0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"if [ ! -d /var/log/kolla ]; then"},{"line_number":18,"context_line":"    mkdir -p /var/log/kolla"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":"if [ ! -d /var/lib/${FLUENTD} ]; then"},{"line_number":21,"context_line":"   mkdir -p /var/lib/${FLUENTD}"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":24,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"},{"line_number":25,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_04aa4718","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":2},"in_reply_to":"7faddb67_04d9e720","updated":"2019-08-12 11:09:14.000000000","message":"Yeah, I feel so. Moreover, permissions should be handled by JSON config seeded by k-a for deployed services.","commit_id":"2811e899578cbaeff0a92c4d3942b69408ca62ce"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"24a3f6ac323bfb29c3df8680ce6c665b1ad0641b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"if [ ! -d /var/log/kolla ]; then"},{"line_number":18,"context_line":"    mkdir -p /var/log/kolla"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":"if [ ! -d /var/lib/${FLUENTD} ]; then"},{"line_number":21,"context_line":"   mkdir -p /var/lib/${FLUENTD}"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":24,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"},{"line_number":25,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7faddb67_04d9e720","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":2},"in_reply_to":"7faddb67_a429f337","updated":"2019-08-12 10:56:29.000000000","message":"Awesome, so you think I should delete lines 29-31 in that file? :-)","commit_id":"2811e899578cbaeff0a92c4d3942b69408ca62ce"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f1085caf93dfe566a6471a4bf6bf0bfee781e02d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    mkdir -p /var/log/kolla"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":"if [ ! -d /var/lib/${FLUENTD} ]; then"},{"line_number":21,"context_line":"   mkdir -p /var/lib/${FLUENTD}"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":"if [[ $(stat -c %U:%G /var/log/kolla) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":24,"context_line":"    sudo chown ${USERGROUP} /var/log/kolla"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7faddb67_a4b9f379","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":3},"updated":"2019-08-12 11:08:50.000000000","message":"4 spaces please","commit_id":"69b116c67cc371f9c33bb12a4c8d67494b2885e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"544af4fade9a82181e3d0ad603fbbfc23b3e5279","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu \u0026\u0026 \"${KOLLA_BASE_ARCH}\" \u003d\u003d \"x86_64\" ]]; then"},{"line_number":10,"context_line":"    USERGROUP\u003d\"td-agent:kolla\""},{"line_number":11,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":12,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":12,"id":"7faddb67_445eff45","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":90},"updated":"2019-08-12 11:13:51.000000000","message":"is this still true? are not there more conditions now?","commit_id":"9f2a85dec272f57f7b7395a0d3c4cae1cea06df9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"7b7b4ddd95f528fb4ce95b8997134242306ba821","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log/kolla directory so that new"},{"line_number":7,"context_line":"# files and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu|centos \u0026\u0026 \"${KOLLA_BASE_ARCH}\" \u003d\u003d \"x86_64\" ]]; then"},{"line_number":10,"context_line":"    USERGROUP\u003d\"td-agent:kolla\""},{"line_number":11,"context_line":"    FLUENTD\u003d\"td-agent\""},{"line_number":12,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":15,"id":"7faddb67_70b972c9","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":55},"updated":"2019-08-12 16:02:49.000000000","message":"Just scrap this. You install \u0027td-agent\u0027 on x86-64 in all distros now.","commit_id":"543125c52e1b58f3304f75f6aa969e65e6e275e6"}],"docker/fluentd/rpm_fluentd_sudoers":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"06d966e1a855dfaca51415d758cd700420247350","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/log/kolla, /usr/bin/chown fluentd\\:kolla /var/log/kolla"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/log/kolla, /usr/bin/chown td-agent\\:kolla /var/log/kolla"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown fluentd\\:kolla /var/lib/fluentd, /usr/bin/chown fluentd\\:kolla /var/lib/fluentd"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chown td-agent\\:kolla /var/lib/td-agent, /usr/bin/chown td-agent\\:kolla /var/lib/td-agent"},{"line_number":5,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/log/kolla, /usr/bin/chmod 2775 /var/log/kolla"},{"line_number":6,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /bin/chmod 2775 /var/lib/fluentd, /usr/bin/chmod 2775 /var/lib/fluentd"}],"source_content_type":"application/octet-stream","patch_set":33,"id":"7faddb67_ad47884c","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":122},"updated":"2019-08-28 07:25:39.000000000","message":"please see the other sudoers file, we should ensure that just the right file (better named) gets deployed and not modify this in place","commit_id":"99c759b1035e0d72ddf757227d0d295f7eb3ac91"}],"docker/macros.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1db5773f8f26ea11eb8f317011c503feb7e7eeab","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        ulimit -n 65536 \u0026\u0026 td-agent-gem install {{ plugins | join(\u0027 \u0027) }}"},{"line_number":113,"context_line":"    {%- else -%}"},{"line_number":114,"context_line":"        ulimit -n 65536 \u0026\u0026 gem install --minimal-deps {{ plugins | join(\u0027 \u0027) }}"},{"line_number":115,"context_line":"    {%- elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] -%}"},{"line_number":116,"context_line":"        {%- if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro \u003d\u003d \u0027ubuntu\u0027 -%}"},{"line_number":117,"context_line":"            ulimit -n 65536 \u0026\u0026 td-agent-gem install {{ plugins | join(\u0027 \u0027) }}"},{"line_number":118,"context_line":"        {%- else -%}"},{"line_number":119,"context_line":"            ulimit -n 65536 \u0026\u0026 gem install --minimal-deps {{ plugins | join(\u0027 \u0027) }}"},{"line_number":120,"context_line":"        {%- endif %}"},{"line_number":121,"context_line":"    {%- endif %}"},{"line_number":122,"context_line":"{%- endif %}"},{"line_number":123,"context_line":"{%- endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"7faddb67_1c375000","line":120,"range":{"start_line":115,"start_character":0,"end_line":120,"end_character":20},"updated":"2019-08-22 09:03:54.000000000","message":"be gone!","commit_id":"db91a6de50eb70932e703ab593b4005bfca936f2"}]}