)]}'
{"docker/nova/nova-api/extend_start.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8d00b6a744f11477bf6e2a99d81c1deb869304c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":13,"context_line":"    nova-manage api_db sync"},{"line_number":14,"context_line":"    nova-manage db sync"},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_4a9688f2","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":23},"updated":"2019-08-20 08:39:33.000000000","message":"Same comment applies here.","commit_id":"c5b355174d8778c7f163c80f33fbd4dcac7c8684"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b16fe02a7c9a9c8dce6953bf92b52443ecf10e45","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    nova-manage api_db sync"},{"line_number":7,"context_line":"    nova-manage db sync  # TODO(dszumski): Remove when Nova Conductor does this"},{"line_number":8,"context_line":"    nova-manage db online_data_migrations"},{"line_number":9,"context_line":"    exit 0"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_53bcfd04","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":41},"updated":"2019-08-20 16:00:24.000000000","message":"and this? are not we going to remove it then too?","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fd93f2d808dc042abecf5fe145b60e1fb990321c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    nova-manage api_db sync"},{"line_number":7,"context_line":"    nova-manage db sync  # TODO(dszumski): Remove when Nova Conductor does this"},{"line_number":8,"context_line":"    nova-manage db online_data_migrations"},{"line_number":9,"context_line":"    exit 0"},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_93d03521","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":41},"in_reply_to":"7faddb67_53bcfd04","updated":"2019-08-20 16:24:30.000000000","message":"I\u0027ve made a general warning to avoid copy and pasting this everywhere.","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b16fe02a7c9a9c8dce6953bf92b52443ecf10e45","unresolved":false,"context_lines":[{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"if [[ \"${!KOLLA_OSM[@]}\" ]]; then"},{"line_number":19,"context_line":"    nova-manage db online_data_migrations"},{"line_number":20,"context_line":"    exit 0"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_73b7b922","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":41},"updated":"2019-08-20 16:00:24.000000000","message":"ditto","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"}],"docker/nova/nova-conductor/extend_start.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8d00b6a744f11477bf6e2a99d81c1deb869304c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Assume the service runs on top of Apache when user is root"},{"line_number":22,"context_line":"if [[ \"$(whoami)\" \u003d\u003d \u0027root\u0027 ]]; then"},{"line_number":23,"context_line":"    # NOTE(pbourke): httpd will not clean up after itself in some cases which"},{"line_number":24,"context_line":"    # results in the container not being able to restart. (bug #1489676, 1557036)"},{"line_number":25,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":26,"context_line":"        # Loading Apache2 ENV variables"},{"line_number":27,"context_line":"        . /etc/apache2/envvars"},{"line_number":28,"context_line":"        rm -rf /var/run/apache2/*"},{"line_number":29,"context_line":"    else"},{"line_number":30,"context_line":"        rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"},{"line_number":31,"context_line":"    fi"},{"line_number":32,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_4abf6860","line":32,"range":{"start_line":21,"start_character":0,"end_line":32,"end_character":2},"updated":"2019-08-20 08:39:33.000000000","message":"Don\u0027t need this bit.","commit_id":"c5b355174d8778c7f163c80f33fbd4dcac7c8684"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b16fe02a7c9a9c8dce6953bf92b52443ecf10e45","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    nova-manage db sync"},{"line_number":7,"context_line":"    nova-manage db online_data_migrations"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_53e39d34","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":61},"updated":"2019-08-20 16:00:24.000000000","message":"are not we being overly verbose with this? other magic variables work the same, yet they are not privileged with this precious note; this is nitpick and not necessarily to change in this very change, but I find it irritating seeing this message over and over again :-) maybe move it to docs / contributor guide? @mgoddard","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"31c0b99d0ce694a8121a466579bf83ee974d80f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    nova-manage db sync"},{"line_number":7,"context_line":"    nova-manage db online_data_migrations"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_5304fd17","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":61},"in_reply_to":"7faddb67_130685cf","updated":"2019-08-20 16:35:40.000000000","message":"Actually I\u0027d prefer to keep it :p","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1d57be67cefc5aa8076a37fbb33da6231ec0d50a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    nova-manage db sync"},{"line_number":7,"context_line":"    nova-manage db online_data_migrations"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_76d247ff","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":61},"in_reply_to":"7faddb67_5304fd17","updated":"2019-08-20 17:00:40.000000000","message":"\u003e Actually I\u0027d prefer to keep it :p\n\nDecisions, decisions :D","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fd93f2d808dc042abecf5fe145b60e1fb990321c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    nova-manage db sync"},{"line_number":7,"context_line":"    nova-manage db online_data_migrations"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_130685cf","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":61},"in_reply_to":"7faddb67_53e39d34","updated":"2019-08-20 16:24:30.000000000","message":"Wouldn\u0027t like to irritate you :) I also prefer reading the script.","commit_id":"49971e801a412623ae56ede312f6d2d219ae464d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6dd926a903fed8de6eab01d46ef516638ebf2e93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":4,"context_line":"    nova-manage db sync"},{"line_number":5,"context_line":"    nova-manage db online_data_migrations"},{"line_number":6,"context_line":"    exit 0"},{"line_number":7,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_3501fa6b","line":4,"updated":"2019-08-22 13:38:27.000000000","message":"Looking at devstack, I think we might want to add --local_cell here.","commit_id":"b087f058c96be252aa32842f208f766295a2b5ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6dd926a903fed8de6eab01d46ef516638ebf2e93","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"${!KOLLA_UPGRADE[@]}\" ]]; then"},{"line_number":10,"context_line":"    nova-manage db sync"},{"line_number":11,"context_line":"    exit 0"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_f5f2829b","line":10,"updated":"2019-08-22 13:38:27.000000000","message":"and here","commit_id":"b087f058c96be252aa32842f208f766295a2b5ca"}]}
