)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fcdb64431e50afe862432cdc0256d33cf5a62155","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add package systemd-sysv to bifrost-deploy image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"CMD of image bifrost-deploy is set to \"/sbin/init\" which is part"},{"line_number":10,"context_line":"of package \"systemd-sysv\" on debian/centos distros."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie2195248443e37dc22b713ecd1eb6de2876446d3"},{"line_number":13,"context_line":"Closes-Bug: 1840949"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5faad753_1ad1d223","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":42},"updated":"2019-09-16 08:20:32.000000000","message":"I see the bug report is about ubuntu issue. CentOS works fine.","commit_id":"e08d5d3f6d75b4c02e44b63e59b10c08f52a388d"}],"docker/bifrost/bifrost-deploy/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"673751bf1b0ec0b6ec0c962e5d722b0b2b66603b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% set bifrost_deploy_packages \u003d ["},{"line_number":52,"context_line":"    \u0027systemd-sysv\u0027,"},{"line_number":53,"context_line":"    \u0027iptables\u0027,"},{"line_number":54,"context_line":"    \u0027e2fsprogs\u0027"},{"line_number":55,"context_line":"] %}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_02d626f3","line":53,"updated":"2019-09-05 10:28:40.000000000","message":"nit: normally these are ordered alphabetically.","commit_id":"842f05af7ec09256a43e374ba5d942a7242002d6"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"4764b8f815967d187b07b5d9ba199b91eae62d91","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% set bifrost_deploy_packages \u003d ["},{"line_number":52,"context_line":"    \u0027systemd-sysv\u0027,"},{"line_number":53,"context_line":"    \u0027iptables\u0027,"},{"line_number":54,"context_line":"    \u0027e2fsprogs\u0027"},{"line_number":55,"context_line":"] %}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_e833ab11","line":53,"in_reply_to":"7faddb67_02d626f3","updated":"2019-09-05 12:34:17.000000000","message":"That makes sense, I\u0027ll send an update","commit_id":"842f05af7ec09256a43e374ba5d942a7242002d6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"829faa8d2cdcf9a4381f3827d27f5da6c03ef1f2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% set bifrost_deploy_packages \u003d ["},{"line_number":52,"context_line":"    \u0027e2fsprogs\u0027"},{"line_number":53,"context_line":"    \u0027iptables\u0027,"},{"line_number":54,"context_line":"    \u0027systemd-sysv\u0027,"},{"line_number":55,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7faddb67_970fb237","line":52,"updated":"2019-09-05 15:24:08.000000000","message":"Missing comma","commit_id":"0c3ade862b290417bb78504ba48d95420e669b76"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4122623201f3418fd819d076ea536709d13a2393","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_distro_tag \u003d\u003d \u002716.04\u0027) %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rm -f $(find /lib/systemd/system/sysinit.target.wants/ ! -name systemd-tmpfiles-setup.service -type l); \\"},{"line_number":13,"context_line":"    rm -f /lib/systemd/system/multi-user.target.wants/*; \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_faf71658","line":10,"range":{"start_line":10,"start_character":97,"end_line":10,"end_character":125},"updated":"2019-09-16 08:45:56.000000000","message":"it looks broken generally because now we build for 18.04 which includes systemd like 16.04","commit_id":"e08d5d3f6d75b4c02e44b63e59b10c08f52a388d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"86f917888fe1cad2f04c4fb1d6366b04e33b5421","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_distro_tag \u003d\u003d \u002716.04\u0027) %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rm -f $(find /lib/systemd/system/sysinit.target.wants/ ! -name systemd-tmpfiles-setup.service -type l); \\"},{"line_number":13,"context_line":"    rm -f /lib/systemd/system/multi-user.target.wants/*; \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_1d654b46","line":10,"range":{"start_line":10,"start_character":97,"end_line":10,"end_character":125},"in_reply_to":"5faad753_150f6537","updated":"2019-09-16 10:25:30.000000000","message":"Hey Jan, Ubuntu 14.04 is no longer supported by us so we can get away with removing the whole branch altogether.","commit_id":"e08d5d3f6d75b4c02e44b63e59b10c08f52a388d"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"b5878bb88a166f2ee937e655edb523fff3644c1b","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_distro_tag \u003d\u003d \u002716.04\u0027) %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rm -f $(find /lib/systemd/system/sysinit.target.wants/ ! -name systemd-tmpfiles-setup.service -type l); \\"},{"line_number":13,"context_line":"    rm -f /lib/systemd/system/multi-user.target.wants/*; \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_63c4de40","line":10,"range":{"start_line":10,"start_character":97,"end_line":10,"end_character":125},"in_reply_to":"5faad753_1d654b46","updated":"2019-09-16 11:57:22.000000000","message":"I have opened https://review.opendev.org/#/c/682349/1 for that.","commit_id":"e08d5d3f6d75b4c02e44b63e59b10c08f52a388d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c76e2f947a546bb3a7662dd88fbf91d82fc4c88e","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_distro_tag \u003d\u003d \u002716.04\u0027) %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rm -f $(find /lib/systemd/system/sysinit.target.wants/ ! -name systemd-tmpfiles-setup.service -type l); \\"},{"line_number":13,"context_line":"    rm -f /lib/systemd/system/multi-user.target.wants/*; \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_c3f7d28a","line":10,"range":{"start_line":10,"start_character":97,"end_line":10,"end_character":125},"in_reply_to":"5faad753_63c4de40","updated":"2019-09-16 11:58:30.000000000","message":"Thanks, great.","commit_id":"e08d5d3f6d75b4c02e44b63e59b10c08f52a388d"},{"author":{"_account_id":30911,"name":"Jan Horstmann","email":"horstmann@osism.tech","username":"jhorstmann"},"change_message_id":"35d2614251cd361981841f989a5a028b7d0413d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027, \u0027debian\u0027] or (base_distro \u003d\u003d \u0027ubuntu\u0027 and base_distro_tag \u003d\u003d \u002716.04\u0027) %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN rm -f $(find /lib/systemd/system/sysinit.target.wants/ ! -name systemd-tmpfiles-setup.service -type l); \\"},{"line_number":13,"context_line":"    rm -f /lib/systemd/system/multi-user.target.wants/*; \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_150f6537","line":10,"range":{"start_line":10,"start_character":97,"end_line":10,"end_character":125},"in_reply_to":"5faad753_faf71658","updated":"2019-09-16 09:43:23.000000000","message":"Ubuntu 14.04 should be the last supported release without systemd, so maybe we could just change the statement to something like:\n\n{% if base_distro \u003d\u003d \u0027ubuntu\u0027 and base_distro_tag \u003d\u003d \u002714.04\u0027) %}\n{# do the stuff from https://raw.githubusercontent.com/tianon/dockerfiles/4d24a12b54b75b3e0904d8a285900d88d3326361/sbin-init/ubuntu/upstart/14.04/Dockerfile #}\n{% else %}\n{# remove the unecessary systemd units #}\n{% endif %}","commit_id":"e08d5d3f6d75b4c02e44b63e59b10c08f52a388d"}]}