)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"892871d088c8d461442bf3fa6622d70b595bcd0c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"{% endif %}"},{"line_number":437,"context_line":"{% endblock %}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_22f9e2c3","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":14},"updated":"2019-09-05 10:11:41.000000000","message":"This part concerns me - if someone has overridden the dumb_init_installation block to disable dumb-init then they\u0027ll now get the entrypoint.\n\nIs this patch necessary for Tripleo?","commit_id":"767219dee8ac2df4d7a6d37ccad02b551483eb18"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7962e6ef3de013661640133f725e03fbe9899d46","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"{% endif %}"},{"line_number":437,"context_line":"{% endblock %}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_dc19d187","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":14},"in_reply_to":"7faddb67_22f9e2c3","updated":"2019-09-05 14:56:46.000000000","message":"I\u0027m actually not 100% certain this is required, however, it was something a colleague put in place within master related to controlling dumb-init, so I thought it best to ensure feature parity with the older releases.\n\nThis change pulls this release in-line with master, https://github.com/openstack/kolla/blob/master/docker/base/Dockerfile.j2#L436-L460\n\nThat said, I will move this `endblock` down to keep the current functionality for this release.","commit_id":"767219dee8ac2df4d7a6d37ccad02b551483eb18"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1a1b25ad3e8492a6dd9baf049d64b409963c5280","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/dumb-init"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"{% endif %}"},{"line_number":437,"context_line":"{% endblock %}"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":440,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_37a27e40","line":437,"range":{"start_line":437,"start_character":0,"end_line":437,"end_character":14},"in_reply_to":"7faddb67_dc19d187","updated":"2019-09-05 15:20:03.000000000","message":"Ok, it\u0027s more palatable now.","commit_id":"767219dee8ac2df4d7a6d37ccad02b551483eb18"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"3bffeb71e11bdc1ec79feed4d099a6fa98f9abc8","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"{% endif %}"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":439,"context_line":"{% endblock %}"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"{% endif %}"},{"line_number":442,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_a8e5060b","line":439,"range":{"start_line":438,"start_character":0,"end_line":439,"end_character":14},"updated":"2019-09-12 18:34:45.000000000","message":"This got lost here in backporting.\n\nENTRYPOINT should be outside of the block but inside of the endif","commit_id":"a3419f060e1aa8c3c9f59fbd9b71595841a8287d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c454969dfb93fe2457be1858d9f0441820c68e23","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"{% endif %}"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"ENTRYPOINT [\"dumb-init\", \"--single-child\", \"--\"]"},{"line_number":439,"context_line":"{% endblock %}"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"{% endif %}"},{"line_number":442,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_e2ceb180","line":439,"range":{"start_line":438,"start_character":0,"end_line":439,"end_character":14},"in_reply_to":"5faad753_a8e5060b","updated":"2019-09-13 08:32:01.000000000","message":"We changed this explicitly to avoid breaking backwards compatibility for people overriding dumb_init_installation, since this is a stable branch. See PS1","commit_id":"a3419f060e1aa8c3c9f59fbd9b71595841a8287d"}],"releasenotes/notes/add-use-dumb-init-config-option-26b47f6d97d7585c.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1a1b25ad3e8492a6dd9baf049d64b409963c5280","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    This can be use to avoid the of ``dumb-init`` as the container entrypoint,"},{"line_number":6,"context_line":"    using ``kolla_start`` directly instead. This option can also be disabled"},{"line_number":7,"context_line":"    via the ``kolla-build --nouse-dumb-init`` CLI argument."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Moves the ``ENTRYPOINT`` statement outside of the"},{"line_number":11,"context_line":"    ``dumb_init_installation`` Jinja block in the base image. Overriding this"},{"line_number":12,"context_line":"    block to install ``dumb-init`` by another method no longer requires"},{"line_number":13,"context_line":"    repeating the ``ENTRYPOINT`` statement. Users wishing to avoid the use of"},{"line_number":14,"context_line":"    ``dumb-init`` altogether can now use the ``use_dumb_init`` configuration"},{"line_number":15,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_d7bd2a68","line":15,"range":{"start_line":8,"start_character":0,"end_line":15,"end_character":11},"updated":"2019-09-05 15:20:03.000000000","message":"No longer applies.","commit_id":"bef242b099142ee526963ee184e17544f8a2a0d8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bffcaca9e2ef49fa00a27cd80195aea7f8a78965","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    This can be use to avoid the of ``dumb-init`` as the container entrypoint,"},{"line_number":6,"context_line":"    using ``kolla_start`` directly instead. This option can also be disabled"},{"line_number":7,"context_line":"    via the ``kolla-build --nouse-dumb-init`` CLI argument."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Moves the ``ENTRYPOINT`` statement outside of the"},{"line_number":11,"context_line":"    ``dumb_init_installation`` Jinja block in the base image. Overriding this"},{"line_number":12,"context_line":"    block to install ``dumb-init`` by another method no longer requires"},{"line_number":13,"context_line":"    repeating the ``ENTRYPOINT`` statement. Users wishing to avoid the use of"},{"line_number":14,"context_line":"    ``dumb-init`` altogether can now use the ``use_dumb_init`` configuration"},{"line_number":15,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5faad753_711bd61a","line":15,"range":{"start_line":8,"start_character":0,"end_line":15,"end_character":11},"in_reply_to":"7faddb67_d7bd2a68","updated":"2019-09-09 16:46:31.000000000","message":"Done","commit_id":"bef242b099142ee526963ee184e17544f8a2a0d8"}]}