)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5faad753_ee3b2ae8","side":"PARENT","updated":"2019-09-12 19:42:40.000000000","message":"patch set 10 is wrong","commit_id":"90892a25bd9aa96d7c070e49b0afbcee9bf5fca7"}],"docker/base/sources.list.debian":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deb https://packages.grafana.com/oss/deb stable main"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# td-agent for fluentd"},{"line_number":17,"context_line":"deb http://packages.treasuredata.com/3/debian/stretch/ stretch contrib"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Percona XtraBackup repo"},{"line_number":20,"context_line":"# NOTE(yoctozepto): enabled only in the xtrabackup image (to spare MariaDB deps and allow Zuul override)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_7708f62b","line":17,"range":{"start_line":17,"start_character":55,"end_line":17,"end_character":62},"updated":"2019-09-05 15:36:10.000000000","message":"How good is stretch package on buster? Usable?","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deb https://packages.grafana.com/oss/deb stable main"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# td-agent for fluentd"},{"line_number":17,"context_line":"deb http://packages.treasuredata.com/3/debian/stretch/ stretch contrib"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Percona XtraBackup repo"},{"line_number":20,"context_line":"# NOTE(yoctozepto): enabled only in the xtrabackup image (to spare MariaDB deps and allow Zuul override)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7faddb67_09a2c63f","line":17,"range":{"start_line":17,"start_character":55,"end_line":17,"end_character":62},"in_reply_to":"7faddb67_7708f62b","updated":"2019-09-12 19:42:40.000000000","message":"According to official Treasure Data site https://docs.fluentd.org/installation/install-by-deb there is no td-agent package for Buster at this moment. Moreover the td-agent package seems to be stand-alone - it has only one dependency to lsb_release. Finally it seems to be functional.","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"388e7ae22811911f071ec8ad75878f8cd6aa6fc2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"deb https://packages.grafana.com/oss/deb stable main"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# td-agent for fluentd"},{"line_number":17,"context_line":"deb http://packages.treasuredata.com/3/debian/stretch/ stretch contrib"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Percona XtraBackup repo"},{"line_number":20,"context_line":"# NOTE(yoctozepto): enabled only in the xtrabackup image (to spare MariaDB deps and allow Zuul override)"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5faad753_4b271014","line":17,"updated":"2019-09-09 09:22:28.000000000","message":"Even if stretch\u0027s td-agent is working on buster, better will be to use buster version when it will be released -\u003e https://github.com/treasure-data/omnibus-td-agent/issues/209","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"}],"docker/fluentd/extend_start.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c20ad4b95de638756add39fe50a7545839e4e6dc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":"if [[ $(stat -c %U:%G /var/run/fluentd) !\u003d \"${USERGROUP}\" ]]; then"},{"line_number":33,"context_line":"    sudo chown ${USERGROUP} /var/run/fluentd"},{"line_number":34,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_cb0e90e4","line":34,"updated":"2019-09-19 10:38:59.000000000","message":"Looks like this fixes https://bugs.launchpad.net/kolla/+bug/1844574. Could you split it out and add Closes-Bug: #1844574 to the commit message?","commit_id":"54ba7fda99d630ec67e1ff31aa23a00914130783"}],"docker/horizon/Dockerfile.j2":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"986990900fbb9f631c67426ae4ad0a6e668b36ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespac e }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block horizon_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_d719aa87","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":17},"updated":"2019-09-05 15:26:44.000000000","message":"Is this a typo?","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespac e }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block horizon_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_29122259","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":18},"updated":"2019-09-05 15:36:10.000000000","message":"typo","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespac e }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block horizon_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_e9ebaad9","line":1,"range":{"start_line":1,"start_character":8,"end_line":1,"end_character":18},"in_reply_to":"7faddb67_29122259","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespac e }}/{{ image_prefix }}openstack-base:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block horizon_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_ac04e0c6","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":17},"in_reply_to":"7faddb67_d719aa87","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"388e7ae22811911f071ec8ad75878f8cd6aa6fc2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 ln -s ../mods-available/headers.load  /etc/apache2/mods-enabled/headers.load \\"},{"line_number":84,"context_line":"    \u0026\u0026 ln -s ../mods-available/expires.load  /etc/apache2/mods-enabled/expires.load \\"},{"line_number":85,"context_line":"    {%- if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":86,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/conf/*.json /etc/openstack-dashboard \\"},{"line_number":87,"context_line":"    \u0026\u0026 rm /etc/apache2/conf-enabled/openstack-dashboard.conf \\"},{"line_number":88,"context_line":"    {%- endif %}"},{"line_number":89,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_6bf68c92","line":86,"updated":"2019-09-09 09:22:28.000000000","message":"Viktor, this path not exist anymore, i think you thought /usr/lib/python3/dist-packages/openstack_dashboard/conf/ , and be sure that you will copy also directories inside , for example cinder_policy.d","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cea503725d60b71cf44bb3da0feef1869efeb9e6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 ln -s ../mods-available/headers.load  /etc/apache2/mods-enabled/headers.load \\"},{"line_number":84,"context_line":"    \u0026\u0026 ln -s ../mods-available/expires.load  /etc/apache2/mods-enabled/expires.load \\"},{"line_number":85,"context_line":"    {%- if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":86,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/conf/*.json /etc/openstack-dashboard \\"},{"line_number":87,"context_line":"    \u0026\u0026 rm /etc/apache2/conf-enabled/openstack-dashboard.conf \\"},{"line_number":88,"context_line":"    {%- endif %}"},{"line_number":89,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_a127c564","line":86,"in_reply_to":"5faad753_6bf68c92","updated":"2019-09-09 10:30:28.000000000","message":"\u003e Viktor, this path not exist anymore, i think you thought\n \u003e /usr/lib/python3/dist-packages/openstack_dashboard/conf/ , and be\n \u003e sure that you will copy also directories inside , for example\n \u003e cinder_policy.d\n\nsorry, i forgot that ubuntu !\u003d debian","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"{% endblock %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    {% endif %}"},{"line_number":98,"context_line":"{%  elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":99,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        {% set horizon_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_e9172a45","line":98,"range":{"start_line":98,"start_character":3,"end_line":98,"end_character":4},"updated":"2019-09-05 15:36:10.000000000","message":"space","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"{% endblock %}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    {% endif %}"},{"line_number":98,"context_line":"{%  elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":99,"context_line":"    {% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        {% set horizon_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_6cb3489b","line":98,"range":{"start_line":98,"start_character":3,"end_line":98,"end_character":4},"in_reply_to":"7faddb67_e9172a45","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"81c606b3803de7ab63351c82db056cab55b45448","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 ln -s ../mods-available/headers.load  /etc/apache2/mods-enabled/headers.load \\"},{"line_number":84,"context_line":"    \u0026\u0026 ln -s ../mods-available/expires.load  /etc/apache2/mods-enabled/expires.load \\"},{"line_number":85,"context_line":"    {%- if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":86,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/conf/*.json /etc/openstack-dashboard \\"},{"line_number":87,"context_line":"    \u0026\u0026 rm /etc/apache2/conf-enabled/openstack-dashboard.conf \\"},{"line_number":88,"context_line":"    {%- endif %}"},{"line_number":89,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_eb0ef3e3","line":86,"updated":"2019-09-09 15:40:36.000000000","message":"Are these the policy files?","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5c870fe32cf2f5f4dbfe7ec4f5075dcb7b1ff342","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    \u0026\u0026 ln -s ../mods-available/headers.load  /etc/apache2/mods-enabled/headers.load \\"},{"line_number":84,"context_line":"    \u0026\u0026 ln -s ../mods-available/expires.load  /etc/apache2/mods-enabled/expires.load \\"},{"line_number":85,"context_line":"    {%- if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":86,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/conf/*.json /etc/openstack-dashboard \\"},{"line_number":87,"context_line":"    \u0026\u0026 rm /etc/apache2/conf-enabled/openstack-dashboard.conf \\"},{"line_number":88,"context_line":"    {%- endif %}"},{"line_number":89,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_41ccba60","line":86,"in_reply_to":"5faad753_eb0ef3e3","updated":"2019-09-10 08:30:56.000000000","message":"Mark, ubuntu guys still using old ( and from my perspective of view ) layout ... so, yes in Ubuntu there are policy files ( and all python code is under /usr/share ...as symlink to /usr/lib ..)\n\nroot@ubuntu-eoan:/home/ubuntu# ls -la /usr/share/openstack-dashboard/openstack_dashboard/conf/\ntotal 68\ndrwxr-xr-x  3 root root  4096 Sep 10 08:12 .\ndrwxr-xr-x 20 root root  4096 Sep 10 08:15 ..\n-rw-r--r--  1 root root  8560 Aug  5 08:41 cinder_policy.json\n-rw-r--r--  1 root root  1388 Aug  5 08:41 glance_policy.json\n-rw-r--r--  1 root root 10144 Aug  5 08:41 keystone_policy.json\n-rw-r--r--  1 root root 12580 Aug  5 08:41 neutron_policy.json\ndrwxr-xr-x  2 root root  4096 Sep 10 08:12 nova_policy.d\n-rw-r--r--  1 root root 10202 Aug  5 08:41 nova_policy.json\n\nIn ubuntu openstack_dashboard is symlink to /usr/lib/python3/dist-packages/openstack_dashboard\n\nroot@ubuntu-eoan:/home/ubuntu# ls -la /usr/share/openstack-dashboard/\ntotal 36\ndrwxr-xr-x   4 root root  4096 Sep 10 08:15 .\ndrwxr-xr-x 126 root root  4096 Sep 10 08:12 ..\ndrwxr-xr-x   3 root root  4096 Sep 10 08:12 bin\n-rwxr-xr-x   1 root root   881 Sep  5 20:26 manage.py\nlrwxrwxrwx   1 root root    37 Sep 10 08:15 openstack_dashboard -\u003e /etc/alternatives/openstack_dashboard\n-rw-r--r--   1 root root 15549 Sep  5 20:26 settings.py\ndrwxr-xr-x  10 root root  4096 Sep 10 08:15 static\n\nroot@ubuntu-eoan:/home/ubuntu# ls -la /etc/alternatives/openstack_dashboard\nlrwxrwxrwx 1 root root 50 Sep 10 08:15 /etc/alternatives/openstack_dashboard -\u003e /usr/lib/python3/dist-packages/openstack_dashboard\n\nIn debian I reworked packages to have only static files and wsgi.py inside /usr/share... all python code is in usr/lib/...\n\nReason, why i\u0027ve done this in Debian was that from version to version we were adding the same patch which was adding sys.path.append(\"/usr/share/openstack-dashboard/\") to openstack_dashboard/wsgi/django.wsgi .... In debian this patch is not using anymore ... From my perspective of view it was a dirty hack\n\nIn debian it is now very clear.","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"654415a6520c8098fd0443ee2b56c47f4b84b218","unresolved":false,"context_lines":[{"line_number":57,"context_line":"{% endblock %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":60,"context_line":"        {% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":61,"context_line":"        {% set horizon_packages \u003d ["},{"line_number":62,"context_line":"                \u0027apache2\u0027,"},{"line_number":63,"context_line":"                \u0027gettext\u0027,"},{"line_number":64,"context_line":"                \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":65,"context_line":"                \u0027locales\u0027,"},{"line_number":66,"context_line":"                \u0027openstack-dashboard\u0027,"},{"line_number":67,"context_line":"                \u0027python3-designate-dashboard\u0027,"},{"line_number":68,"context_line":"                \u0027python3-heat-dashboard\u0027,"},{"line_number":69,"context_line":"                \u0027python3-manila-ui\u0027,"},{"line_number":70,"context_line":"                \u0027python3-sahara-dashboard\u0027,"},{"line_number":71,"context_line":"                \u0027python3-trove-dashboard\u0027,"},{"line_number":72,"context_line":"                \u0027tzdata\u0027"},{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":"        {% else %}"},{"line_number":75,"context_line":"        {% set horizon_packages \u003d ["},{"line_number":76,"context_line":"                \u0027apache2\u0027,"},{"line_number":77,"context_line":"                \u0027gettext\u0027,"},{"line_number":78,"context_line":"                \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":79,"context_line":"                \u0027locales\u0027,"},{"line_number":80,"context_line":"                \u0027openstack-dashboard\u0027,"},{"line_number":81,"context_line":"                \u0027python3-designate-dashboard\u0027,"},{"line_number":82,"context_line":"                \u0027python3-heat-dashboard\u0027,"},{"line_number":83,"context_line":"                \u0027python3-manila-ui\u0027,"},{"line_number":84,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":85,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":86,"context_line":"                \u0027python3-octavia-dashboard\u0027,"},{"line_number":87,"context_line":"                \u0027python3-sahara-dashboard\u0027,"},{"line_number":88,"context_line":"                \u0027python3-trove-dashboard\u0027,"},{"line_number":89,"context_line":"                \u0027tzdata\u0027"},{"line_number":90,"context_line":"        ] %}"},{"line_number":91,"context_line":"        {% endif %}"},{"line_number":92,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"{{ macros.install_packages(horizon_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3fa7e38b_d03422e1","line":91,"range":{"start_line":60,"start_character":0,"end_line":91,"end_character":19},"updated":"2019-09-17 14:31:51.000000000","message":"set horizon_packages\n\nif base_distro \u003d\u003d \u0027debian\u0027\n    set horizon_packages \u003d horizon_packages + [\n...\n]\n\nSo common packages will be listed just once.","commit_id":"211c55d1c71d302eba7f0043ccd62b2b4d88dc17"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"2da2520a97bbd6ac27b2c2f64c8caf73d3f85551","unresolved":false,"context_lines":[{"line_number":57,"context_line":"{% endblock %}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    {% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":60,"context_line":"        {% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":61,"context_line":"        {% set horizon_packages \u003d ["},{"line_number":62,"context_line":"                \u0027apache2\u0027,"},{"line_number":63,"context_line":"                \u0027gettext\u0027,"},{"line_number":64,"context_line":"                \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":65,"context_line":"                \u0027locales\u0027,"},{"line_number":66,"context_line":"                \u0027openstack-dashboard\u0027,"},{"line_number":67,"context_line":"                \u0027python3-designate-dashboard\u0027,"},{"line_number":68,"context_line":"                \u0027python3-heat-dashboard\u0027,"},{"line_number":69,"context_line":"                \u0027python3-manila-ui\u0027,"},{"line_number":70,"context_line":"                \u0027python3-sahara-dashboard\u0027,"},{"line_number":71,"context_line":"                \u0027python3-trove-dashboard\u0027,"},{"line_number":72,"context_line":"                \u0027tzdata\u0027"},{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":"        {% else %}"},{"line_number":75,"context_line":"        {% set horizon_packages \u003d ["},{"line_number":76,"context_line":"                \u0027apache2\u0027,"},{"line_number":77,"context_line":"                \u0027gettext\u0027,"},{"line_number":78,"context_line":"                \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":79,"context_line":"                \u0027locales\u0027,"},{"line_number":80,"context_line":"                \u0027openstack-dashboard\u0027,"},{"line_number":81,"context_line":"                \u0027python3-designate-dashboard\u0027,"},{"line_number":82,"context_line":"                \u0027python3-heat-dashboard\u0027,"},{"line_number":83,"context_line":"                \u0027python3-manila-ui\u0027,"},{"line_number":84,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":85,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":86,"context_line":"                \u0027python3-octavia-dashboard\u0027,"},{"line_number":87,"context_line":"                \u0027python3-sahara-dashboard\u0027,"},{"line_number":88,"context_line":"                \u0027python3-trove-dashboard\u0027,"},{"line_number":89,"context_line":"                \u0027tzdata\u0027"},{"line_number":90,"context_line":"        ] %}"},{"line_number":91,"context_line":"        {% endif %}"},{"line_number":92,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"{{ macros.install_packages(horizon_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3fa7e38b_2b9f4b51","line":91,"range":{"start_line":60,"start_character":0,"end_line":91,"end_character":19},"in_reply_to":"3fa7e38b_d03422e1","updated":"2019-09-20 15:52:09.000000000","message":"Done","commit_id":"211c55d1c71d302eba7f0043ccd62b2b4d88dc17"}],"docker/horizon/extend_start.sh":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"388e7ae22811911f071ec8ad75878f8cd6aa6fc2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"if [[ -f /etc/openstack-dashboard/custom_local_settings ]]; then"},{"line_number":41,"context_line":"    CUSTOM_SETTINGS_FILE\u003d\"${SITE_PACKAGES}/openstack_dashboard/local/custom_local_settings.py\""},{"line_number":42,"context_line":"    if  [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]] \u0026\u0026 [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":43,"context_line":"        CUSTOM_SETTINGS_FILE\u003d\"/usr/share/openstack-dashboard/openstack_dashboard/local/custom_local_settings.py\""},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    if [[ ! -L ${CUSTOM_SETTINGS_FILE} ]]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5faad753_4b5f1041","line":43,"updated":"2019-09-09 09:22:28.000000000","message":"same as comment in other file, this file not exist","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"cea503725d60b71cf44bb3da0feef1869efeb9e6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"if [[ -f /etc/openstack-dashboard/custom_local_settings ]]; then"},{"line_number":41,"context_line":"    CUSTOM_SETTINGS_FILE\u003d\"${SITE_PACKAGES}/openstack_dashboard/local/custom_local_settings.py\""},{"line_number":42,"context_line":"    if  [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]] \u0026\u0026 [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ ubuntu ]]; then"},{"line_number":43,"context_line":"        CUSTOM_SETTINGS_FILE\u003d\"/usr/share/openstack-dashboard/openstack_dashboard/local/custom_local_settings.py\""},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    if [[ ! -L ${CUSTOM_SETTINGS_FILE} ]]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5faad753_2102f5b5","line":43,"in_reply_to":"5faad753_4b5f1041","updated":"2019-09-09 10:30:28.000000000","message":"\u003e same as comment in other file, this file not exist\n\nsorry, i forgot that ubuntu is not using debian packages but they are building their own packages","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% set virtualenv_path\u003d\u0027/opt/ansible\u0027 %}"},{"line_number":7,"context_line":"{%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":8,"context_line":"{% set os_client_config\u003d virtualenv_path + \u0027/lib/python2.7/site-packages/os_client_config/defaults.json\u0027 %}"},{"line_number":9,"context_line":"{%- else %}"},{"line_number":10,"context_line":"{% set os_client_config\u003d virtualenv_path + \u0027/lib/python\u0027 + distro_python_version + \u0027/site-packages/os_client_config/defaults.json\u0027 %}"},{"line_number":11,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_e95e4a11","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":107},"updated":"2019-09-05 15:36:10.000000000","message":"package did not moved to py3?","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% set virtualenv_path\u003d\u0027/opt/ansible\u0027 %}"},{"line_number":7,"context_line":"{%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":8,"context_line":"{% set os_client_config\u003d virtualenv_path + \u0027/lib/python2.7/site-packages/os_client_config/defaults.json\u0027 %}"},{"line_number":9,"context_line":"{%- else %}"},{"line_number":10,"context_line":"{% set os_client_config\u003d virtualenv_path + \u0027/lib/python\u0027 + distro_python_version + \u0027/site-packages/os_client_config/defaults.json\u0027 %}"},{"line_number":11,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_db940d47","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":107},"in_reply_to":"7faddb67_e95e4a11","updated":"2019-09-12 19:42:40.000000000","message":"kolla-toolbox was broken when I started work on this patchset. My first attempts to fix kolla-toolbox on Python3 failed, so I choose to put it back to Python2 and done this ugly hack. It is unneccessary now.","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"     ] %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":36,"context_line":"    {%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":37,"context_line":"    {% set kolla_toolbox_packages \u003d ["},{"line_number":38,"context_line":"        \u0027build-essential\u0027,"},{"line_number":39,"context_line":"        \u0027ca-certificates\u0027,"},{"line_number":40,"context_line":"        \u0027crudini\u0027,"},{"line_number":41,"context_line":"        \u0027gdisk\u0027,"},{"line_number":42,"context_line":"        \u0027git\u0027,"},{"line_number":43,"context_line":"        \u0027jq\u0027,"},{"line_number":44,"context_line":"        \u0027libffi-dev\u0027,"},{"line_number":45,"context_line":"        \u0027libmariadb-dev-compat\u0027,"},{"line_number":46,"context_line":"        \u0027libssl-dev\u0027,"},{"line_number":47,"context_line":"        \u0027libxslt1-dev\u0027,"},{"line_number":48,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":49,"context_line":"        \u0027python-dev\u0027"},{"line_number":50,"context_line":"     ] %}"},{"line_number":51,"context_line":"    {%- else %}"},{"line_number":52,"context_line":"    {% set kolla_toolbox_packages \u003d ["},{"line_number":53,"context_line":"        \u0027build-essential\u0027,"},{"line_number":54,"context_line":"        \u0027ca-certificates\u0027,"},{"line_number":55,"context_line":"        \u0027crudini\u0027,"},{"line_number":56,"context_line":"        \u0027gdisk\u0027,"},{"line_number":57,"context_line":"        \u0027git\u0027,"},{"line_number":58,"context_line":"        \u0027jq\u0027,"},{"line_number":59,"context_line":"        \u0027libffi-dev\u0027,"},{"line_number":60,"context_line":"        \u0027libmariadb-dev-compat\u0027,"},{"line_number":61,"context_line":"        \u0027libssl-dev\u0027,"},{"line_number":62,"context_line":"        \u0027libxslt1-dev\u0027,"},{"line_number":63,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":64,"context_line":"        \u0027python3-dev\u0027"},{"line_number":65,"context_line":"     ] %}"},{"line_number":66,"context_line":"    {%- endif %}"},{"line_number":67,"context_line":"{% endif %}"},{"line_number":68,"context_line":"{{ macros.install_packages(kolla_toolbox_packages | customizable(\"packages\")) }}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_6979fa7f","line":66,"range":{"start_line":36,"start_character":1,"end_line":66,"end_character":16},"updated":"2019-09-05 15:36:10.000000000","message":"set kolla_toolbox_packages \u003d [ common packages for both]\n\nif debian\n   set k_t_p \u003d k_t_p + []\nelif ubuntu\n   set k_t_p \u003d k_t_p + []\nendif\n\nso there will be no duplicates","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"     ] %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":36,"context_line":"    {%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":37,"context_line":"    {% set kolla_toolbox_packages \u003d ["},{"line_number":38,"context_line":"        \u0027build-essential\u0027,"},{"line_number":39,"context_line":"        \u0027ca-certificates\u0027,"},{"line_number":40,"context_line":"        \u0027crudini\u0027,"},{"line_number":41,"context_line":"        \u0027gdisk\u0027,"},{"line_number":42,"context_line":"        \u0027git\u0027,"},{"line_number":43,"context_line":"        \u0027jq\u0027,"},{"line_number":44,"context_line":"        \u0027libffi-dev\u0027,"},{"line_number":45,"context_line":"        \u0027libmariadb-dev-compat\u0027,"},{"line_number":46,"context_line":"        \u0027libssl-dev\u0027,"},{"line_number":47,"context_line":"        \u0027libxslt1-dev\u0027,"},{"line_number":48,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":49,"context_line":"        \u0027python-dev\u0027"},{"line_number":50,"context_line":"     ] %}"},{"line_number":51,"context_line":"    {%- else %}"},{"line_number":52,"context_line":"    {% set kolla_toolbox_packages \u003d ["},{"line_number":53,"context_line":"        \u0027build-essential\u0027,"},{"line_number":54,"context_line":"        \u0027ca-certificates\u0027,"},{"line_number":55,"context_line":"        \u0027crudini\u0027,"},{"line_number":56,"context_line":"        \u0027gdisk\u0027,"},{"line_number":57,"context_line":"        \u0027git\u0027,"},{"line_number":58,"context_line":"        \u0027jq\u0027,"},{"line_number":59,"context_line":"        \u0027libffi-dev\u0027,"},{"line_number":60,"context_line":"        \u0027libmariadb-dev-compat\u0027,"},{"line_number":61,"context_line":"        \u0027libssl-dev\u0027,"},{"line_number":62,"context_line":"        \u0027libxslt1-dev\u0027,"},{"line_number":63,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":64,"context_line":"        \u0027python3-dev\u0027"},{"line_number":65,"context_line":"     ] %}"},{"line_number":66,"context_line":"    {%- endif %}"},{"line_number":67,"context_line":"{% endif %}"},{"line_number":68,"context_line":"{{ macros.install_packages(kolla_toolbox_packages | customizable(\"packages\")) }}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_3b03e175","line":66,"range":{"start_line":36,"start_character":1,"end_line":66,"end_character":16},"in_reply_to":"7faddb67_6979fa7f","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"{{ macros.install_packages(kolla_toolbox_packages | customizable(\"packages\")) }}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% block kolla_toolbox_source_install_python_pip %}"},{"line_number":71,"context_line":"{%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":72,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":73,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":74,"context_line":"    \u0026\u0026 rm get-pip.py"},{"line_number":75,"context_line":"{%- else %}"},{"line_number":76,"context_line":"{{ macros.get_pip() }}"},{"line_number":77,"context_line":"{%- endif %}"},{"line_number":78,"context_line":"{% endblock %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% set kolla_toolbox_pip_virtualenv_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_e98c0a81","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":12},"updated":"2019-09-05 15:36:10.000000000","message":"please add a way to choose python(3) in get_pip instead maybe?","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"{{ macros.install_packages(kolla_toolbox_packages | customizable(\"packages\")) }}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"{% block kolla_toolbox_source_install_python_pip %}"},{"line_number":71,"context_line":"{%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":72,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":73,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":74,"context_line":"    \u0026\u0026 rm get-pip.py"},{"line_number":75,"context_line":"{%- else %}"},{"line_number":76,"context_line":"{{ macros.get_pip() }}"},{"line_number":77,"context_line":"{%- endif %}"},{"line_number":78,"context_line":"{% endblock %}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"{% set kolla_toolbox_pip_virtualenv_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_dbf96d80","line":77,"range":{"start_line":71,"start_character":0,"end_line":77,"end_character":12},"in_reply_to":"7faddb67_e98c0a81","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":90,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":91,"context_line":"        \u0027ansible\u003d\u003d2.2.0.0\u0027,"},{"line_number":92,"context_line":"        \u0027\"cmd2\u003c0.9.0\"\u0027,"},{"line_number":93,"context_line":"        \u0027influxdb\u0027,"},{"line_number":94,"context_line":"        \u0027mysqlclient\u0027,"},{"line_number":95,"context_line":"        \u0027os-client-config\u003d\u003d1.29.0\u0027,"},{"line_number":96,"context_line":"        \u0027pbr\u003d\u003d4.0.0\u0027,"},{"line_number":97,"context_line":"        \u0027pymongo\u0027,"},{"line_number":98,"context_line":"        \u0027python-openstackclient\u003d\u003d3.14.0\u0027,"},{"line_number":99,"context_line":"        \u0027pytz\u0027,"},{"line_number":100,"context_line":"        \u0027pyudev\u0027,"},{"line_number":101,"context_line":"        \u0027shade\u003d\u003d1.27.1\u0027"},{"line_number":102,"context_line":"    ] %}"},{"line_number":103,"context_line":"{%- else %}"},{"line_number":104,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":105,"context_line":"        \u0027ansible\u003d\u003d2.8.*\u0027,"},{"line_number":106,"context_line":"        \u0027cmd2\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_c9390ea3","line":103,"range":{"start_line":89,"start_character":0,"end_line":103,"end_character":11},"updated":"2019-09-05 15:36:10.000000000","message":"Please honor https://review.opendev.org/#/c/642416/","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"{%- if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":90,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":91,"context_line":"        \u0027ansible\u003d\u003d2.2.0.0\u0027,"},{"line_number":92,"context_line":"        \u0027\"cmd2\u003c0.9.0\"\u0027,"},{"line_number":93,"context_line":"        \u0027influxdb\u0027,"},{"line_number":94,"context_line":"        \u0027mysqlclient\u0027,"},{"line_number":95,"context_line":"        \u0027os-client-config\u003d\u003d1.29.0\u0027,"},{"line_number":96,"context_line":"        \u0027pbr\u003d\u003d4.0.0\u0027,"},{"line_number":97,"context_line":"        \u0027pymongo\u0027,"},{"line_number":98,"context_line":"        \u0027python-openstackclient\u003d\u003d3.14.0\u0027,"},{"line_number":99,"context_line":"        \u0027pytz\u0027,"},{"line_number":100,"context_line":"        \u0027pyudev\u0027,"},{"line_number":101,"context_line":"        \u0027shade\u003d\u003d1.27.1\u0027"},{"line_number":102,"context_line":"    ] %}"},{"line_number":103,"context_line":"{%- else %}"},{"line_number":104,"context_line":"{% set kolla_toolbox_pip_packages \u003d ["},{"line_number":105,"context_line":"        \u0027ansible\u003d\u003d2.8.*\u0027,"},{"line_number":106,"context_line":"        \u0027cmd2\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_bbeef1b1","line":103,"range":{"start_line":89,"start_character":0,"end_line":103,"end_character":11},"in_reply_to":"7faddb67_c9390ea3","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"}],"docker/mariadb/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"6e1384e18b69f72baa6071b92047ea9c0762f0b5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":26,"context_line":"        \u0027expect\u0027"},{"line_number":27,"context_line":"    ] %}"},{"line_number":28,"context_line":"    {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":29,"context_line":"        {% set mariadb_packages \u003d mariadb_packages + ["},{"line_number":30,"context_line":"            \u0027mariadb-server\u0027,"},{"line_number":31,"context_line":"            \u0027mariadb-backup\u0027"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":"    {% else %}"},{"line_number":34,"context_line":"        {% set mariadb_packages \u003d mariadb_packages + ["},{"line_number":35,"context_line":"            \u0027mariadb-server\u0027,"},{"line_number":36,"context_line":"            \u0027mariadb-client\u0027,"},{"line_number":37,"context_line":"            \u0027mariadb-backup\u0027,"},{"line_number":38,"context_line":"        ] %}"},{"line_number":39,"context_line":"    {% endif %}"},{"line_number":40,"context_line":"{% endif %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ macros.install_packages(mariadb_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_a95ff2e2","line":39,"range":{"start_line":28,"start_character":1,"end_line":39,"end_character":15},"updated":"2019-09-05 15:36:10.000000000","message":"can you just change it to do -backup/client/server for both distros?","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":26,"context_line":"        \u0027expect\u0027"},{"line_number":27,"context_line":"    ] %}"},{"line_number":28,"context_line":"    {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":29,"context_line":"        {% set mariadb_packages \u003d mariadb_packages + ["},{"line_number":30,"context_line":"            \u0027mariadb-server\u0027,"},{"line_number":31,"context_line":"            \u0027mariadb-backup\u0027"},{"line_number":32,"context_line":"        ] %}"},{"line_number":33,"context_line":"    {% else %}"},{"line_number":34,"context_line":"        {% set mariadb_packages \u003d mariadb_packages + ["},{"line_number":35,"context_line":"            \u0027mariadb-server\u0027,"},{"line_number":36,"context_line":"            \u0027mariadb-client\u0027,"},{"line_number":37,"context_line":"            \u0027mariadb-backup\u0027,"},{"line_number":38,"context_line":"        ] %}"},{"line_number":39,"context_line":"    {% endif %}"},{"line_number":40,"context_line":"{% endif %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ macros.install_packages(mariadb_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_0c5ad41c","line":39,"range":{"start_line":28,"start_character":1,"end_line":39,"end_character":15},"in_reply_to":"7faddb67_a95ff2e2","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"fcba0ddc6daae630341628b6c2949c4c3f9b5318"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"bb40e764f77902e4f2ef3b9d8ea25f446cba312e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":25,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":26,"context_line":"        \u0027expect\u0027,"},{"line_number":27,"context_line":"        \u0027mariadb-server\u0027,"},{"line_number":28,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":29,"context_line":"        \u0027mariadb-backup\u0027,"},{"line_number":30,"context_line":"    ] %}"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7faddb67_0c889468","line":29,"range":{"start_line":27,"start_character":9,"end_line":29,"end_character":25},"updated":"2019-09-05 16:15:58.000000000","message":"alphabetic order please","commit_id":"d0aa2a7eb57afbf4ecb72a9d95ccc744f4c4392d"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":25,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":26,"context_line":"        \u0027expect\u0027,"},{"line_number":27,"context_line":"        \u0027mariadb-server\u0027,"},{"line_number":28,"context_line":"        \u0027mariadb-client\u0027,"},{"line_number":29,"context_line":"        \u0027mariadb-backup\u0027,"},{"line_number":30,"context_line":"    ] %}"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_7dbbd2e4","line":29,"range":{"start_line":27,"start_character":9,"end_line":29,"end_character":25},"in_reply_to":"7faddb67_0c889468","updated":"2019-09-12 19:42:40.000000000","message":"Done","commit_id":"d0aa2a7eb57afbf4ecb72a9d95ccc744f4c4392d"}],"docker/octavia/octavia-api/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"81c606b3803de7ab63351c82db056cab55b45448","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        {% set octavia_api_packages \u003d ["},{"line_number":27,"context_line":"            \u0027apache2\u0027,"},{"line_number":28,"context_line":"            \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":29,"context_line":"            \u0027octavia-api\u0027"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":"        {% else %}"},{"line_number":32,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_0bb7cfd7","line":29,"updated":"2019-09-09 15:40:36.000000000","message":"Does this really not exist for ubuntu?","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"c724b1d1a10a756f6897b350f9a4d1f99d37e6b7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        {% set octavia_api_packages \u003d ["},{"line_number":27,"context_line":"            \u0027apache2\u0027,"},{"line_number":28,"context_line":"            \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":29,"context_line":"            \u0027octavia-api\u0027"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":"        {% else %}"},{"line_number":32,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_2e4e226f","line":29,"in_reply_to":"5faad753_0bb7cfd7","updated":"2019-09-12 19:42:40.000000000","message":"Done in change 11","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5c870fe32cf2f5f4dbfe7ec4f5075dcb7b1ff342","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        {% set octavia_api_packages \u003d ["},{"line_number":27,"context_line":"            \u0027apache2\u0027,"},{"line_number":28,"context_line":"            \u0027libapache2-mod-wsgi-py3\u0027,"},{"line_number":29,"context_line":"            \u0027octavia-api\u0027"},{"line_number":30,"context_line":"        ] %}"},{"line_number":31,"context_line":"        {% else %}"},{"line_number":32,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5faad753_21565e5e","line":29,"in_reply_to":"5faad753_0bb7cfd7","updated":"2019-09-10 08:30:56.000000000","message":"This of course exist in ubuntu, actually the first version of octavia-api was released by me in debian and ubuntu also.\n\nhttp://changelogs.ubuntu.com/changelogs/pool/universe/o/octavia/octavia_5.0.0~b2~git2019073019.f80f25e8-0ubuntu1/changelog","commit_id":"72e8dbc3ac9292ccd983f35e79c5af7957205053"}],"docker/placement/placement-base/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"815c39e0a4ca7421995055499e42f55e28093af2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    {% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ macros.install_packages(placement_base_packages | customizable(\"packages\")) }}{% if base_distro in [\u0027ubuntu\u0027] %} \\"},{"line_number":29,"context_line":"    \u0026\u0026 cp /usr/share/placement/mysql-migrate-db.sh /opt/ \\"},{"line_number":30,"context_line":"    \u0026\u0026 chmod 755 /opt/mysql-migrate-db.sh{% elif base_distro in [\u0027debian\u0027] %} \\"},{"line_number":31,"context_line":"    \u0026\u0026 curl -s https://raw.githubusercontent.com/openstack/placement/master/placement_db_tools/mysql-migrate-db.sh \\"},{"line_number":32,"context_line":"    -o /opt/mysql-migrate-db.sh \u0026\u0026 chmod 755 /opt/mysql-migrate-db.sh{% endif %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"3fa7e38b_7a899624","line":30,"range":{"start_line":29,"start_character":7,"end_line":30,"end_character":41},"updated":"2019-09-17 06:45:24.000000000","message":"also needed for centos","commit_id":"e002344e76b950541b68f41f890ac0b9bf841e63"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"2da2520a97bbd6ac27b2c2f64c8caf73d3f85551","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    {% endif %}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ macros.install_packages(placement_base_packages | customizable(\"packages\")) }}{% if base_distro in [\u0027ubuntu\u0027] %} \\"},{"line_number":29,"context_line":"    \u0026\u0026 cp /usr/share/placement/mysql-migrate-db.sh /opt/ \\"},{"line_number":30,"context_line":"    \u0026\u0026 chmod 755 /opt/mysql-migrate-db.sh{% elif base_distro in [\u0027debian\u0027] %} \\"},{"line_number":31,"context_line":"    \u0026\u0026 curl -s https://raw.githubusercontent.com/openstack/placement/master/placement_db_tools/mysql-migrate-db.sh \\"},{"line_number":32,"context_line":"    -o /opt/mysql-migrate-db.sh \u0026\u0026 chmod 755 /opt/mysql-migrate-db.sh{% endif %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"3fa7e38b_65d572b9","line":30,"range":{"start_line":29,"start_character":7,"end_line":30,"end_character":41},"in_reply_to":"3fa7e38b_7a899624","updated":"2019-09-20 15:52:09.000000000","message":"Done","commit_id":"e002344e76b950541b68f41f890ac0b9bf841e63"}]}