)]}'
{"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed2b7e46d824da0d3a4c12a8b172410127cfcddd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        \u0027pytz\u0027,"},{"line_number":72,"context_line":"        \u0027pyudev\u0027,"},{"line_number":73,"context_line":"        \u0027shade\u0027,"},{"line_number":74,"context_line":"        \u0027openstacksdk\u0027"},{"line_number":75,"context_line":"    ] %}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"RUN mkdir -p /requirements \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_f2921f4b","line":74,"range":{"start_line":74,"start_character":9,"end_line":74,"end_character":21},"updated":"2019-09-12 09:28:30.000000000","message":"nit: these are in alphabetical order","commit_id":"bdca7ec7c7d7818ba9a76b4ec1d6ea50ef065044"}],"docker/kolla-toolbox/kolla_keystone_service.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed2b7e46d824da0d3a4c12a8b172410127cfcddd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        service_type\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":56,"context_line":"        url\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":57,"context_line":"        # \u0027interface\u0027 is used to define the endpoint interface"},{"line_number":58,"context_line":"        interface\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":59,"context_line":"        endpoint_region\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027),"},{"line_number":60,"context_line":"        # \u0027endpoint_type\u0027 is the interface used to communicate with keystone service"},{"line_number":61,"context_line":"        endpoint_type\u003ddict(type\u003d\u0027str\u0027, required\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_4d2832e1","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":17},"updated":"2019-09-12 09:28:30.000000000","message":"Hmm, I looked at the code for the upstream os_keystone_endpoint module, and it has an undocumented endpoint_interface argument, which is actually what we want here. I updated another patch to try using it, let\u0027s see how it goes: https://review.opendev.org/587590","commit_id":"bdca7ec7c7d7818ba9a76b4ec1d6ea50ef065044"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ed2b7e46d824da0d3a4c12a8b172410127cfcddd","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # stash the interface used to define the endpoint interface"},{"line_number":70,"context_line":"    interface \u003d module.params[\u0027interface\u0027]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    # update module params to use \u0027endpoint_type\u0027 for the interface for cloud communication"},{"line_number":73,"context_line":"    module.params[\u0027interface\u0027] \u003d module.params[\u0027endpoint_type\u0027]"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_72f5cf82","line":71,"updated":"2019-09-12 09:28:30.000000000","message":"An easy way to check that these can be different is to add an assertion like:\n\nassert interface \u003d\u003d \"internal\" or interface !\u003d module.params[\"endpoint_type\"]","commit_id":"bdca7ec7c7d7818ba9a76b4ec1d6ea50ef065044"}]}