)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1768fa9fd82ebd0c34d8292fe6f5c19d41ee4fa8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"XtraBackup started failing to install on Ubuntu and does not support"},{"line_number":10,"context_line":"MariaDB 10.3 version."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9cf62c8e03a02574d85e5349df1d23a51d4c99be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_f569a8f8","line":12,"updated":"2019-09-12 10:25:23.000000000","message":"Related-Bug: #1843043","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"870e1e8b9bf526a9a1bcc7bdf34e6d901700ac3a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"XtraBackup started failing to install on Ubuntu and does not support"},{"line_number":10,"context_line":"MariaDB 10.3 version."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9cf62c8e03a02574d85e5349df1d23a51d4c99be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_9ee411e2","line":12,"in_reply_to":"5faad753_f569a8f8","updated":"2019-09-12 12:11:47.000000000","message":"Done","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"}],"docker/mariadb/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a81073e1f0a61a26d83e34476bff4ecaf0d671d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":25,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":26,"context_line":"\t\u0027expect\u0027"},{"line_number":27,"context_line":"\t\u0027mariadb-backup\u0027,"},{"line_number":28,"context_line":"\t\u0027mariadb-client\u0027,"},{"line_number":29,"context_line":"\t\u0027mariadb-server\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_be022d6e","line":26,"updated":"2019-09-12 12:10:52.000000000","message":"Missing comma","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"17def6975983312ee7d018862af15dee7f3af4d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":25,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":26,"context_line":"\t\u0027expect\u0027"},{"line_number":27,"context_line":"\t\u0027mariadb-backup\u0027,"},{"line_number":28,"context_line":"\t\u0027mariadb-client\u0027,"},{"line_number":29,"context_line":"\t\u0027mariadb-server\u0027"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_de15a99d","line":26,"in_reply_to":"5faad753_be022d6e","updated":"2019-09-12 12:12:00.000000000","message":"Done","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1768fa9fd82ebd0c34d8292fe6f5c19d41ee4fa8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\u0027expect\u0027"},{"line_number":27,"context_line":"\t\u0027mariadb-backup\u0027,"},{"line_number":28,"context_line":"\t\u0027mariadb-client\u0027,"},{"line_number":29,"context_line":"\t\u0027mariadb-server\u0027"},{"line_number":30,"context_line":"    ] %}"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_558afcbe","line":29,"updated":"2019-09-12 10:25:23.000000000","message":"nit: tabs","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"870e1e8b9bf526a9a1bcc7bdf34e6d901700ac3a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\t\u0027expect\u0027"},{"line_number":27,"context_line":"\t\u0027mariadb-backup\u0027,"},{"line_number":28,"context_line":"\t\u0027mariadb-client\u0027,"},{"line_number":29,"context_line":"\t\u0027mariadb-server\u0027"},{"line_number":30,"context_line":"    ] %}"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_1ed8211c","line":29,"in_reply_to":"5faad753_558afcbe","updated":"2019-09-12 12:11:47.000000000","message":"Done","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a9a99f628422b5f88ee0c6126a69466db457d98a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"COPY backup.sh /usr/local/bin/kolla_mariadb_backup.sh"},{"line_number":49,"context_line":"RUN chmod 755 /usr/local/bin/kolla_mariadb_backup.sh"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% if use_dumb_init %}"},{"line_number":52,"context_line":"{% block mariadb_entrypoint %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5faad753_0896834d","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":52},"updated":"2019-09-13 17:14:09.000000000","message":"huh?","commit_id":"016c0f577c535def40dd32ddf41e6cb145a2f9b8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1fa54bc9c54ba475d502f9dd0af205078d316dc4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"RUN mkdir -p /var/run/mysqld \u0026\u0026 chown mysql /var/run/mysqld \u0026\u0026 chmod 755 /var/run/mysqld"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"COPY backup.sh /usr/local/bin/kolla_mariadb_backup.sh"},{"line_number":49,"context_line":"RUN chmod 755 /usr/local/bin/kolla_mariadb_backup.sh"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% if use_dumb_init %}"},{"line_number":52,"context_line":"{% block mariadb_entrypoint %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5faad753_3a3dae2a","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":52},"in_reply_to":"5faad753_0896834d","updated":"2019-09-16 08:33:34.000000000","message":"moved from xtrabackup image","commit_id":"016c0f577c535def40dd32ddf41e6cb145a2f9b8"}],"docker/mariadb/backup.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d506cfdfdfab39bf1ef7cda74fd270c7d205efb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"5faad753_69fabdbd","line":1,"updated":"2019-09-12 12:37:08.000000000","message":"I expect it will need some changes, but it\u0027s a start.","commit_id":"016c0f577c535def40dd32ddf41e6cb145a2f9b8"}],"docker/xtrabackup/backup.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1768fa9fd82ebd0c34d8292fe6f5c19d41ee4fa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Execute a full backup"},{"line_number":6,"context_line":"backup_full() {"},{"line_number":7,"context_line":"    echo \"Taking a full backup\""},{"line_number":8,"context_line":"    innobackupex --defaults-file\u003d/etc/mysql/my.cnf \\"},{"line_number":9,"context_line":"        --no-timestamp \\"},{"line_number":10,"context_line":"        --stream\u003dxbstream \\"},{"line_number":11,"context_line":"        --compress \\"},{"line_number":12,"context_line":"        --history\u003d$(date +%d-%m-%Y) ./ \u003e \\"},{"line_number":13,"context_line":"        $BACKUP_DIR/mysqlbackup-$(date +%d-%m-%Y-%s).qp.xbc.xbs"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Execute an incremental backup"},{"line_number":17,"context_line":"backup_incremental() {"},{"line_number":18,"context_line":"    echo \"Taking an incremental backup\""},{"line_number":19,"context_line":"    innobackupex --defaults-file\u003d/etc/mysql/my.cnf \\"},{"line_number":20,"context_line":"        --no-timestamp \\"},{"line_number":21,"context_line":"        --stream\u003dxbstream \\"},{"line_number":22,"context_line":"        --compress \\"},{"line_number":23,"context_line":"        --incremental \\"},{"line_number":24,"context_line":"        --incremental-history-name\u003d$(date +%d-%m-%Y) \\"},{"line_number":25,"context_line":"        --history\u003d$(date +%d-%m-%Y) ./ \u003e \\"},{"line_number":26,"context_line":"        $BACKUP_DIR/incremental-$(date +%H)-mysqlbackup-$(date +%d-%m-%Y-%s).qp.xbc.xbs"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"BACKUP_DIR\u003d/backup/"},{"line_number":30,"context_line":"cd $BACKUP_DIR"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [ -n $BACKUP_TYPE ]; then"},{"line_number":33,"context_line":"    case $BACKUP_TYPE in"},{"line_number":34,"context_line":"        \"full\")"},{"line_number":35,"context_line":"        backup_full"},{"line_number":36,"context_line":"        ;;"},{"line_number":37,"context_line":"        \"incremental\")"},{"line_number":38,"context_line":"        backup_incremental"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"        *)"},{"line_number":41,"context_line":"        echo \"Only full or incremental options are supported.\""},{"line_number":42,"context_line":"        exit 1"},{"line_number":43,"context_line":"        ;;"},{"line_number":44,"context_line":"    esac"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"    echo \"You need to specify either full or incremental backup options.\""},{"line_number":47,"context_line":"    exit 1"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5faad753_95b5d480","side":"PARENT","line":48,"range":{"start_line":1,"start_character":0,"end_line":48,"end_character":2},"updated":"2019-09-12 10:25:23.000000000","message":"I think we\u0027ll need to add a script like this to the mariadb image in order to support backups using mariabackup. There\u0027s some discussion of it here: https://bugs.launchpad.net/kolla/+bug/1843043.","commit_id":"7cda7ac96834c72ca818a3af449b2af6132bad9b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"870e1e8b9bf526a9a1bcc7bdf34e6d901700ac3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -eu"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Execute a full backup"},{"line_number":6,"context_line":"backup_full() {"},{"line_number":7,"context_line":"    echo \"Taking a full backup\""},{"line_number":8,"context_line":"    innobackupex --defaults-file\u003d/etc/mysql/my.cnf \\"},{"line_number":9,"context_line":"        --no-timestamp \\"},{"line_number":10,"context_line":"        --stream\u003dxbstream \\"},{"line_number":11,"context_line":"        --compress \\"},{"line_number":12,"context_line":"        --history\u003d$(date +%d-%m-%Y) ./ \u003e \\"},{"line_number":13,"context_line":"        $BACKUP_DIR/mysqlbackup-$(date +%d-%m-%Y-%s).qp.xbc.xbs"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Execute an incremental backup"},{"line_number":17,"context_line":"backup_incremental() {"},{"line_number":18,"context_line":"    echo \"Taking an incremental backup\""},{"line_number":19,"context_line":"    innobackupex --defaults-file\u003d/etc/mysql/my.cnf \\"},{"line_number":20,"context_line":"        --no-timestamp \\"},{"line_number":21,"context_line":"        --stream\u003dxbstream \\"},{"line_number":22,"context_line":"        --compress \\"},{"line_number":23,"context_line":"        --incremental \\"},{"line_number":24,"context_line":"        --incremental-history-name\u003d$(date +%d-%m-%Y) \\"},{"line_number":25,"context_line":"        --history\u003d$(date +%d-%m-%Y) ./ \u003e \\"},{"line_number":26,"context_line":"        $BACKUP_DIR/incremental-$(date +%H)-mysqlbackup-$(date +%d-%m-%Y-%s).qp.xbc.xbs"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"BACKUP_DIR\u003d/backup/"},{"line_number":30,"context_line":"cd $BACKUP_DIR"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [ -n $BACKUP_TYPE ]; then"},{"line_number":33,"context_line":"    case $BACKUP_TYPE in"},{"line_number":34,"context_line":"        \"full\")"},{"line_number":35,"context_line":"        backup_full"},{"line_number":36,"context_line":"        ;;"},{"line_number":37,"context_line":"        \"incremental\")"},{"line_number":38,"context_line":"        backup_incremental"},{"line_number":39,"context_line":"        ;;"},{"line_number":40,"context_line":"        *)"},{"line_number":41,"context_line":"        echo \"Only full or incremental options are supported.\""},{"line_number":42,"context_line":"        exit 1"},{"line_number":43,"context_line":"        ;;"},{"line_number":44,"context_line":"    esac"},{"line_number":45,"context_line":"else"},{"line_number":46,"context_line":"    echo \"You need to specify either full or incremental backup options.\""},{"line_number":47,"context_line":"    exit 1"},{"line_number":48,"context_line":"fi"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5faad753_7e3d9529","side":"PARENT","line":48,"range":{"start_line":1,"start_character":0,"end_line":48,"end_character":2},"in_reply_to":"5faad753_95b5d480","updated":"2019-09-12 12:11:47.000000000","message":"Done","commit_id":"7cda7ac96834c72ca818a3af449b2af6132bad9b"}],"releasenotes/notes/drop-xtrabackup-e58a97b617ff708c.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1768fa9fd82ebd0c34d8292fe6f5c19d41ee4fa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Percona XtraBackup tool got dropped in favour of MariaDB Backup."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_15a9e422","line":4,"updated":"2019-09-12 10:25:23.000000000","message":"We should mention explicitly that the image no longer exists.","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"501a2aa83f0286a3edac067379f7c10443606aaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Percona XtraBackup tool got dropped in favour of MariaDB Backup."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_9e8091c1","line":4,"in_reply_to":"5faad753_15a9e422","updated":"2019-09-12 12:14:39.000000000","message":"Done","commit_id":"2eb9eb9a454a62bc326df642e029f10957fe5e5e"}]}