)]}'
{"docker/nova/nova-libvirt/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1ea976c30554fd6c98f5ec9ebc728f7985849173","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        \u0027libvirt-daemon-driver-nwfilter\u0027,"},{"line_number":21,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":22,"context_line":"        \u0027trousers\u0027,"},{"line_number":23,"context_line":"        \u0027OVMF\u0027"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":26,"context_line":"        {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_5aa2eafd","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":13},"updated":"2019-09-16 08:01:55.000000000","message":"if base_arch \u003d\u003d x86-64 then OVMF elif aarch64 then AAVMF.","commit_id":"acf33407f62177074a9069e3f5d1560daa59f717"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"476273dee2f987c002d7b11d40eaaed7df02e490","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        \u0027libvirt-daemon-driver-nwfilter\u0027,"},{"line_number":21,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":22,"context_line":"        \u0027trousers\u0027,"},{"line_number":23,"context_line":"        \u0027OVMF\u0027"},{"line_number":24,"context_line":"    ] %}"},{"line_number":25,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":26,"context_line":"        {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_e0514d10","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":13},"in_reply_to":"5faad753_5aa2eafd","updated":"2019-09-17 16:48:37.000000000","message":"+1 - see nova-compute image.\n\nAlso only when base_distro_tag.startswith(\u00277\u0027)\n\nSee commits cbcd2efe71c5ab447fba9b0a5b4dd5f1b2c18b2e and 7e05deafbf8eba823cbd44a4bc5831388a0c1b8d.","commit_id":"acf33407f62177074a9069e3f5d1560daa59f717"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1ea976c30554fd6c98f5ec9ebc728f7985849173","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027qemu-block-extra\u0027,"},{"line_number":48,"context_line":"        \u0027qemu-system\u0027,"},{"line_number":49,"context_line":"        \u0027trousers\u0027,"},{"line_number":50,"context_line":"        \u0027ovmf\u0027"},{"line_number":51,"context_line":"    ] %}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    {% if base_arch \u003d\u003d \"aarch64\" %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_9a29428b","line":50,"range":{"start_line":50,"start_character":9,"end_line":50,"end_character":13},"updated":"2019-09-16 08:01:55.000000000","message":"move it below to \u0027elif x86\u0027 block - we do not need this package on aarch64/ppc64le","commit_id":"acf33407f62177074a9069e3f5d1560daa59f717"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"476273dee2f987c002d7b11d40eaaed7df02e490","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"RUN rm -f /etc/libvirt/qemu/networks/default.xml /etc/libvirt/qemu/networks/autostart/default.xml"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% elif base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"RUN ln -s /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_e02ced9a","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":37},"updated":"2019-09-17 16:48:37.000000000","message":"and base_distro_tag.startswith(\u00277\u0027) \n\nsee commit fe289fe61fbc852f7b6e24fbd09346a6f7e10650.\n\nalso nit: we normally have rpm before deb","commit_id":"acf33407f62177074a9069e3f5d1560daa59f717"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"feae8004d10559d419e212bdc013d937861c8009","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":39,"context_line":"                \u0027OVMF\u0027"},{"line_number":40,"context_line":"            ] %}"},{"line_number":41,"context_line":"            {% else %}"},{"line_number":42,"context_line":"                {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":43,"context_line":"                    \u0027edk2-ovmf\u0027"},{"line_number":44,"context_line":"                ] %}"},{"line_number":45,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_b02ded91","line":42,"range":{"start_line":41,"start_character":17,"end_line":42,"end_character":20},"updated":"2020-01-30 18:20:25.000000000","message":"indent gone wrong","commit_id":"2b37092af4597ec801224b8e430ef87a9b763d71"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"feae8004d10559d419e212bdc013d937861c8009","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":49,"context_line":"                \u0027AAVMF\u0027"},{"line_number":50,"context_line":"            ] %}"},{"line_number":51,"context_line":"            {% else %}"},{"line_number":52,"context_line":"                {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":53,"context_line":"                    \u0027edk2-aarch64\u0027"},{"line_number":54,"context_line":"                ] %}"},{"line_number":55,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_904a3158","line":52,"range":{"start_line":51,"start_character":18,"end_line":52,"end_character":20},"updated":"2020-01-30 18:20:25.000000000","message":"ditto","commit_id":"2b37092af4597ec801224b8e430ef87a9b763d71"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cab9ba114adf77cc9cf3f1b4768e760da41048d9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    {% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":37,"context_line":"        {% if base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":38,"context_line":"            {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":39,"context_line":"                \u0027OVMF\u0027"},{"line_number":40,"context_line":"            ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_408141a1","line":37,"range":{"start_line":37,"start_character":14,"end_line":37,"end_character":45},"updated":"2020-01-31 13:16:04.000000000","message":"We generally use distro_package_manager for this, as it can be overridden.","commit_id":"15b68c15c1dd0c2df1cc49b550f2fa03a4c65e8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d877c779634ffe0898e8a099a82649b1e011e6ef","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    {% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":37,"context_line":"        {% if base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":38,"context_line":"            {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":39,"context_line":"                \u0027OVMF\u0027"},{"line_number":40,"context_line":"            ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_11bb99be","line":37,"range":{"start_line":37,"start_character":14,"end_line":37,"end_character":45},"in_reply_to":"3fa7e38b_11e63915","updated":"2020-01-31 15:23:48.000000000","message":"Probably doesn\u0027t matter too much, it will go away soon on master.","commit_id":"15b68c15c1dd0c2df1cc49b550f2fa03a4c65e8e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"07f13e881c5608656079cbd9f860c5b5f6f235d0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    {% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 %}"},{"line_number":37,"context_line":"        {% if base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":38,"context_line":"            {% set nova_libvirt_packages \u003d nova_libvirt_packages + ["},{"line_number":39,"context_line":"                \u0027OVMF\u0027"},{"line_number":40,"context_line":"            ] %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_11e63915","line":37,"range":{"start_line":37,"start_character":14,"end_line":37,"end_character":45},"in_reply_to":"3fa7e38b_408141a1","updated":"2020-01-31 15:13:30.000000000","message":"This is used in a few places and now nova-base has the same. Should I really switch?","commit_id":"15b68c15c1dd0c2df1cc49b550f2fa03a4c65e8e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cab9ba114adf77cc9cf3f1b4768e760da41048d9","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"{% elif base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    {% if base_arch \u003d\u003d \u0027x86_64\u0027 and base_distro_tag.startswith(\u00277\u0027) %}"},{"line_number":109,"context_line":"# NOTE(jeffrey4l): for x86_64, nova will validate the existence of /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":110,"context_line":"RUN ln -sf /usr/share/OVMF/OVMF_CODE.secboot.fd /usr/share/OVMF/OVMF_CODE.fd"},{"line_number":111,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_13d081f4","line":108,"range":{"start_line":108,"start_character":36,"end_line":108,"end_character":66},"updated":"2020-01-31 13:16:04.000000000","message":"ditto","commit_id":"15b68c15c1dd0c2df1cc49b550f2fa03a4c65e8e"}]}