)]}'
{"docker/horizon/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"09f446188dd9519d1937057f4572df3d3f69fcaa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                \u0027tzdata\u0027"},{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":"        {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":75,"context_line":"        {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"},{"line_number":81,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_f9e77fe3","line":79,"range":{"start_line":75,"start_character":6,"end_line":79,"end_character":12},"updated":"2019-09-20 20:45:47.000000000","message":"indent","commit_id":"2c45db8a0fa5e5e0e35d258b3a190e23376f075a"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                \u0027tzdata\u0027"},{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":"        {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":75,"context_line":"        {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"},{"line_number":81,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_2587cc64","line":79,"range":{"start_line":75,"start_character":6,"end_line":79,"end_character":12},"in_reply_to":"3fa7e38b_f9e77fe3","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"2c45db8a0fa5e5e0e35d258b3a190e23376f075a"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"09f446188dd9519d1937057f4572df3d3f69fcaa","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"},{"line_number":81,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{{ macros.install_packages(horizon_packages | customizable(\"packages\")) }}"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_59e1f3cf","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"updated":"2019-09-20 20:45:47.000000000","message":"please drop that tab","commit_id":"2c45db8a0fa5e5e0e35d258b3a190e23376f075a"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"},{"line_number":81,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{{ macros.install_packages(horizon_packages | customizable(\"packages\")) }}"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_458a086a","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":1},"in_reply_to":"3fa7e38b_59e1f3cf","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"2c45db8a0fa5e5e0e35d258b3a190e23376f075a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e586deb1ae6c76e70e291b2c6c0adf58a10676df","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":"        {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":75,"context_line":"        {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_e9630d41","line":77,"range":{"start_line":76,"start_character":16,"end_line":77,"end_character":51},"updated":"2019-09-24 08:43:57.000000000","message":"Are we sure these aren\u0027t available on ubuntu?","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        ] %}"},{"line_number":74,"context_line":"        {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":75,"context_line":"        {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_c20b4e27","line":77,"range":{"start_line":76,"start_character":16,"end_line":77,"end_character":51},"in_reply_to":"3fa7e38b_e9630d41","updated":"2019-09-27 15:05:51.000000000","message":"python3-neutron-fwaas-dashboard is available since cosmic\nPackage python3-neutron-vpnaas-dashboard is available since disco","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e586deb1ae6c76e70e291b2c6c0adf58a10676df","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"},{"line_number":81,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_696e3d30","line":78,"range":{"start_line":78,"start_character":17,"end_line":78,"end_character":43},"updated":"2019-09-24 08:43:57.000000000","message":"we have it now","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                \u0027python3-neutron-vpnaas-dashboard\u0027,"},{"line_number":78,"context_line":"                \u0027python3-octavia-dashboard\u0027"},{"line_number":79,"context_line":"        ] %}"},{"line_number":80,"context_line":"        {% endif %}"},{"line_number":81,"context_line":"\t#NOTE(hrw): check for python-murano-dashboard"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_e57c5473","line":78,"range":{"start_line":78,"start_character":17,"end_line":78,"end_character":43},"in_reply_to":"3fa7e38b_696e3d30","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e586deb1ae6c76e70e291b2c6c0adf58a10676df","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    \u0026\u0026 ln -s ../mods-available/headers.load  /etc/apache2/mods-enabled/headers.load \\"},{"line_number":89,"context_line":"    \u0026\u0026 ln -s ../mods-available/expires.load  /etc/apache2/mods-enabled/expires.load \\"},{"line_number":90,"context_line":"    {% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":91,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/conf/*.json /etc/openstack-dashboard \\"},{"line_number":92,"context_line":"    \u0026\u0026 rm /etc/apache2/conf-enabled/openstack-dashboard.conf \\"},{"line_number":93,"context_line":"    {% endif %}"},{"line_number":94,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_a9e755ac","line":91,"range":{"start_line":91,"start_character":7,"end_line":91,"end_character":99},"updated":"2019-09-24 08:43:57.000000000","message":"If we do this for debian:\n\ncp /usr/share/openstack-dashboard/openstack_dashboard/policy/*.json /etc/openstack-dashboard\n\nthen we can avoid this change in kolla-ansible: https://review.opendev.org/#/c/680745/5/ansible/roles/horizon/templates/local_settings.j2@857.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    \u0026\u0026 ln -s ../mods-available/headers.load  /etc/apache2/mods-enabled/headers.load \\"},{"line_number":89,"context_line":"    \u0026\u0026 ln -s ../mods-available/expires.load  /etc/apache2/mods-enabled/expires.load \\"},{"line_number":90,"context_line":"    {% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":91,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/openstack_dashboard/conf/*.json /etc/openstack-dashboard \\"},{"line_number":92,"context_line":"    \u0026\u0026 rm /etc/apache2/conf-enabled/openstack-dashboard.conf \\"},{"line_number":93,"context_line":"    {% endif %}"},{"line_number":94,"context_line":"    \u0026\u0026 cp /usr/share/openstack-dashboard/manage.py /usr/bin/manage.py \\"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_cb74c9d1","line":91,"range":{"start_line":91,"start_character":7,"end_line":91,"end_character":99},"in_reply_to":"3fa7e38b_a9e755ac","updated":"2019-09-27 15:05:51.000000000","message":"It is not possible due to different structure of Debian packages.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e28afdb300cd63290951630be7dc967b15566fb4","unresolved":false,"context_lines":[{"line_number":177,"context_line":"# Plugins will be enabled according to deployment (kolla-ansible) configuration at deploy time."},{"line_number":178,"context_line":"RUN find /etc/openstack-dashboard/enabled/ -type f | grep -Ev \\"},{"line_number":179,"context_line":"    `dpkg -L openstack-dashboard python3-django-horizon | \\"},{"line_number":180,"context_line":"    grep \u0027/etc/openstack-dashboard/enabled/\u0027 | sed \u0027s/\\.py/.*.py/g\u0027 |xargs -l1 basename | xargs | tr \u0027 \u0027 \u0027|\u0027` | xargs rm"},{"line_number":181,"context_line":"{% endif %}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"{% block horizon_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_2b512f0f","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":120},"updated":"2019-09-23 09:27:52.000000000","message":"can\u0027t we just clean the directory completely?","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e5223553c89ac698823c98544ea73b9a2f341e3f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"# Plugins will be enabled according to deployment (kolla-ansible) configuration at deploy time."},{"line_number":178,"context_line":"RUN find /etc/openstack-dashboard/enabled/ -type f | grep -Ev \\"},{"line_number":179,"context_line":"    `dpkg -L openstack-dashboard python3-django-horizon | \\"},{"line_number":180,"context_line":"    grep \u0027/etc/openstack-dashboard/enabled/\u0027 | sed \u0027s/\\.py/.*.py/g\u0027 |xargs -l1 basename | xargs | tr \u0027 \u0027 \u0027|\u0027` | xargs rm"},{"line_number":181,"context_line":"{% endif %}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"{% block horizon_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_9b117c55","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":120},"in_reply_to":"3fa7e38b_099c690d","updated":"2019-09-24 08:48:09.000000000","message":"Then it can be moved above as well.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e586deb1ae6c76e70e291b2c6c0adf58a10676df","unresolved":false,"context_lines":[{"line_number":177,"context_line":"# Plugins will be enabled according to deployment (kolla-ansible) configuration at deploy time."},{"line_number":178,"context_line":"RUN find /etc/openstack-dashboard/enabled/ -type f | grep -Ev \\"},{"line_number":179,"context_line":"    `dpkg -L openstack-dashboard python3-django-horizon | \\"},{"line_number":180,"context_line":"    grep \u0027/etc/openstack-dashboard/enabled/\u0027 | sed \u0027s/\\.py/.*.py/g\u0027 |xargs -l1 basename | xargs | tr \u0027 \u0027 \u0027|\u0027` | xargs rm"},{"line_number":181,"context_line":"{% endif %}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"{% block horizon_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_099c690d","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":120},"in_reply_to":"3fa7e38b_2b512f0f","updated":"2019-09-24 08:43:57.000000000","message":"That is what we do for RH distros.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"# Plugins will be enabled according to deployment (kolla-ansible) configuration at deploy time."},{"line_number":178,"context_line":"RUN find /etc/openstack-dashboard/enabled/ -type f | grep -Ev \\"},{"line_number":179,"context_line":"    `dpkg -L openstack-dashboard python3-django-horizon | \\"},{"line_number":180,"context_line":"    grep \u0027/etc/openstack-dashboard/enabled/\u0027 | sed \u0027s/\\.py/.*.py/g\u0027 |xargs -l1 basename | xargs | tr \u0027 \u0027 \u0027|\u0027` | xargs rm"},{"line_number":181,"context_line":"{% endif %}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"{% block horizon_footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_765338e3","line":180,"range":{"start_line":180,"start_character":8,"end_line":180,"end_character":120},"in_reply_to":"3fa7e38b_9b117c55","updated":"2019-09-27 15:05:51.000000000","message":"There must be disabled only plugins, that are not from openstack-dashboard and python3-django-horizon packages. These plugins are enabled dynamically by kolla_extend_start script on base of deployment configuration. On the other hand default plugins (from openstack-dashboard and python3-django-horizon) must stay enabled because kolla_extend_start will not enable them.\n\nThe way you proposed is not usable for Debian due to different package structure.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"61b7c1604e4b4cd82426ac29bfe7e23cd2d03f11","unresolved":false,"context_lines":[{"line_number":169,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":170,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 and base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":173,"context_line":"# Stein/Buster packages are enabling plugins by default at its installation time,"},{"line_number":174,"context_line":"# but we actually know what plugins should be enabled just only at the deploy time."},{"line_number":175,"context_line":"# Therefore we need to install all available plugins and disble them right at the image build time."},{"line_number":176,"context_line":"# Plugins will be enabled according to deployment (kolla-ansible) configuration at deploy time."},{"line_number":177,"context_line":"RUN find /etc/openstack-dashboard/enabled/ -type f | grep -Ev \\"},{"line_number":178,"context_line":"    `dpkg -L openstack-dashboard python3-django-horizon | \\"},{"line_number":179,"context_line":"    grep \u0027/etc/openstack-dashboard/enabled/\u0027 | sed \u0027s/\\.py/.*.py/g\u0027 |xargs -l1 basename | xargs | tr \u0027 \u0027 \u0027|\u0027` | xargs rm"},{"line_number":180,"context_line":"{% endif %}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% block horizon_footer %}{% endblock %}"},{"line_number":183,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3fa7e38b_9be838b3","line":180,"range":{"start_line":172,"start_character":0,"end_line":180,"end_character":11},"updated":"2019-09-30 09:14:42.000000000","message":"move to horizon_ubuntu_binary_setup?","commit_id":"30e3a57e09fc8f0873fea62e1af20b8bcc790fde"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6890e4cddae6c32dcbc308dab2db66f66786fea","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        {% if base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":75,"context_line":"            {% set horizon_packages \u003d horizon_packages + ["},{"line_number":76,"context_line":"                    \u0027python3-neutron-fwaas-dashboard\u0027,"},{"line_number":77,"context_line":"                    \u0027python3-neutron-vpnaas-dashboard\u0027"},{"line_number":78,"context_line":"            ] %}"},{"line_number":79,"context_line":"        {% endif %}"},{"line_number":80,"context_line":"        #NOTE(hrw): check for python-murano-dashboard"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_c648105d","line":77,"updated":"2019-09-30 16:12:03.000000000","message":"comma","commit_id":"d6b6019a960983abfe639a8cbd2aea63597205a5"}],"docker/horizon/extend_start.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"09f446188dd9519d1937057f4572df3d3f69fcaa","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_99c1ab31","line":374,"range":{"start_line":371,"start_character":0,"end_line":374,"end_character":6},"updated":"2019-09-20 20:45:47.000000000","message":"is it true also for Debian/source images?","commit_id":"2c45db8a0fa5e5e0e35d258b3a190e23376f075a"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_e5f1b402","line":374,"range":{"start_line":371,"start_character":0,"end_line":374,"end_character":6},"in_reply_to":"3fa7e38b_99c1ab31","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"2c45db8a0fa5e5e0e35d258b3a190e23376f075a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e28afdb300cd63290951630be7dc967b15566fb4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"FORCE_GENERATE\u003d\"${FORCE_GENERATE}\""},{"line_number":6,"context_line":"HASH_PATH\u003d/var/lib/kolla/.settings.md5sum.txt"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# TODO(mgoddard): Remove this elif when Ubuntu has distro_python_version \u003d\u003d 3."},{"line_number":9,"context_line":"if [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]] \u0026\u0026 [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":10,"context_line":"    KOLLA_DISTRO_PYTHON_VERSION\u003d3"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]]; then"},{"line_number":14,"context_line":"    if [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"debian\" ]] || [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"ubuntu\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_6b188774","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":2},"updated":"2019-09-23 09:27:52.000000000","message":"I think it\u0027s removable per mgoddard\u0027s note. Just set the right python version. :-)","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"FORCE_GENERATE\u003d\"${FORCE_GENERATE}\""},{"line_number":6,"context_line":"HASH_PATH\u003d/var/lib/kolla/.settings.md5sum.txt"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# TODO(mgoddard): Remove this elif when Ubuntu has distro_python_version \u003d\u003d 3."},{"line_number":9,"context_line":"if [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]] \u0026\u0026 [[ \"${KOLLA_BASE_DISTRO}\" \u003d~ debian|ubuntu ]]; then"},{"line_number":10,"context_line":"    KOLLA_DISTRO_PYTHON_VERSION\u003d3"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]]; then"},{"line_number":14,"context_line":"    if [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"debian\" ]] || [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"ubuntu\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_9044bc48","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":2},"in_reply_to":"3fa7e38b_6b188774","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e28afdb300cd63290951630be7dc967b15566fb4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":32,"context_line":"elif [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"debian\" ]] \u0026\u0026 [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]]; then"},{"line_number":33,"context_line":"    if [[ -e ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py ]]; then"},{"line_number":34,"context_line":"        rm ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"    ln -s /etc/openstack-dashboard/local_settings \\"},{"line_number":37,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_8b13835c","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":71},"updated":"2019-09-23 09:27:52.000000000","message":"I think we can simply do this always","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":32,"context_line":"elif [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"debian\" ]] \u0026\u0026 [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]]; then"},{"line_number":33,"context_line":"    if [[ -e ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py ]]; then"},{"line_number":34,"context_line":"        rm ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"    ln -s /etc/openstack-dashboard/local_settings \\"},{"line_number":37,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_854240aa","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":71},"in_reply_to":"3fa7e38b_8b13835c","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e586deb1ae6c76e70e291b2c6c0adf58a10676df","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":32,"context_line":"elif [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"debian\" ]] \u0026\u0026 [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]]; then"},{"line_number":33,"context_line":"    if [[ -e ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py ]]; then"},{"line_number":34,"context_line":"        rm ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"    ln -s /etc/openstack-dashboard/local_settings \\"},{"line_number":37,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_c9bad16c","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":71},"in_reply_to":"3fa7e38b_8b13835c","updated":"2019-09-24 08:43:57.000000000","message":"rm -f, no if","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":32,"context_line":"elif [[ ${KOLLA_BASE_DISTRO} \u003d\u003d \"debian\" ]] \u0026\u0026 [[ ${KOLLA_INSTALL_TYPE} \u003d\u003d \"binary\" ]]; then"},{"line_number":33,"context_line":"    if [[ -e ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py ]]; then"},{"line_number":34,"context_line":"        rm ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"    ln -s /etc/openstack-dashboard/local_settings \\"},{"line_number":37,"context_line":"        ${SITE_PACKAGES}/openstack_dashboard/local/local_settings.py"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_2517cca6","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":71},"in_reply_to":"3fa7e38b_c9bad16c","updated":"2019-09-27 15:05:51.000000000","message":"Done","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e28afdb300cd63290951630be7dc967b15566fb4","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_8b3ce3c8","line":374,"range":{"start_line":371,"start_character":4,"end_line":374,"end_character":6},"updated":"2019-09-23 09:27:52.000000000","message":"does not seem used","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e5223553c89ac698823c98544ea73b9a2f341e3f","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_a938b5ed","line":374,"range":{"start_line":371,"start_character":4,"end_line":374,"end_character":6},"in_reply_to":"3fa7e38b_49a6e155","updated":"2019-09-24 08:48:09.000000000","message":"I mean there is literally nothing picking up these vars that I can see.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eaa48f5c559cf1fadbfb7876bdb3efe0e9dbcead","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_d9a9b524","line":374,"range":{"start_line":371,"start_character":4,"end_line":374,"end_character":6},"in_reply_to":"3fa7e38b_7d254908","updated":"2019-10-02 09:25:07.000000000","message":"What Radoslaw says here makes sense - I don\u0027t see how these variables could be used.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e586deb1ae6c76e70e291b2c6c0adf58a10676df","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_49a6e155","line":374,"range":{"start_line":371,"start_character":4,"end_line":374,"end_character":6},"in_reply_to":"3fa7e38b_8b3ce3c8","updated":"2019-09-24 08:43:57.000000000","message":"We run as root everywhere else IIRC","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"},{"author":{"_account_id":28374,"name":"Viktor Michalek","email":"viktor.michalek@ultimum.io","username":"viktormichalek"},"change_message_id":"bb58d1ba8c4757927c8c1fcb9559ae7175d7922c","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    # Loading Apache2 ENV variables"},{"line_number":369,"context_line":"    . /etc/apache2/envvars"},{"line_number":370,"context_line":"    install -d /var/run/apache2/"},{"line_number":371,"context_line":"    if [[ \"${KOLLA_BASE_DISTRO}\" \u003d\u003d \"debian\" ]]; then"},{"line_number":372,"context_line":"        APACHE_RUN_GROUP\u003dhorizon"},{"line_number":373,"context_line":"        APACHE_RUN_USER\u003dhorizon"},{"line_number":374,"context_line":"    fi"},{"line_number":375,"context_line":"    rm -rf /var/run/apache2/*"},{"line_number":376,"context_line":"else"},{"line_number":377,"context_line":"    rm -rf /var/run/httpd/* /run/httpd/* /tmp/httpd*"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_7d254908","line":374,"range":{"start_line":371,"start_character":4,"end_line":374,"end_character":6},"in_reply_to":"3fa7e38b_a938b5ed","updated":"2019-09-27 15:05:51.000000000","message":"There were some problems with access rights. Debian Horizon packages have different structure than Ubuntu Horizon packages.","commit_id":"8ff7f1ef4ebba54d3e9b30f98e941ff180826c03"}]}