)]}'
{"docker/netcontrold/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2d6d035245aa42cb496eb7f1b101cf5687ba4f8","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block netcontrold_install %}{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% set netcontrold_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_a1c01b7f","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":45},"updated":"2019-12-18 12:21:21.000000000","message":"not too soon?","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"f68191f0eae02103ef0c955f8cfab3ddc6dad50f","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block netcontrold_install %}{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% set netcontrold_packages \u003d ["}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_76797580","line":8,"range":{"start_line":8,"start_character":31,"end_line":8,"end_character":45},"in_reply_to":"3fa7e38b_a1c01b7f","updated":"2019-12-19 06:09:46.000000000","message":"Fixed it. Thanks.\nDone","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2d6d035245aa42cb496eb7f1b101cf5687ba4f8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  ]"},{"line_number":27,"context_line":"%}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_61ba230c","line":29,"updated":"2019-12-18 12:21:21.000000000","message":"so no binary?","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"f68191f0eae02103ef0c955f8cfab3ddc6dad50f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  ]"},{"line_number":27,"context_line":"%}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_568eb97a","line":29,"in_reply_to":"3fa7e38b_61ba230c","updated":"2019-12-19 06:09:46.000000000","message":"Netcontrold does not have any binary at this time, only python source. Appreciating your review. Thanks.","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b06bef498413e2ca7856acfbdb131c9084e0f3e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":34,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/local/bin/ncd_watch\"]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_4105a7c0","line":31,"range":{"start_line":31,"start_character":31,"end_line":31,"end_character":42},"updated":"2019-12-18 12:30:44.000000000","message":"we don\u0027t have oraclelinux anymore","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"f68191f0eae02103ef0c955f8cfab3ddc6dad50f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":34,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/local/bin/ncd_watch\"]"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_f6e1e52c","line":31,"range":{"start_line":31,"start_character":31,"end_line":31,"end_character":42},"in_reply_to":"3fa7e38b_4105a7c0","updated":"2019-12-19 06:09:46.000000000","message":"Thanks. I just noticed oraclelinux in --base params as one of the distro type (and it is still there). As part of patch v7, this block is removed. Thanks.","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b06bef498413e2ca7856acfbdb131c9084e0f3e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":34,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/local/bin/ncd_watch\"]"},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_a1f33be8","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":10},"updated":"2019-12-18 12:30:44.000000000","message":"And what is the rationale behind using it as ENTRYPOINT compared to running it from dumb-init?","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b06bef498413e2ca7856acfbdb131c9084e0f3e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":34,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/local/bin/ncd_watch\"]"},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_010fafe0","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":43},"updated":"2019-12-18 12:30:44.000000000","message":"are you sure about that path, since there are no binary packages?","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"f68191f0eae02103ef0c955f8cfab3ddc6dad50f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":34,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/local/bin/ncd_watch\"]"},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_d6d06955","line":32,"range":{"start_line":32,"start_character":25,"end_line":32,"end_character":43},"in_reply_to":"3fa7e38b_010fafe0","updated":"2019-12-19 06:09:46.000000000","message":"Addressed suggestion wrt dumb-init, so removed this code.","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"f68191f0eae02103ef0c955f8cfab3ddc6dad50f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"RUN {{ macros.install_pip(netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if base_distro in [\u0027rhel\u0027, \u0027oraclelinux\u0027] %}"},{"line_number":32,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/bin/ncd_watch\"]"},{"line_number":33,"context_line":"{% elif base_distro in [\u0027centos\u0027, \u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":34,"context_line":"ENTRYPOINT [\"sh\", \"-c\", \"/usr/local/bin/ncd_watch\"]"},{"line_number":35,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_56bc7906","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":10},"in_reply_to":"3fa7e38b_a1f33be8","updated":"2019-12-19 06:09:46.000000000","message":"Thanks for the pointer on good practice, which I\u0027m just getting aware of now. Added this suggestion in patch v7. Appreciating your review. Thanks.","commit_id":"a22c31d7b673b0821e481333cd0ce8b2a4b37404"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d374755c570429e8a64cb60026f74fa85fc189bd","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% set netcontrold_packages \u003d ["},{"line_number":12,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":13,"context_line":"        \u0027python3-pip\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3fa7e38b_1e6b73b9","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":20},"updated":"2019-12-19 14:19:24.000000000","message":"since it relies on openvswitch - and netcontrold is solely made for openvswitch - I think it would be better to have netcontrold based on openvswitch-base and in the openvswitch/ subdir.","commit_id":"65ddc87b5602495efad4d2c0de11a943612e5966"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"6ba087fa6beed61e276005ef086290e308fa0272","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% set netcontrold_packages \u003d ["},{"line_number":12,"context_line":"        \u0027openvswitch\u0027,"},{"line_number":13,"context_line":"        \u0027python3-pip\u0027,"},{"line_number":14,"context_line":"    ] %}"},{"line_number":15,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3fa7e38b_3e57445d","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":20},"in_reply_to":"3fa7e38b_1e6b73b9","updated":"2019-12-20 07:22:04.000000000","message":"Agreed. Moved containerising it inside openvswitch. Thanks for the suggestion. Could you please check v8.","commit_id":"65ddc87b5602495efad4d2c0de11a943612e5966"}],"docker/openvswitch/openvswitch-netcontrold/Dockerfile.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"8db0abe3d2ac5b53e735683d191e3c244130be3f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"{{ macros.install_packages(openvswitch_netcontrold_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% set openvswitch_netcontrold_pip_packages \u003d ["},{"line_number":17,"context_line":"    \u0027netcontrold\u0027,"},{"line_number":18,"context_line":"  ]"},{"line_number":19,"context_line":"%}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_42033011","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":16},"updated":"2019-12-23 11:36:46.000000000","message":"What version is supported with each ovs release, maybe we should pin versioning here, so we don get a latest release in an older unsupported ovs in the future.","commit_id":"26d31ed73c195bc588d22f1a8e4c1cf9ecaf83b5"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"3ccfdcf143a1c102c01ec6fc751792325a6efd55","unresolved":false,"context_lines":[{"line_number":14,"context_line":"{{ macros.install_packages(openvswitch_netcontrold_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% set openvswitch_netcontrold_pip_packages \u003d ["},{"line_number":17,"context_line":"    \u0027netcontrold\u0027,"},{"line_number":18,"context_line":"  ]"},{"line_number":19,"context_line":"%}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_e5e586dc","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":16},"in_reply_to":"3fa7e38b_42033011","updated":"2019-12-23 12:59:32.000000000","message":"As of today, netcontrold internally takes care of maintaining compatibility with openvswitch versions and do not break its functioning for openvswitch features it works with.\n\nI have added release notes in next patch v11. Could you please check. Thanks for the suggestion.","commit_id":"26d31ed73c195bc588d22f1a8e4c1cf9ecaf83b5"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"e18b578702dec72287bf1188a36bcd35be616bdd","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block openvswitch_netcontrold_install %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% set openvswitch_netcontrold_packages \u003d ["},{"line_number":11,"context_line":"        \u0027python3-pip\u0027,"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(openvswitch_netcontrold_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% set openvswitch_netcontrold_pip_packages \u003d ["},{"line_number":17,"context_line":"    \u0027netcontrold\u0027,"},{"line_number":18,"context_line":"  ]"},{"line_number":19,"context_line":"%}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RUN {{ macros.install_pip(openvswitch_netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_45181a75","line":19,"range":{"start_line":10,"start_character":0,"end_line":19,"end_character":2},"updated":"2019-12-23 11:38:31.000000000","message":"not sure if we will want a source block here","commit_id":"26d31ed73c195bc588d22f1a8e4c1cf9ecaf83b5"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"3ccfdcf143a1c102c01ec6fc751792325a6efd55","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block openvswitch_netcontrold_install %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% set openvswitch_netcontrold_packages \u003d ["},{"line_number":11,"context_line":"        \u0027python3-pip\u0027,"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{{ macros.install_packages(openvswitch_netcontrold_packages | customizable(\"packages\")) }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% set openvswitch_netcontrold_pip_packages \u003d ["},{"line_number":17,"context_line":"    \u0027netcontrold\u0027,"},{"line_number":18,"context_line":"  ]"},{"line_number":19,"context_line":"%}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"RUN {{ macros.install_pip(openvswitch_netcontrold_pip_packages | customizable(\"pip_packages\"), constraints \u003d false, pip_version \u003d \"pip3\") }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_65d196f8","line":19,"range":{"start_line":10,"start_character":0,"end_line":19,"end_character":2},"in_reply_to":"3fa7e38b_45181a75","updated":"2019-12-23 12:59:32.000000000","message":"As of today, netcontrold is only a python source, so we have not met condition to build binary package.","commit_id":"26d31ed73c195bc588d22f1a8e4c1cf9ecaf83b5"}],"docker/openvswitch/openvswitch-netcontrold/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"52ba4fa6a5c4c3124341470e40cb8ff4323513be","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/openvswitch/netcontrold) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/openvswitch/netcontrold"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_ecc2a654","line":9,"updated":"2020-01-14 13:04:55.000000000","message":"extra newline","commit_id":"036ae9be03e95ec17837383cdd9387ddf34aa5d0"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"3d7d078f42ec179756a23358201e47daffea9d1b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ $(stat -c %a /var/log/kolla/openvswitch/netcontrold) !\u003d \"755\" ]]; then"},{"line_number":7,"context_line":"    chmod 755 /var/log/kolla/openvswitch/netcontrold"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa7e38b_94de340d","line":9,"in_reply_to":"3fa7e38b_ecc2a654","updated":"2020-01-21 06:38:01.000000000","message":"Done","commit_id":"036ae9be03e95ec17837383cdd9387ddf34aa5d0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"34873758bcb71a398d9df0d0d3eefe6920591e05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"if [[ ! -d \"/var/log/kolla/openvswitch/netcontrold\" ]]; then"},{"line_number":3,"context_line":"    mkdir -p /var/log/kolla/openvswitch/netcontrold"},{"line_number":4,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa7e38b_454e8fc2","line":1,"updated":"2020-01-24 11:36:10.000000000","message":"nit: now too few newlines but not important","commit_id":"1c6145f0da28c370575882793f2809e72b338f5a"}],"releasenotes/notes/netcontrold-24c9d6602f84e819.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"52ba4fa6a5c4c3124341470e40cb8ff4323513be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"    - Adds possibility to run netcontrold for openvswitch service."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_ac9a6e72","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":41},"updated":"2020-01-14 13:04:55.000000000","message":"netcontrold image","commit_id":"036ae9be03e95ec17837383cdd9387ddf34aa5d0"},{"author":{"_account_id":31108,"name":"Gowrishankar","email":"gmuthukr@redhat.com","username":"gmuthukr"},"change_message_id":"3d7d078f42ec179756a23358201e47daffea9d1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"    - Adds possibility to run netcontrold for openvswitch service."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3fa7e38b_b4e330d7","line":3,"range":{"start_line":3,"start_character":11,"end_line":3,"end_character":41},"in_reply_to":"3fa7e38b_ac9a6e72","updated":"2020-01-21 06:38:01.000000000","message":"Done","commit_id":"036ae9be03e95ec17837383cdd9387ddf34aa5d0"}]}
