)]}'
{"docker/ovn/ovn-nb-db-server/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da3dfe12ddd3d0e21f9d040259a008062bbdf626","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{ macros.install_packages(ovn_nb_db_server_packages | customizable(\"packages\")) }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY start_nb_db_server.sh /usr/local/bin/start-nb-db-server"},{"line_number":22,"context_line":"RUN chmod 755 /usr/local/bin/start-nb-db-server"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% block ovn_nb_db_server_footer %}{% endblock %}"},{"line_number":25,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_90dd00df","line":22,"updated":"2019-11-13 19:57:09.000000000","message":"Removing kolla_ovn_extend_start breaks ovn-base extend start (it\u0027s sourcing kolla_ovn_extend_start at the end)","commit_id":"b8df9f88303fd4369097ae02549ea5a3a6777f0a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bf0250d13813168f790e0b3c7d45c13c9e6e21f9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{ macros.install_packages(ovn_nb_db_server_packages | customizable(\"packages\")) }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY start_nb_db_server.sh /usr/local/bin/start-nb-db-server"},{"line_number":22,"context_line":"RUN chmod 755 /usr/local/bin/start-nb-db-server"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% block ovn_nb_db_server_footer %}{% endblock %}"},{"line_number":25,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_f728e333","line":22,"in_reply_to":"3fa7e38b_90dd00df","updated":"2019-11-14 07:49:14.000000000","message":"\u003e Removing kolla_ovn_extend_start breaks ovn-base extend start (it\u0027s\n \u003e sourcing kolla_ovn_extend_start at the end)\n\nWell, not really breaks - but will be useless then ;-)","commit_id":"b8df9f88303fd4369097ae02549ea5a3a6777f0a"}],"docker/ovn/ovn-nb-db-server/start_nb_db_server.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a403369279912d267ecd2de3aa2d29efb8eebd97","unresolved":false,"context_lines":[{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$@ run_nb_ovsdb"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_670f28e0","line":34,"updated":"2019-10-29 08:51:51.000000000","message":"nit: line","commit_id":"7c6b7e67b941221e3da0d1ffeb5971841f3bfc5e"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"08ba5434a134ef67d5844597d49942e8f9d60605","unresolved":false,"context_lines":[{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$@ run_nb_ovsdb"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_6d35c944","line":34,"in_reply_to":"3fa7e38b_670f28e0","updated":"2019-10-29 12:02:47.000000000","message":"You mean I should delete L34 ?\n\nActually that was the case with patch set 2, but tox complained with the below errors here - https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0d6/691507/2/check/openstack-tox-pep8/0d6b112/job-output.txt\n\n****\n2019-10-27 07:27:07.477301 | ubuntu-bionic | ERROR:__main__:/home/zuul/src/opendev.org/openstack/kolla/docker/ovn/ovn-sb-db-server/start_sb_db_server.sh file error: no newline at end of file\n2019-10-27 07:27:07.477595 | ubuntu-bionic | ERROR:__main__:/home/zuul/src/opendev.org/openstack/kolla/docker/ovn/ovn-nb-db-server/start_nb_db_server.sh file error: no newline at end of file\n****","commit_id":"7c6b7e67b941221e3da0d1ffeb5971841f3bfc5e"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"c513ff0edf6135e102af4186d0bdffb8eac97f7b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$@ run_nb_ovsdb"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_2a0d623d","line":34,"in_reply_to":"3fa7e38b_6d35c944","updated":"2019-10-30 13:18:57.000000000","message":"Hi,\n\nDid I address your comment ?\n\nPlease let me know if I need to do anything.\n\nThanks","commit_id":"7c6b7e67b941221e3da0d1ffeb5971841f3bfc5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da3dfe12ddd3d0e21f9d040259a008062bbdf626","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    fi"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$@ run_nb_ovsdb"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_f0b5547f","line":33,"updated":"2019-11-13 19:57:09.000000000","message":"What about setting path for the db file, sock file, log settings and log file?","commit_id":"b8df9f88303fd4369097ae02549ea5a3a6777f0a"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"0b55805c4b1611dea74fd77d5d761b13cc5aec0c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    fi"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$@ run_nb_ovsdb"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_ad377e4b","line":33,"in_reply_to":"3fa7e38b_f0b5547f","updated":"2019-11-14 10:37:21.000000000","message":"ovn-ctl takes care of that and there are default values [1]\n\nFrom tripleo point of view, I honestly don\u0027t see a need to configure these paths.\nDo you think this would be required for k-a ?\n\nLet me know if you think it needs to be supported.\n\nIf it needs to be supported, I think it can be support something like this\n\ni.e user/deployment tool need to call this script with the same arguments which ovn-ctl expects.  Like\n\n\"start_nb_db_server.sh --ovn-nb-logfile\u003d/var/log/ovn/foo.log --db-nb-port\u003d6789 --with-dbdir\u003d/etc/foo/ovn/ ...\"\n\nAnd this script will internally invoke ovn-ctl with the same args.\n\n\n[1] - https://github.com/ovn-org/ovn/blob/master/utilities/ovn-ctl#L665","commit_id":"b8df9f88303fd4369097ae02549ea5a3a6777f0a"}],"docker/ovn/ovn-sb-db-server/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da3dfe12ddd3d0e21f9d040259a008062bbdf626","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{ macros.install_packages(ovn_sb_db_server_packages | customizable(\"packages\")) }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COPY start_sb_db_server.sh /usr/local/bin/start-sb-db-server"},{"line_number":22,"context_line":"RUN chmod 755 /usr/local/bin/start-sb-db-server"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% block ovn_sb_db_server_footer %}{% endblock %}"},{"line_number":25,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_9052e034","line":22,"updated":"2019-11-13 19:57:09.000000000","message":"ditto","commit_id":"b8df9f88303fd4369097ae02549ea5a3a6777f0a"}],"docker/ovn/ovn-sb-db-server/start_sb_db_server.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a403369279912d267ecd2de3aa2d29efb8eebd97","unresolved":false,"context_lines":[{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"$@ run_sb_ovsdb"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_27f5b0cb","line":35,"updated":"2019-10-29 08:51:51.000000000","message":"nit: line","commit_id":"7c6b7e67b941221e3da0d1ffeb5971841f3bfc5e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f532b9d353eb814e92520936137762fb42ec1961","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# is - /usr/share/ovn/scripts/ovn-ctl. Otherwise it is"},{"line_number":18,"context_line":"# /usr/share/openvswitch/scripts/ovn-ctl."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [[ -f \"/usr/share/openvswitch/scripts/ovn-ctl\" ]]; then"},{"line_number":22,"context_line":"    set /usr/share/openvswitch/scripts/ovn-ctl --no-monitor"},{"line_number":23,"context_line":"elif [[  -f \"/usr/share/ovn/scripts/ovn-ctl\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa7e38b_2238749d","line":20,"updated":"2019-11-14 15:25:59.000000000","message":"nit: extra line but not worth a reiteration","commit_id":"b8c8fa15edcf5336a1121155cdc880a35ccf161f"}]}