)]}'
{"docker/elasticsearch/elasticsearch-curator/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a3e460176260fe0034402c22f6778a697e5dd01","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":9,"context_line":"    {% set elasticsearch_curator_packages \u003d ["},{"line_number":10,"context_line":"        \u0027cronie\u0027,"},{"line_number":11,"context_line":"        \u0027python3-pip\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_f97acdb8","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":54},"updated":"2019-11-20 14:41:45.000000000","message":"base_package_type \u003d\u003d \"rpm\"","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a3e460176260fe0034402c22f6778a697e5dd01","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \u0027cronie\u0027,"},{"line_number":11,"context_line":"        \u0027python3-pip\u0027,"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":14,"context_line":"    {% set elasticsearch_curator_packages \u003d ["},{"line_number":15,"context_line":"        \u0027cron\u0027,"},{"line_number":16,"context_line":"        \u0027python3-pip\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_b94a1580","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":43},"updated":"2019-11-20 14:41:45.000000000","message":"ditto","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"234d9104ca4e0571982b7def5572ec4a00e73845","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \u0027cronie\u0027,"},{"line_number":11,"context_line":"        \u0027python3-pip\u0027,"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":"{% elif base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] %}"},{"line_number":14,"context_line":"    {% set elasticsearch_curator_packages \u003d ["},{"line_number":15,"context_line":"        \u0027cron\u0027,"},{"line_number":16,"context_line":"        \u0027python3-pip\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_3493875e","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":43},"in_reply_to":"3fa7e38b_b94a1580","updated":"2019-11-20 17:58:41.000000000","message":"Thanks, missed that change","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a3e460176260fe0034402c22f6778a697e5dd01","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":26,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":27,"context_line":"] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(elasticsearch_curator_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse, pip_version\u003d\"pip3\") }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_993ab9e3","line":26,"updated":"2019-11-20 14:41:45.000000000","message":"only available as pip packages? So maybe we should fail the -binary build with a message that there are no binary packages available?","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"12c430a846255eeeba45f3e56a2c111cb07a5961","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":26,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":27,"context_line":"] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(elasticsearch_curator_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse, pip_version\u003d\"pip3\") }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_bf398b3f","line":26,"in_reply_to":"3fa7e38b_94aa7b81","updated":"2019-11-21 07:13:59.000000000","message":"In theory we don\u0027t promise anywhere in the docs they would not differ, so it can be as is for now.","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"234d9104ca4e0571982b7def5572ec4a00e73845","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":26,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":27,"context_line":"] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(elasticsearch_curator_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse, pip_version\u003d\"pip3\") }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_94aa7b81","line":26,"in_reply_to":"3fa7e38b_993ab9e3","updated":"2019-11-20 17:58:41.000000000","message":"I don\u0027t think the non-OpenStack images differentiate between source and binary?\n\nThere are packages, at least rpms we could use form the elastic repo. Is there a reason why we would prefer those over pip?","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"824273a0ffaf283d038806cbb8dbc5fe165447ae","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{ macros.configure_user(name\u003d\u0027elasticsearch\u0027) }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% set elasticsearch_curator_pip_packages \u003d ["},{"line_number":26,"context_line":"    \u0027elasticsearch-curator\u0027"},{"line_number":27,"context_line":"] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN {{ macros.install_pip(elasticsearch_curator_pip_packages | customizable(\"pip_packages\"), constraints\u003dfalse, pip_version\u003d\"pip3\") }} \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_388343ab","line":26,"in_reply_to":"3fa7e38b_bf398b3f","updated":"2019-11-25 15:03:58.000000000","message":"We agreed to move to common infra images, so let\u0027s not introduce differences.","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a3e460176260fe0034402c22f6778a697e5dd01","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block elasticsearch_curator_base_footer %}{% endblock %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE(dszumski): Cron runs as root but should be configured to launch Curator"},{"line_number":39,"context_line":"# by the elasticsearch user."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_f9288d98","line":38,"updated":"2019-11-20 14:41:45.000000000","message":"Can we use the existing cron functionality in k-a?","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"12c430a846255eeeba45f3e56a2c111cb07a5961","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block elasticsearch_curator_base_footer %}{% endblock %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE(dszumski): Cron runs as root but should be configured to launch Curator"},{"line_number":39,"context_line":"# by the elasticsearch user."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_7f3f9321","line":38,"in_reply_to":"3fa7e38b_94dcbb45","updated":"2019-11-21 07:13:59.000000000","message":"It was just curiosity - no sense in making the extra step if only one container would use it.","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"234d9104ca4e0571982b7def5572ec4a00e73845","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block elasticsearch_curator_base_footer %}{% endblock %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE(dszumski): Cron runs as root but should be configured to launch Curator"},{"line_number":39,"context_line":"# by the elasticsearch user."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_94dcbb45","line":38,"in_reply_to":"3fa7e38b_f9288d98","updated":"2019-11-20 17:58:41.000000000","message":"Unfortunately the \u0027cron\u0027 image contains logrotate. We could split the \u0027cron\u0027 image in two and then make this inherit from the part which contains only cron. Is it worth it?","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"824273a0ffaf283d038806cbb8dbc5fe165447ae","unresolved":false,"context_lines":[{"line_number":33,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":34,"context_line":"RUN chmod 755 /usr/local/bin/kolla_extend_start"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% block elasticsearch_curator_base_footer %}{% endblock %}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# NOTE(dszumski): Cron runs as root but should be configured to launch Curator"},{"line_number":39,"context_line":"# by the elasticsearch user."}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3fa7e38b_1bcf617f","line":36,"updated":"2019-11-25 15:03:58.000000000","message":"and\n\n{% block footer %}{% endblock %}","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"}],"docker/elasticsearch/elasticsearch-curator/extend_start.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0a3e460176260fe0034402c22f6778a697e5dd01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fa7e38b_5909a12e","line":6,"updated":"2019-11-20 14:41:45.000000000","message":"if [[ $(stat -c %a /var/log/kolla/elasticsearch) !\u003d \"755\" ]]; then\n    chmod 755 /var/log/kolla/elasticsearch\nfi","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"234d9104ca4e0571982b7def5572ec4a00e73845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3fa7e38b_940efbe1","line":6,"in_reply_to":"3fa7e38b_5909a12e","updated":"2019-11-20 17:58:41.000000000","message":"The log folder permissions are handled in the Kolla Ansible patch","commit_id":"e08951d1a6c1a88dadc11c7ead0b7ac512c29c0a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"824273a0ffaf283d038806cbb8dbc5fe165447ae","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/elasticsearch\" ]]; then"},{"line_number":4,"context_line":"    install -d -m 0755 -o elasticsearch -g elasticsearch /var/log/kolla/elasticsearch"},{"line_number":5,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_db99c979","line":5,"updated":"2019-11-25 15:03:58.000000000","message":"nit: normal pattern is:\n\nif [[ ! -d \"/var/log/kolla/elasticsearch\" ]]; then\n    mkdir -p /var/log/kolla/elasticsearch\nfi\nif [[ $(stat -c %a /var/log/kolla/elasticsearch) !\u003d \"755\" ]]; then\n    chmod 755 /var/log/kolla/elasticsearch\nfi","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"481d1d7035e53975076bbdf034a5cd213eb482d0","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/elasticsearch\" ]]; then"},{"line_number":4,"context_line":"    install -d -m 0755 -o elasticsearch -g elasticsearch /var/log/kolla/elasticsearch"},{"line_number":5,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_7b0c5592","line":5,"in_reply_to":"3fa7e38b_9b1351b8","updated":"2019-11-25 15:14:39.000000000","message":"A comment to that effect will hopefully prevent someone from \u0027fixing\u0027 this.","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9cc91e0ce62204d23ca1976061f5c00285e7144f","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/elasticsearch\" ]]; then"},{"line_number":4,"context_line":"    install -d -m 0755 -o elasticsearch -g elasticsearch /var/log/kolla/elasticsearch"},{"line_number":5,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_fbd045f6","line":5,"in_reply_to":"3fa7e38b_db99c979","updated":"2019-11-25 15:11:47.000000000","message":"The reason I changed it was because cron runs as root, so this directory will be created with root ownership. When curator is launched by cron as the elasticsearch user it won\u0027t be able to write to this directory.","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"aada7e8c5bc879ead03d4b80a98814aa8eb94b66","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ! -d \"/var/log/kolla/elasticsearch\" ]]; then"},{"line_number":4,"context_line":"    install -d -m 0755 -o elasticsearch -g elasticsearch /var/log/kolla/elasticsearch"},{"line_number":5,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_9b1351b8","line":5,"in_reply_to":"3fa7e38b_fbd045f6","updated":"2019-11-25 15:13:57.000000000","message":"ok, makes sense.","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"}],"releasenotes/notes/add-elasticsearch-curator-88089d04f7ccd549.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"824273a0ffaf283d038806cbb8dbc5fe165447ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Elasticsearch Curator for managing aggregated log data."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_fb94c542","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2019-11-25 15:03:58.000000000","message":"nit: Adds","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1cca809ad3103173311679d68ea5e82254af3d1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Elasticsearch Curator for managing aggregated log data."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_0da079f3","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"3fa7e38b_8d30e9eb","updated":"2019-11-26 11:54:39.000000000","message":"that makes more sense, thanks","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ecb5eb219b40676627a51cd0c62ed4158c9d109d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Elasticsearch Curator for managing aggregated log data."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_8d30e9eb","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"3fa7e38b_e71186f9","updated":"2019-11-26 11:51:14.000000000","message":"It\u0027s how the release team recommend to write notes. I think the idea is it\u0027s kolla-ansible 9.0.0 adds feature x, fixes bug y.","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4da844c52c02d0802a8f49c3cfe738132a07a1f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add Elasticsearch Curator for managing aggregated log data."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_e71186f9","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"in_reply_to":"3fa7e38b_fb94c542","updated":"2019-11-25 17:55:41.000000000","message":"Not sure I follow but anyway..","commit_id":"f4d128f0dc33aec62e43dd4f27dc46b95bf26365"}]}