)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f98befe8be86a7fb5df3811aaf7d66cb304a18e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dincer Celik \u003chello@dincercelik.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-22 13:41:41 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure lsb-relase exists on debian/ubuntu"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I74142928d97af932a04e33476771360579e01ee7"},{"line_number":10,"context_line":"Closes-Bug: #1853474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_e90df8e6","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":17},"updated":"2019-11-22 13:15:01.000000000","message":"release","commit_id":"0720e023d54a6738e0bad460b9296b7cbbbebb8b"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"7c7259774fadc84e3dd5b7d218b382c7091d1e24","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dincer Celik \u003chello@dincercelik.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-22 13:41:41 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure lsb-relase exists on debian/ubuntu"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I74142928d97af932a04e33476771360579e01ee7"},{"line_number":10,"context_line":"Closes-Bug: #1853474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_a9caa06a","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":17},"in_reply_to":"3fa7e38b_e90df8e6","updated":"2019-11-22 13:21:21.000000000","message":"Done","commit_id":"0720e023d54a6738e0bad460b9296b7cbbbebb8b"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9aa3cdff295766bc03e1a740fa668d7e0a5018ad","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    {# endif for install type is source for RPM based distros #}"},{"line_number":278,"context_line":"{# endif for base_package_type rpm #}"},{"line_number":279,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":280,"context_line":"# Ensure lsb_release exists"},{"line_number":281,"context_line":"RUN which lsb_release \\"},{"line_number":282,"context_line":"    || apt-get update \\"},{"line_number":283,"context_line":"    \u0026\u0026 apt-get -y install lsb-release --no-install-recommends \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_589ad86e","line":280,"updated":"2019-11-22 09:42:58.000000000","message":"This will execute before we do the package repo setup. Not sure if that\u0027s an issue.","commit_id":"c2781f5789734f10bd66f904d1c89679a5558076"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9aa3cdff295766bc03e1a740fa668d7e0a5018ad","unresolved":false,"context_lines":[{"line_number":279,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":280,"context_line":"# Ensure lsb_release exists"},{"line_number":281,"context_line":"RUN which lsb_release \\"},{"line_number":282,"context_line":"    || apt-get update \\"},{"line_number":283,"context_line":"    \u0026\u0026 apt-get -y install lsb-release --no-install-recommends \\"},{"line_number":284,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":285,"context_line":"    \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"},{"line_number":288,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; fi"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_18d3003a","line":285,"range":{"start_line":282,"start_character":7,"end_line":285,"end_character":34},"updated":"2019-11-22 09:42:58.000000000","message":"Can\u0027t you replace this with:\n\nmacros.install_packages([\u0027lsb-release\u0027])","commit_id":"c2781f5789734f10bd66f904d1c89679a5558076"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9aa3cdff295766bc03e1a740fa668d7e0a5018ad","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":285,"context_line":"    \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"},{"line_number":288,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; fi"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"# Customize PS1 bash shell"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_f8b4e4f2","line":287,"range":{"start_line":287,"start_character":0,"end_line":287,"end_character":3},"updated":"2019-11-22 09:42:58.000000000","message":"Could you combine with these two RUN statements into one?","commit_id":"c2781f5789734f10bd66f904d1c89679a5558076"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7d5900763cfec29c87638494eb75d320a279254c","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":285,"context_line":"    \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"},{"line_number":288,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; fi"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"# Customize PS1 bash shell"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_0b288c83","line":287,"range":{"start_line":287,"start_character":52,"end_line":287,"end_character":68},"updated":"2019-11-22 10:25:13.000000000","message":"should probably just call lsb_release in here","commit_id":"c2781f5789734f10bd66f904d1c89679a5558076"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9aa3cdff295766bc03e1a740fa668d7e0a5018ad","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"},{"line_number":288,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; fi"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"# Customize PS1 bash shell"},{"line_number":291,"context_line":"# enlarge \u0027system users\u0027 range so \u0027haproxy\u0027 package will not complain"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_5873b84e","line":288,"updated":"2019-11-22 09:42:58.000000000","message":"If /etc/lsb-release was missing and this still passed, it suggests that this check isn\u0027t working.","commit_id":"c2781f5789734f10bd66f904d1c89679a5558076"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7d5900763cfec29c87638494eb75d320a279254c","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"RUN if [ $(awk -F \u0027\u003d\u0027 \u0027/DISTRIB_RELEASE/{print $2}\u0027 /etc/lsb-release) !\u003d \"{{ supported_distro_release }}\" ]; then \\"},{"line_number":288,"context_line":"        echo \"Only release \u0027{{ supported_distro_release }}\u0027 is supported on {{ base_distro }}\"; false; fi"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"# Customize PS1 bash shell"},{"line_number":291,"context_line":"# enlarge \u0027system users\u0027 range so \u0027haproxy\u0027 package will not complain"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_4b18c474","line":288,"in_reply_to":"3fa7e38b_5873b84e","updated":"2019-11-22 10:25:13.000000000","message":"Errors in if statements are ignored.","commit_id":"c2781f5789734f10bd66f904d1c89679a5558076"}]}