)]}'
{".zuul.d/centos.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check-arm64","change_message_id":"1c2c13943fd9f55dcc7dbaec7009fda069d08533","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-build-centos8"},{"line_number":6,"context_line":"        - tripleo-build-containers-centos-8:"},{"line_number":7,"context_line":"            voting: false"},{"line_number":8,"context_line":"            files:"},{"line_number":9,"context_line":"              - ^docker/.*$"},{"line_number":10,"context_line":"              - ^kolla/.*$"},{"line_number":11,"context_line":"              - ^requirements.txt$"},{"line_number":12,"context_line":"              - ^setup.cfg$"},{"line_number":13,"context_line":"              - ^setup.py$"},{"line_number":14,"context_line":"    check-arm64:"},{"line_number":15,"context_line":"      jobs:"},{"line_number":16,"context_line":"        - kolla-build-centos8-aarch64"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      queue: kolla"},{"line_number":19,"context_line":"      jobs:"},{"line_number":20,"context_line":"        - kolla-build-centos8"},{"line_number":21,"context_line":"        - kolla-ansible-centos8"},{"line_number":22,"context_line":"        - kolla-ansible-centos8-upgrade"},{"line_number":23,"context_line":"    periodic:"},{"line_number":24,"context_line":"      jobs:"},{"line_number":25,"context_line":"        - kolla-publish-centos8"},{"line_number":26,"context_line":"    release:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - kolla-publish-centos8"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- job:"},{"line_number":31,"context_line":"    name: kolla-build-centos8"},{"line_number":32,"context_line":"    parent: kolla-base"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"bf51134e_00349f49","line":29,"range":{"start_line":2,"start_character":2,"end_line":29,"end_character":0},"updated":"2020-07-02 14:42:56.000000000","message":"Job kolla-ansible-centos8 not defined","commit_id":"759b2a15cc95f4d694b5d6b8e8aa96a391aa1be3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6715cbfb652f894f5532c161125a9e1081648d00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-build-centos8"},{"line_number":6,"context_line":"        - tripleo-build-containers-centos-8:"},{"line_number":7,"context_line":"            voting: false"},{"line_number":8,"context_line":"            files:"},{"line_number":9,"context_line":"              - ^docker/.*$"},{"line_number":10,"context_line":"              - ^kolla/.*$"},{"line_number":11,"context_line":"              - ^requirements.txt$"},{"line_number":12,"context_line":"              - ^setup.cfg$"},{"line_number":13,"context_line":"              - ^setup.py$"},{"line_number":14,"context_line":"    check-arm64:"},{"line_number":15,"context_line":"      jobs:"},{"line_number":16,"context_line":"        - kolla-build-centos8-aarch64"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      queue: kolla"},{"line_number":19,"context_line":"      jobs:"},{"line_number":20,"context_line":"        - kolla-build-centos8"},{"line_number":21,"context_line":"        - kolla-ansible-centos8"},{"line_number":22,"context_line":"        - kolla-ansible-centos8-upgrade"},{"line_number":23,"context_line":"    periodic:"},{"line_number":24,"context_line":"      jobs:"},{"line_number":25,"context_line":"        - kolla-publish-centos8"},{"line_number":26,"context_line":"    release:"},{"line_number":27,"context_line":"      jobs:"},{"line_number":28,"context_line":"        - kolla-publish-centos8"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- job:"},{"line_number":31,"context_line":"    name: kolla-build-centos8"},{"line_number":32,"context_line":"    parent: kolla-base"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"bf51134e_60ef5bb0","line":29,"range":{"start_line":2,"start_character":2,"end_line":29,"end_character":0},"updated":"2020-07-02 14:42:41.000000000","message":"Job kolla-ansible-centos8 not defined","commit_id":"759b2a15cc95f4d694b5d6b8e8aa96a391aa1be3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check-arm64","change_message_id":"ffb485e9de65db396169e27ad5ad98e5d31a3b6e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-build-centos8"},{"line_number":6,"context_line":"        - kolla-ansible-centos8-source"},{"line_number":7,"context_line":"        - kolla-ansible-centos8-binary"},{"line_number":8,"context_line":"        - kolla-ansible-centos8-source-upgrade"},{"line_number":9,"context_line":"        - kolla-ansible-centos8-source-bifrost:"},{"line_number":10,"context_line":"            files: ^docker\\/(base|bifrost|openstack-base)\\/.*"},{"line_number":11,"context_line":"        # Test rabbitmq \u0026 mariadb changes in multinode ceph jobs."},{"line_number":12,"context_line":"        - kolla-ansible-centos8-source-ceph-ansible:"},{"line_number":13,"context_line":"            files: ^docker\\/(base|cinder|glance|mariadb|openstack-base|rabbitmq)\\/.*"},{"line_number":14,"context_line":"        - kolla-ansible-centos8-source-upgrade-ceph-ansible:"},{"line_number":15,"context_line":"            files: ^docker\\/(base|cinder|glance|mariadb|openstack-base|rabbitmq)\\/.*"},{"line_number":16,"context_line":"        - kolla-ansible-centos8-source-zun:"},{"line_number":17,"context_line":"            files: ^docker\\/(base|cinder|etcd|iscsid|kuryr|openstack-base|zun)\\/.*"},{"line_number":18,"context_line":"        - kolla-ansible-centos8-source-scenario-nfv:"},{"line_number":19,"context_line":"            files: ^docker\\/(base|barbican|heat|mistral|openstack-base|redis|tacker)\\/.*"},{"line_number":20,"context_line":"        - kolla-ansible-centos8-source-ironic:"},{"line_number":21,"context_line":"            files: ^docker\\/(base|dnsmasq|ironic|ironic-inspector|iscsid|openstack-base)\\/.*"},{"line_number":22,"context_line":"        - kolla-ansible-centos8-source-swift:"},{"line_number":23,"context_line":"            files: ^docker/(base|openstack-base|glance|swift)/"},{"line_number":24,"context_line":"        - kolla-ansible-centos8-source-mariadb:"},{"line_number":25,"context_line":"            files: ^docker/(base|mariadb)/"},{"line_number":26,"context_line":"        - kolla-ansible-centos8-source-masakari:"},{"line_number":27,"context_line":"            files: ^docker/(base|masakari)/"},{"line_number":28,"context_line":"        - kolla-ansible-centos8-source-ovn:"},{"line_number":29,"context_line":"            files: ^docker/(base|neutron|openvswitch|ovn)/"},{"line_number":30,"context_line":"        - kolla-ansible-centos8-source-prometheus-efk:"},{"line_number":31,"context_line":"            files: ^docker/(base|elasticsearch|grafana|kibana|prometheus)/"},{"line_number":32,"context_line":"        - kolla-ansible-centos8-source-kvm:"},{"line_number":33,"context_line":"            files: ^docker/nova/"},{"line_number":34,"context_line":"    check-arm64:"},{"line_number":35,"context_line":"      jobs:"},{"line_number":36,"context_line":"        - kolla-build-centos8-aarch64"},{"line_number":37,"context_line":"    gate:"},{"line_number":38,"context_line":"      queue: kolla"},{"line_number":39,"context_line":"      jobs:"},{"line_number":40,"context_line":"        - kolla-build-centos8"},{"line_number":41,"context_line":"        - kolla-ansible-centos8-source"},{"line_number":42,"context_line":"        - kolla-ansible-centos8-source-upgrade"},{"line_number":43,"context_line":"    periodic:"},{"line_number":44,"context_line":"      jobs:"},{"line_number":45,"context_line":"        - kolla-publish-centos8"},{"line_number":46,"context_line":"    release:"},{"line_number":47,"context_line":"      jobs:"},{"line_number":48,"context_line":"        - kolla-publish-centos8"},{"line_number":49,"context_line":"    experimental:"},{"line_number":50,"context_line":"      jobs:"},{"line_number":51,"context_line":"        - kolla-build-no-infra-wheels-centos8-source"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- job:"},{"line_number":54,"context_line":"    name: kolla-build-centos8"},{"line_number":55,"context_line":"    parent: kolla-base"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_5adcf643","line":52,"range":{"start_line":2,"start_character":2,"end_line":52,"end_character":0},"updated":"2020-09-13 11:32:24.000000000","message":"Job kolla-build-no-infra-wheels-centos8-source not defined","commit_id":"fa60c7291eaa751c74673e869f17fd2f1f517289"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b8ea65e9e3983df19e6abc71e01fa6decfd1d9dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-build-centos8"},{"line_number":6,"context_line":"        - kolla-ansible-centos8-source"},{"line_number":7,"context_line":"        - kolla-ansible-centos8-binary"},{"line_number":8,"context_line":"        - kolla-ansible-centos8-source-upgrade"},{"line_number":9,"context_line":"        - kolla-ansible-centos8-source-bifrost:"},{"line_number":10,"context_line":"            files: ^docker\\/(base|bifrost|openstack-base)\\/.*"},{"line_number":11,"context_line":"        # Test rabbitmq \u0026 mariadb changes in multinode ceph jobs."},{"line_number":12,"context_line":"        - kolla-ansible-centos8-source-ceph-ansible:"},{"line_number":13,"context_line":"            files: ^docker\\/(base|cinder|glance|mariadb|openstack-base|rabbitmq)\\/.*"},{"line_number":14,"context_line":"        - kolla-ansible-centos8-source-upgrade-ceph-ansible:"},{"line_number":15,"context_line":"            files: ^docker\\/(base|cinder|glance|mariadb|openstack-base|rabbitmq)\\/.*"},{"line_number":16,"context_line":"        - kolla-ansible-centos8-source-zun:"},{"line_number":17,"context_line":"            files: ^docker\\/(base|cinder|etcd|iscsid|kuryr|openstack-base|zun)\\/.*"},{"line_number":18,"context_line":"        - kolla-ansible-centos8-source-scenario-nfv:"},{"line_number":19,"context_line":"            files: ^docker\\/(base|barbican|heat|mistral|openstack-base|redis|tacker)\\/.*"},{"line_number":20,"context_line":"        - kolla-ansible-centos8-source-ironic:"},{"line_number":21,"context_line":"            files: ^docker\\/(base|dnsmasq|ironic|ironic-inspector|iscsid|openstack-base)\\/.*"},{"line_number":22,"context_line":"        - kolla-ansible-centos8-source-swift:"},{"line_number":23,"context_line":"            files: ^docker/(base|openstack-base|glance|swift)/"},{"line_number":24,"context_line":"        - kolla-ansible-centos8-source-mariadb:"},{"line_number":25,"context_line":"            files: ^docker/(base|mariadb)/"},{"line_number":26,"context_line":"        - kolla-ansible-centos8-source-masakari:"},{"line_number":27,"context_line":"            files: ^docker/(base|masakari)/"},{"line_number":28,"context_line":"        - kolla-ansible-centos8-source-ovn:"},{"line_number":29,"context_line":"            files: ^docker/(base|neutron|openvswitch|ovn)/"},{"line_number":30,"context_line":"        - kolla-ansible-centos8-source-prometheus-efk:"},{"line_number":31,"context_line":"            files: ^docker/(base|elasticsearch|grafana|kibana|prometheus)/"},{"line_number":32,"context_line":"        - kolla-ansible-centos8-source-kvm:"},{"line_number":33,"context_line":"            files: ^docker/nova/"},{"line_number":34,"context_line":"    check-arm64:"},{"line_number":35,"context_line":"      jobs:"},{"line_number":36,"context_line":"        - kolla-build-centos8-aarch64"},{"line_number":37,"context_line":"    gate:"},{"line_number":38,"context_line":"      queue: kolla"},{"line_number":39,"context_line":"      jobs:"},{"line_number":40,"context_line":"        - kolla-build-centos8"},{"line_number":41,"context_line":"        - kolla-ansible-centos8-source"},{"line_number":42,"context_line":"        - kolla-ansible-centos8-source-upgrade"},{"line_number":43,"context_line":"    periodic:"},{"line_number":44,"context_line":"      jobs:"},{"line_number":45,"context_line":"        - kolla-publish-centos8"},{"line_number":46,"context_line":"    release:"},{"line_number":47,"context_line":"      jobs:"},{"line_number":48,"context_line":"        - kolla-publish-centos8"},{"line_number":49,"context_line":"    experimental:"},{"line_number":50,"context_line":"      jobs:"},{"line_number":51,"context_line":"        - kolla-build-no-infra-wheels-centos8-source"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- job:"},{"line_number":54,"context_line":"    name: kolla-build-centos8"},{"line_number":55,"context_line":"    parent: kolla-base"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"9f560f44_da12c6fc","line":52,"range":{"start_line":2,"start_character":2,"end_line":52,"end_character":0},"updated":"2020-09-13 11:31:46.000000000","message":"Job kolla-build-no-infra-wheels-centos8-source not defined","commit_id":"fa60c7291eaa751c74673e869f17fd2f1f517289"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4ceb283ea90153b67a6add00fff32b86c44d37f9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    name: kolla-build-centos8-binary"},{"line_number":58,"context_line":"    parent: kolla-base"},{"line_number":59,"context_line":"    nodeset: kolla-centos8"},{"line_number":60,"context_line":"    voting: false"},{"line_number":61,"context_line":"    vars:"},{"line_number":62,"context_line":"      base_distro: centos"},{"line_number":63,"context_line":"      install_type: binary"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_0b7056da","side":"PARENT","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":17},"updated":"2020-09-15 10:48:56.000000000","message":"I think we need to be prepared for more CI breakage if we introduce this. If it becomes a problem we can find some ways around it.","commit_id":"0cbba11213f3dcbd9a58815a3e9cbab5c0597faa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f08d66b5a2670e1c238dedb14d16afc7bbeaeb95","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- job:"},{"line_number":77,"context_line":"    name: kolla-build-no-infra-wheels-centos8"},{"line_number":78,"context_line":"    parent: kolla-build-no-infra-wheels-base"},{"line_number":79,"context_line":"    nodeset: kolla-centos8"},{"line_number":80,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9f560f44_0ec31b8c","line":77,"updated":"2020-09-17 07:55:45.000000000","message":"this should ideally only ever build images that are \u0027source\u0027 (no \u0027infra\u0027 nor \u0027binary\u0027) because it\u0027s to test their more-native buildability","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"}],".zuul.d/debian.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f08d66b5a2670e1c238dedb14d16afc7bbeaeb95","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    nodeset: kolla-debian-buster-aarch64"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- job:"},{"line_number":50,"context_line":"    name: kolla-build-no-infra-wheels-debian"},{"line_number":51,"context_line":"    parent: kolla-build-no-infra-wheels-base"},{"line_number":52,"context_line":"    nodeset: kolla-debian-buster"},{"line_number":53,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9f560f44_eebd0704","line":50,"updated":"2020-09-17 07:55:45.000000000","message":"obvious ditto","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"}],".zuul.d/ubuntu.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6715cbfb652f894f5532c161125a9e1081648d00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-build-ubuntu"},{"line_number":6,"context_line":"    check-arm64:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - kolla-build-ubuntu-aarch64"},{"line_number":9,"context_line":"    gate:"},{"line_number":10,"context_line":"      queue: kolla"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - kolla-build-ubuntu"},{"line_number":13,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":14,"context_line":"        - kolla-ansible-ubuntu-upgrade"},{"line_number":15,"context_line":"    periodic:"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - kolla-publish-ubuntu"},{"line_number":18,"context_line":"    release:"},{"line_number":19,"context_line":"      jobs:"},{"line_number":20,"context_line":"        - kolla-publish-ubuntu"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- job:"},{"line_number":23,"context_line":"    name: kolla-build-ubuntu"},{"line_number":24,"context_line":"    parent: kolla-base"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"bf51134e_c02907f3","line":21,"range":{"start_line":2,"start_character":2,"end_line":21,"end_character":0},"updated":"2020-07-02 14:42:41.000000000","message":"Job kolla-ansible-ubuntu not defined","commit_id":"759b2a15cc95f4d694b5d6b8e8aa96a391aa1be3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check-arm64","change_message_id":"1c2c13943fd9f55dcc7dbaec7009fda069d08533","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-build-ubuntu"},{"line_number":6,"context_line":"    check-arm64:"},{"line_number":7,"context_line":"      jobs:"},{"line_number":8,"context_line":"        - kolla-build-ubuntu-aarch64"},{"line_number":9,"context_line":"    gate:"},{"line_number":10,"context_line":"      queue: kolla"},{"line_number":11,"context_line":"      jobs:"},{"line_number":12,"context_line":"        - kolla-build-ubuntu"},{"line_number":13,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":14,"context_line":"        - kolla-ansible-ubuntu-upgrade"},{"line_number":15,"context_line":"    periodic:"},{"line_number":16,"context_line":"      jobs:"},{"line_number":17,"context_line":"        - kolla-publish-ubuntu"},{"line_number":18,"context_line":"    release:"},{"line_number":19,"context_line":"      jobs:"},{"line_number":20,"context_line":"        - kolla-publish-ubuntu"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- job:"},{"line_number":23,"context_line":"    name: kolla-build-ubuntu"},{"line_number":24,"context_line":"    parent: kolla-base"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"bf51134e_e0388b3e","line":21,"range":{"start_line":2,"start_character":2,"end_line":21,"end_character":0},"updated":"2020-07-02 14:42:56.000000000","message":"Job kolla-ansible-ubuntu not defined","commit_id":"759b2a15cc95f4d694b5d6b8e8aa96a391aa1be3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f08d66b5a2670e1c238dedb14d16afc7bbeaeb95","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"- job:"},{"line_number":107,"context_line":"    name: kolla-build-no-infra-wheels-ubuntu"},{"line_number":108,"context_line":"    parent: kolla-build-no-infra-wheels-base"},{"line_number":109,"context_line":"    nodeset: kolla-ubuntu-focal"},{"line_number":110,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9f560f44_6ebc57db","line":107,"updated":"2020-09-17 07:55:45.000000000","message":"obvious ditto","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"}],"docker/horizon/extend_start.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"9f87836c76f125f3697dfe9fcda3f35d4e2cd651","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    SITE_PACKAGES\u003d\"/var/lib/kolla/venv/lib/python${KOLLA_DISTRO_PYTHON_VERSION}/site-packages\""},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"echo \"KOLLA_INSTALL_TYPE\u003d${KOLLA_INSTALL_TYPE}\""},{"line_number":19,"context_line":"echo \"SITE_PACKAGES\u003d${SITE_PACKAGES}\""},{"line_number":20,"context_line":"echo \"KOLLA_BASE_DISTRO\u003d${KOLLA_BASE_DISTRO}\""},{"line_number":21,"context_line":"echo \"KOLLA_DISTRO_PYTHON_VERSION\u003d${KOLLA_DISTRO_PYTHON_VERSION}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ -f \"/var/lib/kolla/venv/bin/python\" ]]; then"},{"line_number":24,"context_line":"    MANAGE_PY\u003d\"/var/lib/kolla/venv/bin/python /var/lib/kolla/venv/bin/manage.py\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_8affc1fd","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":65},"updated":"2020-02-11 12:14:54.000000000","message":"for some debug","commit_id":"0d3be592e4056c0e10e8496e6dd0791e82331a76"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"9f87836c76f125f3697dfe9fcda3f35d4e2cd651","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    if [[ ! -L ${CUSTOM_SETTINGS_FILE} ]]; then"},{"line_number":45,"context_line":"        mkdir -p $(dirname ${CUSTOM_SETTINGS_FILE})"},{"line_number":46,"context_line":"        ln -s /etc/openstack-dashboard/custom_local_settings ${CUSTOM_SETTINGS_FILE}"},{"line_number":47,"context_line":"    fi"},{"line_number":48,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":13,"id":"3fa7e38b_aa04fd13","line":45,"updated":"2020-02-11 12:14:54.000000000","message":"should not be needed...","commit_id":"0d3be592e4056c0e10e8496e6dd0791e82331a76"}],"docker/macros.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"964ee39b1f67a32155c239088179932e0e22d055","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"{% endmacro %}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"{% macro add_binary_source_envs() %}"},{"line_number":94,"context_line":"ENV KOLLA_INSTALL_TYPE\u003d{{ install_type }} \\"},{"line_number":95,"context_line":"    KOLLA_INSTALL_METATYPE\u003d{{ install_metatype }}"},{"line_number":96,"context_line":"{% endmacro %}"}],"source_content_type":"text/x-jinja2","patch_set":45,"id":"9f560f44_dae7660e","line":96,"range":{"start_line":93,"start_character":0,"end_line":96,"end_character":14},"updated":"2020-09-13 11:32:47.000000000","message":"I am thinking of extracting that macro and it\u0027s use to separate patch.\n\nShould not change much with current state and make review easier.","commit_id":"fa60c7291eaa751c74673e869f17fd2f1f517289"}],"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab7b4cad6f565c5772c1c8e97fbe45ee6d7564f2","unresolved":false,"context_lines":[{"line_number":211,"context_line":"BINARY_SOURCE_IMAGES \u003d ["},{"line_number":212,"context_line":"    \u0027monasca-thresh\u0027,"},{"line_number":213,"context_line":"    \u0027non-infra-base\u0027,"},{"line_number":214,"context_line":"    \u0027openvswitch-netcontrold\u0027"},{"line_number":215,"context_line":"]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_94ef60e8","line":214,"updated":"2020-07-01 16:54:01.000000000","message":"This should really be infra.","commit_id":"a1ad180b79581ae4b7e9b732bd6d1bbe60d32741"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fcc0f2ce7a20b01995d82c3e86c8c3941c13125f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"BINARY_SOURCE_IMAGES \u003d ["},{"line_number":212,"context_line":"    \u0027monasca-thresh\u0027,"},{"line_number":213,"context_line":"    \u0027non-infra-base\u0027,"},{"line_number":214,"context_line":"    \u0027openvswitch-netcontrold\u0027"},{"line_number":215,"context_line":"]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_ac116d56","line":214,"in_reply_to":"bf51134e_80538fe2","updated":"2020-07-02 16:42:06.000000000","message":"That is a bug.","commit_id":"a1ad180b79581ae4b7e9b732bd6d1bbe60d32741"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"06590124eee5c1fb6287685fe85734f5b518c847","unresolved":false,"context_lines":[{"line_number":211,"context_line":"BINARY_SOURCE_IMAGES \u003d ["},{"line_number":212,"context_line":"    \u0027monasca-thresh\u0027,"},{"line_number":213,"context_line":"    \u0027non-infra-base\u0027,"},{"line_number":214,"context_line":"    \u0027openvswitch-netcontrold\u0027"},{"line_number":215,"context_line":"]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_80538fe2","line":214,"in_reply_to":"bf51134e_94ef60e8","updated":"2020-07-02 14:36:14.000000000","message":"It has different content for binary and different for source so it is not infra.","commit_id":"a1ad180b79581ae4b7e9b732bd6d1bbe60d32741"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ab7b4cad6f565c5772c1c8e97fbe45ee6d7564f2","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"                    LOG.debug(dockerfile)"},{"line_number":1269,"context_line":"                    dfile.write(dockerfile)"},{"line_number":1270,"context_line":"                    dfile.close()"},{"line_number":1271,"context_line":"                    LOG.debug(f\"Wrote it to {image.path}/Dockerfile\")"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    def build_image_list(self):"},{"line_number":1274,"context_line":"        def process_source_installation(image, section):"}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_b4d6e426","line":1271,"updated":"2020-07-01 16:54:01.000000000","message":"I think we can do all this in the template. Change infra images from using image_prefix to a new infra_image_prefix which we set based on the flag.","commit_id":"a1ad180b79581ae4b7e9b732bd6d1bbe60d32741"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"06590124eee5c1fb6287685fe85734f5b518c847","unresolved":false,"context_lines":[{"line_number":1268,"context_line":"                    LOG.debug(dockerfile)"},{"line_number":1269,"context_line":"                    dfile.write(dockerfile)"},{"line_number":1270,"context_line":"                    dfile.close()"},{"line_number":1271,"context_line":"                    LOG.debug(f\"Wrote it to {image.path}/Dockerfile\")"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"    def build_image_list(self):"},{"line_number":1274,"context_line":"        def process_source_installation(image, section):"}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_60fe3baf","line":1271,"in_reply_to":"bf51134e_b4d6e426","updated":"2020-07-02 14:36:14.000000000","message":"First thing Kolla does is generation of dockerfiles. Then they are used not modified during build.\n\nHere we modify them so need to rewrite them again.","commit_id":"a1ad180b79581ae4b7e9b732bd6d1bbe60d32741"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e8e18bdbf8f513b0377b7aa8431c75b47d96c3f6","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# NOTE(hrw): all non-infra images and their children"},{"line_number":209,"context_line":"BINARY_SOURCE_IMAGES \u003d ["},{"line_number":210,"context_line":"    \u0027monasca-thresh\u0027,"},{"line_number":211,"context_line":"    \u0027kolla-toolbox\u0027,"},{"line_number":212,"context_line":"    \u0027openstack-base\u0027,"},{"line_number":213,"context_line":"    \u0027openvswitch-netcontrold\u0027"}],"source_content_type":"text/x-python","patch_set":37,"id":"bf51134e_9639f9a4","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":21},"updated":"2020-07-06 10:16:37.000000000","message":"I spoke with Doug on taking care of this one.","commit_id":"83e1bed727986470d9572ed7c8c339f99c856cb0"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e8e18bdbf8f513b0377b7aa8431c75b47d96c3f6","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    \u0027monasca-thresh\u0027,"},{"line_number":211,"context_line":"    \u0027kolla-toolbox\u0027,"},{"line_number":212,"context_line":"    \u0027openstack-base\u0027,"},{"line_number":213,"context_line":"    \u0027openvswitch-netcontrold\u0027"},{"line_number":214,"context_line":"]"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bf51134e_d6ced1b2","line":213,"range":{"start_line":213,"start_character":0,"end_line":213,"end_character":29},"updated":"2020-07-06 10:16:37.000000000","message":"https://review.opendev.org/739452 should take care of it","commit_id":"83e1bed727986470d9572ed7c8c339f99c856cb0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f1ce7c24eeb1131ab836eeb01695098e88832d56","unresolved":false,"context_lines":[{"line_number":955,"context_line":"                      \u0027supported_distro_release\u0027: supported_distro_release,"},{"line_number":956,"context_line":"                      \u0027install_metatype\u0027: self.install_metatype,"},{"line_number":957,"context_line":"                      \u0027image_prefix\u0027: self.image_prefix,"},{"line_number":958,"context_line":"                      \u0027infra_image_prefix\u0027: self.infra_image_prefix,"},{"line_number":959,"context_line":"                      \u0027install_type\u0027: self.install_type,"},{"line_number":960,"context_line":"                      \u0027namespace\u0027: self.namespace,"},{"line_number":961,"context_line":"                      \u0027openstack_release\u0027: self.openstack_release,"}],"source_content_type":"text/x-python","patch_set":37,"id":"bf51134e_52ef6a86","line":958,"updated":"2020-07-06 13:11:11.000000000","message":"If we are confident about this approach, I would suggest breaking this out of this change, and the changes to Dockerfiles to use it. We can start with this:\n\ninfra_image_prefix \u003d self.image_prefix","commit_id":"83e1bed727986470d9572ed7c8c339f99c856cb0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2aaaa66fc34b1e8e6744469a806986c99a6f343","unresolved":false,"context_lines":[{"line_number":192,"context_line":"}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# NOTE(hrw): all non-infra images and their children"},{"line_number":195,"context_line":"BINARY_SOURCE_IMAGES \u003d ["},{"line_number":196,"context_line":"    \u0027kolla-toolbox\u0027,"},{"line_number":197,"context_line":"    \u0027openstack-base\u0027,"},{"line_number":198,"context_line":"    \u0027monasca-thresh\u0027,"}],"source_content_type":"text/x-python","patch_set":41,"id":"9f560f44_8cc0a07d","line":195,"range":{"start_line":195,"start_character":0,"end_line":195,"end_character":20},"updated":"2020-07-31 19:07:51.000000000","message":"TYPED_IMAGES?","commit_id":"cbef3c26c4a82eac8414defdfcee35ed0bec3885"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"8c443bdd7d2b60a868e0888b409a3b2cb253e2b2","unresolved":false,"context_lines":[{"line_number":192,"context_line":"}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# NOTE(hrw): all non-infra images and their children"},{"line_number":195,"context_line":"BINARY_SOURCE_IMAGES \u003d ["},{"line_number":196,"context_line":"    \u0027kolla-toolbox\u0027,"},{"line_number":197,"context_line":"    \u0027openstack-base\u0027,"},{"line_number":198,"context_line":"    \u0027monasca-thresh\u0027,"}],"source_content_type":"text/x-python","patch_set":41,"id":"9f560f44_474f7e33","line":195,"range":{"start_line":195,"start_character":0,"end_line":195,"end_character":20},"in_reply_to":"9f560f44_8cc0a07d","updated":"2020-08-01 14:14:05.000000000","message":"BINARY_SOURCE says exactly what it mean without reading code.","commit_id":"cbef3c26c4a82eac8414defdfcee35ed0bec3885"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"130bc4fa6c6e666dc15e38d50ecda9e16edad17a","unresolved":false,"context_lines":[{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"    def change_install_type(self, image, old_type, new_type):"},{"line_number":1017,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1018,"context_line":"        if image.children:"},{"line_number":1019,"context_line":"            for tmp_image in image.children:"},{"line_number":1020,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1021,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"    def filter_images(self):"},{"line_number":1025,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":44,"id":"9f560f44_df0bef79","line":1022,"range":{"start_line":1018,"start_character":0,"end_line":1022,"end_character":48},"updated":"2020-08-26 14:48:47.000000000","message":"If we\u0027re changing all the children...","commit_id":"67278cad4f66bf2987693105ff6167e27c4e3517"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"130bc4fa6c6e666dc15e38d50ecda9e16edad17a","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"                if image.name in BINARY_SOURCE_IMAGES:"},{"line_number":1109,"context_line":"                    # keep as is"},{"line_number":1110,"context_line":"                    is_infra \u003d False"},{"line_number":1111,"context_line":"                else:"},{"line_number":1112,"context_line":"                    # let\u0027s check ancestors if any of them is binary/source"},{"line_number":1113,"context_line":"                    ancestor_image \u003d image"},{"line_number":1114,"context_line":"                    while (ancestor_image.parent is not None):"},{"line_number":1115,"context_line":"                        ancestor_image \u003d ancestor_image.parent"},{"line_number":1116,"context_line":"                        if ancestor_image.name in BINARY_SOURCE_IMAGES:"},{"line_number":1117,"context_line":"                            is_infra \u003d False"},{"line_number":1118,"context_line":"                            break"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"                if is_infra:"},{"line_number":1121,"context_line":"                    self.change_install_type(image, self.install_type, \u0027infra\u0027)"}],"source_content_type":"text/x-python","patch_set":44,"id":"9f560f44_ff235303","line":1118,"range":{"start_line":1111,"start_character":0,"end_line":1118,"end_character":33},"updated":"2020-08-26 14:48:47.000000000","message":"... do we need this part?","commit_id":"67278cad4f66bf2987693105ff6167e27c4e3517"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"84561835bad9f39c83d20e1db18c78988df05df5","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"                if image.name in BINARY_SOURCE_IMAGES:"},{"line_number":1109,"context_line":"                    # keep as is"},{"line_number":1110,"context_line":"                    is_infra \u003d False"},{"line_number":1111,"context_line":"                else:"},{"line_number":1112,"context_line":"                    # let\u0027s check ancestors if any of them is binary/source"},{"line_number":1113,"context_line":"                    ancestor_image \u003d image"},{"line_number":1114,"context_line":"                    while (ancestor_image.parent is not None):"},{"line_number":1115,"context_line":"                        ancestor_image \u003d ancestor_image.parent"},{"line_number":1116,"context_line":"                        if ancestor_image.name in BINARY_SOURCE_IMAGES:"},{"line_number":1117,"context_line":"                            is_infra \u003d False"},{"line_number":1118,"context_line":"                            break"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"                if is_infra:"},{"line_number":1121,"context_line":"                    self.change_install_type(image, self.install_type, \u0027infra\u0027)"}],"source_content_type":"text/x-python","patch_set":44,"id":"9f560f44_1a31dea2","line":1118,"range":{"start_line":1111,"start_character":0,"end_line":1118,"end_character":33},"in_reply_to":"9f560f44_ff235303","updated":"2020-09-13 11:31:08.000000000","message":"I do not trust the list to be sorted in a way that it works without that.","commit_id":"67278cad4f66bf2987693105ff6167e27c4e3517"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5bc231c46a09002d14478711e82e7a32e32e0355","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1019,"context_line":"        if image.children:"},{"line_number":1020,"context_line":"            for tmp_image in image.children:"},{"line_number":1021,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1023,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def filter_images(self):"},{"line_number":1026,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_ebcd2231","line":1023,"range":{"start_line":1021,"start_character":15,"end_line":1023,"end_character":48},"updated":"2020-09-15 10:31:52.000000000","message":"I suppose we could just set it to image.canonical_name?","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8266ed96b960afdaea4f5df6e311142e8c18dc1e","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1019,"context_line":"        if image.children:"},{"line_number":1020,"context_line":"            for tmp_image in image.children:"},{"line_number":1021,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1023,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def filter_images(self):"},{"line_number":1026,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_61c6536b","line":1023,"range":{"start_line":1021,"start_character":15,"end_line":1023,"end_character":48},"in_reply_to":"9f560f44_01d67754","updated":"2020-09-15 12:17:34.000000000","message":"Yes, and tmp_image.parent_name \u003d\u003d image.canonical_name","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"79a3b78277f235eba0e3a0e15e6a95bd2971f757","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1019,"context_line":"        if image.children:"},{"line_number":1020,"context_line":"            for tmp_image in image.children:"},{"line_number":1021,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1023,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def filter_images(self):"},{"line_number":1026,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_01d67754","line":1023,"range":{"start_line":1021,"start_character":15,"end_line":1023,"end_character":48},"in_reply_to":"9f560f44_ebcd2231","updated":"2020-09-15 12:08:21.000000000","message":"It is parent image name mangling.","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4ceb283ea90153b67a6add00fff32b86c44d37f9","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"                if is_infra:"},{"line_number":1122,"context_line":"                    self.change_install_type(image, self.install_type, \u0027infra\u0027)"},{"line_number":1123,"context_line":"                    pass"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        # Next, mark any skipped images."},{"line_number":1126,"context_line":"        for image in self.images:"}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_c67135ab","line":1123,"range":{"start_line":1123,"start_character":20,"end_line":1123,"end_character":24},"updated":"2020-09-15 10:48:56.000000000","message":"What is the pass for?","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"79a3b78277f235eba0e3a0e15e6a95bd2971f757","unresolved":false,"context_lines":[{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"                if is_infra:"},{"line_number":1122,"context_line":"                    self.change_install_type(image, self.install_type, \u0027infra\u0027)"},{"line_number":1123,"context_line":"                    pass"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        # Next, mark any skipped images."},{"line_number":1126,"context_line":"        for image in self.images:"}],"source_content_type":"text/x-python","patch_set":46,"id":"9f560f44_41e06f27","line":1123,"range":{"start_line":1123,"start_character":20,"end_line":1123,"end_character":24},"in_reply_to":"9f560f44_c67135ab","updated":"2020-09-15 12:08:21.000000000","message":"dropped","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f08d66b5a2670e1c238dedb14d16afc7bbeaeb95","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1019,"context_line":"        if image.children:"},{"line_number":1020,"context_line":"            for tmp_image in image.children:"},{"line_number":1021,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1023,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def filter_images(self):"},{"line_number":1026,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"9f560f44_eea98725","line":1023,"range":{"start_line":1021,"start_character":69,"end_line":1023,"end_character":48},"updated":"2020-09-17 07:55:45.000000000","message":"why can\u0027t it be a simple replace like above?\n\nelse these should really be anchored to the string beginning","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b25c408485f9f0a32a2766c4e3d986b0faec710","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1019,"context_line":"        if image.children:"},{"line_number":1020,"context_line":"            for tmp_image in image.children:"},{"line_number":1021,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1023,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def filter_images(self):"},{"line_number":1026,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"9f560f44_74a1c6a8","line":1023,"range":{"start_line":1021,"start_character":69,"end_line":1023,"end_character":48},"in_reply_to":"9f560f44_740546c1","updated":"2020-09-17 09:02:00.000000000","message":"indeed, it\u0027s the very same string","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9fd2446365a0b0002df7c35ccba88a517a8c0d91","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"        image.canonical_name \u003d image.canonical_name.replace(old_type, new_type)"},{"line_number":1019,"context_line":"        if image.children:"},{"line_number":1020,"context_line":"            for tmp_image in image.children:"},{"line_number":1021,"context_line":"                tmp_image.parent_name \u003d tmp_image.parent_name.replace("},{"line_number":1022,"context_line":"                    f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1023,"context_line":"                    f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"    def filter_images(self):"},{"line_number":1026,"context_line":"        \"\"\"Filter which images to build.\"\"\""}],"source_content_type":"text/x-python","patch_set":47,"id":"9f560f44_740546c1","line":1023,"range":{"start_line":1021,"start_character":69,"end_line":1023,"end_character":48},"in_reply_to":"9f560f44_eea98725","updated":"2020-09-17 08:57:44.000000000","message":"even simpler (as I commented previously), tmp_image.parent_name \u003d image.canonical_name","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7f431183e27ad4e512ca883d76ea052d3fdd7096","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"    def change_install_type(self, image, old_type, new_type):"},{"line_number":1018,"context_line":"        # NOTE(hrw): /self.base to make sure that we do not break image name"},{"line_number":1019,"context_line":"        image.canonical_name \u003d image.canonical_name.replace("},{"line_number":1020,"context_line":"            f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1021,"context_line":"            f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1022,"context_line":"        if image.children:"},{"line_number":1023,"context_line":"            for tmp_image in image.children:"}],"source_content_type":"text/x-python","patch_set":48,"id":"9f560f44_15791f81","line":1020,"updated":"2020-09-22 07:40:37.000000000","message":"nit: would be safest to anchor to the string beginning with ^ but it\u0027s probably already safe enough","commit_id":"e40bf80f98ec470f4358fe9511d3bea968f2a25f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"d0efed7328d14f3c547d4fa364550246463440b0","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"    def change_install_type(self, image, old_type, new_type):"},{"line_number":1018,"context_line":"        # NOTE(hrw): /self.base to make sure that we do not break image name"},{"line_number":1019,"context_line":"        image.canonical_name \u003d image.canonical_name.replace("},{"line_number":1020,"context_line":"            f\u0027/{self.base}-{old_type}-\u0027,"},{"line_number":1021,"context_line":"            f\u0027/{self.base}-{new_type}-\u0027)"},{"line_number":1022,"context_line":"        if image.children:"},{"line_number":1023,"context_line":"            for tmp_image in image.children:"}],"source_content_type":"text/x-python","patch_set":48,"id":"9f560f44_d504c780","line":1020,"in_reply_to":"9f560f44_15791f81","updated":"2020-09-22 08:11:30.000000000","message":"then you need to import re, compile regex etc.","commit_id":"e40bf80f98ec470f4358fe9511d3bea968f2a25f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7f431183e27ad4e512ca883d76ea052d3fdd7096","unresolved":false,"context_lines":[{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"                if is_infra:"},{"line_number":1123,"context_line":"                    self.change_install_type(image, self.install_type, \u0027infra\u0027)"},{"line_number":1124,"context_line":"                    pass"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        # Next, mark any skipped images."},{"line_number":1127,"context_line":"        for image in self.images:"}],"source_content_type":"text/x-python","patch_set":48,"id":"9f560f44_75897b6d","line":1124,"updated":"2020-09-22 07:40:37.000000000","message":"nit: srsly? I thought pep8 would get mad at such noops","commit_id":"e40bf80f98ec470f4358fe9511d3bea968f2a25f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"d0efed7328d14f3c547d4fa364550246463440b0","unresolved":false,"context_lines":[{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"                if is_infra:"},{"line_number":1123,"context_line":"                    self.change_install_type(image, self.install_type, \u0027infra\u0027)"},{"line_number":1124,"context_line":"                    pass"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        # Next, mark any skipped images."},{"line_number":1127,"context_line":"        for image in self.images:"}],"source_content_type":"text/x-python","patch_set":48,"id":"9f560f44_f5ff4b63","line":1124,"in_reply_to":"9f560f44_75897b6d","updated":"2020-09-22 08:11:30.000000000","message":"argh. I thought that I removed that already.","commit_id":"e40bf80f98ec470f4358fe9511d3bea968f2a25f"}],"tests/playbooks/run.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"16156206bdb729531d14dc5c3ce32c5d7d14eaa4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    - name: Run build of one image type at time"},{"line_number":14,"context_line":"      include_tasks: run_one_install_type.yml"},{"line_number":15,"context_line":"      loop:"},{"line_number":16,"context_line":"        - \"binary\""},{"line_number":17,"context_line":"        - \"source\""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bf51134e_86cba870","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":18},"updated":"2020-07-02 15:16:53.000000000","message":"here we need to limit it \"not if Debian and AArch64\" but I do not know how to make it","commit_id":"7fe1fc72c24edb9c6779751c3f28ea00dc14a80e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2aaaa66fc34b1e8e6744469a806986c99a6f343","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        mode: 0777"},{"line_number":11,"context_line":"      become: true"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    - name: Run build of one image type at time"},{"line_number":14,"context_line":"      include_tasks: run_one_install_type.yml"},{"line_number":15,"context_line":"      vars:"},{"line_number":16,"context_line":"        install_types:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"9f560f44_6cbb8c0d","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":47},"updated":"2020-07-31 19:07:51.000000000","message":"nit: \u0027at a time\u0027","commit_id":"cbef3c26c4a82eac8414defdfcee35ed0bec3885"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f08d66b5a2670e1c238dedb14d16afc7bbeaeb95","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        mode: 0777"},{"line_number":11,"context_line":"      become: true"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    - name: Run build of one image type at time"},{"line_number":14,"context_line":"      include_tasks: run_one_install_type.yml"},{"line_number":15,"context_line":"      vars:"},{"line_number":16,"context_line":"        install_types:"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9f560f44_0e5ddb47","line":13,"range":{"start_line":13,"start_character":43,"end_line":13,"end_character":47},"updated":"2020-09-17 07:55:45.000000000","message":"nit: a time","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"}],"tests/playbooks/run_one_install_type.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4ceb283ea90153b67a6add00fff32b86c44d37f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set type of build"},{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"    install_type: \"{{ item }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Template kolla-build.conf"},{"line_number":7,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_260f5130","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":30},"updated":"2020-09-15 10:48:56.000000000","message":"You can do this with include_tasks:\n\ninclude_tasks: run_one_install_type.yml\nloop_control:\n  loop_var: install_type\n\nThis allows this tasks file to use the standard item loop variable.","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"79a3b78277f235eba0e3a0e15e6a95bd2971f757","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set type of build"},{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"    install_type: \"{{ item }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Template kolla-build.conf"},{"line_number":7,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_41b98f13","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":30},"in_reply_to":"9f560f44_260f5130","updated":"2020-09-15 12:08:21.000000000","message":"Done","commit_id":"aa0dd56a66d8c471fb8162c76773854f9c66cf29"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f08d66b5a2670e1c238dedb14d16afc7bbeaeb95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"9f560f44_ae3b0fe8","line":20,"updated":"2020-09-17 07:55:45.000000000","message":"aren\u0027t we thus building infra images twice?","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a7914ec9b6fa7779561421fbfdc33425a944c098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"9f560f44_f4f036dd","line":20,"in_reply_to":"9f560f44_ae3b0fe8","updated":"2020-09-17 08:58:50.000000000","message":"docker cache says no. It gets split out in a later commit","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ead26d25ebb2a83057d9e279182d7727fa345933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"9f560f44_f49af65d","line":20,"in_reply_to":"9f560f44_f4f036dd","updated":"2020-09-17 09:03:06.000000000","message":"hmm, true; infra images should not be affected by the cache bug indeed","commit_id":"3e3c3b33f4ebae734ae66ed27f3bac181c142799"}]}