)]}'
{"kolla/image/build.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5db803ee6e86a5b0105dd24e408fd4a0e4b98693","unresolved":false,"context_lines":[{"line_number":1433,"context_line":"    kolla.create_dockerfiles()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"    if conf.template_only:"},{"line_number":1436,"context_line":"        kolla.build_image_list()"},{"line_number":1437,"context_line":"        kolla.find_parents()"},{"line_number":1438,"context_line":"        kolla.filter_images()"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"        for image in kolla.images:"},{"line_number":1441,"context_line":"            if image.status \u003d\u003d STATUS_MATCHED:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_7a0a2427","line":1438,"range":{"start_line":1436,"start_character":0,"end_line":1438,"end_character":29},"updated":"2020-01-28 10:23:07.000000000","message":"Alternative is to push these calls up before find_dockerfiles and only template files we will build.\n\nAlso removes repeated calls to these methods we now have in every path.","commit_id":"fa2e1304362d3b81b9903b77d180aa2eb3f1af8b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"acbf2de15ebbc07e0552cad8cbaeba65e3ec029a","unresolved":false,"context_lines":[{"line_number":1433,"context_line":"    kolla.create_dockerfiles()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"    if conf.template_only:"},{"line_number":1436,"context_line":"        kolla.build_image_list()"},{"line_number":1437,"context_line":"        kolla.find_parents()"},{"line_number":1438,"context_line":"        kolla.filter_images()"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"        for image in kolla.images:"},{"line_number":1441,"context_line":"            if image.status \u003d\u003d STATUS_MATCHED:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_40709a73","line":1438,"range":{"start_line":1436,"start_character":0,"end_line":1438,"end_character":29},"in_reply_to":"3fa7e38b_2029de81","updated":"2020-01-28 10:46:37.000000000","message":"ok, thanks for explanation.","commit_id":"fa2e1304362d3b81b9903b77d180aa2eb3f1af8b"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"a95b00012c01cfd15a040530eb993ef76f28fcb5","unresolved":false,"context_lines":[{"line_number":1433,"context_line":"    kolla.create_dockerfiles()"},{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"    if conf.template_only:"},{"line_number":1436,"context_line":"        kolla.build_image_list()"},{"line_number":1437,"context_line":"        kolla.find_parents()"},{"line_number":1438,"context_line":"        kolla.filter_images()"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"        for image in kolla.images:"},{"line_number":1441,"context_line":"            if image.status \u003d\u003d STATUS_MATCHED:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_2029de81","line":1438,"range":{"start_line":1436,"start_character":0,"end_line":1438,"end_character":29},"in_reply_to":"3fa7e38b_7a0a2427","updated":"2020-01-28 10:25:56.000000000","message":"nope.\n\nWe create docker files, then build image list by analizing them, then we find parents to build tree of images and then we filter unbuildable ones from that tree.","commit_id":"fa2e1304362d3b81b9903b77d180aa2eb3f1af8b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b7dbc3ff0f20ea808898700f56b557f6a325c049","unresolved":false,"context_lines":[{"line_number":1438,"context_line":"        kolla.filter_images()"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"        for image in kolla.images:"},{"line_number":1441,"context_line":"            if image.status \u003d\u003d STATUS_MATCHED:"},{"line_number":1442,"context_line":"                continue"},{"line_number":1443,"context_line":""},{"line_number":1444,"context_line":"            shutil.rmtree(image.path)"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"        LOG.info(\u0027Dockerfiles are generated in %s\u0027, kolla.working_dir)"},{"line_number":1447,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_df3c6a92","line":1444,"range":{"start_line":1441,"start_character":12,"end_line":1444,"end_character":37},"updated":"2020-01-28 08:00:23.000000000","message":"nit: would be clearer to just run rmtree when not \"status matched\"","commit_id":"fa2e1304362d3b81b9903b77d180aa2eb3f1af8b"}]}