)]}'
{"id":"openstack%2Fkolla~704532","triplet_id":"openstack%2Fkolla~master~I2cd8d3997eec171db043c7042e42174c5ba8c298","project":"openstack/kolla","branch":"master","hashtags":[],"change_id":"I2cd8d3997eec171db043c7042e42174c5ba8c298","subject":"Reduce duplication in kolla.image.build.run()","status":"MERGED","created":"2020-01-28 10:53:01.000000000","updated":"2020-01-28 15:22:25.000000000","submitted":"2020-01-28 15:20:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"704532-1580224830682-fa858c1e","meta_rev_id":"79ee31713d8aa91577d61a4c24f10bfd1d6ea919","_number":704532,"virtual_id_number":704532,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-28 15:20:30.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-01-28 11:25:08.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-01-28 12:25:10.000000000","_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":2,"date":"2020-01-28 13:11:30.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":2,"date":"2020-01-28 13:10:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":1,"date":"2020-01-28 13:11:30.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":1,"date":"2020-01-28 13:10:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-01-28 11:25:08.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-01-28 12:25:10.000000000","updated_by":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"reviewer":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"state":"REVIEWER"},{"updated":"2020-01-28 13:10:35.000000000","updated_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"reviewer":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"state":"REVIEWER"},{"updated":"2020-01-28 13:11:30.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-01-28 15:20:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"04a244c5ff0fe200e50b1f5ba7700179ed628721","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-01-28 10:53:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0fb9eb69a816896a45231b2c5a527662e9390ad7","author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"date":"2020-01-28 10:55:41.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f2628c86dcca2ec1ddd0f6680bef54a7266673b3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-01-28 11:25:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-build-containers-rhel-8-master https://review.rdoproject.org/zuul/build/aa059eda470f4e46a7d39658ef66f9b1 : SUCCESS in 27m 46s","accounts_in_message":[],"_revision_number":1},{"id":"bf2ebeeb2aa09af4650e93a09a9627cb1494150e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 12:21:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- kolla-build-centos-binary https://zuul.opendev.org/t/openstack/build/8f0c847107f84bc191c701525a866375 : SUCCESS in 44m 34s (non-voting)\n- kolla-build-centos-source https://zuul.opendev.org/t/openstack/build/26babc3da9c34101b91faaf99ea45415 : SUCCESS in 53m 52s\n- kolla-build-centos8-binary https://zuul.opendev.org/t/openstack/build/33fa1173983848da8f53f567810079cf : SUCCESS in 12m 48s (non-voting)\n- kolla-build-centos8-source https://zuul.opendev.org/t/openstack/build/479cc49b8b70479fadad6ffdfcef47c3 : SUCCESS in 5m 49s\n- kolla-ansible-centos-source https://zuul.opendev.org/t/openstack/build/36e00c9a406a477a842a706e41795412 : SUCCESS in 1h 20m 01s\n- kolla-ansible-centos-binary https://zuul.opendev.org/t/openstack/build/ed2e57212696432fa2f218f580843994 : SUCCESS in 1h 10m 54s (non-voting)\n- kolla-ansible-centos-source-upgrade https://zuul.opendev.org/t/openstack/build/05193a7d2c8c46f4a2f652a95822bcfb : SUCCESS in 1h 27m 09s\n- tripleo-build-containers-centos-7 https://zuul.opendev.org/t/openstack/build/238ee800d3f64c189245306565aef172 : SUCCESS in 42m 49s\n- kolla-build-debian-source https://zuul.opendev.org/t/openstack/build/aeab902264014bfcb61ec89f756cc082 : SUCCESS in 24m 31s (non-voting)\n- kolla-build-debian-binary https://zuul.opendev.org/t/openstack/build/c8f6aa92f16346b6835957d715c40780 : SUCCESS in 20m 04s (non-voting)\n- kolla-ansible-debian-source https://zuul.opendev.org/t/openstack/build/77df80e01747456f9aee26153708a2e8 : SUCCESS in 1h 00m 16s (non-voting)\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1fc48330310c41e3af11419bed687997 : SUCCESS in 4m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bff579534ba4425d8a6c72312672dfe0 : SUCCESS in 4m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0870b719c7db4900834dbc1eb2cc85bd : SUCCESS in 4m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a2727dc1dfa34b97ab1c73e0c03357ff : SUCCESS in 4m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2a23cb6ceb4148a6877bc869588297af : SUCCESS in 4m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6bc57680a61441a4a10e925121f80c89 : SUCCESS in 6m 01s\n- kolla-build-ubuntu-binary https://zuul.opendev.org/t/openstack/build/9007e4db27ea426894baa83074d8c556 : SUCCESS in 25m 21s (non-voting)\n- kolla-build-ubuntu-source https://zuul.opendev.org/t/openstack/build/cdadaf85035641e181110eb9c4799d8a : SUCCESS in 30m 27s\n- kolla-ansible-ubuntu-source https://zuul.opendev.org/t/openstack/build/22f1ae3fb04c4c09ad45b5db442363c6 : SUCCESS in 55m 03s\n- kolla-ansible-ubuntu-binary https://zuul.opendev.org/t/openstack/build/356ef052b47d48729fa7c518cc330f29 : SUCCESS in 54m 06s (non-voting)\n- kolla-ansible-ubuntu-source-upgrade https://zuul.opendev.org/t/openstack/build/4cf741b379454113957968408c6f8c05 : SUCCESS in 1h 04m 06s","accounts_in_message":[],"_revision_number":1},{"id":"401f96118f37c82227da79e713e89a105ce828e5","author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"date":"2020-01-28 12:25:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fe106b902c64f5793eb8e2cca15bc1a5c2d0cff2","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-01-28 13:10:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"21c6b4a79895f28e1db9ea98dbb3b218f422116f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 13:10:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0812a6f146f8fb3451473e61daf698d22475f68d","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-01-28 13:11:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"5ad31730505189fdb56d2e1fe1027ab80b38debe","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 14:27:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- kolla-build-debian-source-aarch64 https://zuul.opendev.org/t/openstack/build/3dc4df45be474a2cae4fea062f9bfede : SUCCESS in 3h 02m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"295a19d5a68c588327de7b6acdf83b4fe4be3b1b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 15:20:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"19ac9e07e5f9aecb97a4bb5603706e4fb0d39865","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 15:20:30.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- kolla-build-centos-source https://zuul.opendev.org/t/openstack/build/77e98c669d7946aba34cd032540bff2b : SUCCESS in 44m 25s\n- kolla-build-centos8-source https://zuul.opendev.org/t/openstack/build/8ae9c5d3967047ddb2663ffb3c1528c5 : SUCCESS in 7m 11s\n- kolla-ansible-centos-source https://zuul.opendev.org/t/openstack/build/09c19ae64fc54a93ac824cf03513e170 : SUCCESS in 1h 35m 52s\n- kolla-ansible-centos-source-upgrade https://zuul.opendev.org/t/openstack/build/9b16c9dfaf3b4c9caffcd380c35d6179 : SUCCESS in 2h 07m 08s\n- tripleo-build-containers-centos-7 https://zuul.opendev.org/t/openstack/build/b41253fda1e54a0592b6e62eea4216ab : SUCCESS in 1h 01m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d003d0eceb814fbda5e2e5aff5801233 : SUCCESS in 5m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/df8ab64dfb4c444283435965985e08a7 : SUCCESS in 6m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a851e50be5bb42cba91bd2c0cd5c798a : SUCCESS in 4m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7c1169ed224747bb96a6d81b750b9b68 : SUCCESS in 4m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5e84bb58007a484c9e11e7fec5844d97 : SUCCESS in 9m 41s\n- kolla-build-ubuntu-source https://zuul.opendev.org/t/openstack/build/a1c490a8476a405f9cac4c47421cdbff : SUCCESS in 29m 07s\n- kolla-ansible-ubuntu-source https://zuul.opendev.org/t/openstack/build/ef1be3dac50d4887856f5fb1f82f7d12 : SUCCESS in 1h 08m 16s\n- kolla-ansible-ubuntu-source-upgrade https://zuul.opendev.org/t/openstack/build/d9e33621cc1a4711aeb081e82804ee0f : SUCCESS in 1h 04m 21s","accounts_in_message":[],"_revision_number":1},{"id":"79ee31713d8aa91577d61a4c24f10bfd1d6ea919","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 15:22:25.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b4eb4f16c6ad4c3585b8a95853eb9e73 : SUCCESS in 1m 30s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fd1db6cd89a03114c3d8db1b7a7ae5e7498b3d0a","revisions":{"fd1db6cd89a03114c3d8db1b7a7ae5e7498b3d0a":{"kind":"REWORK","_number":1,"created":"2020-01-28 10:53:01.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/32/704532/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/32/704532/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/32/704532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/32/704532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/32/704532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/32/704532/1"}}},"commit":{"parents":[{"commit":"fa2e1304362d3b81b9903b77d180aa2eb3f1af8b","subject":"build: list only buildable templates for --template-only","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/fa2e1304362d3b81b9903b77d180aa2eb3f1af8b"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-01-28 10:52:43.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-01-28 10:52:43.000000000","tz":0},"subject":"Reduce duplication in kolla.image.build.run()","message":"Reduce duplication in kolla.image.build.run()\n\nSmall refactor, now that all call paths use the same methods.\n\nChange-Id: I2cd8d3997eec171db043c7042e42174c5ba8c298\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/fd1db6cd89a03114c3d8db1b7a7ae5e7498b3d0a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/fd1db6cd89a03114c3d8db1b7a7ae5e7498b3d0a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}