)]}'
{"docker/base/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3163bcc8cb9352ae8cda579d89b45b8962c285f1","unresolved":false,"context_lines":[{"line_number":224,"context_line":"{% set base_centos_yum_repo_packages \u003d ["},{"line_number":225,"context_line":"    \u0027epel-release\u0027,"},{"line_number":226,"context_line":"] %}"},{"line_number":227,"context_line":"# FIXME(mgoddard): Not available for CentOS 8 yet."},{"line_number":228,"context_line":"{% if distro_package_manager \u003d\u003d \u0027yum\u0027 %}"},{"line_number":229,"context_line":"    {% set base_centos_yum_repo_packages \u003d base_centos_yum_repo_packages + ["},{"line_number":230,"context_line":"        \u0027centos-release-ceph-nautilus\u0027,"},{"line_number":231,"context_line":"        \u0027centos-release-opstools\u0027,"},{"line_number":232,"context_line":"        \u0027centos-release-qemu-ev\u0027,"},{"line_number":233,"context_line":"    ] %}"},{"line_number":234,"context_line":"# FIXME(mnasiadka): Replace with CentOS Storage SIG packages when avail"},{"line_number":235,"context_line":"{% else %}"},{"line_number":236,"context_line":"COPY ceph_master.repo /etc/yum.repos.d/"},{"line_number":237,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_12e15b9b","line":234,"range":{"start_line":227,"start_character":0,"end_line":234,"end_character":71},"updated":"2020-02-25 09:15:53.000000000","message":"this sounds wrong","commit_id":"d8f071b24bffe91f1c5de7744d30ab37b984b9d3"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"596ccba2b63679898781f82c93c41d6a1c915aa4","unresolved":false,"context_lines":[{"line_number":224,"context_line":"{% set base_centos_yum_repo_packages \u003d ["},{"line_number":225,"context_line":"    \u0027epel-release\u0027,"},{"line_number":226,"context_line":"] %}"},{"line_number":227,"context_line":"# FIXME(mgoddard): Not available for CentOS 8 yet."},{"line_number":228,"context_line":"{% if distro_package_manager \u003d\u003d \u0027yum\u0027 %}"},{"line_number":229,"context_line":"    {% set base_centos_yum_repo_packages \u003d base_centos_yum_repo_packages + ["},{"line_number":230,"context_line":"        \u0027centos-release-ceph-nautilus\u0027,"},{"line_number":231,"context_line":"        \u0027centos-release-opstools\u0027,"},{"line_number":232,"context_line":"        \u0027centos-release-qemu-ev\u0027,"},{"line_number":233,"context_line":"    ] %}"},{"line_number":234,"context_line":"# FIXME(mnasiadka): Replace with CentOS Storage SIG packages when avail"},{"line_number":235,"context_line":"{% else %}"},{"line_number":236,"context_line":"COPY ceph_master.repo /etc/yum.repos.d/"},{"line_number":237,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_6a2453c7","line":234,"range":{"start_line":227,"start_character":0,"end_line":234,"end_character":71},"in_reply_to":"1fa4df85_07891a74","updated":"2020-02-25 13:21:15.000000000","message":"yes, i just mean last workd, \"avail\" seems cut, that\u0027s it. other than that i see it fine.","commit_id":"d8f071b24bffe91f1c5de7744d30ab37b984b9d3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"100292dc5ac4b98c349470de5918783caedda03f","unresolved":false,"context_lines":[{"line_number":224,"context_line":"{% set base_centos_yum_repo_packages \u003d ["},{"line_number":225,"context_line":"    \u0027epel-release\u0027,"},{"line_number":226,"context_line":"] %}"},{"line_number":227,"context_line":"# FIXME(mgoddard): Not available for CentOS 8 yet."},{"line_number":228,"context_line":"{% if distro_package_manager \u003d\u003d \u0027yum\u0027 %}"},{"line_number":229,"context_line":"    {% set base_centos_yum_repo_packages \u003d base_centos_yum_repo_packages + ["},{"line_number":230,"context_line":"        \u0027centos-release-ceph-nautilus\u0027,"},{"line_number":231,"context_line":"        \u0027centos-release-opstools\u0027,"},{"line_number":232,"context_line":"        \u0027centos-release-qemu-ev\u0027,"},{"line_number":233,"context_line":"    ] %}"},{"line_number":234,"context_line":"# FIXME(mnasiadka): Replace with CentOS Storage SIG packages when avail"},{"line_number":235,"context_line":"{% else %}"},{"line_number":236,"context_line":"COPY ceph_master.repo /etc/yum.repos.d/"},{"line_number":237,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_07891a74","line":234,"range":{"start_line":227,"start_character":0,"end_line":234,"end_character":71},"in_reply_to":"1fa4df85_086a8c7f","updated":"2020-02-25 11:31:27.000000000","message":"The comment is accurate AFAIK. centos-release-ceph-nautilus is not available for CentOS 8 yet - we are creating the repo file manually.","commit_id":"d8f071b24bffe91f1c5de7744d30ab37b984b9d3"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"15d6cc6f8b4479977f3f0895a0864153d4467705","unresolved":false,"context_lines":[{"line_number":224,"context_line":"{% set base_centos_yum_repo_packages \u003d ["},{"line_number":225,"context_line":"    \u0027epel-release\u0027,"},{"line_number":226,"context_line":"] %}"},{"line_number":227,"context_line":"# FIXME(mgoddard): Not available for CentOS 8 yet."},{"line_number":228,"context_line":"{% if distro_package_manager \u003d\u003d \u0027yum\u0027 %}"},{"line_number":229,"context_line":"    {% set base_centos_yum_repo_packages \u003d base_centos_yum_repo_packages + ["},{"line_number":230,"context_line":"        \u0027centos-release-ceph-nautilus\u0027,"},{"line_number":231,"context_line":"        \u0027centos-release-opstools\u0027,"},{"line_number":232,"context_line":"        \u0027centos-release-qemu-ev\u0027,"},{"line_number":233,"context_line":"    ] %}"},{"line_number":234,"context_line":"# FIXME(mnasiadka): Replace with CentOS Storage SIG packages when avail"},{"line_number":235,"context_line":"{% else %}"},{"line_number":236,"context_line":"COPY ceph_master.repo /etc/yum.repos.d/"},{"line_number":237,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_086a8c7f","line":234,"range":{"start_line":227,"start_character":0,"end_line":234,"end_character":71},"in_reply_to":"1fa4df85_12e15b9b","updated":"2020-02-25 10:50:41.000000000","message":"Other that the comment which seems to be incomplete, the base_centos_yum_repo_packages definition for CentOS7 (distro_package_manager \u003d\u003d \u0027yum\u0027) looks good to me.\n\nWhat seems wrong?","commit_id":"d8f071b24bffe91f1c5de7744d30ab37b984b9d3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"be7ba86a0ec70b370070de0e620f3d62a442ec2c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"{% set base_centos_yum_repo_packages \u003d ["},{"line_number":225,"context_line":"    \u0027epel-release\u0027,"},{"line_number":226,"context_line":"] %}"},{"line_number":227,"context_line":"# FIXME(mgoddard): Not available for CentOS 8 yet."},{"line_number":228,"context_line":"{% if distro_package_manager \u003d\u003d \u0027yum\u0027 %}"},{"line_number":229,"context_line":"    {% set base_centos_yum_repo_packages \u003d base_centos_yum_repo_packages + ["},{"line_number":230,"context_line":"        \u0027centos-release-ceph-nautilus\u0027,"},{"line_number":231,"context_line":"        \u0027centos-release-opstools\u0027,"},{"line_number":232,"context_line":"        \u0027centos-release-qemu-ev\u0027,"},{"line_number":233,"context_line":"    ] %}"},{"line_number":234,"context_line":"# FIXME(mnasiadka): Replace with CentOS Storage SIG packages when avail"},{"line_number":235,"context_line":"{% else %}"},{"line_number":236,"context_line":"COPY ceph_master.repo /etc/yum.repos.d/"},{"line_number":237,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_d3365bb5","line":234,"range":{"start_line":227,"start_character":0,"end_line":234,"end_character":71},"in_reply_to":"1fa4df85_6a2453c7","updated":"2020-02-25 19:25:21.000000000","message":"oh, sorry, these are the *packages*, my bad","commit_id":"d8f071b24bffe91f1c5de7744d30ab37b984b9d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a874b44c916de31cb0d489c444f4900ce8fa6906","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    ] %}"},{"line_number":234,"context_line":"# FIXME(mnasiadka): Replace with CentOS Storage SIG packages when avail"},{"line_number":235,"context_line":"{% else %}"},{"line_number":236,"context_line":"COPY ceph_master.repo /etc/yum.repos.d/"},{"line_number":237,"context_line":"{% endif %}"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"{% if distro_package_manager \u003d\u003d \u0027dnf\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1fa4df85_e25cda4c","line":236,"range":{"start_line":236,"start_character":9,"end_line":236,"end_character":16},"updated":"2020-02-26 10:00:07.000000000","message":"can we rename it to ceph.repo? It\u0027s not master (Octopus) anymore.","commit_id":"d8f071b24bffe91f1c5de7744d30ab37b984b9d3"}],"docker/base/ceph_master.repo":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"40b1536faac65f67f034be1ec899ccd2a8fc8338","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[centos-ceph-nautilus]"},{"line_number":2,"context_line":"name\u003dCeph packages for $basearch"},{"line_number":3,"context_line":"baseurl\u003dhttp://cbs.centos.org/repos/storage8-ceph-nautilus-candidate/$basearch/os"},{"line_number":4,"context_line":"enabled\u003d1"},{"line_number":5,"context_line":"gpgcheck\u003d0"},{"line_number":6,"context_line":"type\u003drpm-md"},{"line_number":7,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_1c278d20","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":9},"updated":"2020-02-12 09:01:14.000000000","message":"they should be disabled and you should enable them in each Dockerfile where you need it.","commit_id":"9d1ee1236119e5ecae3e6f43fe4c991ce940ebbe"}]}
