)]}'
{"docker/haproxy/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"cd3591dcaceb74f8085516e1420816f84819c976","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ macros.configure_user(name\u003d\u0027haproxy\u0027) }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% set haproxy_packages \u003d ["},{"line_number":12,"context_line":"    \u0027haproxy\u0027"},{"line_number":13,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1fa4df85_b44da973","line":10,"updated":"2020-02-27 12:50:26.000000000","message":"nit: newline","commit_id":"7f4a737b4033b3bca02e6fad4d587d3631fd2da7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ae5e2ce88ae67eaee034806a56a5d97ba15b7b4a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":16,"context_line":"    {% set haproxy_packages \u003d haproxy_packages + [\u0027mariadb\u0027] %}"},{"line_number":17,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":18,"context_line":"    {% set haproxy_packages \u003d haproxy_packages + [\u0027mysql-client\u0027] %}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(haproxy_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1fa4df85_3441b93a","line":18,"range":{"start_line":18,"start_character":51,"end_line":18,"end_character":63},"updated":"2020-02-27 12:51:02.000000000","message":"mariadb-client","commit_id":"7f4a737b4033b3bca02e6fad4d587d3631fd2da7"}],"docker/mariadb/mariadb-clustercheck/Dockerfile.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"90140e6317b93c2fa931248eea7faa35e5205d53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}mariadb:{{ tag }}"},{"line_number":2,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block mariadb_clustercheck_header %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f4c43b2_cc55ad52","line":1,"range":{"start_line":1,"start_character":39,"end_line":1,"end_character":46},"updated":"2020-04-16 08:52:11.000000000","message":"but we only need client in here though","commit_id":"8ae3f264f6b6f58b39d9335fc6813b8219b9489d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"90140e6317b93c2fa931248eea7faa35e5205d53","unresolved":false,"context_lines":[{"line_number":27,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/master/f/clustercheck.sh \\"},{"line_number":28,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% if use_dumb_init %}"},{"line_number":32,"context_line":"{% block mariadb_entrypoint %}"},{"line_number":33,"context_line":"# NOTE(mgoddard): Override the dumb-init arguments to avoid passing"},{"line_number":34,"context_line":"# --single-child. This does not play well with mysqld_safe, which ignores"},{"line_number":35,"context_line":"# SIGTERM, meaning Docker needs to forcibly kill the container to stop it."},{"line_number":36,"context_line":"# Without --single-child, the TERM signal is sent to all subprocesses,"},{"line_number":37,"context_line":"# including mysqld."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"ENTRYPOINT [\"dumb-init\", \"--\"]"},{"line_number":40,"context_line":"CMD [\"kolla_start\"]"},{"line_number":41,"context_line":"{% endblock %}"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"{% block mariadb_clustercheck_footer %}{% endblock %}"},{"line_number":45,"context_line":"{% block footer %}{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f4c43b2_8c5c457f","line":42,"range":{"start_line":30,"start_character":0,"end_line":42,"end_character":11},"updated":"2020-04-16 08:52:11.000000000","message":"this does not seem relevant at all","commit_id":"8ae3f264f6b6f58b39d9335fc6813b8219b9489d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a9e61ddb7a0dd645646d2217a0c334f040bcfb55","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set mariadb_clustercheck_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb-server-galera\u0027,"},{"line_number":11,"context_line":"        \u0027xinetd\u0027"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f493fa4_8e046719","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":30},"updated":"2020-04-22 07:59:44.000000000","message":"why?","commit_id":"328959e70d3ec115f1a79584c6ad755388836137"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7aabb3cdc401e4d74030a55315aca73acefaf1c5","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set mariadb_clustercheck_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb-server-galera\u0027,"},{"line_number":11,"context_line":"        \u0027xinetd\u0027"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f493fa4_99a94f7d","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":30},"in_reply_to":"1f493fa4_8e046719","updated":"2020-04-22 08:31:42.000000000","message":"because this one contains clustercheck script, and on Ubuntu/Debian we need to download it as in line 23 (because it\u0027s not packaged in any package). We could just download it on any distro - if that\u0027s makes you feel better :)","commit_id":"328959e70d3ec115f1a79584c6ad755388836137"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1a29ec408e13089ce2f4bc14f809eb7478fb3f6c","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set mariadb_clustercheck_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb-server-galera\u0027,"},{"line_number":11,"context_line":"        \u0027xinetd\u0027"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f493fa4_79272314","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":30},"in_reply_to":"1f493fa4_99a94f7d","updated":"2020-04-22 08:38:39.000000000","message":"Ah, I missed that it was downloaded only for deb distros.","commit_id":"328959e70d3ec115f1a79584c6ad755388836137"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b47056605ca1b094a3bde9aef683eed372131e8d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/master/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f493fa4_f927b3b5","line":23,"range":{"start_line":23,"start_character":86,"end_line":23,"end_character":92},"updated":"2020-04-22 08:02:26.000000000","message":"this is worrisome","commit_id":"328959e70d3ec115f1a79584c6ad755388836137"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1a29ec408e13089ce2f4bc14f809eb7478fb3f6c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/master/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f493fa4_f97853f9","line":23,"range":{"start_line":23,"start_character":86,"end_line":23,"end_character":92},"in_reply_to":"1f493fa4_59c86754","updated":"2020-04-22 08:38:39.000000000","message":"The one that matches mariadb release.","commit_id":"328959e70d3ec115f1a79584c6ad755388836137"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7aabb3cdc401e4d74030a55315aca73acefaf1c5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/master/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f493fa4_59c86754","line":23,"range":{"start_line":23,"start_character":86,"end_line":23,"end_character":92},"in_reply_to":"1f493fa4_f927b3b5","updated":"2020-04-22 08:31:42.000000000","message":"We can change it to 10.3/10.4/10.5 branch if you feel safer ;-) So which one?","commit_id":"328959e70d3ec115f1a79584c6ad755388836137"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7174534151164b8e929776fa4f9e72e56de84d77","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set mariadb_clustercheck_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb-server-galera\u0027,"},{"line_number":11,"context_line":"        \u0027xinetd\u0027"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_203a20cb","line":10,"updated":"2020-04-27 09:23:37.000000000","message":"Could go in mariadb-base image as common to both/","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c9c42a08e7690d5526d160ca4e7a3392970a4b57","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":9,"context_line":"    {% set mariadb_clustercheck_packages \u003d ["},{"line_number":10,"context_line":"        \u0027mariadb-server-galera\u0027,"},{"line_number":11,"context_line":"        \u0027xinetd\u0027"},{"line_number":12,"context_line":"    ] %}"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_80bdf403","line":10,"in_reply_to":"1f493fa4_203a20cb","updated":"2020-04-27 10:11:54.000000000","message":"Right, will follow up.","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7174534151164b8e929776fa4f9e72e56de84d77","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/10.3/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_e072f8ac","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":108},"updated":"2020-04-27 09:23:37.000000000","message":"Based on the references to @INSTALL_SYSCONFDIR@ I\u0027d say this is a template.","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"62b998495eb680641c518b4c980076f499010b06","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/10.3/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_0a6e1ec8","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":108},"in_reply_to":"1f493fa4_373f03b5","updated":"2020-04-27 11:30:37.000000000","message":"TBH I\u0027m not that keen on curling scripts from github. It\u0027s not very friendly for environments without internet. It should at least be wrapped in a block.\n\nFedora seems like the most \u0027legit\u0027 source of these. Maybe we should use sed like you suggest.","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"07ba17904c3082d5eb289b9cd36e21fa9fb1993a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/10.3/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_373f03b5","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":108},"in_reply_to":"1f493fa4_74fd09b0","updated":"2020-04-27 10:44:14.000000000","message":"So - either we use sed to rework this to /etc/sysconfig - or use the version of the script not maintained by Red Hat:\n1. https://github.com/gitmstoute/mariadb-clustercheck/blob/master/clustercheck\n2. Percona original one (https://github.com/olafz/percona-clustercheck), but has a lot of references to Percona - and is not really the same that is bundled with Galera on CentOS\nWhat do you think?","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c9c42a08e7690d5526d160ca4e7a3392970a4b57","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{ macros.install_packages(mariadb_clustercheck_packages | customizable(\"packages\")) }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% if base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":23,"context_line":"RUN curl -sSL -o /usr/bin/clustercheck https://src.fedoraproject.org/rpms/mariadb/raw/10.3/f/clustercheck.sh \\"},{"line_number":24,"context_line":"    \u0026\u0026 chmod 755 /usr/bin/clustercheck"},{"line_number":25,"context_line":"{% endif %}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_74fd09b0","line":23,"range":{"start_line":23,"start_character":39,"end_line":23,"end_character":108},"in_reply_to":"1f493fa4_e072f8ac","updated":"2020-04-27 10:11:54.000000000","message":"Argh, didn\u0027t notice - not that it doesn\u0027t work in that form - let me see how to make it better.","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"}],"docker/mariadb/mariadb-server/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7174534151164b8e929776fa4f9e72e56de84d77","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{{ macros.enable_extra_repos([\u0027epel\u0027, \u0027mariadb\u0027]) }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":16,"context_line":"    {% set mariadb_packages \u003d ["},{"line_number":17,"context_line":"        \u0027expect\u0027,"},{"line_number":18,"context_line":"        \u0027galera\u0027,"},{"line_number":19,"context_line":"        \u0027hostname\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"1f493fa4_808fb473","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":27},"updated":"2020-04-27 09:23:37.000000000","message":"nit: mariadb_server_packages?","commit_id":"59616d4423712a9b4b55d7025c95c8bddd504850"}]}