)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"69e2b09c9b3fd0b820d1be5d516592719c793e59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix kolla_toolbox_pip_virtualenv_packages override"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"backport: train, stein, rocky, queens, pike"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"override in filter needs to follow the rule:"},{"line_number":12,"context_line":"\u003cimage_name\u003e_\u003ccall_type\u003e_\u003coverride/append/remove\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_ecd58db8","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":43},"updated":"2020-02-28 07:57:24.000000000","message":"queens\u0026pike are eol","commit_id":"6203862351602f67ce0af0cda387479f4bcca817"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3065b621d31a716c00fe6064966fb8bd3ed62f40","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix kolla_toolbox_pip_virtualenv_packages override"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"backport: train, stein, rocky, queens, pike"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"override in filter needs to follow the rule:"},{"line_number":12,"context_line":"\u003cimage_name\u003e_\u003ccall_type\u003e_\u003coverride/append/remove\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_972e62a3","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":43},"in_reply_to":"1fa4df85_b77b5ebc","updated":"2020-02-28 09:37:19.000000000","message":"Anyone can propose a backport to those branches, but the core team does not actively maintain them, so there may be some work required to make CI functional if it has broken.","commit_id":"6203862351602f67ce0af0cda387479f4bcca817"},{"author":{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},"change_message_id":"51f92986ff4f4e6b298e83a2e9ed01ad238f11f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix kolla_toolbox_pip_virtualenv_packages override"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"backport: train, stein, rocky, queens, pike"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"override in filter needs to follow the rule:"},{"line_number":12,"context_line":"\u003cimage_name\u003e_\u003ccall_type\u003e_\u003coverride/append/remove\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_b77b5ebc","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":43},"in_reply_to":"1fa4df85_ecd58db8","updated":"2020-02-28 09:32:46.000000000","message":"from https://releases.openstack.org/ queens and pike are at\nExtended Maintenance, should we backport this patch to these branch?","commit_id":"6203862351602f67ce0af0cda387479f4bcca817"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9f49e523532f5bb5ba4fec92e51b570a26e896af","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027virtualenv\u0027"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages|customizable(\"pip_virtualenv_packages\"), constraints\u003dfalse) }} \\"},{"line_number":76,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1fa4df85_5731ca0a","line":75,"range":{"start_line":75,"start_character":64,"end_line":75,"end_character":103},"updated":"2020-02-28 09:35:56.000000000","message":"For backwards compatibility, please also add the old name.\n\nkolla_toolbox_pip_virtualenv_packages|customizable(\"pip_virtualenv_packages\")customizable(\"pip_packages\")\n\nPlease also add a TODO comment to remove the old name in the next release.","commit_id":"80ebdd297a3ce61fc7dec45ea763e3fe60e1ec72"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ea618f75d24f4c26ded0c56e20a62604f2367619","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027virtualenv\u0027"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages|customizable(\"pip_virtualenv_packages\"), constraints\u003dfalse) }} \\"},{"line_number":76,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1fa4df85_32445c1b","line":75,"range":{"start_line":75,"start_character":64,"end_line":75,"end_character":103},"in_reply_to":"1fa4df85_5731ca0a","updated":"2020-02-28 09:52:41.000000000","message":"The bug is about it exactly. Adding it back will not fix the issue.","commit_id":"80ebdd297a3ce61fc7dec45ea763e3fe60e1ec72"},{"author":{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},"change_message_id":"2ee5aab4f19daa45296ed360a2a733aebf4f0b86","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027virtualenv\u0027"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages|customizable(\"pip_virtualenv_packages\"), constraints\u003dfalse) }} \\"},{"line_number":76,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1fa4df85_b28ccc7f","line":75,"range":{"start_line":75,"start_character":64,"end_line":75,"end_character":103},"in_reply_to":"1fa4df85_5731ca0a","updated":"2020-02-28 09:55:18.000000000","message":"This one is a wrong parameter for customizable filter, not export to user in template override, and also customisation for kolla_toolbox_pip_virtualenv_packages/kolla_toolbox_pip_packages never works from pike actually.\n\nUsers override kolla_toolbox_pip_virtualenv_packages with override/append/remove won\u0027t work and also make the following  kolla_toolbox_pip_packages cannot override also.\n\nSee https://github.com/openstack/kolla/blob/1e4cf4517165b4e6bca1a84e837dccbd10a33686/kolla/template/filters.py#L27-L35","commit_id":"80ebdd297a3ce61fc7dec45ea763e3fe60e1ec72"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9494c1b4a1cca6b72c636c8cfc8fa52e58aee24c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027virtualenv\u0027"},{"line_number":73,"context_line":"    ] %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"RUN {{ macros.install_pip(kolla_toolbox_pip_virtualenv_packages|customizable(\"pip_virtualenv_packages\"), constraints\u003dfalse) }} \\"},{"line_number":76,"context_line":"    \u0026\u0026 virtualenv --system-site-packages {{ virtualenv_path }}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"ENV PATH {{ virtualenv_path }}/bin:$PATH"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1fa4df85_92c99079","line":75,"range":{"start_line":75,"start_character":64,"end_line":75,"end_character":103},"in_reply_to":"1fa4df85_b28ccc7f","updated":"2020-02-28 10:06:51.000000000","message":"I tested the following and it worked:\n\n$ cat \u003c\u003c EOF \u003e to.j2\n{% extends parent_template %}\n{% set kolla_toolbox_pip_packages_append \u003d [\u0027foo\u0027] %}\nEOF\n\n$ python tools/build.py --template-only kolla-toolbox --template-override to.j2\n\nI know it doesn\u0027t follow the pattern, but if someone has worked around it we should try not to break them - especially on stable branches.","commit_id":"80ebdd297a3ce61fc7dec45ea763e3fe60e1ec72"},{"author":{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},"change_message_id":"2ee5aab4f19daa45296ed360a2a733aebf4f0b86","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"RUN mkdir -p /requirements \\"},{"line_number":95,"context_line":"    \u0026\u0026 curl -sSL -o /requirements/upper-constraints.txt https://releases.openstack.org/constraints/upper/{{ openstack_release }} \\"},{"line_number":96,"context_line":"    \u0026\u0026 {{ macros.install_pip(kolla_toolbox_pip_packages | customizable(\"pip_packages\")) }} \\"},{"line_number":97,"context_line":"    \u0026\u0026 mkdir -p /etc/ansible /usr/share/ansible \\"},{"line_number":98,"context_line":"    \u0026\u0026 echo \u0027localhost ansible_connection\u003dlocal ansible_python_interpreter\u003d{{ virtualenv_path }}/bin/python\u0027 \u003e /etc/ansible/hosts \\"},{"line_number":99,"context_line":"    \u0026\u0026 sed -i \u0027s|  \"identity_api_version\": \"2.0\",|  \"identity_api_version\": \"3\",|\u0027 {{ os_client_config }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1fa4df85_12a5a004","line":96,"range":{"start_line":96,"start_character":72,"end_line":96,"end_character":84},"updated":"2020-02-28 09:55:18.000000000","message":"here","commit_id":"80ebdd297a3ce61fc7dec45ea763e3fe60e1ec72"}]}