)]}'
{"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2c9c7b5cc97d126174a9a1da3c37b800930ba0e0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"{% endif %}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% set cinder_volume_pip_packages \u003d [] %}"},{"line_number":66,"context_line":"RUN {{ macros.install_pip(cinder_volume_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"COPY cinder_sudoers /etc/sudoers.d/kolla_cinder_volume_sudoers"},{"line_number":69,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_cinder_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1fa4df85_84755ffc","line":66,"updated":"2020-03-06 15:27:55.000000000","message":"I\u0027m not sure we should add a pip install to binary images.\n\nWhy not use the cinder_volume_footer?","commit_id":"9cb92f5a651c601490ca325b57188f4cec3802b3"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"3a393b806602bd017f8ecc75b505c5ae150106b5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"{% endif %}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"{% set cinder_volume_pip_packages \u003d [] %}"},{"line_number":66,"context_line":"RUN {{ macros.install_pip(cinder_volume_pip_packages | customizable(\"pip_packages\")) }}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"COPY cinder_sudoers /etc/sudoers.d/kolla_cinder_volume_sudoers"},{"line_number":69,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_cinder_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1fa4df85_c7b4b982","line":66,"in_reply_to":"1fa4df85_84755ffc","updated":"2020-03-06 16:18:42.000000000","message":"In nova-compute we do it the same way?\n\nI think it makes sense to offer this possibility in images where the installation of Pypi packages is often necessary.\n\nOf course it also works via the footer and this is how we do it at the moment.","commit_id":"9cb92f5a651c601490ca325b57188f4cec3802b3"}]}
