)]}'
{"docker/heat/heat-api/extend_start.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8b27236a9908d54ab144c6a2820f7e633967ead","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain \u003e /dev/null 2\u003e\u00261"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":11,"context_line":"        openstack domain create heat_user_domain"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_77ca2fa1","line":8,"range":{"start_line":8,"start_character":42,"end_line":8,"end_character":59},"updated":"2020-03-10 09:08:36.000000000","message":"I would drop this, this hides any issues","commit_id":"c1ec6a908b545fbf10d3c681802392c5db9ca227"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8b27236a9908d54ab144c6a2820f7e633967ead","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain \u003e /dev/null 2\u003e\u00261"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    if [[ $? -eq 1 ]]; then"},{"line_number":11,"context_line":"        openstack domain create heat_user_domain"},{"line_number":12,"context_line":"        openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"},{"line_number":13,"context_line":"        openstack role add --domain heat_user_domain --user-domain heat_user_domain --user heat_domain_admin admin"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fa4df85_17b97b13","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":18},"updated":"2020-03-10 09:08:36.000000000","message":"this part will never be reached because errexit will already exit on the above command","commit_id":"c1ec6a908b545fbf10d3c681802392c5db9ca227"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e226ec58557e84b88b1e8b0714c5b2722e6eb4a7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain || {"},{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_3215a540","line":8,"updated":"2020-03-10 10:28:36.000000000","message":"This still hides API errors doesn\u0027t it? Even if 1 only means not found, then we ignroe other errors.","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6d9070ad119447e5a9042ea243cc18fb79ddee4e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain || {"},{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_f2486d5c","line":8,"in_reply_to":"1fa4df85_3215a540","updated":"2020-03-10 10:31:52.000000000","message":"How about:\n\nset -o pipefail\n\nopenstack domain list | awk \u0027$4 \u003d\u003d \"heat_user_domain\" { print \"found\" }\u0027","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d22e12c7392ad0eb2a4dc252131be72c8dee8744","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain || {"},{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_d2521113","line":8,"in_reply_to":"1fa4df85_3215a540","updated":"2020-03-10 10:30:27.000000000","message":"ack, commented parallelly below","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"73ddd219966427b5c91db88ea20da550ea277ede","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain || {"},{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_b2d5151e","line":8,"in_reply_to":"1fa4df85_7258fdf8","updated":"2020-03-10 10:47:08.000000000","message":"Indeed. Is that a problem? It fixes the problem with false positives.","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6dabe7c6c58235b0466e795eb706a7930357ccec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain || {"},{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_6df10001","line":8,"in_reply_to":"1fa4df85_b2d5151e","updated":"2020-03-10 11:26:58.000000000","message":"Nope :-)","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4491f4360d7b78b450a389edfab830bbc702ffd2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    openstack domain show heat_user_domain || {"},{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_7258fdf8","line":8,"in_reply_to":"1fa4df85_f2486d5c","updated":"2020-03-10 10:43:01.000000000","message":"better grep on that, but it ends up pretty similar to the original one;","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a7b7bf2c981fc653458c3002b8741f029d075382","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        if [[ $? -eq 1 ]]; then"},{"line_number":10,"context_line":"            openstack domain create heat_user_domain"},{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"},{"line_number":12,"context_line":"            openstack role add --domain heat_user_domain --user-domain heat_user_domain --user heat_domain_admin admin"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_922339a7","line":12,"updated":"2020-03-10 10:28:48.000000000","message":"also check branch for neither 1 nor 0 and exit with the same code","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e226ec58557e84b88b1e8b0714c5b2722e6eb4a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"},{"line_number":12,"context_line":"            openstack role add --domain heat_user_domain --user-domain heat_user_domain --user heat_domain_admin admin"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_1216694a","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":5},"updated":"2020-03-10 10:28:36.000000000","message":"Is it valid syntax? This doesn\u0027t work for me:\n\nfalse || { echo $? }\n\nThis does:\n\nfalse || ( echo $? )\n1\necho $?\n0","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d22e12c7392ad0eb2a4dc252131be72c8dee8744","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"},{"line_number":12,"context_line":"            openstack role add --domain heat_user_domain --user-domain heat_user_domain --user heat_domain_admin admin"},{"line_number":13,"context_line":"        fi"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1fa4df85_b24f5569","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":5},"in_reply_to":"1fa4df85_1216694a","updated":"2020-03-10 10:30:27.000000000","message":"in your case needs semicolon before }","commit_id":"bdf355b466e3cacdc3bd0b3d5b2b89d569936641"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"635b03faa9434aac786875dfdb695570389e91ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \"^heat_user_domain$\")"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"},{"line_number":10,"context_line":"        openstack domain create heat_user_domain"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1fa4df85_462f34a7","line":7,"range":{"start_line":7,"start_character":96,"end_line":7,"end_character":97},"updated":"2020-03-11 10:19:02.000000000","message":"single quotes (or escape the dollar sign there)","commit_id":"118cce9446ff20a01d2fb314855f3550611f4635"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"635b03faa9434aac786875dfdb695570389e91ec","unresolved":false,"context_lines":[{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \"^heat_user_domain$\")"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"},{"line_number":10,"context_line":"        openstack domain create heat_user_domain"},{"line_number":11,"context_line":"        openstack user create --domain heat_user_domain heat_domain_admin --password ${HEAT_DOMAIN_ADMIN_PASSWORD}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1fa4df85_e65ae04e","line":8,"updated":"2020-03-11 10:19:02.000000000","message":"whitespace","commit_id":"118cce9446ff20a01d2fb314855f3550611f4635"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3c017c0f5142d64edd1888aa0ec20b5f089fd621","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1fa4df85_e9fe3137","line":6,"updated":"2020-03-11 11:06:07.000000000","message":"Needs this to catch API failures:\n\nset -o pipefail","commit_id":"8b2b62c70f40be8a5462cabb614baf6d284c2b4e"},{"author":{"_account_id":31693,"name":"Fabian Bermel","email":"fabian.bermel@noris.de","username":"fbermel"},"change_message_id":"7f54b93a26e23642862d195086e551c1d1e3014c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1fa4df85_8cc30b39","line":6,"in_reply_to":"1fa4df85_29a2094d","updated":"2020-03-11 11:49:49.000000000","message":"Should this be part of this change then or should this rather be handled in another change?","commit_id":"8b2b62c70f40be8a5462cabb614baf6d284c2b4e"},{"author":{"_account_id":31693,"name":"Fabian Bermel","email":"fabian.bermel@noris.de","username":"fbermel"},"change_message_id":"42f198410cec269d2198471a589b6a852ff01112","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1fa4df85_4c18b383","line":6,"in_reply_to":"1fa4df85_2cbbf772","updated":"2020-03-11 12:11:13.000000000","message":"Ok thanks. Sorry for the stupid questions but this is my first time contributing to any opensource project. I guess this won\u0027t be merged unless docker/base/start.sh gets changed first?","commit_id":"8b2b62c70f40be8a5462cabb614baf6d284c2b4e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"92329b50d686ad77d7737846768d5973b8666d9a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1fa4df85_329cae5c","line":6,"in_reply_to":"1fa4df85_4c18b383","updated":"2020-03-11 13:02:33.000000000","message":"No problem, all related questions are welcome. We can merge this before that. The issue is that whole CI is broken atm due to external bug.","commit_id":"8b2b62c70f40be8a5462cabb614baf6d284c2b4e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0728388593c06684e16505b36ed78aecfecf29d7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1fa4df85_2cbbf772","line":6,"in_reply_to":"1fa4df85_8cc30b39","updated":"2020-03-11 12:03:08.000000000","message":"Another.","commit_id":"8b2b62c70f40be8a5462cabb614baf6d284c2b4e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"54980de1efa55af9b09ff4377b6794610c6f5522","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1fa4df85_29a2094d","line":6,"in_reply_to":"1fa4df85_e9fe3137","updated":"2020-03-11 11:07:37.000000000","message":"+1, should not we set this in main start? It sounds reasonable to always expect.","commit_id":"8b2b62c70f40be8a5462cabb614baf6d284c2b4e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"eed12e88858f2b46e80d7a5b2b3a5e3cb4a5ceab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027 || true)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"},{"line_number":10,"context_line":"        openstack domain create heat_user_domain"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9f560f44_4b2a132f","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":28},"updated":"2020-10-03 18:22:58.000000000","message":"while we are fixing this, it should really be named: CURRENT_HEAT_DOMAIN_ADMIN_NAME","commit_id":"568ed12241b0f13115c7332c86f4c208812888c6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7ad48de22ca80083cd7b5a54095fedc3a98f5a06","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    heat-manage db_sync"},{"line_number":7,"context_line":"    CURRENT_HEAT_DOMAIN_NAME\u003d$(openstack domain list -f value -c Name | grep \u0027^heat_user_domain$\u0027 || true)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    if [[ \"heat_user_domain\" !\u003d \"$CURRENT_HEAT_DOMAIN_NAME\" ]]; then"},{"line_number":10,"context_line":"        openstack domain create heat_user_domain"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9f560f44_660d8e8e","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":28},"in_reply_to":"9f560f44_4b2a132f","updated":"2020-10-04 09:34:07.000000000","message":"nope, I misread it","commit_id":"568ed12241b0f13115c7332c86f4c208812888c6"}]}