)]}'
{"docker/cyborg/cyborg-agent/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"0b3bd168ea7398e76589f75ef0962d623079f023","unresolved":false,"context_lines":[{"line_number":35,"context_line":"ENV opae_devel_rpm_url\u003dhttps://github.com/OPAE/opae-sdk/releases/download/1.1.0-2/opae-devel-1.1.0-2.x86_64.rpm"},{"line_number":36,"context_line":"ENV opae_devel_rpm_sha1sum\u003d461356b987b41843f60123d66195620bf1e4e28e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"RUN curl -sSL -o /tmp/opae-libs.rpm ${opae_libs_rpm_url} \\"},{"line_number":39,"context_line":"    \u0026\u0026 echo \"${opae_libs_rpm_sha1sum} /tmp/opae-libs.rpm\" | sha1sum -c \\"},{"line_number":40,"context_line":"    \u0026\u0026 curl -sSL -o /tmp/opae-devel.rpm ${opae_devel_rpm_url} \\"},{"line_number":41,"context_line":"    \u0026\u0026 echo \"${opae_devel_rpm_sha1sum} /tmp/opae-devel.rpm\" | sha1sum -c \\"},{"line_number":42,"context_line":"    \u0026\u0026 dnf -y install /tmp/opae-libs.rpm /tmp/opae-devel.rpm \\"},{"line_number":43,"context_line":"    \u0026\u0026 rm -f /tmp/opae-libs.rpm /tmp/opae-devel.rpm"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NOTE(Bai Yongjun) Required packages are only supported Ubuntu16.04"},{"line_number":46,"context_line":"# Please check the details:https://github.com/OPAE/opae-sdk/releases/tag/1.1.0-2"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1fa4df85_d5fe0837","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":51},"updated":"2020-03-17 18:34:05.000000000","message":"We should change whole block and pass URL to package_install macro.\n\n\"dnf install ${opae_libs_rpm_url} ${opae_devel_rpm_url}\" is valid and proper use.","commit_id":"dd7f31c2b396e08f0478ff28cfb2c3657fd2cba5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8eb526b3eb66c571c01f7a3afcbd250bb332d951","unresolved":false,"context_lines":[{"line_number":35,"context_line":"ENV opae_devel_rpm_url\u003dhttps://github.com/OPAE/opae-sdk/releases/download/1.1.0-2/opae-devel-1.1.0-2.x86_64.rpm"},{"line_number":36,"context_line":"ENV opae_devel_rpm_sha1sum\u003d461356b987b41843f60123d66195620bf1e4e28e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"RUN curl -sSL -o /tmp/opae-libs.rpm ${opae_libs_rpm_url} \\"},{"line_number":39,"context_line":"    \u0026\u0026 echo \"${opae_libs_rpm_sha1sum} /tmp/opae-libs.rpm\" | sha1sum -c \\"},{"line_number":40,"context_line":"    \u0026\u0026 curl -sSL -o /tmp/opae-devel.rpm ${opae_devel_rpm_url} \\"},{"line_number":41,"context_line":"    \u0026\u0026 echo \"${opae_devel_rpm_sha1sum} /tmp/opae-devel.rpm\" | sha1sum -c \\"},{"line_number":42,"context_line":"    \u0026\u0026 dnf -y install /tmp/opae-libs.rpm /tmp/opae-devel.rpm \\"},{"line_number":43,"context_line":"    \u0026\u0026 rm -f /tmp/opae-libs.rpm /tmp/opae-devel.rpm"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# NOTE(Bai Yongjun) Required packages are only supported Ubuntu16.04"},{"line_number":46,"context_line":"# Please check the details:https://github.com/OPAE/opae-sdk/releases/tag/1.1.0-2"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3f4c43b2_b70fdadf","line":43,"range":{"start_line":38,"start_character":0,"end_line":43,"end_character":51},"in_reply_to":"1fa4df85_d5fe0837","updated":"2020-04-15 13:18:26.000000000","message":"We could do. We\u0027d lose the SHA validation of the package. It\u0027s not really relevant to this change though.","commit_id":"dd7f31c2b396e08f0478ff28cfb2c3657fd2cba5"}],"docker/logstash/Dockerfile.j2":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"0b3bd168ea7398e76589f75ef0962d623079f023","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"ENV logstash_rpm_url\u003dhttps://download.elastic.co/logstash/logstash/packages/centos/logstash-2.4.1.noarch.rpm"},{"line_number":47,"context_line":"ENV logstash_rpm_sha1sum\u003d68c5e78c3d941f06f77d638c0756b6aea715bec5"},{"line_number":48,"context_line":"RUN curl -sSL -o /tmp/logstash.rpm ${logstash_rpm_url} \\"},{"line_number":49,"context_line":"    \u0026\u0026 echo \"${logstash_rpm_sha1sum} /tmp/logstash.rpm\" | sha1sum -c \\"},{"line_number":50,"context_line":"    \u0026\u0026 dnf -y install /tmp/logstash.rpm \\"},{"line_number":51,"context_line":"    \u0026\u0026 rm -f /tmp/logstash.rpm"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1fa4df85_5598d819","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":30},"updated":"2020-03-17 18:34:05.000000000","message":"same here","commit_id":"dd7f31c2b396e08f0478ff28cfb2c3657fd2cba5"}],"kolla/image/build.py":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"20164e2b1e776cdbf6872c53da9ded3bc3d5c1a4","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        for config in rpm_setup_config:"},{"line_number":838,"context_line":"            if config.endswith(\u0027.rpm\u0027):"},{"line_number":839,"context_line":"                # RPM files can be installed with yum from file path or url"},{"line_number":840,"context_line":"                cmd \u003d \"RUN dnf -y install {}\".format(config)"},{"line_number":841,"context_line":"            elif config.endswith(\u0027.repo\u0027):"},{"line_number":842,"context_line":"                if config.startswith(\u0027http\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f3f37e8_bd3fffb3","line":839,"range":{"start_line":839,"start_character":50,"end_line":839,"end_character":53},"updated":"2020-04-11 14:51:01.000000000","message":"yum here should be updated to dnf too","commit_id":"dd7f31c2b396e08f0478ff28cfb2c3657fd2cba5"}],"tools/validate-install-command.sh":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"0b3bd168ea7398e76589f75ef0962d623079f023","unresolved":false,"context_lines":[{"line_number":3,"context_line":"RES\u003d0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for dockerfile in \"$@\"; do"},{"line_number":6,"context_line":"    if grep \"apt-get install\\|yum install\\|dnf install\" \"$dockerfile\"; then"},{"line_number":7,"context_line":"        echo \"ERROR: $dockerfile has incorrectly formatted install command Should be in the form \u0027apt-get|yum|dnf -y install ...\u0027\" \u003e\u00262"},{"line_number":8,"context_line":"        RES\u003d1"},{"line_number":9,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1fa4df85_b5882cc6","line":6,"range":{"start_line":6,"start_character":30,"end_line":6,"end_character":41},"updated":"2020-03-17 18:34:05.000000000","message":"drop yum use.","commit_id":"dd7f31c2b396e08f0478ff28cfb2c3657fd2cba5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"558ef1e7295d090abe0c20b60821409eca0bf693","unresolved":false,"context_lines":[{"line_number":3,"context_line":"RES\u003d0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"for dockerfile in \"$@\"; do"},{"line_number":6,"context_line":"    if grep \"apt-get install\\|dnf install\" \"$dockerfile\"; then"},{"line_number":7,"context_line":"        echo \"ERROR: $dockerfile has incorrectly formatted install command Should be in the form \u0027apt-get|dnf -y install ...\u0027\" \u003e\u00262"},{"line_number":8,"context_line":"        RES\u003d1"},{"line_number":9,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f4c43b2_8c00c569","line":6,"updated":"2020-04-16 08:46:11.000000000","message":"hah, now we get this great validation 8-)","commit_id":"788978211326093e10795c611971ca8911e2a986"}]}