)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5c104df90321296f105933c506cd2834a3869421","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nfs dependencies to glance container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With a recent change[1], the nfs mounts will happen in the glance"},{"line_number":10,"context_line":"container(and not in cinder container) due to which the glance"},{"line_number":11,"context_line":"container requires the appropriate nfs packages to do the mount."},{"line_number":12,"context_line":"This patch adds those dependencies."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_b8a37f4f","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":37},"updated":"2020-03-23 08:42:16.000000000","message":"I don\u0027t see that in the referenced change. It either always happened this way and it is broken (so needs a bug report) or nothing is changing and this is still not needed. I see glance still calling cinder in there, only passsing configured directory. Please clarify.","commit_id":"9af8b7e8bbd3f580a85ad48abb8cefd6b25ed87d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6de64650bb3a95b965b57aff47542f71b74663a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nfs dependencies to glance container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With a recent change[1], the nfs mounts will happen in the glance"},{"line_number":10,"context_line":"container(and not in cinder container) due to which the glance"},{"line_number":11,"context_line":"container requires the appropriate nfs packages to do the mount."},{"line_number":12,"context_line":"This patch adds those dependencies."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_ee0d3891","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":37},"in_reply_to":"df33271e_03c5dc8e","updated":"2020-03-23 15:09:26.000000000","message":"1) I\u0027ve reported a bug.\n2) i\u0027m not sure where we need to fix this in kolla-ansible, could you guide me on that?\n3) The intention is to backport the patch till queens but i think will require discussion with the glance team","commit_id":"9af8b7e8bbd3f580a85ad48abb8cefd6b25ed87d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5626e8683b1b7bed94c3fe0b91b75200dd16b55d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nfs dependencies to glance container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With a recent change[1], the nfs mounts will happen in the glance"},{"line_number":10,"context_line":"container(and not in cinder container) due to which the glance"},{"line_number":11,"context_line":"container requires the appropriate nfs packages to do the mount."},{"line_number":12,"context_line":"This patch adds those dependencies."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_03c5dc8e","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":37},"in_reply_to":"df33271e_43b88429","updated":"2020-03-23 09:15:54.000000000","message":"Thanks, that\u0027s what I needed. Then we need a bug report on that and handle as bug. We also need fixing this in kolla-ansible (for the path issue by default). Also, this depends a bit on whether Glance is going with that change as non-backportable feature (which I believe will likely happen) or a backportable fix (then we approach defaults differently to accommodate for nfs from cinder).","commit_id":"9af8b7e8bbd3f580a85ad48abb8cefd6b25ed87d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a134ba53e876b84abdb162f1e9d93af7c454892d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add nfs dependencies to glance container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With a recent change[1], the nfs mounts will happen in the glance"},{"line_number":10,"context_line":"container(and not in cinder container) due to which the glance"},{"line_number":11,"context_line":"container requires the appropriate nfs packages to do the mount."},{"line_number":12,"context_line":"This patch adds those dependencies."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_43b88429","line":10,"range":{"start_line":9,"start_character":25,"end_line":10,"end_character":37},"in_reply_to":"df33271e_b8a37f4f","updated":"2020-03-23 09:09:31.000000000","message":"This was broken from the start.\nThe initial problem was when we set glance backend as cinder and cinder backend as nfs and create an image, we get premission denied error[1]\nTechnically glance needs to mount the image-volume in the glance data path to make it work (similar to what nova does)\nAfter changing the directory path, there was one more issue encountered when the mount failed as the nfs dependency wasn\u0027t installed in the glance container and this change fixed the issue.\nIf you need more info regarding how connection_properties are fetched and passed to/from os-brick and how the original change works, we can discuss on IRC but practically this patch is required to completely fix the issue.\n\n[1] http://paste.openstack.org/show/791003/","commit_id":"9af8b7e8bbd3f580a85ad48abb8cefd6b25ed87d"}],"docker/glance/glance-api/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aacf48e5bd8ffa3bc90168d6503e6a3c82a3eb51","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% if distro_package_manager \u003d\u003d \u0027dnf\u0027 or base_distro not in [\u0027centos\u0027] %}"},{"line_number":12,"context_line":"    {% set glance_api_packages \u003d [\u0027qemu-img\u0027] %}"},{"line_number":13,"context_line":"    {% else %}"},{"line_number":14,"context_line":"    {% set glance_api_packages \u003d [\u0027qemu-img-ev\u0027] %}"},{"line_number":15,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df33271e_2595bb87","line":12,"updated":"2020-04-02 07:31:33.000000000","message":"nit: no indent makes it a bit unreadable, not really related to this change - but we could fix it here I guess","commit_id":"6b4d33be7f0ae0453b080e05b7a9e65542b04b93"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d3198fdb2f134f6514af4cc8c7ee0fdf1ea2a2b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":11,"context_line":"    {% if distro_package_manager \u003d\u003d \u0027dnf\u0027 or base_distro not in [\u0027centos\u0027] %}"},{"line_number":12,"context_line":"    {% set glance_api_packages \u003d [\u0027qemu-img\u0027] %}"},{"line_number":13,"context_line":"    {% else %}"},{"line_number":14,"context_line":"    {% set glance_api_packages \u003d [\u0027qemu-img-ev\u0027] %}"},{"line_number":15,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df33271e_25c93b58","line":12,"in_reply_to":"df33271e_2595bb87","updated":"2020-04-02 07:53:46.000000000","message":"Done","commit_id":"6b4d33be7f0ae0453b080e05b7a9e65542b04b93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aacf48e5bd8ffa3bc90168d6503e6a3c82a3eb51","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    {% endif %}"},{"line_number":16,"context_line":"    {% set glance_api_packages \u003d glance_api_packages + [\u0027nfs-utils\u0027] %}"},{"line_number":17,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":18,"context_line":"    {% set glance_api_packages \u003d [\u0027qemu-utils\u0027, \u0027nfs-common\u0027] %}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(glance_api_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df33271e_8562c7d6","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":60},"updated":"2020-04-02 07:31:33.000000000","message":"split it to multiline and alphabetical order please","commit_id":"6b4d33be7f0ae0453b080e05b7a9e65542b04b93"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1d3198fdb2f134f6514af4cc8c7ee0fdf1ea2a2b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    {% endif %}"},{"line_number":16,"context_line":"    {% set glance_api_packages \u003d glance_api_packages + [\u0027nfs-utils\u0027] %}"},{"line_number":17,"context_line":"{% elif base_package_type \u003d\u003d \u0027deb\u0027 %}"},{"line_number":18,"context_line":"    {% set glance_api_packages \u003d [\u0027qemu-utils\u0027, \u0027nfs-common\u0027] %}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ macros.install_packages(glance_api_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df33271e_65bfc3a9","line":18,"range":{"start_line":18,"start_character":34,"end_line":18,"end_character":60},"in_reply_to":"df33271e_8562c7d6","updated":"2020-04-02 07:53:46.000000000","message":"Done","commit_id":"6b4d33be7f0ae0453b080e05b7a9e65542b04b93"}]}