)]}'
{"docker/collectd/Dockerfile.j2":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"caee92f1edfa982746cc668b16158e08ed9f03ed","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  {% endif %}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% endif %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{{ macros.install_packages(collectd_packages | customizable(\"packages\")) }}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df33271e_b625c20b","line":84,"updated":"2020-03-31 07:08:13.000000000","message":"Please add something like \n\nhttps://github.com/openstack/kolla/blob/stable/rocky/docker/collectd/Dockerfile.j2#L68-L69\n\nto make sure, there is really nothing pulled from epel, otherwise that would clash here.\nThat needs to be run only on centos/rhel.","commit_id":"e9efdb8d20ed82d00f47220e2f0625ef8606ca53"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"132bc422125e3ca7b7170767bbedaeed06b027d8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  {% endif %}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% endif %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{{ macros.install_packages(collectd_packages | customizable(\"packages\")) }}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df33271e_dcafc5e0","line":84,"in_reply_to":"df33271e_0116e6f1","updated":"2020-03-31 08:25:31.000000000","message":"yes, that makes sense.","commit_id":"e9efdb8d20ed82d00f47220e2f0625ef8606ca53"},{"author":{"_account_id":31539,"name":"Piotr Rabiega","email":"piotrx.rabiega@intel.com","username":"prabiegx"},"change_message_id":"e7443638f8a96f4d5a5fea9eceb9b771e137f5a6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  {% endif %}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% endif %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{{ macros.install_packages(collectd_packages | customizable(\"packages\")) }}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"df33271e_0116e6f1","line":84,"in_reply_to":"df33271e_b625c20b","updated":"2020-03-31 07:48:28.000000000","message":"I tested suggested change:\n\n{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}\n  # make sure, collectd is pulled from centos-opstools\n  RUN yum-config-manager --disable epel\n{% endif %}\n\nUsing command:\n\nsudo python3 tools/build.py -b centos --base-tag 8 -t source collectd |\u0026 tee C8disableepel.txt\n\nAnd got error:\n\nINFO:kolla.common.utils.collectd:Step 4/8 : RUN yum-config-manager --disable epel\nINFO:kolla.common.utils.collectd: ---\u003e Running in 27fcd4c6ab7c\nINFO:kolla.common.utils.collectd:/bin/sh: yum-config-manager: command not found\nINFO:kolla.common.utils.collectd:\nINFO:kolla.common.utils.collectd:Removing intermediate container 27fcd4c6ab7c\nERROR:kolla.common.utils.collectd:Error\u0027d with the following message\nERROR:kolla.common.utils.collectd:The command \u0027/bin/sh -c yum-config-manager --disable epel\u0027 returned a non-zero code: 127\n\n\nSince C7 isn\u0027t supported anymore, should I use \"RUN dnf config-manager --disablerepo epel\" instead? It works for build described above. Maybe with additional \"{% if distro_package_manager \u003d\u003d \u0027dnf\u0027 %}\"?","commit_id":"e9efdb8d20ed82d00f47220e2f0625ef8606ca53"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f17755c429493680419fe633e6374cf52dab6ce","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"{% endif %}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027rhel\u0027] %}"},{"line_number":86,"context_line":"  {% if distro_package_manager \u003d\u003d \u0027dnf\u0027 %}"},{"line_number":87,"context_line":"# make sure, collectd is pulled from centos-opstools"},{"line_number":88,"context_line":"RUN dnf config-manager --disablerepo epel"},{"line_number":89,"context_line":"  {% endif %}"},{"line_number":90,"context_line":"{% endif %}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"{{ macros.install_packages(collectd_packages | customizable(\"packages\")) }}"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"df33271e_c1482230","line":90,"range":{"start_line":85,"start_character":0,"end_line":90,"end_character":11},"updated":"2020-04-03 12:48:37.000000000","message":"This isn\u0027t required - we disable EPEL in the base image.","commit_id":"396321f9ea77fee87114548d6d7ae1b15a2c5c58"}],"releasenotes/notes/add_dpdk_telemetry_and_logparser-bcf9b13bcefc99c9.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f17755c429493680419fe633e6374cf52dab6ce","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    Adds \u0027\u0027collectd-dpdk_telemetry\u0027\u0027 and \u0027\u0027collectd-logparser\u0027\u0027 packages"},{"line_number":6,"context_line":"    to \u0027\u0027collectd\u0027\u0027 RHEL-based image. dpdk_telemetry plugin collects DPDK"},{"line_number":7,"context_line":"    ethernet device metrics via dpdk_telemetry library. Logparser is"},{"line_number":8,"context_line":"    plugin for filtering and parsing log messages."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df33271e_415ed2e9","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":11},"updated":"2020-04-03 12:48:37.000000000","message":"These should be backticks ``","commit_id":"396321f9ea77fee87114548d6d7ae1b15a2c5c58"}]}