)]}'
{"kolla/image/build.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4abc2897803ab7aac5e3e077eef10107808d3971","unresolved":false,"context_lines":[{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# NOTE(hrw): images which need source archive even for binary build"},{"line_number":234,"context_line":"SOURCES_EVEN_FOR_BINARY \u003d [ \u0027kolla-toolbox\u0027 ]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"class ArchivingError(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b647341d","line":234,"updated":"2020-04-02 20:24:06.000000000","message":"pep8: E201 whitespace after \u0027[\u0027","commit_id":"a5020e4f40b35ad89d07d82e4c4574aeeaa12569"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4abc2897803ab7aac5e3e077eef10107808d3971","unresolved":false,"context_lines":[{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# NOTE(hrw): images which need source archive even for binary build"},{"line_number":234,"context_line":"SOURCES_EVEN_FOR_BINARY \u003d [ \u0027kolla-toolbox\u0027 ]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"class ArchivingError(Exception):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_165380e3","line":234,"updated":"2020-04-02 20:24:06.000000000","message":"pep8: E202 whitespace before \u0027]\u0027","commit_id":"a5020e4f40b35ad89d07d82e4c4574aeeaa12569"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4abc2897803ab7aac5e3e077eef10107808d3971","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                return"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        if (self.install_type \u003d\u003d \u0027source\u0027 or"},{"line_number":585,"context_line":"            image.name in SOURCES_EVEN_FOR_BINARY):"},{"line_number":586,"context_line":"            try:"},{"line_number":587,"context_line":"                plugins_am \u003d make_an_archive(image.plugins, \u0027plugins\u0027)"},{"line_number":588,"context_line":"            except ArchivingError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_f64d3c3b","line":585,"updated":"2020-04-02 20:24:06.000000000","message":"pep8: E129 visually indented line with same indent as next logical line","commit_id":"a5020e4f40b35ad89d07d82e4c4574aeeaa12569"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"adc13c0f856d4beeda1a1ae68853a7d65619dfcf","unresolved":false,"context_lines":[{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# NOTE(hrw): images which need source archive even for binary build"},{"line_number":234,"context_line":"SOURCES_EVEN_FOR_BINARY \u003d [\u0027kolla-toolbox\u0027]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"class ArchivingError(Exception):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_645a042b","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":23},"updated":"2020-04-03 13:21:00.000000000","message":"While this makes sense for source images, I think this is the wrong path for binary images. It\u0027s confusing to have an exception.\n\nHow many packages are we lacking suitable binary packages for? I\u0027d guess it\u0027s just ansible, and we don\u0027t need upper constraints for that. Maybe we should do a proper source/binary split?","commit_id":"14151802c27bedb7742a753cd4d5fc6e6b748358"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6f20bd83f4ae523bb8b361238471dc9bb10fd6b3","unresolved":false,"context_lines":[{"line_number":231,"context_line":"}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"# NOTE(hrw): images which need source archive even for binary build"},{"line_number":234,"context_line":"SOURCES_EVEN_FOR_BINARY \u003d [\u0027kolla-toolbox\u0027]"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"class ArchivingError(Exception):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_55067e22","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":23},"in_reply_to":"df33271e_645a042b","updated":"2020-04-04 14:11:39.000000000","message":"Hmm, that makes sense, we would have the same tooling distro provides which solves the issue as well. Very good idea, Mark.","commit_id":"14151802c27bedb7742a753cd4d5fc6e6b748358"}]}